Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-16 05:26:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Drivers: hv: vmbus: Remove unnecessary channel->lock critical sections (sc_list readers)

Browse Source 
Additions/deletions to/from sc_list (as well as modifications of
target_cpu(s)) are protected by channel_mutex, which hv_synic_cleanup()
and vmbus_bus_suspend() own for the duration of the channel->lock
critical section in question.

Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Link: https://lore.kernel.org/r/20200617164642.37393-5-parri.andrea@gmail.com
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Wei Liu <wei.liu@kernel.org>
This commit is contained in:
Andrea Parri (Microsoft) 2020-06-17 18:46:38 +02:00 committed by Wei Liu
parent 0a96820929
commit 12d0dd8e72
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hv/hv.c
View File

@ -241,7 +241,6 @@ int hv_synic_cleanup(unsigned int cpu)
{ {
struct vmbus_channel *channel, *sc; struct vmbus_channel *channel, *sc;
bool channel_found = false; bool channel_found = false;
unsigned long flags;
/* /*
* Hyper-V does not provide a way to change the connect CPU once * Hyper-V does not provide a way to change the connect CPU once
@ -263,14 +262,12 @@ int hv_synic_cleanup(unsigned int cpu)
channel_found = true; channel_found = true;
break; break;
} }
spin_lock_irqsave(&channel->lock, flags);
list_for_each_entry(sc, &channel->sc_list, sc_list) { list_for_each_entry(sc, &channel->sc_list, sc_list) {
if (sc->target_cpu == cpu) { if (sc->target_cpu == cpu) {
channel_found = true; channel_found = true;
break; break;
} }
} }
spin_unlock_irqrestore(&channel->lock, flags);
if (channel_found) if (channel_found)
break; break;
} }

3
drivers/hv/vmbus_drv.c
View File

@ -2344,7 +2344,6 @@ acpi_walk_err:
static int vmbus_bus_suspend(struct device *dev) static int vmbus_bus_suspend(struct device *dev)
{ {
struct vmbus_channel *channel, *sc; struct vmbus_channel *channel, *sc;
unsigned long flags;
while (atomic_read(&vmbus_connection.offer_in_progress) != 0) { while (atomic_read(&vmbus_connection.offer_in_progress) != 0) {
/* /*
@ -2402,12 +2401,10 @@ static int vmbus_bus_suspend(struct device *dev)
continue; continue;
} }
spin_lock_irqsave(&channel->lock, flags);
list_for_each_entry(sc, &channel->sc_list, sc_list) { list_for_each_entry(sc, &channel->sc_list, sc_list) {
pr_err("Sub-channel not deleted!\n"); pr_err("Sub-channel not deleted!\n");
WARN_ON_ONCE(1); WARN_ON_ONCE(1);
} }
spin_unlock_irqrestore(&channel->lock, flags);
atomic_inc(&vmbus_connection.nr_chan_fixup_on_resume); atomic_inc(&vmbus_connection.nr_chan_fixup_on_resume);
} }