Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-08 15:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

PM: Convert dev_pm_put_subsys_data() into a void function

Browse Source 
Clients using the dev_pm_put_subsys_data() API isn't interested of a
return value. They care only of decreasing a reference to the device's
pm_subsys_data. So, let's convert the API to a void function, which
anyway seems like reasonable thing to do.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Ulf Hansson 2015-01-29 18:39:05 +01:00 committed by Rafael J. Wysocki
parent 766bb53c01
commit 1e95e3b2da
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/base/power/common.c
View File

@ -56,13 +56,11 @@ EXPORT_SYMBOL_GPL(dev_pm_get_subsys_data);
* @dev: Device to handle. * @dev: Device to handle.
* *
* If the reference counter of power.subsys_data is zero after dropping the * If the reference counter of power.subsys_data is zero after dropping the
* reference, power.subsys_data is removed. Return 1 if that happens or 0 * reference, power.subsys_data is removed.
* otherwise.
*/ */
int dev_pm_put_subsys_data(struct device *dev) void dev_pm_put_subsys_data(struct device *dev)
{ {
struct pm_subsys_data *psd; struct pm_subsys_data *psd;
int ret = 1;
spin_lock_irq(&dev->power.lock); spin_lock_irq(&dev->power.lock);
@ -70,18 +68,14 @@ int dev_pm_put_subsys_data(struct device *dev)
if (!psd) if (!psd)
goto out; goto out;
if (--psd->refcount == 0) { if (--psd->refcount == 0)
dev->power.subsys_data = NULL; dev->power.subsys_data = NULL;
} else { else
psd = NULL; psd = NULL;
ret = 0;
}
out: out:
spin_unlock_irq(&dev->power.lock); spin_unlock_irq(&dev->power.lock);
kfree(psd); kfree(psd);
return ret;
} }
EXPORT_SYMBOL_GPL(dev_pm_put_subsys_data); EXPORT_SYMBOL_GPL(dev_pm_put_subsys_data);

2
include/linux/pm.h
View File

@ -597,7 +597,7 @@ struct dev_pm_info {
extern void update_pm_runtime_accounting(struct device *dev); extern void update_pm_runtime_accounting(struct device *dev);
extern int dev_pm_get_subsys_data(struct device *dev); extern int dev_pm_get_subsys_data(struct device *dev);
extern int dev_pm_put_subsys_data(struct device *dev); extern void dev_pm_put_subsys_data(struct device *dev);
/* /*
* Power domains provide callbacks that are executed during system suspend, * Power domains provide callbacks that are executed during system suspend,