From 233d687d1b78080ee79f67356327e0e0e50ef6f5 Mon Sep 17 00:00:00 2001 From: Rob Herring Date: Fri, 14 Jul 2023 11:46:54 -0600 Subject: [PATCH] macintosh: Explicitly include correct DT includes The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Link: https://lore.kernel.org/r/20230714174654.4058898-1-robh@kernel.org Signed-off-by: Rob Herring --- drivers/macintosh/ams/ams.h | 1 - drivers/macintosh/macio_asic.c | 1 + drivers/macintosh/smu.c | 1 + drivers/macintosh/therm_adt746x.c | 2 ++ drivers/macintosh/therm_windtunnel.c | 2 ++ drivers/macintosh/windfarm_lm75_sensor.c | 2 +- 6 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/ams/ams.h b/drivers/macintosh/ams/ams.h index 2c159c8844c1..e053c1515460 100644 --- a/drivers/macintosh/ams/ams.h +++ b/drivers/macintosh/ams/ams.h @@ -8,7 +8,6 @@ #include #include #include -#include enum ams_irq { AMS_IRQ_FREEFALL = 0x01, diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c index 211ed9aa9edc..a5ee8f736a8e 100644 --- a/drivers/macintosh/macio_asic.c +++ b/drivers/macintosh/macio_asic.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 5183a00529f5..b2b78a53e532 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include diff --git a/drivers/macintosh/therm_adt746x.c b/drivers/macintosh/therm_adt746x.c index 53ea56b286f9..00693741f744 100644 --- a/drivers/macintosh/therm_adt746x.c +++ b/drivers/macintosh/therm_adt746x.c @@ -25,7 +25,9 @@ #include #include #include +#include #include +#include #include #include diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c index 18a982454321..3c1b29476ce2 100644 --- a/drivers/macintosh/therm_windtunnel.c +++ b/drivers/macintosh/therm_windtunnel.c @@ -36,7 +36,9 @@ #include #include #include +#include #include +#include #include #include diff --git a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c index 48dbdb2bda15..b5d9c2e40148 100644 --- a/drivers/macintosh/windfarm_lm75_sensor.c +++ b/drivers/macintosh/windfarm_lm75_sensor.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include