Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-11 00:08:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

drm/radeon/radeon_fence.c: move a dereference below the NULL test

Browse Source 
If a NULL value is possible, the dereference should only occur after the
NULL test.

Coverity CID: 13334

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Darren Jenkins 2009-12-30 12:20:05 +11:00 committed by Dave Airlie
parent d8a7f79246
commit 3655d54af8
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/gpu/drm/radeon/radeon_fence.c
View File

@ -140,16 +140,15 @@ int radeon_fence_create(struct radeon_device *rdev, struct radeon_fence **fence)
bool radeon_fence_signaled(struct radeon_fence *fence) bool radeon_fence_signaled(struct radeon_fence *fence)
{ {
struct radeon_device *rdev = fence->rdev;
unsigned long irq_flags; unsigned long irq_flags;
bool signaled = false; bool signaled = false;
if (rdev->gpu_lockup) { if (!fence)
return true; return true;
}
if (fence == NULL) { if (fence->rdev->gpu_lockup)
return true; return true;
}
write_lock_irqsave(&fence->rdev->fence_drv.lock, irq_flags); write_lock_irqsave(&fence->rdev->fence_drv.lock, irq_flags);
signaled = fence->signaled; signaled = fence->signaled;
/* if we are shuting down report all fence as signaled */ /* if we are shuting down report all fence as signaled */