Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-16 21:35:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pmdomain: qcom-cpr: Fix the return of uninitialized variable

Browse Source 
The of_property_read_u64() can fail and remain the variable uninitialized,
which will then be returned. Initializing the variable "rate" to zero to
fix this problem.

Fixes: 181c8148556a ("pmdomain: qcom-cpr: Use scope based of_node_put() to simplify code.")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-pm/455a6a49-41d2-4a20-9a31-f57ee7a67920@huawei.com/T/#m0a62b501b453a6d6e94c52a428a66f65b5422c65
Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Link: https://lore.kernel.org/r/20240926134211.45394-1-zhangzekun11@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Zhang Zekun 2024-09-26 21:42:11 +08:00 committed by Ulf Hansson
parent eb8333673e
commit 500580c7ae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pmdomain/qcom/cpr.c
View File

@ -1052,7 +1052,7 @@ static unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
of_parse_phandle(child_np, "required-opps", 0); of_parse_phandle(child_np, "required-opps", 0);
if (child_req_np == ref_np) { if (child_req_np == ref_np) {
u64 rate; u64 rate = 0;
of_property_read_u64(child_np, "opp-hz", &rate); of_property_read_u64(child_np, "opp-hz", &rate);
return (unsigned long) rate; return (unsigned long) rate;