Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-18 22:34:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phy: qcom-qmp: fix return value check in qcom_qmp_phy_create()

Browse Source 
In case of error, the function of_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
Wei Yongjun 2017-04-25 03:14:54 +00:00 committed by Kishon Vijay Abraham I
parent 2ea659a9ef
commit 53bf959015
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/phy/phy-qcom-qmp.c
View File

@ -983,16 +983,16 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id)
* Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2. * Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2.
*/ */
qphy->tx = of_iomap(np, 0); qphy->tx = of_iomap(np, 0);
if (IS_ERR(qphy->tx)) if (!qphy->tx)
return PTR_ERR(qphy->tx); return -ENOMEM;
qphy->rx = of_iomap(np, 1); qphy->rx = of_iomap(np, 1);
if (IS_ERR(qphy->rx)) if (!qphy->rx)
return PTR_ERR(qphy->rx); return -ENOMEM;
qphy->pcs = of_iomap(np, 2); qphy->pcs = of_iomap(np, 2);
if (IS_ERR(qphy->pcs)) if (!qphy->pcs)
return PTR_ERR(qphy->pcs); return -ENOMEM;
/* /*
* Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3 * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3