Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-15 02:05:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ipmi: Remove incorrect use of seq_has_overflowed

Browse Source 
commit d6c5dc18d863 ("ipmi: Remove uses of return value of seq_printf")
incorrectly changed the return value of various proc_show functions
to use seq_has_overflowed().

These functions should return 0 on completion rather than 1/true
on overflow.  1 is the same as #define SEQ_SKIP which would cause
the output to not be emitted (skipped) instead.

This is a logical defect only as the length of these outputs are
all smaller than the initial allocation done by the seq filesystem.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Joe Perches 2015-02-22 10:21:07 -08:00 committed by Corey Minyard
parent b0e9aaa99d
commit 5e33cd0c5a
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/ipmi/ipmi_msghandler.c
View File

@ -2000,7 +2000,7 @@ static int smi_ipmb_proc_show(struct seq_file *m, void *v)
seq_printf(m, " %x", intf->channels[i].address); seq_printf(m, " %x", intf->channels[i].address);
seq_putc(m, '\n'); seq_putc(m, '\n');
return seq_has_overflowed(m); return 0;
} }
static int smi_ipmb_proc_open(struct inode *inode, struct file *file) static int smi_ipmb_proc_open(struct inode *inode, struct file *file)
@ -2023,7 +2023,7 @@ static int smi_version_proc_show(struct seq_file *m, void *v)
ipmi_version_major(&intf->bmc->id), ipmi_version_major(&intf->bmc->id),
ipmi_version_minor(&intf->bmc->id)); ipmi_version_minor(&intf->bmc->id));
return seq_has_overflowed(m); return 0;
} }
static int smi_version_proc_open(struct inode *inode, struct file *file) static int smi_version_proc_open(struct inode *inode, struct file *file)

4
drivers/char/ipmi/ipmi_si_intf.c
View File

@ -3080,7 +3080,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)
seq_printf(m, "%s\n", si_to_str[smi->si_type]); seq_printf(m, "%s\n", si_to_str[smi->si_type]);
return seq_has_overflowed(m); return 0;
} }
static int smi_type_proc_open(struct inode *inode, struct file *file) static int smi_type_proc_open(struct inode *inode, struct file *file)
@ -3153,7 +3153,7 @@ static int smi_params_proc_show(struct seq_file *m, void *v)
smi->irq, smi->irq,
smi->slave_addr); smi->slave_addr);
return seq_has_overflowed(m); return 0;
} }
static int smi_params_proc_open(struct inode *inode, struct file *file) static int smi_params_proc_open(struct inode *inode, struct file *file)

2
drivers/char/ipmi/ipmi_ssif.c
View File

@ -1200,7 +1200,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)
{ {
seq_puts(m, "ssif\n"); seq_puts(m, "ssif\n");
return seq_has_overflowed(m); return 0;
} }
static int smi_type_proc_open(struct inode *inode, struct file *file) static int smi_type_proc_open(struct inode *inode, struct file *file)