Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-04 04:02:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

io_uring: small optimisation of tctx_task_work

Browse Source 
There should be no completions stashed when we first get into
tctx_task_work(), so move completion flushing checks a bit later
after we had a chance to execute some task works.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/c6765c804f3c438591b9825ab9c43d22039073c4.1647897811.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Pavel Begunkov 2022-03-21 22:02:19 +00:00 committed by Jens Axboe
parent af2d861d4c
commit 68ca8fc002
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/io_uring.c
View File

@ -2475,10 +2475,6 @@ static void tctx_task_work(struct callback_head *cb)
while (1) { while (1) {
struct io_wq_work_node *node1, *node2; struct io_wq_work_node *node1, *node2;
if (!tctx->task_list.first &&
!tctx->prior_task_list.first && uring_locked)
io_submit_flush_completions(ctx);
spin_lock_irq(&tctx->task_lock); spin_lock_irq(&tctx->task_lock);
node1 = tctx->prior_task_list.first; node1 = tctx->prior_task_list.first;
node2 = tctx->task_list.first; node2 = tctx->task_list.first;
@ -2492,10 +2488,13 @@ static void tctx_task_work(struct callback_head *cb)
if (node1) if (node1)
handle_prev_tw_list(node1, &ctx, &uring_locked); handle_prev_tw_list(node1, &ctx, &uring_locked);
if (node2) if (node2)
handle_tw_list(node2, &ctx, &uring_locked); handle_tw_list(node2, &ctx, &uring_locked);
cond_resched(); cond_resched();
if (!tctx->task_list.first &&
!tctx->prior_task_list.first && uring_locked)
io_submit_flush_completions(ctx);
} }
ctx_flush_and_put(ctx, &uring_locked); ctx_flush_and_put(ctx, &uring_locked);