Merge branch 'for-next/hardening' into for-next/kspp

This commit is contained in:
Kees Cook 2024-12-16 16:37:56 -08:00
commit 7a059073b0
3 changed files with 55 additions and 6 deletions

View File

@ -616,6 +616,12 @@ __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size,
return false;
}
/*
* To work around what seems to be an optimizer bug, the macro arguments
* need to have const copies or the values end up changed by the time they
* reach fortify_warn_once(). See commit 6f7630b1b5bc ("fortify: Capture
* __bos() results in const temp vars") for more details.
*/
#define __fortify_memcpy_chk(p, q, size, p_size, q_size, \
p_size_field, q_size_field, op) ({ \
const size_t __fortify_size = (size_t)(size); \
@ -623,6 +629,8 @@ __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size,
const size_t __q_size = (q_size); \
const size_t __p_size_field = (p_size_field); \
const size_t __q_size_field = (q_size_field); \
/* Keep a mutable version of the size for the final copy. */ \
size_t __copy_size = __fortify_size; \
fortify_warn_once(fortify_memcpy_chk(__fortify_size, __p_size, \
__q_size, __p_size_field, \
__q_size_field, FORTIFY_FUNC_ ##op), \
@ -630,7 +638,11 @@ __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size,
__fortify_size, \
"field \"" #p "\" at " FILE_LINE, \
__p_size_field); \
__underlying_##op(p, q, __fortify_size); \
/* Hide only the run-time size from value range tracking to */ \
/* silence compile-time false positive bounds warnings. */ \
if (!__builtin_constant_p(__copy_size)) \
OPTIMIZER_HIDE_VAR(__copy_size); \
__underlying_##op(p, q, __copy_size); \
})
/*

View File

@ -38,22 +38,56 @@ TRACE_EVENT(task_rename,
TP_ARGS(task, comm),
TP_STRUCT__entry(
__field( pid_t, pid)
__array( char, oldcomm, TASK_COMM_LEN)
__array( char, newcomm, TASK_COMM_LEN)
__field( short, oom_score_adj)
),
TP_fast_assign(
__entry->pid = task->pid;
memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
strscpy(entry->newcomm, comm, TASK_COMM_LEN);
__entry->oom_score_adj = task->signal->oom_score_adj;
),
TP_printk("pid=%d oldcomm=%s newcomm=%s oom_score_adj=%hd",
__entry->pid, __entry->oldcomm,
__entry->newcomm, __entry->oom_score_adj)
TP_printk("oldcomm=%s newcomm=%s oom_score_adj=%hd",
__entry->oldcomm, __entry->newcomm, __entry->oom_score_adj)
);
/**
* task_prctl_unknown - called on unknown prctl() option
* @option: option passed
* @arg2: arg2 passed
* @arg3: arg3 passed
* @arg4: arg4 passed
* @arg5: arg5 passed
*
* Called on an unknown prctl() option.
*/
TRACE_EVENT(task_prctl_unknown,
TP_PROTO(int option, unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5),
TP_ARGS(option, arg2, arg3, arg4, arg5),
TP_STRUCT__entry(
__field( int, option)
__field( unsigned long, arg2)
__field( unsigned long, arg3)
__field( unsigned long, arg4)
__field( unsigned long, arg5)
),
TP_fast_assign(
__entry->option = option;
__entry->arg2 = arg2;
__entry->arg3 = arg3;
__entry->arg4 = arg4;
__entry->arg5 = arg5;
),
TP_printk("option=%d arg2=%ld arg3=%ld arg4=%ld arg5=%ld",
__entry->option, __entry->arg2, __entry->arg3, __entry->arg4, __entry->arg5)
);
#endif

View File

@ -75,6 +75,8 @@
#include <asm/io.h>
#include <asm/unistd.h>
#include <trace/events/task.h>
#include "uid16.h"
#ifndef SET_UNALIGN_CTL
@ -2810,6 +2812,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
error = arch_lock_shadow_stack_status(me, arg2);
break;
default:
trace_task_prctl_unknown(option, arg2, arg3, arg4, arg5);
error = -EINVAL;
break;
}