mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-28 00:32:00 +00:00
mm/page-owner: use gfp_nested_mask() instead of open coded masking
The page-owner tracking code records stack traces during page allocation. To do this, it must do a memory allocation for the stack information from inside an existing memory allocation context. This internal allocation must obey the high level caller allocation constraints to avoid generating false positive warnings that have nothing to do with the code they are instrumenting/tracking (e.g. through lockdep reclaim state tracking) We also don't want recording stack traces to deplete emergency memory reserves - debug code is useless if it creates new issues that can't be replicated when the debug code is disabled. Switch the stack tracking allocation masking to use gfp_nested_mask() to address these issues. gfp_nested_mask() naturally strips GFP_ZONEMASK, too, which greatly simplifies this code. Link: https://lkml.kernel.org/r/20240430054604.4169568-4-david@fromorbit.com Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Oscar Salvador <osalvador@suse.de> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Marco Elver <elver@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
parent
70c435ca8d
commit
99b80ac45f
@ -168,13 +168,8 @@ static void add_stack_record_to_list(struct stack_record *stack_record,
|
||||
unsigned long flags;
|
||||
struct stack *stack;
|
||||
|
||||
/* Filter gfp_mask the same way stackdepot does, for consistency */
|
||||
gfp_mask &= ~GFP_ZONEMASK;
|
||||
gfp_mask &= (GFP_ATOMIC | GFP_KERNEL | __GFP_NOLOCKDEP);
|
||||
gfp_mask |= __GFP_NOWARN;
|
||||
|
||||
set_current_in_page_owner();
|
||||
stack = kmalloc(sizeof(*stack), gfp_mask);
|
||||
stack = kmalloc(sizeof(*stack), gfp_nested_mask(gfp_mask));
|
||||
if (!stack) {
|
||||
unset_current_in_page_owner();
|
||||
return;
|
||||
|
Loading…
Reference in New Issue
Block a user