Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-16 13:34:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

leds: aw200xx: Switch to device_for_each_child_node_scoped()

Browse Source 
Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240927-leds_device_for_each_child_node_scoped-v1-4-95c0614b38c8@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Javier Carrasco 2024-09-27 01:20:55 +02:00 committed by Lee Jones
parent f64dd42a4f
commit a361af3c16
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/leds/leds-aw200xx.c
View File

@ -409,7 +409,6 @@ static int aw200xx_probe_get_display_rows(struct device *dev,
static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip) static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip)
{ {
struct fwnode_handle *child;
u32 current_min, current_max, min_uA; u32 current_min, current_max, min_uA;
int ret; int ret;
int i; int i;
@ -424,7 +423,7 @@ static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip)
min_uA = UINT_MAX; min_uA = UINT_MAX;
i = 0; i = 0;
device_for_each_child_node(dev, child) { device_for_each_child_node_scoped(dev, child) {
struct led_init_data init_data = {}; struct led_init_data init_data = {};
struct aw200xx_led *led; struct aw200xx_led *led;
u32 source, imax; u32 source, imax;
@ -468,10 +467,8 @@ static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip)
ret = devm_led_classdev_register_ext(dev, &led->cdev, ret = devm_led_classdev_register_ext(dev, &led->cdev,
&init_data); &init_data);
if (ret) { if (ret)
fwnode_handle_put(child);
break; break;
}
i++; i++;
} }