Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-11 16:29:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

HSI: nokia-modem: fix error return code

Browse Source 
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
Julia Lawall 2014-11-22 15:39:16 +01:00 committed by Sebastian Reichel
parent c517d838eb
commit b2249129f4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/hsi/clients/nokia-modem.c
View File

@ -200,6 +200,7 @@ static int nokia_modem_probe(struct device *dev)
modem->ssi_protocol = hsi_new_client(port, &ssip); modem->ssi_protocol = hsi_new_client(port, &ssip);
if (!modem->ssi_protocol) { if (!modem->ssi_protocol) {
dev_err(dev, "Could not register ssi-protocol device\n"); dev_err(dev, "Could not register ssi-protocol device\n");
err = -ENOMEM;
goto error2; goto error2;
} }