Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-15 21:23:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tty: serial: samsung: Improve naming for common macro

Browse Source 
Having "_USI" suffix in EXYNOS_COMMON_SERIAL_DRV_DATA_USI() macro is
confusing. Rename it to just EXYNOS_COMMON_SERIAL_DRV_DATA() and provide
USI registers availability for all Exynos variants instead. While at it,
also convert .has_usi field type to bool, so its usage is more obvious.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Link: https://lore.kernel.org/r/20211005095800.2165-1-semen.protsenko@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sam Protsenko 2021-10-05 12:58:00 +03:00 committed by Greg Kroah-Hartman
parent aec079f887
commit b84d000151
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/tty/serial/samsung_tty.c
View File

@ -65,7 +65,7 @@ enum s3c24xx_port_type {
struct s3c24xx_uart_info { struct s3c24xx_uart_info {
char *name; char *name;
enum s3c24xx_port_type type; enum s3c24xx_port_type type;
unsigned int has_usi; bool has_usi;
unsigned int port_type; unsigned int port_type;
unsigned int fifosize; unsigned int fifosize;
unsigned long rx_fifomask; unsigned long rx_fifomask;
@ -2780,7 +2780,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
#endif #endif
#if defined(CONFIG_ARCH_EXYNOS) #if defined(CONFIG_ARCH_EXYNOS)
#define EXYNOS_COMMON_SERIAL_DRV_DATA_USI(_has_usi) \ #define EXYNOS_COMMON_SERIAL_DRV_DATA(_has_usi) \
.info = &(struct s3c24xx_uart_info) { \ .info = &(struct s3c24xx_uart_info) { \
.name = "Samsung Exynos UART", \ .name = "Samsung Exynos UART", \
.type = TYPE_S3C6400, \ .type = TYPE_S3C6400, \
@ -2804,21 +2804,18 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
.has_fracval = 1, \ .has_fracval = 1, \
} \ } \
#define EXYNOS_COMMON_SERIAL_DRV_DATA \
EXYNOS_COMMON_SERIAL_DRV_DATA_USI(0)
static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
EXYNOS_COMMON_SERIAL_DRV_DATA, EXYNOS_COMMON_SERIAL_DRV_DATA(false),
.fifosize = { 256, 64, 16, 16 }, .fifosize = { 256, 64, 16, 16 },
}; };
static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
EXYNOS_COMMON_SERIAL_DRV_DATA, EXYNOS_COMMON_SERIAL_DRV_DATA(false),
.fifosize = { 64, 256, 16, 256 }, .fifosize = { 64, 256, 16, 256 },
}; };
static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), EXYNOS_COMMON_SERIAL_DRV_DATA(true),
.fifosize = { 256, 64, 64, 64 }, .fifosize = { 256, 64, 64, 64 },
}; };