Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2024-12-29 09:12:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cpufreq: Avoid a bad reference count on CPU node

Browse Source 
In the parse_perf_domain function, if the call to
of_parse_phandle_with_args returns an error, then the reference to the
CPU device node that was acquired at the start of the function would not
be properly decremented.

Address this by declaring the variable with the __free(device_node)
cleanup attribute.

Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/20240917134246.584026-1-mikisabate@gmail.com
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Miquel Sabaté Solà 2024-09-17 15:42:46 +02:00 committed by Rafael J. Wysocki
parent 8b4865cd90
commit c0f02536ff
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/cpufreq.h
View File

@ -1107,10 +1107,9 @@ static inline int parse_perf_domain(int cpu, const char *list_name,
const char *cell_name, const char *cell_name,
struct of_phandle_args *args) struct of_phandle_args *args)
{ {
struct device_node *cpu_np;
int ret; int ret;
cpu_np = of_cpu_device_node_get(cpu); struct device_node *cpu_np __free(device_node) = of_cpu_device_node_get(cpu);
if (!cpu_np) if (!cpu_np)
return -ENODEV; return -ENODEV;
@ -1118,9 +1117,6 @@ static inline int parse_perf_domain(int cpu, const char *list_name,
args); args);
if (ret < 0) if (ret < 0)
return ret; return ret;
of_node_put(cpu_np);
return 0; return 0;
} }