Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2024-12-29 09:12:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc_contig*()

Browse Source 
Patch series "mm: don't use __GFP_HARDWALL when migrating remote pages".

__GFP_HARDWALL means that we will be respecting the cpuset of the caller
when allocating a page.  However, when we are migrating remote allocations
(pages allocated from other context), the cpuset of the current context is
irrelevant.

For memory offlining + alloc_contig_*(), this is rather obvious.  There
might be other such page migration users, let's start with the obvious
ones.


This patch (of 2):

We'll migrate pages allocated by other contexts; respecting the cpuset of
the alloc_contig*() caller when allocating a migration target does not
make sense.

Drop the __GFP_HARDWALL.

Note that in an ideal world, migration code could figure out the cpuset
of the original context and take that into consideration.

Link: https://lkml.kernel.org/r/20241205090508.2095225-1-david@redhat.com
Link: https://lkml.kernel.org/r/20241205090508.2095225-2-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
David Hildenbrand 2024-12-05 10:05:07 +01:00 committed by Andrew Morton
parent 86a4cc8aec
commit d235a15489
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/page_alloc.c
View File

@ -6412,11 +6412,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask)
* page range. Migratable pages are movable, __GFP_MOVABLE is implied
* for them.
*
* Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set,
* keep doing that to not degrade callers.
* Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that
* to not degrade callers.
*/
*gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) |
__GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
__GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
return 0;
}