mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-29 09:12:07 +00:00
checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit
As opposed to the --diff option, --commit can get ref names instead of commit hashes. When using the --commit option, the script resets the working directory to the commit before the given ref, by adding '~' to the end of the ref. However, the 'HEAD' ref is relative, and so when the working directory is reset to 'HEAD~', 'HEAD' points to what was 'HEAD~'. Then when the script resets to 'HEAD' it actually stays in the same commit. In this case, the script won't report any cases because there is no diff between the cases of the two refs. Prevent the user from using HEAD refs. A better solution might be to resolve the refs before doing the reset, but for now just disallow such refs. Signed-off-by: Ariel Marcovitch <arielmarcovitch@gmail.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
parent
6880fa6c56
commit
d62d5aed33
@ -102,6 +102,9 @@ def parse_options():
|
||||
"continue.")
|
||||
|
||||
if args.commit:
|
||||
if args.commit.startswith('HEAD'):
|
||||
sys.exit("The --commit option can't use the HEAD ref")
|
||||
|
||||
args.find = False
|
||||
|
||||
if args.ignore:
|
||||
|
Loading…
Reference in New Issue
Block a user