Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-08 15:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: vchiq_core: get rid of typedef

Browse Source 
The typedef BITSET_T is acting as a synonym of u32. However, using the type u32
directly makes the code more readable. Furthermore, typedef should only be used
in some cases, [1]. Hence, get rid of it.

[1] Documentation/process/coding-style.rst

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20211029200012.45986-1-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gaston Gonzalez 2021-10-29 17:00:12 -03:00 committed by Greg Kroah-Hartman
parent bdcfac6ab6
commit d8a364820e
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
View File

@ -711,7 +711,7 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking)
} }
static void static void
process_free_data_message(struct vchiq_state *state, BITSET_T *service_found, process_free_data_message(struct vchiq_state *state, u32 *service_found,
struct vchiq_header *header) struct vchiq_header *header)
{ {
int msgid = header->msgid; int msgid = header->msgid;
@ -767,7 +767,7 @@ process_free_data_message(struct vchiq_state *state, BITSET_T *service_found,
/* Called by the recycle thread. */ /* Called by the recycle thread. */
static void static void
process_free_queue(struct vchiq_state *state, BITSET_T *service_found, process_free_queue(struct vchiq_state *state, u32 *service_found,
size_t length) size_t length)
{ {
struct vchiq_shared_state *local = state->local; struct vchiq_shared_state *local = state->local;
@ -1981,7 +1981,7 @@ recycle_func(void *v)
{ {
struct vchiq_state *state = v; struct vchiq_state *state = v;
struct vchiq_shared_state *local = state->local; struct vchiq_shared_state *local = state->local;
BITSET_T *found; u32 *found;
size_t length; size_t length;
length = sizeof(*found) * BITSET_SIZE(VCHIQ_MAX_SERVICES); length = sizeof(*found) * BITSET_SIZE(VCHIQ_MAX_SERVICES);

4
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
View File

@ -74,9 +74,7 @@
((fourcc) >> 8) & 0xff, \ ((fourcc) >> 8) & 0xff, \
(fourcc) & 0xff (fourcc) & 0xff
typedef u32 BITSET_T; static_assert((sizeof(u32) * 8) == 32);
static_assert((sizeof(BITSET_T) * 8) == 32);
#define BITSET_SIZE(b) ((b + 31) >> 5) #define BITSET_SIZE(b) ((b + 31) >> 5)
#define BITSET_WORD(b) (b >> 5) #define BITSET_WORD(b) (b >> 5)