Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 15:29:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: unisys: visorbus: add error handling to error_show

Browse Source 
Don't just drop the error from visorchannel_read on the floor, report it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2017-03-28 09:34:25 -04:00 committed by Greg Kroah-Hartman
parent 0b01c6ce5a
commit d9857c794e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/unisys/visorbus/visorchipset.c
View File

@ -170,11 +170,14 @@ static ssize_t error_show(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
{ {
u32 error = 0; u32 error = 0;
int err;
visorchannel_read(chipset_dev->controlvm_channel, err = visorchannel_read(chipset_dev->controlvm_channel,
offsetof(struct spar_controlvm_channel_protocol, offsetof(struct spar_controlvm_channel_protocol,
installation_error), installation_error),
&error, sizeof(u32)); &error, sizeof(u32));
if (err)
return err;
return sprintf(buf, "%i\n", error); return sprintf(buf, "%i\n", error);
} }