Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-01 10:42:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

platform/x86: hp-wmi: Fix implementation of the platform_profile_omen_get function

Browse Source 
Fix ill-formed implementation of the platform_profile_omen_get function
introduced by the commit d234302334 ("platform/x86: hp-wmi: Fix
platform profile option switch bug on Omen and Victus laptops").
platform_profile_omen_get() is .profile_get function that should set
*profile and return 0 on success.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: d234302334 ("platform/x86: hp-wmi: Fix platform profile option switch bug on Omen and Victus laptops")
Signed-off-by: Alexis Belmonte <alexbelm48@gmail.com>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/ZpFnV8w1558BW7iZ@alexis-pc
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Alexis Belmonte 2024-07-12 19:26:47 +02:00 committed by Ilpo Järvinen
parent 1e02e31747
commit f6bd2f633b
No known key found for this signature in database
GPG Key ID: 59AC4F6153E5CE31
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/platform/x86/hp/hp-wmi.c
View File

@ -1238,8 +1238,6 @@ static int platform_profile_omen_get_ec(enum platform_profile_option *profile)
static int platform_profile_omen_get(struct platform_profile_handler *pprof,
enum platform_profile_option *profile)
{
enum platform_profile_option selected_platform_profile;
/*
* We directly return the stored platform profile, as the embedded
* controller will not accept switching to the performance option when
@ -1253,9 +1251,9 @@ static int platform_profile_omen_get(struct platform_profile_handler *pprof,
* See also omen_powersource_event.
*/
guard(mutex)(&active_platform_profile_lock);
selected_platform_profile = active_platform_profile;
*profile = active_platform_profile;
return selected_platform_profile;
return 0;
}
static bool has_omen_thermal_profile_ec_timer(void)