mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-28 16:52:18 +00:00
d4519378e4
Currently btrfs_validate_super() only does a very basic check on the array chunk size (not too large than the available space, but not too small to contain no chunk). The more comprehensive checks (the regular chunk checks and size check inside the system chunk array) is all done inside btrfs_read_sys_array(). It's not a big deal, but for the sake of concentrated verification, we should validate the system chunk array at the time of super block validation. So this patch does the following modification: - Introduce a helper btrfs_check_system_chunk_array() * Validate the disk key * Validate the size before we access the full chunk/stripe items. * Do the full chunk item validation - Call btrfs_check_system_chunk_array() at btrfs_validate_super() - Simplify the checks inside btrfs_read_sys_array() Now the checks will be converted to an ASSERT(). - Simplify the checks inside read_one_chunk() Now all chunk items inside system chunk array and chunk tree is verified, there is no need to verify it again inside read_one_chunk(). This change has the following advantages: - More comprehensive checks at write time Although this also means extra memcpy() for the superblocks at write time, due to the limits that we need a dummy extent buffer to utilize all the extent buffer helpers. - Slightly improved readablity when iterating the system chunk array Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
79 lines
2.1 KiB
C
79 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (C) Qu Wenruo 2017. All rights reserved.
|
|
*/
|
|
|
|
#ifndef BTRFS_TREE_CHECKER_H
|
|
#define BTRFS_TREE_CHECKER_H
|
|
|
|
#include <linux/types.h>
|
|
#include <uapi/linux/btrfs_tree.h>
|
|
#include "fs.h"
|
|
|
|
struct extent_buffer;
|
|
struct btrfs_chunk;
|
|
struct btrfs_key;
|
|
|
|
/* All the extra info needed to verify the parentness of a tree block. */
|
|
struct btrfs_tree_parent_check {
|
|
/*
|
|
* The owner check against the tree block.
|
|
*
|
|
* Can be 0 to skip the owner check.
|
|
*/
|
|
u64 owner_root;
|
|
|
|
/*
|
|
* Expected transid, can be 0 to skip the check, but such skip
|
|
* should only be utilized for backref walk related code.
|
|
*/
|
|
u64 transid;
|
|
|
|
/*
|
|
* The expected first key.
|
|
*
|
|
* This check can be skipped if @has_first_key is false, such skip
|
|
* can happen for case where we don't have the parent node key,
|
|
* e.g. reading the tree root, doing backref walk.
|
|
*/
|
|
struct btrfs_key first_key;
|
|
bool has_first_key;
|
|
|
|
/* The expected level. Should always be set. */
|
|
u8 level;
|
|
};
|
|
|
|
enum btrfs_tree_block_status {
|
|
BTRFS_TREE_BLOCK_CLEAN,
|
|
BTRFS_TREE_BLOCK_INVALID_NRITEMS,
|
|
BTRFS_TREE_BLOCK_INVALID_PARENT_KEY,
|
|
BTRFS_TREE_BLOCK_BAD_KEY_ORDER,
|
|
BTRFS_TREE_BLOCK_INVALID_LEVEL,
|
|
BTRFS_TREE_BLOCK_INVALID_FREE_SPACE,
|
|
BTRFS_TREE_BLOCK_INVALID_OFFSETS,
|
|
BTRFS_TREE_BLOCK_INVALID_BLOCKPTR,
|
|
BTRFS_TREE_BLOCK_INVALID_ITEM,
|
|
BTRFS_TREE_BLOCK_INVALID_OWNER,
|
|
BTRFS_TREE_BLOCK_WRITTEN_NOT_SET,
|
|
};
|
|
|
|
/*
|
|
* Exported simply for btrfs-progs which wants to have the
|
|
* btrfs_tree_block_status return codes.
|
|
*/
|
|
enum btrfs_tree_block_status __btrfs_check_leaf(struct extent_buffer *leaf);
|
|
enum btrfs_tree_block_status __btrfs_check_node(struct extent_buffer *node);
|
|
|
|
int btrfs_check_leaf(struct extent_buffer *leaf);
|
|
int btrfs_check_node(struct extent_buffer *node);
|
|
|
|
int btrfs_check_chunk_valid(struct extent_buffer *leaf,
|
|
struct btrfs_chunk *chunk, u64 logical);
|
|
int btrfs_check_system_chunk_array(struct btrfs_fs_info *fs_info,
|
|
const struct btrfs_super_block *sb);
|
|
int btrfs_check_eb_owner(const struct extent_buffer *eb, u64 root_owner);
|
|
int btrfs_verify_level_key(struct extent_buffer *eb,
|
|
const struct btrfs_tree_parent_check *check);
|
|
|
|
#endif
|