mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-28 16:52:18 +00:00
dbefa1f31a
Commitb1fca27d38("kernel debug: support resetting WARN*_ONCE") added support for clearing the state of once warnings. However, it is not functional when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION or CONFIG_LTO_CLANG is enabled, because .data.once matches the .data.[0-9a-zA-Z_]* pattern in the DATA_MAIN macro. Commitcb87481ee8("kbuild: linker script do not match C names unless LD_DEAD_CODE_DATA_ELIMINATION is configured") was introduced to suppress the issue for the default CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n case, providing a minimal fix for stable backporting. We were aware this did not address the issue for CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y. The plan was to apply correct fixes and then revertcb87481ee8. [1] Seven years have passed since then, yet the #ifdef workaround remains in place. Meanwhile, commitb1fca27d38introduced the .data.once section, and commitdc5723b02e("kbuild: add support for Clang LTO") extended the #ifdef. Using a ".." separator in the section name fixes the issue for CONFIG_LD_DEAD_CODE_DATA_ELIMINATION and CONFIG_LTO_CLANG. [1]: https://lore.kernel.org/linux-kbuild/CAK7LNASck6BfdLnESxXUeECYL26yUDm0cwRZuM4gmaWUkxjL5g@mail.gmail.com/ Fixes:b1fca27d38("kernel debug: support resetting WARN*_ONCE") Fixes:dc5723b02e("kbuild: add support for Clang LTO") Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
87 lines
2.7 KiB
C
87 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_ONCE_H
|
|
#define _LINUX_ONCE_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/jump_label.h>
|
|
|
|
/* Helpers used from arbitrary contexts.
|
|
* Hard irqs are blocked, be cautious.
|
|
*/
|
|
bool __do_once_start(bool *done, unsigned long *flags);
|
|
void __do_once_done(bool *done, struct static_key_true *once_key,
|
|
unsigned long *flags, struct module *mod);
|
|
|
|
/* Variant for process contexts only. */
|
|
bool __do_once_sleepable_start(bool *done);
|
|
void __do_once_sleepable_done(bool *done, struct static_key_true *once_key,
|
|
struct module *mod);
|
|
|
|
/* Call a function exactly once. The idea of DO_ONCE() is to perform
|
|
* a function call such as initialization of random seeds, etc, only
|
|
* once, where DO_ONCE() can live in the fast-path. After @func has
|
|
* been called with the passed arguments, the static key will patch
|
|
* out the condition into a nop. DO_ONCE() guarantees type safety of
|
|
* arguments!
|
|
*
|
|
* Note that the following is not equivalent ...
|
|
*
|
|
* DO_ONCE(func, arg);
|
|
* DO_ONCE(func, arg);
|
|
*
|
|
* ... to this version:
|
|
*
|
|
* void foo(void)
|
|
* {
|
|
* DO_ONCE(func, arg);
|
|
* }
|
|
*
|
|
* foo();
|
|
* foo();
|
|
*
|
|
* In case the one-time invocation could be triggered from multiple
|
|
* places, then a common helper function must be defined, so that only
|
|
* a single static key will be placed there!
|
|
*/
|
|
#define DO_ONCE(func, ...) \
|
|
({ \
|
|
bool ___ret = false; \
|
|
static bool __section(".data..once") ___done = false; \
|
|
static DEFINE_STATIC_KEY_TRUE(___once_key); \
|
|
if (static_branch_unlikely(&___once_key)) { \
|
|
unsigned long ___flags; \
|
|
___ret = __do_once_start(&___done, &___flags); \
|
|
if (unlikely(___ret)) { \
|
|
func(__VA_ARGS__); \
|
|
__do_once_done(&___done, &___once_key, \
|
|
&___flags, THIS_MODULE); \
|
|
} \
|
|
} \
|
|
___ret; \
|
|
})
|
|
|
|
/* Variant of DO_ONCE() for process/sleepable contexts. */
|
|
#define DO_ONCE_SLEEPABLE(func, ...) \
|
|
({ \
|
|
bool ___ret = false; \
|
|
static bool __section(".data..once") ___done = false; \
|
|
static DEFINE_STATIC_KEY_TRUE(___once_key); \
|
|
if (static_branch_unlikely(&___once_key)) { \
|
|
___ret = __do_once_sleepable_start(&___done); \
|
|
if (unlikely(___ret)) { \
|
|
func(__VA_ARGS__); \
|
|
__do_once_sleepable_done(&___done, &___once_key,\
|
|
THIS_MODULE); \
|
|
} \
|
|
} \
|
|
___ret; \
|
|
})
|
|
|
|
#define get_random_once(buf, nbytes) \
|
|
DO_ONCE(get_random_bytes, (buf), (nbytes))
|
|
|
|
#define get_random_sleepable_once(buf, nbytes) \
|
|
DO_ONCE_SLEEPABLE(get_random_bytes, (buf), (nbytes))
|
|
|
|
#endif /* _LINUX_ONCE_H */
|