mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-28 16:52:18 +00:00
78eb4ea25c
const qualify the struct ctl_table argument in the proc_handler function
signatures. This is a prerequisite to moving the static ctl_table
structs into .rodata data which will ensure that proc_handler function
pointers cannot be modified.
This patch has been generated by the following coccinelle script:
```
virtual patch
@r1@
identifier ctl, write, buffer, lenp, ppos;
identifier func !~ "appldata_(timer|interval)_handler|sched_(rt|rr)_handler|rds_tcp_skbuf_handler|proc_sctp_do_(hmac_alg|rto_min|rto_max|udp_port|alpha_beta|auth|probe_interval)";
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int write, void *buffer, size_t *lenp, loff_t *ppos);
@r2@
identifier func, ctl, write, buffer, lenp, ppos;
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int write, void *buffer, size_t *lenp, loff_t *ppos)
{ ... }
@r3@
identifier func;
@@
int func(
- struct ctl_table *
+ const struct ctl_table *
,int , void *, size_t *, loff_t *);
@r4@
identifier func, ctl;
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int , void *, size_t *, loff_t *);
@r5@
identifier func, write, buffer, lenp, ppos;
@@
int func(
- struct ctl_table *
+ const struct ctl_table *
,int write, void *buffer, size_t *lenp, loff_t *ppos);
```
* Code formatting was adjusted in xfs_sysctl.c to comply with code
conventions. The xfs_stats_clear_proc_handler,
xfs_panic_mask_proc_handler and xfs_deprecated_dointvec_minmax where
adjusted.
* The ctl_table argument in proc_watchdog_common was const qualified.
This is called from a proc_handler itself and is calling back into
another proc_handler, making it necessary to change it as part of the
proc_handler migration.
Co-developed-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Co-developed-by: Joel Granados <j.granados@samsung.com>
Signed-off-by: Joel Granados <j.granados@samsung.com>
96 lines
2.2 KiB
C
96 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* File: sysctl.c
|
|
*
|
|
* Phonet /proc/sys/net/phonet interface implementation
|
|
*
|
|
* Copyright (C) 2008 Nokia Corporation.
|
|
*
|
|
* Author: Rémi Denis-Courmont
|
|
*/
|
|
|
|
#include <linux/seqlock.h>
|
|
#include <linux/sysctl.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
|
|
#include <net/sock.h>
|
|
#include <linux/phonet.h>
|
|
#include <net/phonet/phonet.h>
|
|
|
|
#define DYNAMIC_PORT_MIN 0x40
|
|
#define DYNAMIC_PORT_MAX 0x7f
|
|
|
|
static DEFINE_SEQLOCK(local_port_range_lock);
|
|
static int local_port_range_min[2] = {0, 0};
|
|
static int local_port_range_max[2] = {1023, 1023};
|
|
static int local_port_range[2] = {DYNAMIC_PORT_MIN, DYNAMIC_PORT_MAX};
|
|
static struct ctl_table_header *phonet_table_hrd;
|
|
|
|
static void set_local_port_range(int range[2])
|
|
{
|
|
write_seqlock(&local_port_range_lock);
|
|
local_port_range[0] = range[0];
|
|
local_port_range[1] = range[1];
|
|
write_sequnlock(&local_port_range_lock);
|
|
}
|
|
|
|
void phonet_get_local_port_range(int *min, int *max)
|
|
{
|
|
unsigned int seq;
|
|
|
|
do {
|
|
seq = read_seqbegin(&local_port_range_lock);
|
|
if (min)
|
|
*min = local_port_range[0];
|
|
if (max)
|
|
*max = local_port_range[1];
|
|
} while (read_seqretry(&local_port_range_lock, seq));
|
|
}
|
|
|
|
static int proc_local_port_range(const struct ctl_table *table, int write,
|
|
void *buffer, size_t *lenp, loff_t *ppos)
|
|
{
|
|
int ret;
|
|
int range[2] = {local_port_range[0], local_port_range[1]};
|
|
struct ctl_table tmp = {
|
|
.data = &range,
|
|
.maxlen = sizeof(range),
|
|
.mode = table->mode,
|
|
.extra1 = &local_port_range_min,
|
|
.extra2 = &local_port_range_max,
|
|
};
|
|
|
|
ret = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
|
|
|
|
if (write && ret == 0) {
|
|
if (range[1] < range[0])
|
|
ret = -EINVAL;
|
|
else
|
|
set_local_port_range(range);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static struct ctl_table phonet_table[] = {
|
|
{
|
|
.procname = "local_port_range",
|
|
.data = &local_port_range,
|
|
.maxlen = sizeof(local_port_range),
|
|
.mode = 0644,
|
|
.proc_handler = proc_local_port_range,
|
|
},
|
|
};
|
|
|
|
int __init phonet_sysctl_init(void)
|
|
{
|
|
phonet_table_hrd = register_net_sysctl(&init_net, "net/phonet", phonet_table);
|
|
return phonet_table_hrd == NULL ? -ENOMEM : 0;
|
|
}
|
|
|
|
void phonet_sysctl_exit(void)
|
|
{
|
|
unregister_net_sysctl_table(phonet_table_hrd);
|
|
}
|