Al Viro
1d2ef59014
restore pinning the victim dentry in vfs_rmdir()/vfs_rename_dir() ...
We used to get the victim pinned by dentry_unhash() prior to commit
64252c75a219 ("vfs: remove dget() from dentry_unhash()") and ->rmdir()
and ->rename() instances relied on that; most of them don't care, but
ones that used d_delete() themselves do. As the result, we are getting
rmdir() oopses on NFS now.
Just grab the reference before locking the victim and drop it explicitly
after unlocking, same as vfs_rename_other() does.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Tested-by: Simon Kirby <sim@hostway.ca>
Cc: stable@kernel.org (3.0.x)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-09-14 11:31:55 -07:00
2011-09-06 08:17:16 -05:00
2011-03-31 11:26:23 -03:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:48:03 -04:00
2011-08-08 12:02:43 -07:00
2011-08-17 13:31:24 -07:00
2011-05-28 01:02:50 -04:00
2011-09-12 11:47:49 -07:00
2011-07-20 01:44:21 -04:00
2011-09-09 15:48:34 -07:00
2011-08-18 16:55:10 +00:00
2011-07-20 20:47:59 -04:00
2011-05-28 01:02:54 -04:00
2011-07-17 23:22:02 -04:00
2011-05-19 16:55:28 +09:30
2011-03-22 17:44:17 -07:00
2011-07-25 22:49:19 -07:00
2011-08-09 23:29:01 -05:00
2011-07-20 01:44:26 -04:00
2011-08-06 22:56:03 -07:00
2011-03-15 02:21:44 -04:00
2011-08-01 13:48:31 -10:00
2011-08-11 17:23:40 -07:00
2011-08-31 11:50:51 -04:00
2011-08-18 14:16:13 -07:00
2011-05-10 10:16:21 +02:00
2011-07-21 10:59:16 -07:00
2011-09-12 11:47:10 -07:00
2011-08-01 13:48:31 -10:00
2011-07-20 20:47:59 -04:00
2011-07-22 19:02:39 -07:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:47:59 -04:00
2011-07-27 22:21:58 -04:00
2011-08-25 10:50:18 -07:00
2011-07-22 19:42:12 -04:00
2011-06-28 00:06:41 +02:00
2011-07-10 22:05:08 -04:00
2011-08-01 02:10:06 -04:00
2011-08-15 08:40:24 -07:00
2011-07-27 13:23:02 -07:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:47:53 -04:00
2011-07-20 20:47:59 -04:00
2011-08-18 22:47:13 -07:00
2011-03-31 11:26:23 -03:00
2011-07-25 22:49:19 -07:00
2011-07-20 20:47:59 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-08-01 02:10:06 -04:00
2011-07-26 13:05:28 -04:00
2011-07-01 16:17:13 +02:00
2011-08-06 11:51:33 -07:00
2011-07-22 16:14:39 -07:00
2011-03-10 08:52:07 +01:00
2011-05-25 08:39:26 -07:00
2011-04-14 16:06:56 -07:00
2011-08-01 02:10:06 -04:00
2011-06-27 18:00:12 -07:00
2011-07-25 22:50:35 -07:00
2011-07-20 01:43:24 -04:00
2011-05-28 01:02:50 -04:00
2011-08-19 18:58:58 +03:00
2011-07-20 01:43:07 -04:00
2011-07-20 01:44:26 -04:00
2011-09-01 09:46:11 -05:00
2011-03-24 10:16:26 -07:00
2011-07-26 12:57:09 -04:00
2011-07-20 20:47:47 -04:00
2011-07-20 20:47:59 -04:00
2011-07-20 01:43:10 -04:00
2011-07-20 01:43:10 -04:00
2011-05-03 10:10:51 +10:00
2011-07-20 01:43:10 -04:00
2011-03-17 11:11:05 +01:00
2011-05-28 14:44:46 +02:00
2011-09-10 17:20:21 +10:00
2011-06-16 11:44:46 -04:00
2011-01-13 10:45:01 -08:00
2011-08-07 22:24:41 -07:00
2011-08-26 15:09:58 -07:00
2011-08-06 22:52:40 -07:00
2011-05-31 16:33:35 +02:00
2011-07-26 16:49:47 -07:00
2011-05-25 08:39:26 -07:00
2011-02-21 15:07:04 -08:00
2011-07-26 16:49:47 -07:00
2011-08-11 11:24:42 -07:00
2011-03-23 19:47:13 -07:00
2011-04-14 16:06:56 -07:00
2011-03-21 00:16:09 -04:00
2011-07-26 16:49:47 -07:00
2011-04-28 11:28:20 -07:00
2011-04-17 10:42:01 -07:00
2011-01-16 13:47:07 -05:00
2011-07-31 22:52:08 +08:00
2011-08-01 02:10:06 -04:00
2011-08-25 10:50:18 -07:00
2011-07-20 01:44:38 -04:00
2011-03-21 00:16:08 -04:00
2011-08-03 14:25:25 -10:00
2011-07-22 19:42:11 -04:00
2011-07-20 20:23:19 -04:00
2011-07-15 18:58:42 -04:00
2011-05-25 08:39:26 -07:00
2011-05-26 10:01:43 -06:00
2011-09-14 11:31:55 -07:00
2011-07-24 10:08:32 -04:00
2011-07-26 15:07:43 -04:00
2011-07-26 12:57:09 -04:00
2011-08-01 02:10:32 -04:00
2011-07-26 12:57:09 -04:00
2011-03-21 00:16:08 -04:00
2011-07-25 20:57:11 -07:00
2011-08-03 14:25:24 -10:00
2011-08-06 22:53:23 -07:00
2011-03-14 09:15:28 -04:00
2011-07-25 10:33:36 -07:00
2011-07-20 20:47:59 -04:00
2011-06-14 11:46:14 +02:00
2011-03-23 19:47:13 -07:00
2011-05-28 12:02:09 -04:00
1d2ef59014