linux-next/security/smack
Jiawei Ye 2749749afa smackfs: Use rcu_assign_pointer() to ensure safe assignment in smk_set_cipso
In the `smk_set_cipso` function, the `skp->smk_netlabel.attr.mls.cat`
field is directly assigned to a new value without using the appropriate
RCU pointer assignment functions. According to RCU usage rules, this is
illegal and can lead to unpredictable behavior, including data
inconsistencies and impossible-to-diagnose memory corruption issues.

This possible bug was identified using a static analysis tool developed
by myself, specifically designed to detect RCU-related issues.

To address this, the assignment is now done using rcu_assign_pointer(),
which ensures that the pointer assignment is done safely, with the
necessary memory barriers and synchronization. This change prevents
potential RCU dereference issues by ensuring that the `cat` field is
safely updated while still adhering to RCU's requirements.

Fixes: 0817534ff9 ("smackfs: Fix use-after-free in netlbl_catmap_walk()")
Signed-off-by: Jiawei Ye <jiawei.ye@foxmail.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
2024-09-03 08:37:17 -07:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
smack_access.c smack: Replace kzalloc + strncpy with kstrndup 2022-08-01 11:26:09 -07:00
smack_lsm.c Two fixes for Smack networking by Konstantin Andreev. 2024-07-16 14:56:13 -07:00
smack_netfilter.c security: smack: Fix indentation in smack_netfilter.c 2024-08-22 13:38:56 -07:00
smack.h smack: Set the SMACK64TRANSMUTE xattr in smack_inode_init_security() 2023-07-10 13:59:38 -04:00
smackfs.c smackfs: Use rcu_assign_pointer() to ensure safe assignment in smk_set_cipso 2024-09-03 08:37:17 -07:00