Qu Wenruo 31723c9542 btrfs: tree-checker: reject BTRFS_FT_UNKNOWN dir type ...

[REPORT]
There is a bug report that kernel is rejecting a mismatching inode mode
and its dir item:

  [ 1881.553937] BTRFS critical (device dm-0): inode mode mismatch with
  dir: inode mode=040700 btrfs type=2 dir type=0

[CAUSE]
It looks like the inode mode is correct, while the dir item type
0 is BTRFS_FT_UNKNOWN, which should not be generated by btrfs at all.

This may be caused by a memory bit flip.

[ENHANCEMENT]
Although tree-checker is not able to do any cross-leaf verification, for
this particular case we can at least reject any dir type with
BTRFS_FT_UNKNOWN.

So here we enhance the dir type check from [0, BTRFS_FT_MAX), to
(0, BTRFS_FT_MAX).
Although the existing corruption can not be fixed just by such enhanced
checking, it should prevent the same 0x2->0x0 bitflip for dir type to
reach disk in the future.

Reported-by: Kota <nospam@kota.moe>
Link: https://lore.kernel.org/linux-btrfs/CACsxjPYnQF9ZF-0OhH16dAx50=BXXOcP74MxBc3BG+xae4vTTw@mail.gmail.com/
CC: stable@vger.kernel.org # 5.4+
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

2024-08-13 13:42:26 +02:00

..

tests

btrfs: fix corrupt read due to bad offset of a compressed extent map

2024-07-25 23:54:06 +02:00

accessors.c

btrfs: remove unused included headers

2024-03-04 16:24:46 +01:00

accessors.h

btrfs: remove raid-stripe-tree encoding field from stripe_extent

2024-07-11 15:33:28 +02:00

acl.c

btrfs: remove unused included headers

2024-03-04 16:24:46 +01:00

acl.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

async-thread.c

btrfs: remove unused included headers

2024-03-04 16:24:46 +01:00

async-thread.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

backref.c

btrfs: change root->root_key.objectid to btrfs_root_id()

2024-05-07 21:31:06 +02:00

backref.h

btrfs: uninline some static inline helpers from backref.h

2024-03-04 16:24:53 +01:00

bio.c

btrfs: introduce new "rescue=ignoremetacsums" mount option

2024-07-11 15:33:29 +02:00

bio.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

block-group.c

btrfs: zoned: fix zone_unusable accounting on making block group read-write again

2024-07-29 19:21:19 +02:00

block-group.h

btrfs: switch btrfs_block_group::inode to struct btrfs_inode

2024-07-11 15:33:28 +02:00

block-rsv.c

btrfs: change root->root_key.objectid to btrfs_root_id()

2024-05-07 21:31:06 +02:00

block-rsv.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

btrfs_inode.h

btrfs: move the direct IO code into its own file

2024-07-11 15:33:29 +02:00

compression.c

btrfs: fix extent map use-after-free when adding pages to compressed bio

2024-07-11 16:32:22 +02:00

compression.h

btrfs: pass a btrfs_inode to btrfs_compress_heuristic()

2024-07-11 15:33:28 +02:00

ctree.c

btrfs: fix data race when accessing the last_trans field of a root

2024-07-11 15:52:25 +02:00

ctree.h

btrfs: fix corruption after buffer fault in during direct IO append write

2024-07-29 19:21:22 +02:00

defrag.c

btrfs: fix data race when accessing the last_trans field of a root

2024-07-11 15:52:25 +02:00

defrag.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

delalloc-space.c

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

delalloc-space.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

delayed-inode.c

btrfs: pass a btrfs_inode to btrfs_readdir_get_delayed_items()

2024-07-11 15:33:28 +02:00

delayed-inode.h

btrfs: pass a btrfs_inode to btrfs_readdir_get_delayed_items()

2024-07-11 15:33:28 +02:00

delayed-ref.c

btrfs: check delayed refs when we're checking if a ref exists

2024-08-13 13:42:26 +02:00

delayed-ref.h

btrfs: check delayed refs when we're checking if a ref exists

2024-08-13 13:42:26 +02:00

dev-replace.c

btrfs: simplify range parameters of btrfs_wait_ordered_roots()

2024-07-11 15:33:19 +02:00

dev-replace.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

dir-item.c

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

dir-item.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

direct-io.c

btrfs: fix corruption after buffer fault in during direct IO append write

2024-07-29 19:21:22 +02:00

direct-io.h

btrfs: move the direct IO code into its own file

2024-07-11 15:33:29 +02:00

discard.c

btrfs: unexport btrfs_run_discard_work and make it static

2023-06-19 13:59:25 +02:00

discard.h

btrfs: unexport btrfs_run_discard_work and make it static

2023-06-19 13:59:25 +02:00

disk-io.c

for-6.11-tag

2024-07-17 12:38:04 -07:00

disk-io.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

export.c

btrfs: remove super block argument from btrfs_iget()

2024-07-11 15:33:25 +02:00

export.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

extent_io.c

btrfs: move extent_range_clear_dirty_for_io() into inode.c

2024-07-11 15:52:25 +02:00

extent_io.h

btrfs: move extent_range_clear_dirty_for_io() into inode.c

2024-07-11 15:52:25 +02:00

extent_map.c

for-6.11-rc1-tag

2024-07-30 19:28:36 -07:00

extent_map.h

btrfs: do not directly include rwlock_types.h

2024-07-11 15:33:22 +02:00

extent-io-tree.c

btrfs: preallocate ulist memory for qgroup rsv

2024-07-11 15:33:26 +02:00

extent-io-tree.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

extent-tree.c

btrfs: check delayed refs when we're checking if a ref exists

2024-08-13 13:42:26 +02:00

extent-tree.h

btrfs: do not BUG_ON() when freeing tree block after error

2024-07-11 15:33:26 +02:00

fiemap.c

btrfs: move fiemap code into its own file

2024-07-11 15:33:20 +02:00

fiemap.h

btrfs: move fiemap code into its own file

2024-07-11 15:33:20 +02:00

file-item.c

btrfs: introduce new "rescue=ignoremetacsums" mount option

2024-07-11 15:33:29 +02:00

file-item.h

btrfs: remove search_commit parameter from btrfs_lookup_csums_list()

2024-05-07 21:31:03 +02:00

file.c

btrfs: fix double inode unlock for direct IO sync writes

2024-08-02 22:32:40 +02:00

file.h

btrfs: move the direct IO code into its own file

2024-07-11 15:33:29 +02:00

free-space-cache.c

btrfs: zoned: fix zone_unusable accounting on making block group read-write again

2024-07-29 19:21:19 +02:00

free-space-cache.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

free-space-tree.c

btrfs: do not BUG_ON() when freeing tree block after error

2024-07-11 15:33:26 +02:00

free-space-tree.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

fs.c

btrfs: sysfs: update fs features directory asynchronously

2023-02-13 17:50:35 +01:00

fs.h

for-6.11-tag

2024-07-19 14:34:52 -07:00

inode-item.c

btrfs: abort transaction if we don't find extref in btrfs_del_inode_extref()

2024-07-11 15:33:27 +02:00

inode-item.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

inode.c

for-6.11-rc2-tag

2024-08-07 09:53:41 -07:00

ioctl.c

for-6.11-tag

2024-07-17 12:38:04 -07:00

ioctl.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

Kconfig

btrfs: check-integrity: remove CONFIG_BTRFS_FS_CHECK_INTEGRITY option

2023-10-12 16:44:05 +02:00

locking.c

btrfs: change root->root_key.objectid to btrfs_root_id()

2024-05-07 21:31:06 +02:00

locking.h

btrfs: cleanup recursive include of the same header

2024-07-11 15:33:22 +02:00

lru_cache.c

btrfs: fix typos found by codespell

2023-12-15 23:00:04 +01:00

lru_cache.h

btrfs: cleanup recursive include of the same header

2024-07-11 15:33:22 +02:00

lzo.c

btrfs: enhance compression error messages

2024-07-11 15:52:25 +02:00

Makefile

btrfs: move the direct IO code into its own file

2024-07-11 15:33:29 +02:00

messages.c

btrfs: introduce new "rescue=ignoremetacsums" mount option

2024-07-11 15:33:29 +02:00

messages.h

btrfs: constify fs_info parameter in __btrfs_panic()

2023-12-15 20:27:02 +01:00

misc.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

ordered-data.c

btrfs: switch btrfs_ordered_extent::inode to struct btrfs_inode

2024-07-11 15:33:28 +02:00

ordered-data.h

btrfs: switch btrfs_ordered_extent::inode to struct btrfs_inode

2024-07-11 15:33:28 +02:00

orphan.c

btrfs: remove unused included headers

2024-03-04 16:24:46 +01:00

orphan.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

print-tree.c

btrfs: avoid using fixed char array size for tree names

2024-08-02 22:44:27 +02:00

print-tree.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

props.c

btrfs: pass a btrfs_inode to btrfs_set_prop()

2024-07-11 15:33:29 +02:00

props.h

btrfs: pass a btrfs_inode to btrfs_set_prop()

2024-07-11 15:33:29 +02:00

qgroup.c

btrfs: qgroup: preallocate memory before adding a relation

2024-07-11 15:33:27 +02:00

qgroup.h

btrfs: qgroup: preallocate memory before adding a relation

2024-07-11 15:33:27 +02:00

raid56.c

btrfs: rename the extra_gfp parameter of btrfs_alloc_page_array()

2024-07-11 15:33:30 +02:00

raid56.h

btrfs: add forward declarations and headers, part 2

2024-03-04 16:24:49 +01:00

raid-stripe-tree.c

btrfs: remove raid-stripe-tree encoding field from stripe_extent

2024-07-11 15:33:28 +02:00

raid-stripe-tree.h

btrfs: remove raid-stripe-tree encoding field from stripe_extent

2024-07-11 15:33:28 +02:00

rcu-string.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

ref-verify.c

btrfs: fix uninitialized return value in the ref-verify tool

2024-07-02 19:14:57 +02:00

ref-verify.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

reflink.c

btrfs: pass a btrfs_inode to btrfs_wait_ordered_range()

2024-07-11 15:33:18 +02:00

reflink.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

relocation.c

- 875fa64577da ("mm/hugetlb_vmemmap: fix race with speculative PFN

2024-07-21 17:15:46 -07:00

relocation.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

root-tree.c

btrfs: change root->root_key.objectid to btrfs_root_id()

2024-05-07 21:31:06 +02:00

root-tree.h

btrfs: qgroup: fix qgroup prealloc rsv leak in subvolume operations

2024-04-02 19:18:23 +02:00

scrub.c

btrfs: scrub: update last_physical after scrubbing one stripe

2024-08-01 17:15:07 +02:00

scrub.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

send.c

- 875fa64577da ("mm/hugetlb_vmemmap: fix race with speculative PFN

2024-07-21 17:15:46 -07:00

send.h

btrfs: pass a btrfs_inode to btrfs_ioctl_send()

2024-07-11 15:33:28 +02:00

space-info.c

btrfs: zoned: fix zone_unusable accounting on making block group read-write again

2024-07-29 19:21:19 +02:00

space-info.h

btrfs: zoned: fix zone_unusable accounting on making block group read-write again

2024-07-29 19:21:19 +02:00

subpage.c

btrfs: pass a btrfs_inode to is_data_inode()

2024-07-11 15:33:28 +02:00

subpage.h

btrfs: subpage: introduce helpers to handle subpage delalloc locking

2024-07-11 15:33:22 +02:00

super.c

btrfs: emit a warning about space cache v1 being deprecated

2024-08-01 17:30:50 +02:00

super.h

btrfs: change BTRFS_MOUNT_* flags to 64bit type

2024-07-19 17:20:23 +02:00

sysfs.c

btrfs: introduce new "rescue=ignoresuperflags" mount option

2024-07-11 15:33:30 +02:00

sysfs.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

transaction.c

btrfs: fix data race when accessing the last_trans field of a root

2024-07-11 15:52:25 +02:00

transaction.h

btrfs: switch btrfs_pending_snapshot::dir to btrfs_inode

2024-07-11 15:33:28 +02:00

tree-checker.c

btrfs: tree-checker: reject BTRFS_FT_UNKNOWN dir type

2024-08-13 13:42:26 +02:00

tree-checker.h

btrfs: make sure that WRITTEN is set on all metadata blocks

2024-05-02 22:11:13 +02:00

tree-log.c

btrfs: remove super block argument from btrfs_iget()

2024-07-11 15:33:25 +02:00

tree-log.h

btrfs: avoid transaction commit on any fsync after subvolume creation

2024-07-11 15:33:24 +02:00

tree-mod-log.c

btrfs: change root->root_key.objectid to btrfs_root_id()

2024-05-07 21:31:06 +02:00

tree-mod-log.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

ulist.c

btrfs: preallocate ulist memory for qgroup rsv

2024-07-11 15:33:26 +02:00

ulist.h

btrfs: preallocate ulist memory for qgroup rsv

2024-07-11 15:33:26 +02:00

uuid-tree.c

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

uuid-tree.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

verity.c

btrfs: remove unused included headers

2024-03-04 16:24:46 +01:00

verity.h

btrfs: add forward declarations and headers, part 1

2024-03-04 16:24:49 +01:00

volumes.c

btrfs: abort transaction on errors in btrfs_free_chunk()

2024-07-11 15:33:27 +02:00

volumes.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

xattr.c

btrfs: pass a btrfs_inode to btrfs_set_prop()

2024-07-11 15:33:29 +02:00

xattr.h

btrfs: constify pointer parameters where applicable

2024-07-11 15:33:22 +02:00

zlib.c

btrfs: enhance compression error messages

2024-07-11 15:52:25 +02:00

zoned.c

btrfs: change BTRFS_MOUNT_* flags to 64bit type

2024-07-19 17:20:23 +02:00

zoned.h

btrfs: change BTRFS_MOUNT_* flags to 64bit type

2024-07-19 17:20:23 +02:00

zstd.c

btrfs: enhance compression error messages

2024-07-11 15:52:25 +02:00