Eric Sandeen 225add6196 [PATCH] udf: initialize parts of inode earlier in create ...

I saw an oops down this path when trying to create a new file on a UDF
filesystem which was internally marked as readonly, but mounted rw:

udf_create
        udf_new_inode
                new_inode
                        alloc_inode
                        	udf_alloc_inode
                udf_new_block
                        returns EIO due to readonlyness
                iput (on error)
                        udf_put_inode
                                udf_discard_prealloc
                                        udf_next_aext
                                                udf_current_aext
                                                        udf_get_fileshortad
                                                                OOPS

the udf_discard_prealloc() path was examining uninitialized fields of the
udf inode.

udf_discard_prealloc() already has this code to short-circuit the discard
path if no extents are preallocated:

        if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_IN_ICB ||
                inode->i_size == UDF_I_LENEXTENTS(inode))
        {
                return;
        }

so if we initialize UDF_I_LENEXTENTS(inode) = 0 earlier in udf_new_inode,
we won't try to free the (not) preallocated blocks, since this will match
the i_size = 0 set when the inode was initialized.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

2006-08-06 08:57:49 -07:00

..

9p

[PATCH] 9p: fix fid behavior on failed remove

2006-07-31 13:28:44 -07:00

adfs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

affs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

afs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

autofs

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

autofs4

[PATCH] fs: use list_move()

2006-06-26 09:58:18 -07:00

befs

[PATCH] Fix BeFS slab corruption

2006-08-06 08:57:48 -07:00

bfs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

cifs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

coda

[PATCH] Remove incorrect unlock_kernel from allocation failure path in coda_open()

2006-07-31 13:28:41 -07:00

configfs

configfs: Clear up a few extra spaces where there should be TABs.

2006-06-29 14:43:01 -07:00

cramfs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

debugfs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

devpts

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

efs

[PATCH] efs: Remove incorrect unlock_kernel from failure path in efs_symlink_readpage()

2006-07-31 13:28:41 -07:00

exportfs

[PATCH] NFS server subtree_check returns dubious value

2006-05-21 12:59:16 -07:00

ext2

[PATCH] lockdep: annotate the quota code

2006-07-03 15:27:08 -07:00

ext3

[PATCH] ext3 -nobh option causes oops

2006-07-31 13:28:44 -07:00

fat

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

freevxfs

[PATCH] freevxfs: Add missing lock_kernel() to vxfs_readdir

2006-07-31 13:28:44 -07:00

fuse

[PATCH] fuse: fix typo

2006-07-31 13:28:43 -07:00

hfs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

hfsplus

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

hostfs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

hpfs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

hppfs

[PATCH] VFS: Permit filesystem to perform statfs with a known root dentry

2006-06-23 07:42:45 -07:00

hugetlbfs

[PATCH] mmap zero-length hugetlb file with PROT_NONE to protect a hugetlb virtual area

2006-07-10 13:24:21 -07:00

isofs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

jbd

[PATCH] add poison.h and patch primary users

2006-06-27 17:32:38 -07:00

jffs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

jffs2

Merge git://git.infradead.org/mtd-2.6

2006-07-03 21:29:08 -07:00

jfs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6

2006-07-15 14:43:30 -07:00

lockd

NLM/lockd: remove b_done

2006-08-03 16:56:02 -04:00

minix

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

msdos

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

ncpfs

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial

2006-06-30 15:39:30 -07:00

nfs

NFS: make 2 functions static

2006-08-03 16:55:41 -04:00

nfs_common

[PATCH] nfsacl: Solaris VxFS compatibility fix

2005-10-11 09:46:54 -07:00

nfsd

[PATCH] knfsd: Fix stale file handle problem with subtree_checking.

2006-07-31 13:28:37 -07:00

nls

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

ntfs

[PATCH] lockdep: annotate NTFS locking rules

2006-07-03 15:27:08 -07:00

ocfs2

ocfs2: remove redundant NULL checks in ocfs2_direct_IO_get_blocks()

2006-06-29 16:13:35 -07:00

openpromfs

[OPENPROMFS]: Rewrite using in-kernel device tree and seq_file.

2006-06-25 23:19:14 -07:00

partitions

[PATCH] enable mac partition label per default on pmac

2006-07-31 13:28:41 -07:00

proc

Don't allow chmod() on the /proc/<pid>/ files

2006-07-15 12:26:45 -07:00

qnx4

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

ramfs

[PATCH] NOMMU: Fix execution off of ramfs with mmap()

2006-07-10 13:24:21 -07:00

reiserfs

[PATCH] reiserfs_write_full_page() should not get_block past eof

2006-08-06 08:57:49 -07:00

romfs

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

smbfs

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

sysfs

[PATCH] lockdep: annotate the sysfs i_mutex to be a separate class

2006-07-12 12:52:54 -07:00

sysv

[PATCH] mark address_space_operations const

2006-06-28 14:59:04 -07:00

udf

[PATCH] udf: initialize parts of inode earlier in create

2006-08-06 08:57:49 -07:00

ufs

[PATCH] ufs: handle truncated pages

2006-08-06 08:57:46 -07:00

vfat

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

xfs

[XFS] Ensure bulkstat from an invalid inode number gets caught always with

2006-07-28 17:05:51 +10:00

aio.c

spelling fixes

2006-06-26 18:35:02 +02:00

attr.c

[PATCH] capable/capability.h (fs/)

2006-01-11 18:42:13 -08:00

bad_inode.c

[PATCH] Make most file operations structs in fs/ const

2006-03-28 09:16:06 -08:00

binfmt_aout.c

[PATCH] dump_thread() cleanup

2006-01-10 08:01:25 -08:00

binfmt_elf_fdpic.c

[PATCH] FDPIC: Add coredump capability for the ELF-FDPIC binfmt

2006-07-10 13:24:22 -07:00

binfmt_elf.c

[PATCH] FDPIC: Move roundup() into linux/kernel.h

2006-07-10 13:24:22 -07:00

binfmt_em86.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

binfmt_flat.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

binfmt_misc.c

Merge branch 'master' of /home/trondmy/kernel/linux-2.6/

2006-06-24 13:07:53 -04:00

binfmt_script.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

binfmt_som.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

bio.c

[PATCH] Fix missing ret assignment in __bio_map_user() error path

2006-06-17 10:52:12 -07:00

block_dev.c

[PATCH] lockdep: annotate blkdev nesting

2006-07-03 15:27:10 -07:00

buffer.c

[PATCH] invalidate_bdev() speedup

2006-07-31 13:28:38 -07:00

char_dev.c

[PATCH] add function documentation for register_chrdev()

2006-07-14 21:53:54 -07:00

compat_ioctl.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

compat.c

[PATCH] x86_64: Add compat_printk and sysctl to turn off compat layer warnings

2006-06-26 10:48:16 -07:00

dcache.c

[PATCH] lockdep: annotate dcache

2006-07-03 15:27:06 -07:00

dcookies.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

direct-io.c

[PATCH] lockdep: annotate direct io

2006-07-03 15:27:06 -07:00

dnotify.c

[PATCH] Use __read_mostly on some hot fs variables

2006-03-26 08:56:56 -08:00

dquot.c

[PATCH] use list_add_tail() instead of list_add()

2006-06-26 09:58:17 -07:00

drop_caches.c

[PATCH] drop-pagecache

2006-01-08 20:12:40 -08:00

eventpoll.c

[PATCH] sched: cleanup, remove task_t, convert to struct task_struct

2006-07-03 15:27:11 -07:00

exec.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

fcntl.c

BUG_ON() Conversion in fs/fcntl.c

2006-04-02 13:37:19 +02:00

fifo.c

[PATCH] pipe.c/fifo.c code cleanups

2006-04-11 13:53:33 +02:00

file_table.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

file.c

[PATCH] alloc_fdtable() expansion fix

2006-07-12 12:52:55 -07:00

filesystems.c

[PATCH] fix missing includes

2005-10-30 17:37:32 -08:00

fs-writeback.c

[PATCH] zoned vm counters: conversion of nr_unstable to per zone counter

2006-06-30 11:25:36 -07:00

inode.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial

2006-06-30 15:39:30 -07:00

inotify_user.c

[PATCH] inotify: fix deadlock found by lockdep

2006-07-31 13:28:41 -07:00

inotify.c

[PATCH] inotify (4/5): allow watch removal from event handler

2006-06-20 05:25:19 -04:00

ioctl.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

ioprio.c

[PATCH] SELinux: Add security hook definition for getioprio and insert hooks

2006-06-30 11:25:37 -07:00

Kconfig

Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6

2006-07-13 16:38:58 -07:00

Kconfig.binfmt

[PATCH] frv: suppress configuration of certain features for FRV

2006-01-08 20:13:36 -08:00

libfs.c

[PATCH] core: use list_move()

2006-06-26 09:58:17 -07:00

locks.c

VFS: Add support for the FL_ACCESS flag to flock_lock_file()

2006-07-05 13:13:18 -04:00

Makefile

[PATCH] devfs: Remove devfs from the kernel tree

2006-06-26 12:25:05 -07:00

mbcache.c

[PATCH] Typo fixes

2006-03-28 09:16:08 -08:00

mpage.c

[PATCH] writeback: fix range handling

2006-06-23 07:42:49 -07:00

namei.c

[PATCH] don't bother with aux entires for dummy context

2006-08-03 10:59:42 -04:00

namespace.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

nfsctl.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

open.c

[PATCH] ftruncate does not always update m/ctime

2006-06-25 10:01:15 -07:00

pipe.c

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

pnode.c

[PATCH] core: use list_move()

2006-06-26 09:58:17 -07:00

pnode.h

[PATCH] unbindable mounts

2005-11-07 18:18:11 -08:00

posix_acl.c

[PATCH] gfp flags annotations - part 1

2005-10-08 15:00:57 -07:00

quota_v1.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

quota_v2.c

[PATCH] sem2mutex: quota

2006-03-23 07:38:11 -08:00

quota.c

[PATCH] sem2mutex: quota

2006-03-23 07:38:11 -08:00

read_write.c

[PATCH] fs/read_write.c: EXPORT_UNUSED_SYMBOL

2006-07-10 13:24:18 -07:00

readdir.c

[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem

2006-01-09 15:59:24 -08:00

select.c

[PATCH] fs: sys_poll with timeout -1 bug fix

2006-06-25 10:01:22 -07:00

seq_file.c

[PATCH] sem2mutex: fs/seq_file.c

2006-03-23 07:38:12 -08:00

splice.c

[PATCH] splice: fix problems with sys_tee()

2006-07-10 11:00:01 +02:00

stat.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

super.c

[PATCH] lockdep: annotate sb ->s_umount

2006-07-03 15:27:09 -07:00

sync.c

[PATCH] writeback: fix range handling

2006-06-23 07:42:49 -07:00

xattr_acl.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

xattr.c

[PATCH] log more info for directory entry change events

2006-06-20 05:25:28 -04:00