Mikulas Patocka
5df96f2b9f
dm integrity: fix integrity recalculation that is improperly skipped ...
Commit adc0daad366b62ca1bce3e2958a40b0b71a8b8b3 ("dm: report suspended
device during destroy") broke integrity recalculation.
The problem is dm_suspended() returns true not only during suspend,
but also during resume. So this race condition could occur:
1. dm_integrity_resume calls queue_work(ic->recalc_wq, &ic->recalc_work)
2. integrity_recalc (&ic->recalc_work) preempts the current thread
3. integrity_recalc calls if (unlikely(dm_suspended(ic->ti))) goto unlock_ret;
4. integrity_recalc exits and no recalculating is done.
To fix this race condition, add a function dm_post_suspending that is
only true during the postsuspend phase and use it instead of
dm_suspended().
Signed-off-by: Mikulas Patocka <mpatocka redhat com>
Fixes: adc0daad366b ("dm: report suspended device during destroy")
Cc: stable vger kernel org # v4.18+
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
2020-07-23 14:39:37 -04:00
2020-06-14 16:47:56 -06:00
2020-06-14 01:57:21 +09:00
2019-11-05 14:53:03 -05:00
2017-06-09 09:27:32 -06:00
2020-01-07 12:07:08 -05:00
2017-03-07 11:30:16 -05:00
2020-03-03 10:02:46 -05:00
2020-06-05 15:45:03 -07:00
2017-11-02 11:10:55 +01:00
2018-04-30 15:40:40 -04:00
2017-03-07 13:28:31 -05:00
2016-12-16 00:13:41 +02:00
2019-04-18 16:18:25 -04:00
2017-03-07 13:28:31 -05:00
2017-03-07 13:28:31 -05:00
2018-10-16 14:34:59 -04:00
2017-03-07 13:28:31 -05:00
2020-03-03 11:10:21 -05:00
2020-03-27 14:42:51 -04:00
2020-03-27 14:42:51 -04:00
2020-03-27 14:42:51 -04:00
2019-04-04 15:33:59 -04:00
2020-06-05 14:59:59 -04:00
2019-04-26 11:29:32 -04:00
2020-01-07 11:43:36 -05:00
2020-06-05 14:59:42 -04:00
2019-05-21 10:50:45 +02:00
2019-05-16 15:55:48 -07:00
2019-11-12 19:12:07 -07:00
2020-05-15 10:29:36 -04:00
2019-07-15 11:03:01 -03:00
2020-07-23 14:39:37 -04:00
2018-06-05 08:47:43 -06:00
2020-06-17 12:31:45 -04:00
2019-08-15 15:57:39 -04:00
2020-04-02 19:15:03 -07:00
2018-05-30 15:33:32 -06:00
2020-05-20 17:09:44 -04:00
2016-11-01 09:43:26 -06:00
2020-06-05 14:59:58 -04:00
2020-05-15 10:29:36 -04:00
2020-05-15 10:29:36 -04:00
2020-05-20 17:09:44 -04:00
2020-05-20 17:09:44 -04:00
2018-06-12 18:28:00 -07:00
2017-02-17 00:54:09 -05:00
2020-07-07 12:00:01 -04:00
2019-03-05 14:48:50 -05:00
2020-05-15 10:29:36 -04:00
2020-01-15 21:43:09 -07:00
2016-01-08 20:03:05 -05:00
2020-01-07 12:07:17 -05:00
2020-05-20 17:09:44 -04:00
2017-11-02 11:10:55 +01:00
2020-05-20 17:09:44 -04:00
2020-05-20 17:09:44 -04:00
2018-10-11 11:36:09 -04:00
2020-04-25 09:45:43 -06:00
2019-04-25 15:38:52 -04:00
2020-02-27 12:00:53 -05:00
2019-12-05 17:05:24 -05:00
2020-01-14 20:23:13 -05:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2018-12-18 09:02:26 -05:00
2020-04-16 16:16:38 -04:00
2019-05-30 11:26:32 -07:00
2020-03-03 11:10:21 -05:00
2019-08-23 10:13:14 -04:00
2019-08-23 10:13:14 -04:00
2019-08-23 10:13:14 -04:00
2020-07-08 11:06:57 -04:00
2017-06-09 09:27:32 -06:00
2020-07-08 12:21:53 -04:00
2020-07-08 12:21:53 -04:00
2020-07-08 12:21:53 -04:00
2020-06-05 14:59:53 -04:00
2020-07-23 14:39:37 -04:00
2019-08-23 10:13:12 -04:00
2020-06-14 01:57:21 +09:00
2020-05-15 10:29:36 -04:00
2020-06-02 10:59:07 -07:00
2018-08-01 15:49:39 -07:00
2019-05-24 17:27:12 +02:00
2018-10-18 09:36:35 -07:00
2019-05-24 17:27:13 +02:00
2019-10-24 15:22:40 -07:00
2020-05-13 12:02:23 -07:00
2019-10-24 15:22:40 -07:00
2018-05-30 15:33:32 -06:00
2020-05-13 11:49:19 -07:00
2020-05-13 11:22:31 -07:00
2020-01-15 21:43:09 -07:00
2019-09-13 13:10:05 -07:00
2019-06-15 01:37:35 -06:00
2020-05-13 11:22:31 -07:00
2020-05-13 12:02:23 -07:00
2019-06-05 17:36:37 +02:00
2019-03-12 10:15:18 -07:00
2020-05-22 08:45:46 -06:00
2020-05-13 11:22:31 -07:00
2019-09-13 13:14:43 -07:00
2019-11-11 16:47:39 -08:00
2020-05-13 12:02:23 -07:00
5df96f2b9f