David Howells
8f92054e7c
CRED: Fix __task_cred()'s lockdep check and banner comment ...
Fix __task_cred()'s lockdep check by removing the following validation
condition:
lockdep_tasklist_lock_is_held()
as commit_creds() does not take the tasklist_lock, and nor do most of the
functions that call it, so this check is pointless and it can prevent
detection of the RCU lock not being held if the tasklist_lock is held.
Instead, add the following validation condition:
task->exit_state >= 0
to permit the access if the target task is dead and therefore unable to change
its own credentials.
Fix __task_cred()'s comment to:
(1) discard the bit that says that the caller must prevent the target task
from being deleted. That shouldn't need saying.
(2) Add a comment indicating the result of __task_cred() should not be passed
directly to get_cred(), but rather than get_task_cred() should be used
instead.
Also put a note into the documentation to enforce this point there too.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-07-29 15:16:18 -07:00
2010-06-11 13:08:37 -07:00
2009-09-23 07:39:28 -07:00
2010-05-19 22:42:08 -04:00
2008-02-08 09:22:31 -08:00
2010-05-28 19:31:31 +09:00
2009-09-24 07:20:57 -07:00
2010-04-23 02:09:52 +02:00
2010-03-08 09:11:07 +01:00
2009-10-01 21:17:49 +02:00
2009-12-13 20:41:53 -08:00
2010-05-27 09:12:43 -07:00
2010-04-23 02:09:52 +02:00
2010-02-24 13:51:32 +01:00
2010-01-13 10:55:16 -05:00
2008-02-14 00:16:13 -05:00
2008-10-16 11:21:30 -07:00
2009-08-29 19:09:27 -07:00
2010-05-24 07:30:55 -07:00
2010-03-06 02:29:56 +00:00
2010-06-04 15:38:12 -07:00
2010-02-05 12:22:34 +01:00
2010-04-23 02:09:52 +02:00
2008-04-21 22:19:05 +00:00
2010-03-06 11:26:32 -08:00
2010-04-07 08:38:02 -07:00
2010-06-04 13:22:30 -05:00
2009-06-15 21:30:24 -07:00
2008-02-03 15:54:28 +02:00
2010-05-27 19:59:02 +02:00
2010-06-03 11:33:50 +02:00
2007-05-09 08:58:19 +02:00
2009-09-23 07:39:28 -07:00
2009-06-07 13:52:52 +02:00
2009-12-09 14:21:36 -08:00
2010-05-20 09:20:59 -07:00
2010-03-19 09:43:06 -07:00
2010-02-26 01:24:22 -08:00
2009-06-19 08:08:50 +02:00
2010-06-01 08:55:52 -07:00
2009-06-12 18:01:47 +02:00
2007-12-17 10:33:19 -08:00
2010-05-19 11:41:09 +03:00
2010-05-21 17:13:24 -07:00
2010-04-23 02:09:52 +02:00
2008-01-11 18:22:30 -06:00
2007-10-17 08:43:05 -07:00
2009-01-14 19:19:03 +01:00
2009-12-15 08:53:25 -08:00
2009-06-12 18:01:47 +02:00
2009-06-12 18:01:47 +02:00
2007-11-29 09:24:53 -08:00
2010-04-23 02:09:52 +02:00
2010-05-20 21:04:44 -07:00
2010-05-21 18:58:52 -07:00
2010-05-10 10:23:17 +02:00
2010-05-21 18:58:52 -07:00
2010-05-21 11:17:05 -07:00
2009-06-18 13:04:04 -07:00
2008-04-19 19:19:55 +02:00
2010-05-18 08:27:54 -07:00
2010-03-08 16:55:37 +01:00
2010-04-02 20:12:01 +02:00
2010-04-23 02:09:52 +02:00
2010-03-12 15:52:43 -08:00
2008-12-22 18:44:05 +09:00
2010-05-20 09:41:44 -07:00
2008-08-29 02:15:25 -07:00
2010-05-25 00:23:16 -06:00
2010-05-25 08:06:59 -07:00
2008-07-22 19:24:29 +10:00
2009-11-05 18:18:10 -05:00
2010-06-01 10:05:19 -07:00
2010-05-20 09:20:59 -07:00
2006-11-30 04:58:40 +01:00
2010-05-20 21:26:12 -07:00
2010-07-08 16:50:05 -03:00
2010-05-27 09:12:57 -07:00
2010-04-23 02:09:52 +02:00
2010-07-01 16:02:55 +00:00
2009-01-07 10:00:18 -08:00
2010-02-15 14:34:18 -08:00
2008-01-24 20:40:04 -08:00
2010-04-08 11:34:34 +02:00
2010-07-20 17:49:30 +00:00
2010-04-23 02:09:52 +02:00
2008-12-03 16:09:53 -07:00
2007-05-09 08:58:19 +02:00
2009-06-12 18:01:47 +02:00
2008-07-25 10:53:30 -07:00
2009-08-22 14:25:32 -07:00
2008-02-06 10:41:09 -08:00
2010-07-20 17:49:30 +00:00
2010-04-23 02:09:52 +02:00
2010-03-25 17:04:57 +01:00
2010-03-24 16:31:22 -07:00
2009-06-12 18:01:46 +02:00
2009-12-17 11:43:29 +10:30
2007-03-01 14:53:39 -08:00
2009-10-30 14:59:52 -07:00
2010-07-29 15:16:18 -07:00
2008-02-03 15:27:38 +02:00
2009-10-03 09:28:11 +02:00
2009-06-12 18:01:50 +02:00
2010-05-25 15:08:26 -07:00
2010-05-27 09:12:53 -07:00
2010-03-12 15:52:43 -08:00
2008-07-22 10:39:36 +10:00
2006-11-30 04:55:36 +01:00
2009-01-05 18:10:19 -07:00
2010-02-25 14:43:57 -08:00
2009-03-24 16:38:27 -07:00
2010-05-10 11:49:30 -03:00
2010-02-05 12:22:39 +01:00
2010-03-12 15:52:35 -08:00
2010-07-24 23:26:09 -04:00
2009-10-15 07:25:20 -06:00
2009-05-09 07:12:50 +02:00
2009-09-21 15:14:56 +02:00
2010-03-06 11:26:48 -08:00
2008-04-21 15:10:15 -07:00
2010-04-22 15:24:56 -07:00
2008-03-24 19:22:19 -07:00
2010-03-06 11:26:29 -08:00
2008-02-03 14:54:41 +02:00
2010-05-20 09:20:59 -07:00
2009-09-19 09:37:23 -07:00
2008-11-03 18:21:44 +01:00
2008-07-26 12:00:06 -07:00
2010-03-12 15:52:39 -08:00
2008-06-05 15:18:30 +02:00
2006-06-29 10:26:25 -07:00
2006-07-03 15:27:03 -07:00
2007-10-20 02:37:21 +02:00
2010-01-11 09:34:07 -08:00
2010-04-23 02:09:52 +02:00
2010-07-24 23:26:09 -04:00
2008-04-29 08:06:16 -07:00
2009-09-02 21:29:22 +10:00
2009-07-01 22:36:22 +02:00
2009-09-08 16:36:08 +01:00
2010-03-19 07:12:20 -07:00
2010-05-20 09:20:59 -07:00
2009-09-18 09:48:52 -07:00
2007-05-21 09:58:40 -07:00
2009-08-28 15:21:12 -04:00
2009-06-23 20:21:38 +01:00
2009-06-12 18:01:47 +02:00
2009-08-07 12:03:46 +02:00
2009-12-06 13:20:02 +01:00
2009-04-27 12:00:27 -07:00
2009-04-27 12:00:27 -07:00
2009-01-06 15:59:28 -08:00
2010-03-12 15:52:35 -08:00
2008-10-30 11:38:46 -07:00
2008-03-17 09:03:05 +01:00
2010-04-23 02:09:52 +02:00
2010-03-24 16:31:22 -07:00
2009-12-15 08:53:17 -08:00
2009-09-22 07:17:26 -07:00
2006-10-03 22:53:09 +02:00
2010-03-03 11:26:00 +01:00
2008-10-30 19:07:04 +01:00
2009-12-15 08:53:24 -08:00
2009-09-22 07:17:39 -07:00
2010-05-19 08:37:43 +01:00
2010-05-14 09:18:55 -06:00
2007-11-26 19:39:01 -08:00
2006-10-03 23:39:02 +02:00
2010-02-05 12:22:44 +01:00
2008-11-12 17:17:17 -08:00
2006-10-03 22:57:56 +02:00
2010-02-18 15:40:56 -08:00
2010-03-10 17:09:33 -05:00
2009-06-18 13:03:56 -07:00
2006-11-30 05:21:10 +01:00
2010-04-23 02:09:52 +02:00
2006-06-27 17:32:47 -07:00
2009-09-23 07:39:46 -07:00
2008-10-16 11:21:32 -07:00
2008-08-27 08:54:08 +10:00
2006-03-25 08:23:00 -08:00
2009-12-01 08:20:31 -08:00
2009-06-12 18:01:47 +02:00
2010-04-23 02:09:52 +02:00
2010-04-27 22:59:07 +02:00
2009-12-14 09:46:56 -08:00
2007-07-30 14:25:12 -07:00
2010-04-22 15:24:56 -07:00
2010-05-24 07:31:20 -07:00
2010-05-27 09:12:43 -07:00
2009-10-01 16:11:12 -07:00
2010-03-16 11:47:56 +01:00
2010-05-19 10:14:15 -07:00
2009-04-14 09:14:58 +10:00
2008-07-25 10:53:27 -07:00
2006-10-03 22:57:56 +02:00
2009-12-16 11:28:58 -08:00
2006-12-20 01:46:58 -05:00
2010-03-24 16:31:20 -07:00
8f92054e7c
