Brian Foster 9b1f4e9831 xfs: cancel dfops on xfs_defer_finish() error
The current semantics of xfs_defer_finish() require the caller to
call xfs_defer_cancel() on error. This is slightly inconsistent with
transaction commit error handling where a failed commit cleans up
the transaction before returning.

More significantly, the only requirement for exposure of
->dop_pending outside of xfs_defer_finish() is so that
xfs_defer_cancel() can drain it on error. Since the only recourse of
xfs_defer_finish() errors is cancellation, mirror the transaction
logic and cancel remaining dfops before returning from
xfs_defer_finish() with an error.

Beside simplifying xfs_defer_finish() semantics, this ensures that
xfs_defer_finish() always returns with an empty ->dop_pending and
thus facilitates removal of the list from xfs_defer_ops.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-08-02 23:05:14 -07:00
..
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-07-11 22:25:59 -07:00
2018-06-06 14:17:53 -07:00
2018-06-08 10:07:52 -07:00
2018-07-11 22:26:35 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-07-30 07:57:48 -07:00
2018-06-12 15:49:00 -07:00
2018-06-06 14:17:53 -07:00
2018-07-26 10:15:16 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-08-01 07:40:48 -07:00
2018-08-01 07:40:48 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-07-26 10:15:16 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-12 15:49:00 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00
2018-06-06 14:17:53 -07:00