Alan Stern
e47373ec1c
[SCSI] return success after retries in scsi_eh_tur
...
The problem lies in the way the error handler uses TEST UNIT READY to
tell whether error recovery has succeeded. The scsi_eh_tur function
gives up after one round of retrying; after that it decides that more
error recovery is needed.
However TUR is liable to report sense data indicating a retry is needed
when in fact error recovery has succeeded. A typical example might be
SK=2, ASC=4, ASCQ=1 (Logical unit in process of becoming ready). The mere
fact that we were able to get a sensible reply to the TUR should indicate
that the device is working well enough to stop error recovery.
I ran across a case back in January where this happened. A CD-ROM drive
timed out the INQUIRY command, and a device reset fixed the blockage.
But then the drive kept responding with 2/4/1 -- because it was spinning
up I suppose -- until the error handler gave up and placed it offline.
If the initial INQUIRY had received the 2/4/1 instead, everything would
have worked okay. It doesn't seem reasonable for things to fail just
because the error handler had started running.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
2005-09-06 17:19:23 -05:00
..
2005-09-04 19:46:06 -05:00
2005-09-04 19:46:07 -05:00
2005-04-16 15:20:36 -07:00
2005-06-20 15:15:35 -07:00
2005-07-27 16:26:08 -07:00
2005-09-06 17:11:54 -05:00
2005-08-12 12:09:32 -05:00
2005-06-26 08:31:47 -05:00
2005-07-07 18:24:07 -07:00
2005-09-04 19:54:06 -05:00
2005-07-27 16:26:08 -07:00
2005-06-27 21:52:47 -07:00
2005-04-16 15:20:36 -07:00
2005-06-27 21:52:47 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-18 12:32:20 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-20 15:15:35 -07:00
2005-04-16 20:09:43 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-08-08 09:55:39 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:03 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-28 00:08:00 -04:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-07-28 15:54:15 -04:00
2005-04-16 15:20:36 -07:00
2005-04-18 12:32:20 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-05-20 12:53:31 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-07-30 09:08:21 -05:00
2005-08-28 11:14:10 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-18 13:49:58 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-07-27 16:26:20 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:04:45 -05:00
2005-07-11 09:35:55 -05:00
2005-06-25 16:25:03 -07:00
2005-07-27 16:26:08 -07:00
2005-07-27 16:26:08 -07:00
2005-04-16 15:20:36 -07:00
2005-06-26 12:14:46 -05:00
2005-04-16 15:20:36 -07:00
2005-06-26 12:14:10 -05:00
2005-04-26 07:43:42 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:10 -05:00
2005-07-27 16:26:20 -07:00
2005-04-16 15:20:36 -07:00
2005-05-20 12:53:34 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:04:45 -05:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-18 13:50:23 -05:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-07-30 11:13:01 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-06-17 12:05:10 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:10 -05:00
2005-06-17 12:04:45 -05:00
2005-07-27 16:26:08 -07:00
2005-06-25 16:25:00 -07:00
2005-06-27 21:52:47 -07:00
2005-05-20 12:53:45 -05:00
2005-06-17 12:05:18 -05:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-08-30 22:48:51 -05:00
2005-04-16 20:09:43 -05:00
2005-07-26 13:28:47 -07:00
2005-06-27 00:47:48 -04:00
2005-05-29 14:48:20 -04:00
2005-07-06 12:55:20 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:04:45 -05:00
2005-06-17 12:04:45 -05:00
2005-08-30 22:48:51 -05:00
2005-04-16 15:20:36 -07:00
2005-07-26 13:28:47 -07:00
2005-06-26 12:16:24 -05:00
2005-07-06 12:55:20 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-07-27 16:26:08 -07:00
2005-06-17 12:05:10 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:10 -05:00
2005-06-17 12:04:45 -05:00
2005-04-16 20:09:43 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-20 15:15:08 -07:00
2005-04-16 15:20:36 -07:00
2005-07-27 16:26:08 -07:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:10 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-05-20 12:53:13 -05:00
2005-05-20 12:53:13 -05:00
2005-05-20 12:53:13 -05:00
2005-08-02 11:43:52 -05:00
2005-08-02 11:43:52 -05:00
2005-06-17 12:05:10 -05:00
2005-06-17 12:04:45 -05:00
2005-06-17 12:04:45 -05:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-06-26 08:31:47 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-08-30 22:48:51 -05:00
2005-05-26 21:54:27 -04:00
2005-06-04 00:40:40 -04:00
2005-04-16 15:20:36 -07:00
2005-05-26 21:54:27 -04:00
2005-06-09 03:06:22 -04:00
2005-05-26 21:54:27 -04:00
2005-06-09 03:10:56 -04:00
2005-05-26 21:54:27 -04:00
2005-05-26 21:54:27 -04:00
2005-05-26 21:54:27 -04:00
2005-05-29 14:24:57 -04:00
2005-04-16 15:20:36 -07:00
2005-06-24 00:06:43 -07:00
2005-04-16 15:20:36 -07:00
2005-08-12 11:40:50 -05:00
2005-09-06 17:19:23 -05:00
2005-07-30 11:10:24 -05:00
2005-07-30 11:10:24 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-26 12:17:24 -05:00
2005-04-16 15:20:36 -07:00
2005-07-30 11:13:01 -05:00
2005-04-16 15:20:36 -07:00
2005-07-30 11:10:24 -05:00
2005-08-14 17:21:27 -05:00
2005-04-16 15:20:36 -07:00
2005-08-14 17:21:27 -05:00
2005-04-16 15:20:36 -07:00
2005-08-12 12:27:44 -05:00
2005-04-18 13:49:58 -05:00
2005-04-16 15:20:36 -07:00
2005-07-14 11:25:17 -04:00
2005-06-17 12:05:10 -05:00
2005-06-17 12:04:45 -05:00
2005-09-04 19:46:03 -05:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 20:09:43 -05:00
2005-04-21 16:14:05 -04:00
2005-04-16 15:20:36 -07:00
2005-08-28 11:14:12 -05:00
2005-08-28 11:14:12 -05:00
2005-04-16 15:20:36 -07:00
2005-09-04 19:45:59 -05:00
2005-08-08 09:33:48 -05:00
2005-04-18 12:32:20 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-05-20 12:53:32 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-06-17 12:04:45 -05:00
2005-06-17 12:04:45 -05:00
2005-07-27 16:26:08 -07:00
2005-06-17 12:05:10 -05:00
2005-04-16 15:20:36 -07:00
2005-06-26 12:14:10 -05:00
2005-06-17 12:04:55 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-06-17 12:05:18 -05:00
2005-04-16 15:20:36 -07:00