Jason A. Donenfeld
d2a02e3c8b
lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI
...
blake2s_compress_generic is weakly aliased by blake2s_compress. The
current harness for function selection uses a function pointer, which is
ordinarily inlined and resolved at compile time. But when Clang's CFI is
enabled, CFI still triggers when making an indirect call via a weak
symbol. This seems like a bug in Clang's CFI, as though it's bucketing
weak symbols and strong symbols differently. It also only seems to
trigger when "full LTO" mode is used, rather than "thin LTO".
[ 0.000000][ T0] Kernel panic - not syncing: CFI failure (target: blake2s_compress_generic+0x0/0x1444)
[ 0.000000][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.16.0-mainline-06981-g076c855b846e #1
[ 0.000000][ T0] Hardware name: MT6873 (DT)
[ 0.000000][ T0] Call trace:
[ 0.000000][ T0] dump_backtrace+0xfc/0x1dc
[ 0.000000][ T0] dump_stack_lvl+0xa8/0x11c
[ 0.000000][ T0] panic+0x194/0x464
[ 0.000000][ T0] __cfi_check_fail+0x54/0x58
[ 0.000000][ T0] __cfi_slowpath_diag+0x354/0x4b0
[ 0.000000][ T0] blake2s_update+0x14c/0x178
[ 0.000000][ T0] _extract_entropy+0xf4/0x29c
[ 0.000000][ T0] crng_initialize_primary+0x24/0x94
[ 0.000000][ T0] rand_initialize+0x2c/0x6c
[ 0.000000][ T0] start_kernel+0x2f8/0x65c
[ 0.000000][ T0] __primary_switched+0xc4/0x7be4
[ 0.000000][ T0] Rebooting in 5 seconds..
Nonetheless, the function pointer method isn't so terrific anyway, so
this patch replaces it with a simple boolean, which also gets inlined
away. This successfully works around the Clang bug.
In general, I'm not too keen on all of the indirection involved here; it
clearly does more harm than good. Hopefully the whole thing can get
cleaned up down the road when lib/crypto is overhauled more
comprehensively. But for now, we go with a simple bandaid.
Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in")
Link: https://github.com/ClangBuiltLinux/linux/issues/1567
Reported-by: Miles Chen <miles.chen@mediatek.com>
Tested-by: Miles Chen <miles.chen@mediatek.com>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2022-02-04 19:22:32 +01:00
..
2020-08-10 01:32:59 +09:00
2022-02-04 19:22:32 +01:00
2020-11-18 14:15:17 -06:00
2021-07-08 11:48:20 -07:00
2022-01-17 05:49:30 +02:00
2020-08-09 14:10:26 -07:00
2022-01-20 08:52:53 +02:00
2020-12-15 22:46:19 -08:00
2021-09-08 11:50:26 -07:00
2022-01-07 14:30:01 +11:00
2021-07-08 11:48:20 -07:00
2022-01-06 08:37:03 -08:00
2021-07-08 11:48:20 -07:00
2021-10-18 12:28:52 -07:00
2021-04-14 23:04:44 +10:00
2021-10-19 23:44:30 +08:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-09-24 16:13:35 -07:00
2021-11-18 13:16:22 -08:00
2021-10-18 12:28:52 -07:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2022-01-20 08:52:55 +02:00
2021-10-13 14:54:13 -05:00
2019-05-30 11:26:32 -07:00
2021-12-13 10:56:09 +01:00
2021-10-01 16:52:48 -04:00
2017-11-02 11:10:55 +01:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2021-10-26 19:30:38 -07:00
2019-05-21 10:50:45 +02:00
2021-11-06 14:08:17 -07:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-04-01 09:54:37 +01:00
2019-05-24 17:27:11 +02:00
2021-07-08 11:48:22 -07:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2021-06-23 16:41:41 -06:00
2021-05-05 16:07:40 +02:00
2019-05-24 17:39:02 +02:00
2021-10-01 16:52:48 -04:00
2019-10-18 15:01:57 +02:00
2021-11-06 13:30:41 -07:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2021-06-05 08:58:12 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2021-08-19 09:02:55 +09:00
2021-06-22 13:56:43 +02:00
2021-08-13 10:07:44 +02:00
2018-06-12 23:33:24 +02:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-10-19 23:44:30 +08:00
2021-11-08 16:55:26 -08:00
2020-07-31 11:49:08 +02:00
2021-08-13 14:09:32 -10:00
2021-09-23 09:25:59 +02:00
2020-11-20 14:45:33 +11:00
2021-09-08 11:50:26 -07:00
2021-10-21 13:01:25 +02:00
2020-10-16 11:11:20 -07:00
2021-04-16 16:10:37 -07:00
2020-12-15 22:46:15 -08:00
2021-09-30 21:24:06 -04:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2022-01-15 08:47:31 -08:00
2022-01-15 08:47:31 -08:00
2021-10-18 07:49:39 -04:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2022-01-15 08:47:31 -08:00
2019-10-14 15:04:00 -07:00
2020-11-18 14:15:17 -06:00
2017-02-24 17:46:57 -08:00
2020-10-16 11:11:19 -07:00
2019-05-13 11:07:33 +02:00
2020-10-20 14:39:37 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2022-01-04 13:15:33 -05:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2021-08-19 09:02:55 +09:00
2022-01-23 06:20:44 +02:00
2022-01-20 10:41:01 +02:00
2022-01-22 08:33:37 +02:00
2021-12-09 16:42:28 -08:00
2021-11-06 13:30:43 -07:00
2020-09-28 12:14:08 +01:00
2022-01-20 08:52:55 +02:00
2021-07-08 11:48:20 -07:00
2019-06-19 17:09:08 +02:00
2021-12-28 11:26:18 +01:00
2021-12-27 10:40:00 +01:00
2022-01-20 08:52:53 +02:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2021-08-13 18:37:38 +02:00
2022-01-20 08:52:53 +02:00
2021-07-08 11:48:20 -07:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-12-04 10:56:24 +01:00
2019-06-07 13:15:06 -07:00
2021-12-21 21:31:08 +01:00
2021-02-17 17:31:06 -06:00
2021-04-16 16:10:37 -07:00
2019-05-24 17:39:02 +02:00
2022-01-20 10:41:01 +02:00
2018-10-16 13:45:44 +02:00
2021-10-18 12:28:52 -07:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2021-11-10 16:12:00 +01:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2021-12-24 14:54:29 -08:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2021-08-08 13:00:20 +01:00
2021-09-17 13:52:17 +01:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2021-09-19 17:13:35 -07:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2021-05-13 03:27:38 +00:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2021-04-16 16:10:37 -07:00
2021-10-18 06:17:01 -06:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2022-01-12 14:29:50 +00:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2022-01-27 10:15:32 -07:00
2021-11-09 10:02:50 -08:00
2021-07-08 11:48:20 -07:00
2021-08-24 19:52:40 -03:00
2019-08-08 07:45:01 -06:00
2022-01-18 13:03:55 +01:00
2019-09-24 15:54:09 -07:00
2021-11-29 19:50:50 -08:00
2021-06-29 10:53:46 -07:00
2021-05-19 10:51:40 +02:00
2021-07-08 11:48:20 -07:00
2022-01-22 08:33:38 +02:00
2019-05-30 11:26:32 -07:00
2021-11-18 18:40:08 +02:00
2021-09-25 08:20:49 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2021-06-18 11:43:09 +02:00
2022-01-15 08:47:31 -08:00
2021-07-08 11:48:20 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2021-11-16 14:03:15 +01:00
2019-05-21 10:50:45 +02:00
2021-05-13 16:14:45 +02:00
2021-01-18 11:03:26 +01:00
2020-12-15 22:46:16 -08:00
2022-01-20 08:52:54 +02:00
2018-11-30 12:13:15 -08:00
2021-07-01 11:06:03 -07:00
2022-01-15 16:30:31 +02:00
2018-10-15 16:31:29 -04:00
2021-11-06 13:30:33 -07:00
2022-01-30 09:56:58 +02:00
2021-07-08 11:48:20 -07:00
2021-10-26 17:23:46 -04:00
2020-05-08 18:18:12 +01:00
2021-06-25 11:31:03 -06:00
2021-08-17 19:05:33 +02:00
2018-10-16 13:45:44 +02:00
2022-01-20 08:52:54 +02:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2021-10-27 13:40:14 +02:00
2021-12-06 16:04:44 -08:00
2021-03-24 15:16:09 -07:00
2021-09-06 11:04:03 -07:00
2017-01-09 13:58:57 -05:00
2021-09-08 11:50:26 -07:00
2021-08-22 00:21:36 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2021-07-01 11:06:05 -07:00
2019-04-08 16:44:21 -06:00
2022-01-22 08:33:35 +02:00
2022-01-20 08:52:55 +02:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2021-11-06 13:30:37 -07:00
2021-03-30 13:42:33 -04:00
2015-09-10 13:29:01 -07:00
2021-07-19 11:39:28 +02:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2020-08-12 10:58:00 -07:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2021-08-13 13:19:06 -06:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-10-16 11:11:22 -07:00
2020-03-23 17:01:47 +01:00
2022-01-23 06:20:44 +02:00
2017-11-02 11:10:55 +01:00
2022-01-08 00:28:41 -05:00
2020-08-12 10:58:00 -07:00