Herton Ronaldo Krzesinski cf7474451c [SCSI] advansys: fix regression with request_firmware change
On newer kernels users of advansys module are reporting system hang when
trying to load it without firmware files present. After looking closely
at description on https://qa.mandriva.com/show_bug.cgi?id=53220, I think
this is related to commit "[SCSI] advansys: use request_firmware". The
problem is that after switch to request_firmware, asc_dvc->err_code
isn't being set when firmware files aren't found or loading fails.

err_code is used by the driver to judge if there was a fatal error or
not, as can be seen for example on advansys_board_found, which will only
return -ENODEV when err_code is set. Because err_code isn't being set
when request_firmware fails, this is a change of behaviour of the code
before request_firmware addition, making it continue to load and it
fails later as the firmware wasn't really loaded.

Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-03-27 15:12:37 -04:00
..
2010-02-17 17:43:54 -06:00
2010-03-15 14:50:17 +01:00
2008-01-11 18:22:30 -06:00
2009-05-15 12:24:59 -04:00
2010-02-09 11:13:56 +01:00
2009-04-03 10:17:31 -05:00
2009-04-03 10:17:31 -05:00
2009-04-03 10:17:17 -05:00
2009-04-03 10:17:17 -05:00
2008-10-16 16:52:06 +02:00
2009-10-31 12:11:38 -07:00
2010-01-18 10:48:07 -06:00
2008-08-29 02:13:10 -07:00
2010-01-18 10:48:08 -06:00
2010-02-09 11:13:56 +01:00
2010-02-27 18:31:10 +01:00
2008-12-28 20:00:03 +01:00
2008-01-30 13:14:02 -06:00
2010-02-09 11:13:56 +01:00
2008-01-30 13:14:02 -06:00
2008-07-02 15:06:25 -06:00
2009-12-10 08:54:15 -06:00
2008-02-07 18:02:44 -06:00
2009-12-10 08:54:13 -06:00
2008-10-23 11:42:19 -05:00
2010-01-18 10:48:07 -06:00