Salman Qazi f13d4f979c hrtimer: Preserve timer state in remove_hrtimer()
The race is described as follows:

CPU X                                 CPU Y
remove_hrtimer
// state & QUEUED == 0
timer->state = CALLBACK
unlock timer base
timer->f(n) //very long
                                  hrtimer_start
                                    lock timer base
                                    remove_hrtimer // no effect
                                    hrtimer_enqueue
                                    timer->state = CALLBACK |
                                                   QUEUED
                                    unlock timer base
                                  hrtimer_start
                                    lock timer base
                                    remove_hrtimer
                                        mode = INACTIVE
                                        // CALLBACK bit lost!
                                    switch_hrtimer_base
                                            CALLBACK bit not set:
                                                    timer->base
                                                    changes to a
                                                    different CPU.
lock this CPU's timer base

The bug was introduced with commit ca109491f (hrtimer: removing all ur
callback modes) in 2.6.29

[ tglx: Feed new state via local variable and add a comment. ]

Signed-off-by: Salman Qazi <sqazi@google.com>
Cc: akpm@linux-foundation.org
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20101012142351.8485.21823.stgit@dungbeetle.mtv.corp.google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org
2010-10-14 13:29:59 +02:00
..
2010-07-29 13:24:57 +02:00
2010-08-09 16:48:42 -04:00
2010-07-14 11:29:46 +02:00
2010-07-28 09:58:19 -04:00
2010-08-11 00:28:20 -04:00
2010-09-09 18:57:23 -07:00
2009-09-18 09:48:52 -07:00
2010-09-22 17:22:39 -07:00
2010-10-01 10:50:58 -07:00
2010-06-29 10:07:09 +02:00
2009-01-14 18:09:02 +01:00
2010-08-11 23:04:20 +09:30
2010-05-11 12:01:10 -07:00
2010-09-21 13:50:50 +02:00
2010-10-07 09:41:25 +02:00
2010-07-27 12:40:54 +02:00
2010-03-06 11:26:23 -08:00
2009-09-23 18:13:10 -07:00
2010-05-10 08:48:39 +02:00
2009-06-18 13:03:55 -07:00
2010-09-13 10:26:52 +02:00