Pablo Neira Ayuso
83731671d9
netfilter: ctnetlink: fix regression in expectation handling ...
This patch fixes a regression (introduced by myself in commit 19abb7b:
netfilter: ctnetlink: deliver events for conntracks changed from
userspace) that results in an expectation re-insertion since
__nf_ct_expect_check() may return 0 for expectation timer refreshing.
This patch also removes a unnecessary refcount bump that
pretended to avoid a possible race condition with event delivery
and expectation timers (as said, not needed since we hold a
reference to the object since until we finish the expectation
setup). This also merges nf_ct_expect_related_report() and
nf_ct_expect_related() which look basically the same.
Reported-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
2009-04-06 17:47:20 +02:00
2008-10-22 18:54:47 -05:00
2009-02-27 06:14:43 +01:00
2008-12-17 15:44:58 -08:00
2008-12-25 13:39:04 +01:00
2009-04-06 17:47:20 +02:00
2009-03-25 21:05:46 +01:00
2009-01-26 21:03:35 -08:00
2009-03-21 13:41:09 -07:00
2008-09-12 16:30:20 -07:00
2008-07-14 22:42:19 -07:00
2008-01-28 15:11:17 -08:00
2009-03-24 19:49:11 -07:00
2007-04-26 15:50:17 -07:00
2008-11-26 15:32:27 -08:00
2007-10-10 16:55:55 -07:00
2008-01-31 19:27:33 -08:00
2009-01-21 14:01:59 -08:00
2008-02-12 17:53:34 -08:00
2009-03-24 23:32:03 -07:00
2009-03-27 20:13:13 -04:00
2008-11-19 15:44:53 -08:00
2009-03-28 15:01:36 +11:00
2008-07-19 22:35:47 -07:00
2008-12-21 20:09:50 -08:00
2008-11-27 00:12:47 -08:00
2007-10-10 16:52:50 -07:00
2008-11-27 23:04:13 -08:00
2009-03-21 19:06:54 -07:00
2008-01-28 14:55:58 -08:00
2008-11-25 17:35:18 -08:00
2008-01-31 19:27:02 -08:00
2009-03-27 00:16:21 -07:00
2008-07-05 19:01:28 -07:00
2008-11-25 17:35:18 -08:00
2008-07-05 21:26:57 -07:00
2008-11-26 15:24:32 -08:00
2008-06-03 16:36:54 -07:00
2008-07-18 04:04:22 -07:00
2009-03-27 20:12:52 -04:00
2009-03-21 13:29:05 -07:00
2008-10-07 12:41:01 -07:00
2008-04-03 14:28:30 -07:00
2008-08-28 02:53:51 -07:00
2009-02-14 22:58:35 -08:00
2009-02-26 23:13:35 -08:00
2009-02-01 12:31:33 -08:00
2008-10-01 07:46:49 -07:00
2008-11-16 19:40:17 -08:00
2008-06-11 21:00:38 -07:00
2008-03-04 13:48:30 -08:00
2008-08-14 15:33:21 -07:00
2008-06-11 21:00:38 -07:00
2008-02-05 02:54:16 -08:00
2009-02-14 22:58:35 -08:00
2009-02-15 22:43:38 -08:00
2008-07-25 02:54:40 -07:00
2008-06-11 21:00:38 -07:00
2008-10-09 12:03:17 -07:00
2009-02-14 22:58:35 -08:00
2009-02-14 22:58:35 -08:00
2008-06-16 18:50:49 -07:00
2008-11-21 11:42:55 -05:00
2007-10-10 16:49:07 -07:00
2008-02-29 11:46:17 -08:00
2008-03-31 21:02:47 -07:00
2008-03-31 21:02:47 -07:00
2008-03-28 16:28:36 -07:00
2009-03-27 20:13:23 -04:00
2008-04-12 13:43:22 +09:00
2009-01-04 16:04:39 -08:00
2008-11-12 00:54:54 -08:00
2009-03-03 01:14:27 -08:00
2009-01-06 11:38:15 -07:00
2008-01-28 14:53:38 -08:00
2009-03-28 15:01:37 +11:00
2009-03-25 18:26:30 +01:00
2009-01-21 14:02:01 -08:00
2008-11-16 23:01:49 -08:00
2009-02-01 01:12:42 -08:00
2009-01-08 10:40:57 -08:00
2009-03-21 19:06:50 -07:00
2008-03-22 16:56:51 -07:00
2008-01-28 14:54:29 -08:00
2007-04-25 22:27:55 -07:00
2008-11-21 16:45:22 -08:00
2008-06-17 17:08:32 -07:00
2008-10-01 07:35:39 -07:00
2008-04-16 00:46:52 -07:00
2009-03-20 01:33:32 -07:00
2008-11-14 11:29:12 +11:00
2008-06-11 21:00:38 -07:00
2009-02-24 03:50:29 -08:00
2008-07-05 21:25:39 -07:00
2009-04-02 16:31:44 -07:00
2008-11-21 16:45:22 -08:00
2009-02-14 22:58:35 -08:00
2009-03-24 19:49:11 -07:00
2008-10-29 01:41:45 -07:00
2008-06-16 18:32:46 -07:00
2009-01-11 00:06:32 -08:00
2009-02-27 14:52:59 -05:00
2007-02-08 13:34:36 -08:00
2007-04-25 22:24:32 -07:00
2008-11-25 18:00:48 -08:00
83731671d9