2019-04-30 18:42:43 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2008-01-29 13:53:40 +00:00
|
|
|
/*
|
|
|
|
* Functions related to setting various queue properties from drivers
|
|
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/bio.h>
|
2024-06-13 08:48:22 +00:00
|
|
|
#include <linux/blk-integrity.h>
|
2021-05-07 01:02:27 +00:00
|
|
|
#include <linux/pagemap.h>
|
2021-08-09 14:17:43 +00:00
|
|
|
#include <linux/backing-dev-defs.h>
|
2009-07-31 15:49:12 +00:00
|
|
|
#include <linux/gcd.h>
|
2010-03-15 11:46:51 +00:00
|
|
|
#include <linux/lcm.h>
|
2009-11-11 12:47:45 +00:00
|
|
|
#include <linux/jiffies.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/gfp.h>
|
2019-08-28 12:35:42 +00:00
|
|
|
#include <linux/dma-mapping.h>
|
2008-01-29 13:53:40 +00:00
|
|
|
|
|
|
|
#include "blk.h"
|
2023-02-03 15:03:51 +00:00
|
|
|
#include "blk-rq-qos.h"
|
block: hook up writeback throttling
Enable throttling of buffered writeback to make it a lot
more smooth, and has way less impact on other system activity.
Background writeback should be, by definition, background
activity. The fact that we flush huge bundles of it at the time
means that it potentially has heavy impacts on foreground workloads,
which isn't ideal. We can't easily limit the sizes of writes that
we do, since that would impact file system layout in the presence
of delayed allocation. So just throttle back buffered writeback,
unless someone is waiting for it.
The algorithm for when to throttle takes its inspiration in the
CoDel networking scheduling algorithm. Like CoDel, blk-wb monitors
the minimum latencies of requests over a window of time. In that
window of time, if the minimum latency of any request exceeds a
given target, then a scale count is incremented and the queue depth
is shrunk. The next monitoring window is shrunk accordingly. Unlike
CoDel, if we hit a window that exhibits good behavior, then we
simply increment the scale count and re-calculate the limits for that
scale value. This prevents us from oscillating between a
close-to-ideal value and max all the time, instead remaining in the
windows where we get good behavior.
Unlike CoDel, blk-wb allows the scale count to to negative. This
happens if we primarily have writes going on. Unlike positive
scale counts, this doesn't change the size of the monitoring window.
When the heavy writers finish, blk-bw quickly snaps back to it's
stable state of a zero scale count.
The patch registers a sysfs entry, 'wb_lat_usec'. This sets the latency
target to me met. It defaults to 2 msec for non-rotational storage, and
75 msec for rotational storage. Setting this value to '0' disables
blk-wb. Generally, a user would not have to touch this setting.
We don't enable WBT on devices that are managed with CFQ, and have
a non-root block cgroup attached. If we have a proportional share setup
on this particular disk, then the wbt throttling will interfere with
that. We don't have a strong need for wbt for that case, since we will
rely on CFQ doing that for us.
Signed-off-by: Jens Axboe <axboe@fb.com>
2016-11-09 19:38:14 +00:00
|
|
|
#include "blk-wbt.h"
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2008-09-14 12:55:09 +00:00
|
|
|
void blk_queue_rq_timeout(struct request_queue *q, unsigned int timeout)
|
|
|
|
{
|
|
|
|
q->rq_timeout = timeout;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(blk_queue_rq_timeout);
|
|
|
|
|
2012-01-11 15:27:11 +00:00
|
|
|
/**
|
|
|
|
* blk_set_stacking_limits - set default limits for stacking devices
|
|
|
|
* @lim: the queue_limits structure to reset
|
|
|
|
*
|
2024-02-13 07:34:13 +00:00
|
|
|
* Prepare queue limits for applying limits from underlying devices using
|
|
|
|
* blk_stack_limits().
|
2012-01-11 15:27:11 +00:00
|
|
|
*/
|
|
|
|
void blk_set_stacking_limits(struct queue_limits *lim)
|
|
|
|
{
|
2024-02-13 07:34:13 +00:00
|
|
|
memset(lim, 0, sizeof(*lim));
|
|
|
|
lim->logical_block_size = SECTOR_SIZE;
|
|
|
|
lim->physical_block_size = SECTOR_SIZE;
|
|
|
|
lim->io_min = SECTOR_SIZE;
|
|
|
|
lim->discard_granularity = SECTOR_SIZE;
|
|
|
|
lim->dma_alignment = SECTOR_SIZE - 1;
|
|
|
|
lim->seg_boundary_mask = BLK_SEG_BOUNDARY_MASK;
|
2012-01-11 15:27:11 +00:00
|
|
|
|
|
|
|
/* Inherit limits from component devices */
|
|
|
|
lim->max_segments = USHRT_MAX;
|
2018-07-20 18:57:38 +00:00
|
|
|
lim->max_discard_segments = USHRT_MAX;
|
2012-01-11 15:27:11 +00:00
|
|
|
lim->max_hw_sectors = UINT_MAX;
|
2013-10-18 15:44:49 +00:00
|
|
|
lim->max_segment_size = UINT_MAX;
|
2012-08-01 08:44:28 +00:00
|
|
|
lim->max_sectors = UINT_MAX;
|
2015-11-13 21:46:48 +00:00
|
|
|
lim->max_dev_sectors = UINT_MAX;
|
2016-11-30 20:28:59 +00:00
|
|
|
lim->max_write_zeroes_sectors = UINT_MAX;
|
2024-11-08 15:46:51 +00:00
|
|
|
lim->max_hw_zone_append_sectors = UINT_MAX;
|
2024-02-13 07:34:16 +00:00
|
|
|
lim->max_user_discard_sectors = UINT_MAX;
|
2012-01-11 15:27:11 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(blk_set_stacking_limits);
|
|
|
|
|
2024-06-26 14:26:27 +00:00
|
|
|
void blk_apply_bdi_limits(struct backing_dev_info *bdi,
|
2024-02-13 07:34:12 +00:00
|
|
|
struct queue_limits *lim)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* For read-ahead of large files to be effective, we need to read ahead
|
|
|
|
* at least twice the optimal I/O size.
|
|
|
|
*/
|
|
|
|
bdi->ra_pages = max(lim->io_opt * 2 / PAGE_SIZE, VM_READAHEAD_PAGES);
|
|
|
|
bdi->io_pages = lim->max_sectors >> PAGE_SECTORS_SHIFT;
|
|
|
|
}
|
|
|
|
|
2024-02-13 07:34:14 +00:00
|
|
|
static int blk_validate_zoned_limits(struct queue_limits *lim)
|
|
|
|
{
|
2024-06-17 06:04:49 +00:00
|
|
|
if (!(lim->features & BLK_FEAT_ZONED)) {
|
2024-02-13 07:34:14 +00:00
|
|
|
if (WARN_ON_ONCE(lim->max_open_zones) ||
|
|
|
|
WARN_ON_ONCE(lim->max_active_zones) ||
|
|
|
|
WARN_ON_ONCE(lim->zone_write_granularity) ||
|
|
|
|
WARN_ON_ONCE(lim->max_zone_append_sectors))
|
|
|
|
return -EINVAL;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(!IS_ENABLED(CONFIG_BLK_DEV_ZONED)))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2024-06-11 02:36:36 +00:00
|
|
|
/*
|
|
|
|
* Given that active zones include open zones, the maximum number of
|
|
|
|
* open zones cannot be larger than the maximum number of active zones.
|
|
|
|
*/
|
|
|
|
if (lim->max_active_zones &&
|
|
|
|
lim->max_open_zones > lim->max_active_zones)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2024-02-13 07:34:14 +00:00
|
|
|
if (lim->zone_write_granularity < lim->logical_block_size)
|
|
|
|
lim->zone_write_granularity = lim->logical_block_size;
|
|
|
|
|
2024-11-08 15:46:51 +00:00
|
|
|
/*
|
|
|
|
* The Zone Append size is limited by the maximum I/O size and the zone
|
|
|
|
* size given that it can't span zones.
|
|
|
|
*
|
|
|
|
* If no max_hw_zone_append_sectors limit is provided, the block layer
|
|
|
|
* will emulated it, else we're also bound by the hardware limit.
|
|
|
|
*/
|
|
|
|
lim->max_zone_append_sectors =
|
|
|
|
min_not_zero(lim->max_hw_zone_append_sectors,
|
|
|
|
min(lim->chunk_sectors, lim->max_hw_sectors));
|
2024-02-13 07:34:14 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2024-06-13 08:48:22 +00:00
|
|
|
static int blk_validate_integrity_limits(struct queue_limits *lim)
|
|
|
|
{
|
|
|
|
struct blk_integrity *bi = &lim->integrity;
|
|
|
|
|
|
|
|
if (!bi->tuple_size) {
|
|
|
|
if (bi->csum_type != BLK_INTEGRITY_CSUM_NONE ||
|
|
|
|
bi->tag_size || ((bi->flags & BLK_INTEGRITY_REF_TAG))) {
|
|
|
|
pr_warn("invalid PI settings.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) {
|
|
|
|
pr_warn("integrity support disabled.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bi->csum_type == BLK_INTEGRITY_CSUM_NONE &&
|
|
|
|
(bi->flags & BLK_INTEGRITY_REF_TAG)) {
|
|
|
|
pr_warn("ref tag not support without checksum.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!bi->interval_exp)
|
|
|
|
bi->interval_exp = ilog2(lim->logical_block_size);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
/*
|
|
|
|
* Returns max guaranteed bytes which we can fit in a bio.
|
|
|
|
*
|
|
|
|
* We request that an atomic_write is ITER_UBUF iov_iter (so a single vector),
|
|
|
|
* so we assume that we can fit in at least PAGE_SIZE in a segment, apart from
|
|
|
|
* the first and last segments.
|
|
|
|
*/
|
2024-06-26 14:26:26 +00:00
|
|
|
static unsigned int blk_queue_max_guaranteed_bio(struct queue_limits *lim)
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
{
|
|
|
|
unsigned int max_segments = min(BIO_MAX_VECS, lim->max_segments);
|
|
|
|
unsigned int length;
|
|
|
|
|
|
|
|
length = min(max_segments, 2) * lim->logical_block_size;
|
|
|
|
if (max_segments > 2)
|
|
|
|
length += (max_segments - 2) * PAGE_SIZE;
|
|
|
|
|
|
|
|
return length;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void blk_atomic_writes_update_limits(struct queue_limits *lim)
|
|
|
|
{
|
|
|
|
unsigned int unit_limit = min(lim->max_hw_sectors << SECTOR_SHIFT,
|
|
|
|
blk_queue_max_guaranteed_bio(lim));
|
|
|
|
|
|
|
|
unit_limit = rounddown_pow_of_two(unit_limit);
|
|
|
|
|
|
|
|
lim->atomic_write_max_sectors =
|
|
|
|
min(lim->atomic_write_hw_max >> SECTOR_SHIFT,
|
|
|
|
lim->max_hw_sectors);
|
|
|
|
lim->atomic_write_unit_min =
|
|
|
|
min(lim->atomic_write_hw_unit_min, unit_limit);
|
|
|
|
lim->atomic_write_unit_max =
|
|
|
|
min(lim->atomic_write_hw_unit_max, unit_limit);
|
|
|
|
lim->atomic_write_boundary_sectors =
|
|
|
|
lim->atomic_write_hw_boundary >> SECTOR_SHIFT;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void blk_validate_atomic_write_limits(struct queue_limits *lim)
|
|
|
|
{
|
|
|
|
unsigned int boundary_sectors;
|
|
|
|
|
|
|
|
if (!lim->atomic_write_hw_max)
|
|
|
|
goto unsupported;
|
|
|
|
|
2024-11-18 10:50:14 +00:00
|
|
|
if (WARN_ON_ONCE(!is_power_of_2(lim->atomic_write_hw_unit_min)))
|
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(!is_power_of_2(lim->atomic_write_hw_unit_max)))
|
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(lim->atomic_write_hw_unit_min >
|
|
|
|
lim->atomic_write_hw_unit_max))
|
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
if (WARN_ON_ONCE(lim->atomic_write_hw_unit_max >
|
|
|
|
lim->atomic_write_hw_max))
|
|
|
|
goto unsupported;
|
|
|
|
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
boundary_sectors = lim->atomic_write_hw_boundary >> SECTOR_SHIFT;
|
|
|
|
|
|
|
|
if (boundary_sectors) {
|
2024-11-18 10:50:14 +00:00
|
|
|
if (WARN_ON_ONCE(lim->atomic_write_hw_max >
|
|
|
|
lim->atomic_write_hw_boundary))
|
|
|
|
goto unsupported;
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
/*
|
|
|
|
* A feature of boundary support is that it disallows bios to
|
|
|
|
* be merged which would result in a merged request which
|
|
|
|
* crosses either a chunk sector or atomic write HW boundary,
|
|
|
|
* even though chunk sectors may be just set for performance.
|
|
|
|
* For simplicity, disallow atomic writes for a chunk sector
|
|
|
|
* which is non-zero and smaller than atomic write HW boundary.
|
|
|
|
* Furthermore, chunk sectors must be a multiple of atomic
|
|
|
|
* write HW boundary. Otherwise boundary support becomes
|
|
|
|
* complicated.
|
|
|
|
* Devices which do not conform to these rules can be dealt
|
|
|
|
* with if and when they show up.
|
|
|
|
*/
|
2024-06-21 18:30:16 +00:00
|
|
|
if (WARN_ON_ONCE(lim->chunk_sectors % boundary_sectors))
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The boundary size just needs to be a multiple of unit_max
|
|
|
|
* (and not necessarily a power-of-2), so this following check
|
|
|
|
* could be relaxed in future.
|
|
|
|
* Furthermore, if needed, unit_max could even be reduced so
|
|
|
|
* that it is compliant with a !power-of-2 boundary.
|
|
|
|
*/
|
|
|
|
if (!is_power_of_2(boundary_sectors))
|
|
|
|
goto unsupported;
|
|
|
|
}
|
|
|
|
|
|
|
|
blk_atomic_writes_update_limits(lim);
|
|
|
|
return;
|
|
|
|
|
|
|
|
unsupported:
|
|
|
|
lim->atomic_write_max_sectors = 0;
|
|
|
|
lim->atomic_write_boundary_sectors = 0;
|
|
|
|
lim->atomic_write_unit_min = 0;
|
|
|
|
lim->atomic_write_unit_max = 0;
|
|
|
|
}
|
|
|
|
|
2024-02-13 07:34:14 +00:00
|
|
|
/*
|
|
|
|
* Check that the limits in lim are valid, initialize defaults for unset
|
|
|
|
* values, and cap values based on others where needed.
|
|
|
|
*/
|
2024-11-13 08:45:35 +00:00
|
|
|
int blk_validate_limits(struct queue_limits *lim)
|
2024-02-13 07:34:14 +00:00
|
|
|
{
|
|
|
|
unsigned int max_hw_sectors;
|
2024-05-24 10:46:51 +00:00
|
|
|
unsigned int logical_block_sectors;
|
2024-06-13 08:48:22 +00:00
|
|
|
int err;
|
2024-02-13 07:34:14 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Unless otherwise specified, default to 512 byte logical blocks and a
|
|
|
|
* physical block size equal to the logical block size.
|
|
|
|
*/
|
|
|
|
if (!lim->logical_block_size)
|
|
|
|
lim->logical_block_size = SECTOR_SIZE;
|
2024-07-08 09:16:48 +00:00
|
|
|
else if (blk_validate_block_size(lim->logical_block_size)) {
|
|
|
|
pr_warn("Invalid logical block size (%d)\n", lim->logical_block_size);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2024-02-13 07:34:14 +00:00
|
|
|
if (lim->physical_block_size < lim->logical_block_size)
|
|
|
|
lim->physical_block_size = lim->logical_block_size;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The minimum I/O size defaults to the physical block size unless
|
|
|
|
* explicitly overridden.
|
|
|
|
*/
|
|
|
|
if (lim->io_min < lim->physical_block_size)
|
|
|
|
lim->io_min = lim->physical_block_size;
|
|
|
|
|
2024-11-18 14:52:50 +00:00
|
|
|
/*
|
|
|
|
* The optimal I/O size may not be aligned to physical block size
|
|
|
|
* (because it may be limited by dma engines which have no clue about
|
|
|
|
* block size of the disks attached to them), so we round it down here.
|
|
|
|
*/
|
|
|
|
lim->io_opt = round_down(lim->io_opt, lim->physical_block_size);
|
|
|
|
|
2024-02-13 07:34:14 +00:00
|
|
|
/*
|
|
|
|
* max_hw_sectors has a somewhat weird default for historical reason,
|
|
|
|
* but driver really should set their own instead of relying on this
|
|
|
|
* value.
|
|
|
|
*
|
|
|
|
* The block layer relies on the fact that every driver can
|
|
|
|
* handle at lest a page worth of data per I/O, and needs the value
|
|
|
|
* aligned to the logical block size.
|
|
|
|
*/
|
|
|
|
if (!lim->max_hw_sectors)
|
|
|
|
lim->max_hw_sectors = BLK_SAFE_MAX_SECTORS;
|
|
|
|
if (WARN_ON_ONCE(lim->max_hw_sectors < PAGE_SECTORS))
|
|
|
|
return -EINVAL;
|
2024-05-24 10:46:51 +00:00
|
|
|
logical_block_sectors = lim->logical_block_size >> SECTOR_SHIFT;
|
|
|
|
if (WARN_ON_ONCE(logical_block_sectors > lim->max_hw_sectors))
|
|
|
|
return -EINVAL;
|
2024-02-13 07:34:14 +00:00
|
|
|
lim->max_hw_sectors = round_down(lim->max_hw_sectors,
|
2024-05-24 10:46:51 +00:00
|
|
|
logical_block_sectors);
|
2024-02-13 07:34:14 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The actual max_sectors value is a complex beast and also takes the
|
|
|
|
* max_dev_sectors value (set by SCSI ULPs) and a user configurable
|
|
|
|
* value into account. The ->max_sectors value is always calculated
|
|
|
|
* from these, so directly setting it won't have any effect.
|
|
|
|
*/
|
|
|
|
max_hw_sectors = min_not_zero(lim->max_hw_sectors,
|
|
|
|
lim->max_dev_sectors);
|
|
|
|
if (lim->max_user_sectors) {
|
2024-03-26 06:07:45 +00:00
|
|
|
if (lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE)
|
2024-02-13 07:34:14 +00:00
|
|
|
return -EINVAL;
|
|
|
|
lim->max_sectors = min(max_hw_sectors, lim->max_user_sectors);
|
2024-07-01 05:17:51 +00:00
|
|
|
} else if (lim->io_opt > (BLK_DEF_MAX_SECTORS_CAP << SECTOR_SHIFT)) {
|
2024-05-31 07:47:59 +00:00
|
|
|
lim->max_sectors =
|
|
|
|
min(max_hw_sectors, lim->io_opt >> SECTOR_SHIFT);
|
2024-07-01 05:17:50 +00:00
|
|
|
} else if (lim->io_min > (BLK_DEF_MAX_SECTORS_CAP << SECTOR_SHIFT)) {
|
2024-05-31 07:47:59 +00:00
|
|
|
lim->max_sectors =
|
|
|
|
min(max_hw_sectors, lim->io_min >> SECTOR_SHIFT);
|
2024-02-13 07:34:14 +00:00
|
|
|
} else {
|
|
|
|
lim->max_sectors = min(max_hw_sectors, BLK_DEF_MAX_SECTORS_CAP);
|
|
|
|
}
|
|
|
|
lim->max_sectors = round_down(lim->max_sectors,
|
2024-05-24 10:46:51 +00:00
|
|
|
logical_block_sectors);
|
2024-02-13 07:34:14 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Random default for the maximum number of segments. Driver should not
|
|
|
|
* rely on this and set their own.
|
|
|
|
*/
|
|
|
|
if (!lim->max_segments)
|
|
|
|
lim->max_segments = BLK_MAX_SEGMENTS;
|
|
|
|
|
2024-02-13 07:34:16 +00:00
|
|
|
lim->max_discard_sectors =
|
|
|
|
min(lim->max_hw_discard_sectors, lim->max_user_discard_sectors);
|
|
|
|
|
2024-02-13 07:34:14 +00:00
|
|
|
if (!lim->max_discard_segments)
|
|
|
|
lim->max_discard_segments = 1;
|
|
|
|
|
|
|
|
if (lim->discard_granularity < lim->physical_block_size)
|
|
|
|
lim->discard_granularity = lim->physical_block_size;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* By default there is no limit on the segment boundary alignment,
|
|
|
|
* but if there is one it can't be smaller than the page size as
|
|
|
|
* that would break all the normal I/O patterns.
|
|
|
|
*/
|
|
|
|
if (!lim->seg_boundary_mask)
|
|
|
|
lim->seg_boundary_mask = BLK_SEG_BOUNDARY_MASK;
|
|
|
|
if (WARN_ON_ONCE(lim->seg_boundary_mask < PAGE_SIZE - 1))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/*
|
2024-04-07 13:19:31 +00:00
|
|
|
* Stacking device may have both virtual boundary and max segment
|
|
|
|
* size limit, so allow this setting now, and long-term the two
|
|
|
|
* might need to move out of stacking limits since we have immutable
|
|
|
|
* bvec and lower layer bio splitting is supposed to handle the two
|
|
|
|
* correctly.
|
2024-02-13 07:34:14 +00:00
|
|
|
*/
|
2024-04-24 13:47:22 +00:00
|
|
|
if (lim->virt_boundary_mask) {
|
|
|
|
if (!lim->max_segment_size)
|
|
|
|
lim->max_segment_size = UINT_MAX;
|
|
|
|
} else {
|
2024-02-21 12:50:10 +00:00
|
|
|
/*
|
|
|
|
* The maximum segment size has an odd historic 64k default that
|
|
|
|
* drivers probably should override. Just like the I/O size we
|
|
|
|
* require drivers to at least handle a full page per segment.
|
|
|
|
*/
|
|
|
|
if (!lim->max_segment_size)
|
|
|
|
lim->max_segment_size = BLK_MAX_SEGMENT_SIZE;
|
|
|
|
if (WARN_ON_ONCE(lim->max_segment_size < PAGE_SIZE))
|
|
|
|
return -EINVAL;
|
2024-02-13 07:34:14 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We require drivers to at least do logical block aligned I/O, but
|
|
|
|
* historically could not check for that due to the separate calls
|
|
|
|
* to set the limits. Once the transition is finished the check
|
|
|
|
* below should be narrowed down to check the logical block size.
|
|
|
|
*/
|
|
|
|
if (!lim->dma_alignment)
|
|
|
|
lim->dma_alignment = SECTOR_SIZE - 1;
|
|
|
|
if (WARN_ON_ONCE(lim->dma_alignment > PAGE_SIZE))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (lim->alignment_offset) {
|
|
|
|
lim->alignment_offset &= (lim->physical_block_size - 1);
|
2024-06-26 14:26:24 +00:00
|
|
|
lim->flags &= ~BLK_FLAG_MISALIGNED;
|
2024-02-13 07:34:14 +00:00
|
|
|
}
|
|
|
|
|
2024-06-17 06:04:40 +00:00
|
|
|
if (!(lim->features & BLK_FEAT_WRITE_CACHE))
|
|
|
|
lim->features &= ~BLK_FEAT_FUA;
|
|
|
|
|
block: Add core atomic write support
Add atomic write support, as follows:
- add helper functions to get request_queue atomic write limits
- report request_queue atomic write support limits to sysfs and update Doc
- support to safely merge atomic writes
- deal with splitting atomic writes
- misc helper functions
- add a per-request atomic write flag
New request_queue limits are added, as follows:
- atomic_write_hw_max is set by the block driver and is the maximum length
of an atomic write which the device may support. It is not
necessarily a power-of-2.
- atomic_write_max_sectors is derived from atomic_write_hw_max_sectors and
max_hw_sectors. It is always a power-of-2. Atomic writes may be merged,
and atomic_write_max_sectors would be the limit on a merged atomic write
request size. This value is not capped at max_sectors, as the value in
max_sectors can be controlled from userspace, and it would only cause
trouble if userspace could limit atomic_write_unit_max_bytes and the
other atomic write limits.
- atomic_write_hw_unit_{min,max} are set by the block driver and are the
min/max length of an atomic write unit which the device may support. They
both must be a power-of-2. Typically atomic_write_hw_unit_max will hold
the same value as atomic_write_hw_max.
- atomic_write_unit_{min,max} are derived from
atomic_write_hw_unit_{min,max}, max_hw_sectors, and block core limits.
Both min and max values must be a power-of-2.
- atomic_write_hw_boundary is set by the block driver. If non-zero, it
indicates an LBA space boundary at which an atomic write straddles no
longer is atomically executed by the disk. The value must be a
power-of-2. Note that it would be acceptable to enforce a rule that
atomic_write_hw_boundary_sectors is a multiple of
atomic_write_hw_unit_max, but the resultant code would be more
complicated.
All atomic writes limits are by default set 0 to indicate no atomic write
support. Even though it is assumed by Linux that a logical block can always
be atomically written, we ignore this as it is not of particular interest.
Stacked devices are just not supported either for now.
An atomic write must always be submitted to the block driver as part of a
single request. As such, only a single BIO must be submitted to the block
layer for an atomic write. When a single atomic write BIO is submitted, it
cannot be split. As such, atomic_write_unit_{max, min}_bytes are limited
by the maximum guaranteed BIO size which will not be required to be split.
This max size is calculated by request_queue max segments and the number
of bvecs a BIO can fit, BIO_MAX_VECS. Currently we rely on userspace
issuing a write with iovcnt=1 for pwritev2() - as such, we can rely on each
segment containing PAGE_SIZE of data, apart from the first+last, which each
can fit logical block size of data. The first+last will be LBS
length/aligned as we rely on direct IO alignment rules also.
New sysfs files are added to report the following atomic write limits:
- atomic_write_unit_max_bytes - same as atomic_write_unit_max_sectors in
bytes
- atomic_write_unit_min_bytes - same as atomic_write_unit_min_sectors in
bytes
- atomic_write_boundary_bytes - same as atomic_write_hw_boundary_sectors in
bytes
- atomic_write_max_bytes - same as atomic_write_max_sectors in bytes
Atomic writes may only be merged with other atomic writes and only under
the following conditions:
- total resultant request length <= atomic_write_max_bytes
- the merged write does not straddle a boundary
Helper function bdev_can_atomic_write() is added to indicate whether
atomic writes may be issued to a bdev. If a bdev is a partition, the
partition start must be aligned with both atomic_write_unit_min_sectors
and atomic_write_hw_boundary_sectors.
FSes will rely on the block layer to validate that an atomic write BIO
submitted will be of valid size, so add blk_validate_atomic_write_op_size()
for this purpose. Userspace expects an atomic write which is of invalid
size to be rejected with -EINVAL, so add BLK_STS_INVAL for this. Also use
BLK_STS_INVAL for when a BIO needs to be split, as this should mean an
invalid size BIO.
Flag REQ_ATOMIC is used for indicating an atomic write.
Co-developed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240620125359.2684798-6-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-06-20 12:53:54 +00:00
|
|
|
blk_validate_atomic_write_limits(lim);
|
|
|
|
|
2024-06-13 08:48:22 +00:00
|
|
|
err = blk_validate_integrity_limits(lim);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2024-02-13 07:34:14 +00:00
|
|
|
return blk_validate_zoned_limits(lim);
|
|
|
|
}
|
2024-11-13 08:45:35 +00:00
|
|
|
EXPORT_SYMBOL_GPL(blk_validate_limits);
|
2024-02-13 07:34:14 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Set the default limits for a newly allocated queue. @lim contains the
|
|
|
|
* initial limits set by the driver, which could be no limit in which case
|
|
|
|
* all fields are cleared to zero.
|
|
|
|
*/
|
|
|
|
int blk_set_default_limits(struct queue_limits *lim)
|
|
|
|
{
|
2024-02-13 07:34:16 +00:00
|
|
|
/*
|
|
|
|
* Most defaults are set by capping the bounds in blk_validate_limits,
|
|
|
|
* but max_user_discard_sectors is special and needs an explicit
|
|
|
|
* initialization to the max value here.
|
|
|
|
*/
|
|
|
|
lim->max_user_discard_sectors = UINT_MAX;
|
2024-02-13 07:34:14 +00:00
|
|
|
return blk_validate_limits(lim);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* queue_limits_commit_update - commit an atomic update of queue limits
|
|
|
|
* @q: queue to update
|
|
|
|
* @lim: limits to apply
|
|
|
|
*
|
|
|
|
* Apply the limits in @lim that were obtained from queue_limits_start_update()
|
|
|
|
* and updated by the caller to @q.
|
|
|
|
*
|
|
|
|
* Returns 0 if successful, else a negative error code.
|
|
|
|
*/
|
|
|
|
int queue_limits_commit_update(struct request_queue *q,
|
|
|
|
struct queue_limits *lim)
|
|
|
|
{
|
2024-06-13 08:48:22 +00:00
|
|
|
int error;
|
2024-02-13 07:34:14 +00:00
|
|
|
|
2024-06-13 08:48:22 +00:00
|
|
|
error = blk_validate_limits(lim);
|
|
|
|
if (error)
|
|
|
|
goto out_unlock;
|
|
|
|
|
|
|
|
#ifdef CONFIG_BLK_INLINE_ENCRYPTION
|
|
|
|
if (q->crypto_profile && lim->integrity.tag_size) {
|
|
|
|
pr_warn("blk-integrity: Integrity and hardware inline encryption are not supported together.\n");
|
|
|
|
error = -EINVAL;
|
|
|
|
goto out_unlock;
|
2024-02-13 07:34:14 +00:00
|
|
|
}
|
2024-06-13 08:48:22 +00:00
|
|
|
#endif
|
|
|
|
|
|
|
|
q->limits = *lim;
|
|
|
|
if (q->disk)
|
|
|
|
blk_apply_bdi_limits(q->disk->bdi, lim);
|
|
|
|
out_unlock:
|
2024-02-13 07:34:14 +00:00
|
|
|
mutex_unlock(&q->limits_lock);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(queue_limits_commit_update);
|
|
|
|
|
2024-02-28 22:56:40 +00:00
|
|
|
/**
|
2024-03-14 02:56:15 +00:00
|
|
|
* queue_limits_set - apply queue limits to queue
|
2024-02-28 22:56:40 +00:00
|
|
|
* @q: queue to update
|
|
|
|
* @lim: limits to apply
|
|
|
|
*
|
|
|
|
* Apply the limits in @lim that were freshly initialized to @q.
|
|
|
|
* To update existing limits use queue_limits_start_update() and
|
|
|
|
* queue_limits_commit_update() instead.
|
|
|
|
*
|
|
|
|
* Returns 0 if successful, else a negative error code.
|
|
|
|
*/
|
|
|
|
int queue_limits_set(struct request_queue *q, struct queue_limits *lim)
|
|
|
|
{
|
|
|
|
mutex_lock(&q->limits_lock);
|
|
|
|
return queue_limits_commit_update(q, lim);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(queue_limits_set);
|
|
|
|
|
2022-10-25 19:17:54 +00:00
|
|
|
static int queue_limit_alignment_offset(const struct queue_limits *lim,
|
2022-04-15 04:52:49 +00:00
|
|
|
sector_t sector)
|
|
|
|
{
|
|
|
|
unsigned int granularity = max(lim->physical_block_size, lim->io_min);
|
|
|
|
unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
|
|
|
|
<< SECTOR_SHIFT;
|
|
|
|
|
|
|
|
return (granularity + lim->alignment_offset - alignment) % granularity;
|
|
|
|
}
|
|
|
|
|
2022-10-25 19:17:54 +00:00
|
|
|
static unsigned int queue_limit_discard_alignment(
|
|
|
|
const struct queue_limits *lim, sector_t sector)
|
2022-04-15 04:52:52 +00:00
|
|
|
{
|
|
|
|
unsigned int alignment, granularity, offset;
|
|
|
|
|
|
|
|
if (!lim->max_discard_sectors)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Why are these in bytes, not sectors? */
|
|
|
|
alignment = lim->discard_alignment >> SECTOR_SHIFT;
|
|
|
|
granularity = lim->discard_granularity >> SECTOR_SHIFT;
|
|
|
|
|
|
|
|
/* Offset of the partition start in 'granularity' sectors */
|
|
|
|
offset = sector_div(sector, granularity);
|
|
|
|
|
|
|
|
/* And why do we do this modulus *again* in blkdev_issue_discard()? */
|
|
|
|
offset = (granularity + alignment - offset) % granularity;
|
|
|
|
|
|
|
|
/* Turn it back into bytes, gaah */
|
|
|
|
return offset << SECTOR_SHIFT;
|
|
|
|
}
|
|
|
|
|
blk-settings: align max_sectors on "logical_block_size" boundary
We get I/O errors when we run md-raid1 on the top of dm-integrity on the
top of ramdisk.
device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1
device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8048, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8147, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8246, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8345, 0xbb
The ramdisk device has logical_block_size 512 and max_sectors 255. The
dm-integrity device uses logical_block_size 4096 and it doesn't affect the
"max_sectors" value - thus, it inherits 255 from the ramdisk. So, we have
a device with max_sectors not aligned on logical_block_size.
The md-raid device sees that the underlying leg has max_sectors 255 and it
will split the bios on 255-sector boundary, making the bios unaligned on
logical_block_size.
In order to fix the bug, we round down max_sectors to logical_block_size.
Cc: stable@vger.kernel.org
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-02-24 02:25:30 +00:00
|
|
|
static unsigned int blk_round_down_sectors(unsigned int sectors, unsigned int lbs)
|
|
|
|
{
|
|
|
|
sectors = round_down(sectors, lbs >> SECTOR_SHIFT);
|
|
|
|
if (sectors < PAGE_SIZE >> SECTOR_SHIFT)
|
|
|
|
sectors = PAGE_SIZE >> SECTOR_SHIFT;
|
|
|
|
return sectors;
|
|
|
|
}
|
|
|
|
|
2024-11-18 10:50:15 +00:00
|
|
|
/* Check if second and later bottom devices are compliant */
|
|
|
|
static bool blk_stack_atomic_writes_tail(struct queue_limits *t,
|
|
|
|
struct queue_limits *b)
|
|
|
|
{
|
|
|
|
/* We're not going to support different boundary sizes.. yet */
|
|
|
|
if (t->atomic_write_hw_boundary != b->atomic_write_hw_boundary)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Can't support this */
|
|
|
|
if (t->atomic_write_hw_unit_min > b->atomic_write_hw_unit_max)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Or this */
|
|
|
|
if (t->atomic_write_hw_unit_max < b->atomic_write_hw_unit_min)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
t->atomic_write_hw_max = min(t->atomic_write_hw_max,
|
|
|
|
b->atomic_write_hw_max);
|
|
|
|
t->atomic_write_hw_unit_min = max(t->atomic_write_hw_unit_min,
|
|
|
|
b->atomic_write_hw_unit_min);
|
|
|
|
t->atomic_write_hw_unit_max = min(t->atomic_write_hw_unit_max,
|
|
|
|
b->atomic_write_hw_unit_max);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Check for valid boundary of first bottom device */
|
|
|
|
static bool blk_stack_atomic_writes_boundary_head(struct queue_limits *t,
|
|
|
|
struct queue_limits *b)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Ensure atomic write boundary is aligned with chunk sectors. Stacked
|
|
|
|
* devices store chunk sectors in t->io_min.
|
|
|
|
*/
|
|
|
|
if (b->atomic_write_hw_boundary > t->io_min &&
|
|
|
|
b->atomic_write_hw_boundary % t->io_min)
|
|
|
|
return false;
|
|
|
|
if (t->io_min > b->atomic_write_hw_boundary &&
|
|
|
|
t->io_min % b->atomic_write_hw_boundary)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
t->atomic_write_hw_boundary = b->atomic_write_hw_boundary;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* Check stacking of first bottom device */
|
|
|
|
static bool blk_stack_atomic_writes_head(struct queue_limits *t,
|
|
|
|
struct queue_limits *b)
|
|
|
|
{
|
|
|
|
if (b->atomic_write_hw_boundary &&
|
|
|
|
!blk_stack_atomic_writes_boundary_head(t, b))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (t->io_min <= SECTOR_SIZE) {
|
|
|
|
/* No chunk sectors, so use bottom device values directly */
|
|
|
|
t->atomic_write_hw_unit_max = b->atomic_write_hw_unit_max;
|
|
|
|
t->atomic_write_hw_unit_min = b->atomic_write_hw_unit_min;
|
|
|
|
t->atomic_write_hw_max = b->atomic_write_hw_max;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Find values for limits which work for chunk size.
|
|
|
|
* b->atomic_write_hw_unit_{min, max} may not be aligned with chunk
|
|
|
|
* size (t->io_min), as chunk size is not restricted to a power-of-2.
|
|
|
|
* So we need to find highest power-of-2 which works for the chunk
|
|
|
|
* size.
|
|
|
|
* As an example scenario, we could have b->unit_max = 16K and
|
|
|
|
* t->io_min = 24K. For this case, reduce t->unit_max to a value
|
|
|
|
* aligned with both limits, i.e. 8K in this example.
|
|
|
|
*/
|
|
|
|
t->atomic_write_hw_unit_max = b->atomic_write_hw_unit_max;
|
|
|
|
while (t->io_min % t->atomic_write_hw_unit_max)
|
|
|
|
t->atomic_write_hw_unit_max /= 2;
|
|
|
|
|
|
|
|
t->atomic_write_hw_unit_min = min(b->atomic_write_hw_unit_min,
|
|
|
|
t->atomic_write_hw_unit_max);
|
|
|
|
t->atomic_write_hw_max = min(b->atomic_write_hw_max, t->io_min);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void blk_stack_atomic_writes_limits(struct queue_limits *t,
|
|
|
|
struct queue_limits *b)
|
|
|
|
{
|
|
|
|
if (!(t->features & BLK_FEAT_ATOMIC_WRITES_STACKED))
|
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
if (!b->atomic_write_unit_min)
|
|
|
|
goto unsupported;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If atomic_write_hw_max is set, we have already stacked 1x bottom
|
|
|
|
* device, so check for compliance.
|
|
|
|
*/
|
|
|
|
if (t->atomic_write_hw_max) {
|
|
|
|
if (!blk_stack_atomic_writes_tail(t, b))
|
|
|
|
goto unsupported;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!blk_stack_atomic_writes_head(t, b))
|
|
|
|
goto unsupported;
|
|
|
|
return;
|
|
|
|
|
|
|
|
unsupported:
|
|
|
|
t->atomic_write_hw_max = 0;
|
|
|
|
t->atomic_write_hw_unit_max = 0;
|
|
|
|
t->atomic_write_hw_unit_min = 0;
|
|
|
|
t->atomic_write_hw_boundary = 0;
|
|
|
|
t->features &= ~BLK_FEAT_ATOMIC_WRITES_STACKED;
|
|
|
|
}
|
|
|
|
|
2009-05-22 21:17:53 +00:00
|
|
|
/**
|
|
|
|
* blk_stack_limits - adjust queue_limits for stacked devices
|
2009-12-29 07:35:35 +00:00
|
|
|
* @t: the stacking driver limits (top device)
|
|
|
|
* @b: the underlying queue limits (bottom, component device)
|
2010-01-11 08:21:51 +00:00
|
|
|
* @start: first data sector within component device
|
2009-05-22 21:17:53 +00:00
|
|
|
*
|
|
|
|
* Description:
|
2009-12-29 07:35:35 +00:00
|
|
|
* This function is used by stacking drivers like MD and DM to ensure
|
|
|
|
* that all component devices have compatible block sizes and
|
|
|
|
* alignments. The stacking driver must provide a queue_limits
|
|
|
|
* struct (top) and then iteratively call the stacking function for
|
|
|
|
* all component (bottom) devices. The stacking function will
|
|
|
|
* attempt to combine the values and ensure proper alignment.
|
|
|
|
*
|
|
|
|
* Returns 0 if the top and bottom queue_limits are compatible. The
|
|
|
|
* top device's block sizes and alignment offsets may be adjusted to
|
|
|
|
* ensure alignment with the bottom device. If no compatible sizes
|
|
|
|
* and alignments exist, -1 is returned and the resulting top
|
|
|
|
* queue_limits will have the misaligned flag set to indicate that
|
|
|
|
* the alignment_offset is undefined.
|
2009-05-22 21:17:53 +00:00
|
|
|
*/
|
|
|
|
int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
|
2010-01-11 08:21:51 +00:00
|
|
|
sector_t start)
|
2009-05-22 21:17:53 +00:00
|
|
|
{
|
2010-01-11 08:21:51 +00:00
|
|
|
unsigned int top, bottom, alignment, ret = 0;
|
2009-11-10 10:50:21 +00:00
|
|
|
|
2024-06-17 06:04:40 +00:00
|
|
|
t->features |= (b->features & BLK_FEAT_INHERIT_MASK);
|
|
|
|
|
2024-06-17 06:04:46 +00:00
|
|
|
/*
|
2024-11-04 05:42:18 +00:00
|
|
|
* Some feaures need to be supported both by the stacking driver and all
|
|
|
|
* underlying devices. The stacking driver sets these flags before
|
|
|
|
* stacking the limits, and this will clear the flags if any of the
|
|
|
|
* underlying devices does not support it.
|
2024-06-17 06:04:46 +00:00
|
|
|
*/
|
|
|
|
if (!(b->features & BLK_FEAT_NOWAIT))
|
|
|
|
t->features &= ~BLK_FEAT_NOWAIT;
|
2024-06-17 06:04:48 +00:00
|
|
|
if (!(b->features & BLK_FEAT_POLL))
|
|
|
|
t->features &= ~BLK_FEAT_POLL;
|
2024-06-17 06:04:46 +00:00
|
|
|
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= (b->flags & BLK_FLAG_MISALIGNED);
|
2024-06-19 15:45:36 +00:00
|
|
|
|
2009-05-22 21:17:53 +00:00
|
|
|
t->max_sectors = min_not_zero(t->max_sectors, b->max_sectors);
|
2024-05-23 18:26:14 +00:00
|
|
|
t->max_user_sectors = min_not_zero(t->max_user_sectors,
|
|
|
|
b->max_user_sectors);
|
2009-05-22 21:17:53 +00:00
|
|
|
t->max_hw_sectors = min_not_zero(t->max_hw_sectors, b->max_hw_sectors);
|
2015-11-13 21:46:48 +00:00
|
|
|
t->max_dev_sectors = min_not_zero(t->max_dev_sectors, b->max_dev_sectors);
|
2016-11-30 20:28:59 +00:00
|
|
|
t->max_write_zeroes_sectors = min(t->max_write_zeroes_sectors,
|
|
|
|
b->max_write_zeroes_sectors);
|
2024-11-08 15:46:51 +00:00
|
|
|
t->max_hw_zone_append_sectors = min(t->max_hw_zone_append_sectors,
|
|
|
|
b->max_hw_zone_append_sectors);
|
2009-05-22 21:17:53 +00:00
|
|
|
|
|
|
|
t->seg_boundary_mask = min_not_zero(t->seg_boundary_mask,
|
|
|
|
b->seg_boundary_mask);
|
2015-08-19 21:24:05 +00:00
|
|
|
t->virt_boundary_mask = min_not_zero(t->virt_boundary_mask,
|
|
|
|
b->virt_boundary_mask);
|
2009-05-22 21:17:53 +00:00
|
|
|
|
2010-02-26 05:20:39 +00:00
|
|
|
t->max_segments = min_not_zero(t->max_segments, b->max_segments);
|
2017-02-08 13:46:49 +00:00
|
|
|
t->max_discard_segments = min_not_zero(t->max_discard_segments,
|
|
|
|
b->max_discard_segments);
|
2010-09-10 18:50:10 +00:00
|
|
|
t->max_integrity_segments = min_not_zero(t->max_integrity_segments,
|
|
|
|
b->max_integrity_segments);
|
2009-05-22 21:17:53 +00:00
|
|
|
|
|
|
|
t->max_segment_size = min_not_zero(t->max_segment_size,
|
|
|
|
b->max_segment_size);
|
|
|
|
|
2010-01-11 08:21:51 +00:00
|
|
|
alignment = queue_limit_alignment_offset(b, start);
|
2009-12-21 14:55:51 +00:00
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Bottom device has different alignment. Check that it is
|
|
|
|
* compatible with the current top alignment.
|
|
|
|
*/
|
2009-12-21 14:55:51 +00:00
|
|
|
if (t->alignment_offset != alignment) {
|
|
|
|
|
|
|
|
top = max(t->physical_block_size, t->io_min)
|
|
|
|
+ t->alignment_offset;
|
2009-12-29 07:35:35 +00:00
|
|
|
bottom = max(b->physical_block_size, b->io_min) + alignment;
|
2009-12-21 14:55:51 +00:00
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Verify that top and bottom intervals line up */
|
2014-10-08 22:26:13 +00:00
|
|
|
if (max(top, bottom) % min(top, bottom)) {
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2010-01-11 08:21:47 +00:00
|
|
|
ret = -1;
|
|
|
|
}
|
2009-12-21 14:55:51 +00:00
|
|
|
}
|
|
|
|
|
2009-05-22 21:17:53 +00:00
|
|
|
t->logical_block_size = max(t->logical_block_size,
|
|
|
|
b->logical_block_size);
|
|
|
|
|
|
|
|
t->physical_block_size = max(t->physical_block_size,
|
|
|
|
b->physical_block_size);
|
|
|
|
|
|
|
|
t->io_min = max(t->io_min, b->io_min);
|
2015-03-30 17:39:09 +00:00
|
|
|
t->io_opt = lcm_not_zero(t->io_opt, b->io_opt);
|
2022-11-10 18:44:57 +00:00
|
|
|
t->dma_alignment = max(t->dma_alignment, b->dma_alignment);
|
2020-12-01 16:07:09 +00:00
|
|
|
|
|
|
|
/* Set non-power-of-2 compatible chunk_sectors boundary */
|
|
|
|
if (b->chunk_sectors)
|
|
|
|
t->chunk_sectors = gcd(t->chunk_sectors, b->chunk_sectors);
|
2009-12-21 14:55:51 +00:00
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Physical block size a multiple of the logical block size? */
|
2009-12-21 14:55:51 +00:00
|
|
|
if (t->physical_block_size & (t->logical_block_size - 1)) {
|
|
|
|
t->physical_block_size = t->logical_block_size;
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2010-01-11 08:21:47 +00:00
|
|
|
ret = -1;
|
2009-11-10 10:50:21 +00:00
|
|
|
}
|
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Minimum I/O a multiple of the physical block size? */
|
2009-12-21 14:55:51 +00:00
|
|
|
if (t->io_min & (t->physical_block_size - 1)) {
|
|
|
|
t->io_min = t->physical_block_size;
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2010-01-11 08:21:47 +00:00
|
|
|
ret = -1;
|
2009-05-22 21:17:53 +00:00
|
|
|
}
|
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Optimal I/O a multiple of the physical block size? */
|
2009-12-21 14:55:51 +00:00
|
|
|
if (t->io_opt & (t->physical_block_size - 1)) {
|
|
|
|
t->io_opt = 0;
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2010-01-11 08:21:47 +00:00
|
|
|
ret = -1;
|
2009-12-21 14:55:51 +00:00
|
|
|
}
|
2009-05-22 21:17:53 +00:00
|
|
|
|
2020-09-22 02:32:48 +00:00
|
|
|
/* chunk_sectors a multiple of the physical block size? */
|
|
|
|
if ((t->chunk_sectors << 9) & (t->physical_block_size - 1)) {
|
|
|
|
t->chunk_sectors = 0;
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2020-09-22 02:32:48 +00:00
|
|
|
ret = -1;
|
|
|
|
}
|
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Find lowest common alignment_offset */
|
2015-03-30 17:39:09 +00:00
|
|
|
t->alignment_offset = lcm_not_zero(t->alignment_offset, alignment)
|
2014-10-08 22:26:13 +00:00
|
|
|
% max(t->physical_block_size, t->io_min);
|
2009-11-10 10:50:21 +00:00
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
/* Verify that new alignment_offset is on a logical block boundary */
|
2010-01-11 08:21:47 +00:00
|
|
|
if (t->alignment_offset & (t->logical_block_size - 1)) {
|
2024-06-26 14:26:24 +00:00
|
|
|
t->flags |= BLK_FLAG_MISALIGNED;
|
2010-01-11 08:21:47 +00:00
|
|
|
ret = -1;
|
|
|
|
}
|
2009-05-22 21:17:53 +00:00
|
|
|
|
blk-settings: align max_sectors on "logical_block_size" boundary
We get I/O errors when we run md-raid1 on the top of dm-integrity on the
top of ramdisk.
device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1
device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8048, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8147, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8246, 0xff
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8345, 0xbb
The ramdisk device has logical_block_size 512 and max_sectors 255. The
dm-integrity device uses logical_block_size 4096 and it doesn't affect the
"max_sectors" value - thus, it inherits 255 from the ramdisk. So, we have
a device with max_sectors not aligned on logical_block_size.
The md-raid device sees that the underlying leg has max_sectors 255 and it
will split the bios on 255-sector boundary, making the bios unaligned on
logical_block_size.
In order to fix the bug, we round down max_sectors to logical_block_size.
Cc: stable@vger.kernel.org
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-02-24 02:25:30 +00:00
|
|
|
t->max_sectors = blk_round_down_sectors(t->max_sectors, t->logical_block_size);
|
|
|
|
t->max_hw_sectors = blk_round_down_sectors(t->max_hw_sectors, t->logical_block_size);
|
|
|
|
t->max_dev_sectors = blk_round_down_sectors(t->max_dev_sectors, t->logical_block_size);
|
|
|
|
|
2009-12-21 14:55:51 +00:00
|
|
|
/* Discard alignment and granularity */
|
|
|
|
if (b->discard_granularity) {
|
2010-01-11 08:21:51 +00:00
|
|
|
alignment = queue_limit_discard_alignment(b, start);
|
2009-12-21 14:55:51 +00:00
|
|
|
|
2009-12-29 07:35:35 +00:00
|
|
|
t->max_discard_sectors = min_not_zero(t->max_discard_sectors,
|
|
|
|
b->max_discard_sectors);
|
2015-07-16 15:14:26 +00:00
|
|
|
t->max_hw_discard_sectors = min_not_zero(t->max_hw_discard_sectors,
|
|
|
|
b->max_hw_discard_sectors);
|
2009-12-21 14:55:51 +00:00
|
|
|
t->discard_granularity = max(t->discard_granularity,
|
|
|
|
b->discard_granularity);
|
2015-03-30 17:39:09 +00:00
|
|
|
t->discard_alignment = lcm_not_zero(t->discard_alignment, alignment) %
|
2012-12-14 03:15:36 +00:00
|
|
|
t->discard_granularity;
|
2009-12-21 14:55:51 +00:00
|
|
|
}
|
2022-04-15 04:52:57 +00:00
|
|
|
t->max_secure_erase_sectors = min_not_zero(t->max_secure_erase_sectors,
|
|
|
|
b->max_secure_erase_sectors);
|
2021-01-28 04:47:30 +00:00
|
|
|
t->zone_write_granularity = max(t->zone_write_granularity,
|
|
|
|
b->zone_write_granularity);
|
2024-06-17 06:04:49 +00:00
|
|
|
if (!(t->features & BLK_FEAT_ZONED)) {
|
2024-02-22 13:17:23 +00:00
|
|
|
t->zone_write_granularity = 0;
|
|
|
|
t->max_zone_append_sectors = 0;
|
|
|
|
}
|
2024-11-18 10:50:15 +00:00
|
|
|
blk_stack_atomic_writes_limits(t, b);
|
|
|
|
|
2010-01-11 08:21:47 +00:00
|
|
|
return ret;
|
2009-05-22 21:17:53 +00:00
|
|
|
}
|
2009-05-28 09:04:53 +00:00
|
|
|
EXPORT_SYMBOL(blk_stack_limits);
|
2009-05-22 21:17:53 +00:00
|
|
|
|
2024-02-28 22:56:41 +00:00
|
|
|
/**
|
|
|
|
* queue_limits_stack_bdev - adjust queue_limits for stacked devices
|
|
|
|
* @t: the stacking driver limits (top device)
|
|
|
|
* @bdev: the underlying block device (bottom)
|
|
|
|
* @offset: offset to beginning of data within component device
|
|
|
|
* @pfx: prefix to use for warnings logged
|
|
|
|
*
|
|
|
|
* Description:
|
|
|
|
* This function is used by stacking drivers like MD and DM to ensure
|
|
|
|
* that all component devices have compatible block sizes and
|
|
|
|
* alignments. The stacking driver must provide a queue_limits
|
|
|
|
* struct (top) and then iteratively call the stacking function for
|
|
|
|
* all component (bottom) devices. The stacking function will
|
|
|
|
* attempt to combine the values and ensure proper alignment.
|
|
|
|
*/
|
|
|
|
void queue_limits_stack_bdev(struct queue_limits *t, struct block_device *bdev,
|
|
|
|
sector_t offset, const char *pfx)
|
|
|
|
{
|
2024-10-29 14:19:37 +00:00
|
|
|
if (blk_stack_limits(t, bdev_limits(bdev),
|
2024-02-28 22:56:41 +00:00
|
|
|
get_start_sect(bdev) + offset))
|
|
|
|
pr_notice("%s: Warning: Device %pg is misaligned\n",
|
|
|
|
pfx, bdev);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(queue_limits_stack_bdev);
|
|
|
|
|
2024-06-13 08:48:22 +00:00
|
|
|
/**
|
|
|
|
* queue_limits_stack_integrity - stack integrity profile
|
|
|
|
* @t: target queue limits
|
|
|
|
* @b: base queue limits
|
|
|
|
*
|
|
|
|
* Check if the integrity profile in the @b can be stacked into the
|
|
|
|
* target @t. Stacking is possible if either:
|
|
|
|
*
|
|
|
|
* a) does not have any integrity information stacked into it yet
|
|
|
|
* b) the integrity profile in @b is identical to the one in @t
|
|
|
|
*
|
|
|
|
* If @b can be stacked into @t, return %true. Else return %false and clear the
|
|
|
|
* integrity information in @t.
|
|
|
|
*/
|
|
|
|
bool queue_limits_stack_integrity(struct queue_limits *t,
|
|
|
|
struct queue_limits *b)
|
|
|
|
{
|
|
|
|
struct blk_integrity *ti = &t->integrity;
|
|
|
|
struct blk_integrity *bi = &b->integrity;
|
|
|
|
|
|
|
|
if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!ti->tuple_size) {
|
|
|
|
/* inherit the settings from the first underlying device */
|
|
|
|
if (!(ti->flags & BLK_INTEGRITY_STACKED)) {
|
|
|
|
ti->flags = BLK_INTEGRITY_DEVICE_CAPABLE |
|
|
|
|
(bi->flags & BLK_INTEGRITY_REF_TAG);
|
|
|
|
ti->csum_type = bi->csum_type;
|
|
|
|
ti->tuple_size = bi->tuple_size;
|
|
|
|
ti->pi_offset = bi->pi_offset;
|
|
|
|
ti->interval_exp = bi->interval_exp;
|
|
|
|
ti->tag_size = bi->tag_size;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
if (!bi->tuple_size)
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ti->tuple_size != bi->tuple_size)
|
|
|
|
goto incompatible;
|
|
|
|
if (ti->interval_exp != bi->interval_exp)
|
|
|
|
goto incompatible;
|
|
|
|
if (ti->tag_size != bi->tag_size)
|
|
|
|
goto incompatible;
|
|
|
|
if (ti->csum_type != bi->csum_type)
|
|
|
|
goto incompatible;
|
|
|
|
if ((ti->flags & BLK_INTEGRITY_REF_TAG) !=
|
|
|
|
(bi->flags & BLK_INTEGRITY_REF_TAG))
|
|
|
|
goto incompatible;
|
|
|
|
|
|
|
|
done:
|
|
|
|
ti->flags |= BLK_INTEGRITY_STACKED;
|
|
|
|
return true;
|
|
|
|
|
|
|
|
incompatible:
|
|
|
|
memset(ti, 0, sizeof(*ti));
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(queue_limits_stack_integrity);
|
|
|
|
|
2016-03-30 16:21:08 +00:00
|
|
|
/**
|
|
|
|
* blk_set_queue_depth - tell the block layer about the device queue depth
|
|
|
|
* @q: the request queue for the device
|
|
|
|
* @depth: queue depth
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
void blk_set_queue_depth(struct request_queue *q, unsigned int depth)
|
|
|
|
{
|
|
|
|
q->queue_depth = depth;
|
2019-08-28 22:05:55 +00:00
|
|
|
rq_qos_queue_depth_changed(q);
|
2016-03-30 16:21:08 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(blk_set_queue_depth);
|
|
|
|
|
2022-04-15 04:52:49 +00:00
|
|
|
int bdev_alignment_offset(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
struct request_queue *q = bdev_get_queue(bdev);
|
|
|
|
|
2024-06-26 14:26:24 +00:00
|
|
|
if (q->limits.flags & BLK_FLAG_MISALIGNED)
|
2022-04-15 04:52:49 +00:00
|
|
|
return -1;
|
|
|
|
if (bdev_is_partition(bdev))
|
|
|
|
return queue_limit_alignment_offset(&q->limits,
|
|
|
|
bdev->bd_start_sect);
|
|
|
|
return q->limits.alignment_offset;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bdev_alignment_offset);
|
2022-04-15 04:52:52 +00:00
|
|
|
|
|
|
|
unsigned int bdev_discard_alignment(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
struct request_queue *q = bdev_get_queue(bdev);
|
|
|
|
|
|
|
|
if (bdev_is_partition(bdev))
|
|
|
|
return queue_limit_discard_alignment(&q->limits,
|
|
|
|
bdev->bd_start_sect);
|
|
|
|
return q->limits.discard_alignment;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bdev_discard_alignment);
|