2017-11-06 18:11:51 +01:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Driver core for serial ports
|
|
|
|
*
|
|
|
|
* Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o.
|
|
|
|
*
|
|
|
|
* Copyright 1999 ARM Limited
|
|
|
|
* Copyright (C) 2000-2001 Deep Blue Solutions Ltd.
|
|
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/tty.h>
|
2011-11-09 21:33:43 +01:00
|
|
|
#include <linux/tty_flip.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <linux/slab.h>
|
2017-02-02 19:15:33 +01:00
|
|
|
#include <linux/sched/signal.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/console.h>
|
2020-06-10 17:51:21 +02:00
|
|
|
#include <linux/gpio/consumer.h>
|
2023-03-09 10:09:16 +02:00
|
|
|
#include <linux/kernel.h>
|
2014-03-27 18:29:46 -07:00
|
|
|
#include <linux/of.h>
|
2023-05-25 14:30:30 +03:00
|
|
|
#include <linux/pm_runtime.h>
|
2009-03-31 15:19:21 -07:00
|
|
|
#include <linux/proc_fs.h>
|
|
|
|
#include <linux/seq_file.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/serial.h> /* for serial_state and serial_icounter_struct */
|
2009-09-19 13:13:30 -07:00
|
|
|
#include <linux/serial_core.h>
|
2020-03-02 17:51:35 +00:00
|
|
|
#include <linux/sysrq.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <linux/delay.h>
|
2006-01-12 18:44:32 +00:00
|
|
|
#include <linux/mutex.h>
|
2022-04-25 17:33:58 +03:00
|
|
|
#include <linux/math64.h>
|
2019-08-19 17:17:54 -07:00
|
|
|
#include <linux/security.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2017-08-13 17:47:42 +03:00
|
|
|
#include <linux/irq.h>
|
2016-12-24 11:46:01 -08:00
|
|
|
#include <linux/uaccess.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-05-25 14:30:30 +03:00
|
|
|
#include "serial_base.h"
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* This is used to lock changes in serial line configuration.
|
|
|
|
*/
|
2006-01-12 18:44:32 +00:00
|
|
|
static DEFINE_MUTEX(port_mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2006-07-03 00:25:03 -07:00
|
|
|
/*
|
|
|
|
* lockdep: port->lock is initialized in two places, but we
|
|
|
|
* want only one lock-class:
|
|
|
|
*/
|
|
|
|
static struct lock_class_key port_lock_key;
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
#define HIGH_BITS_OFFSET ((sizeof(long)-sizeof(int))*8)
|
|
|
|
|
2022-04-10 12:46:34 +02:00
|
|
|
/*
|
|
|
|
* Max time with active RTS before/after data is sent.
|
|
|
|
*/
|
|
|
|
#define RS485_MAX_RTS_DELAY 100 /* msecs */
|
|
|
|
|
2012-12-07 11:36:08 +01:00
|
|
|
static void uart_change_pm(struct uart_state *state,
|
|
|
|
enum uart_pm_state pm_state);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2011-11-09 21:33:51 +01:00
|
|
|
static void uart_port_shutdown(struct tty_port *port);
|
|
|
|
|
2014-09-10 15:06:24 -04:00
|
|
|
static int uart_dcd_enabled(struct uart_port *uport)
|
|
|
|
{
|
2014-10-16 14:19:47 -04:00
|
|
|
return !!(uport->status & UPSTAT_DCD_ENABLE);
|
2014-09-10 15:06:24 -04:00
|
|
|
}
|
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
static inline struct uart_port *uart_port_ref(struct uart_state *state)
|
|
|
|
{
|
|
|
|
if (atomic_add_unless(&state->refcount, 1, 0))
|
|
|
|
return state->uart_port;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void uart_port_deref(struct uart_port *uport)
|
|
|
|
{
|
2016-11-24 14:18:55 +02:00
|
|
|
if (atomic_dec_and_test(&uport->state->refcount))
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
wake_up(&uport->state->remove_wait);
|
|
|
|
}
|
|
|
|
|
|
|
|
#define uart_port_lock(state, flags) \
|
|
|
|
({ \
|
|
|
|
struct uart_port *__uport = uart_port_ref(state); \
|
|
|
|
if (__uport) \
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(__uport, &flags); \
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
__uport; \
|
|
|
|
})
|
|
|
|
|
|
|
|
#define uart_port_unlock(uport, flags) \
|
|
|
|
({ \
|
|
|
|
struct uart_port *__uport = uport; \
|
2016-11-24 14:18:55 +02:00
|
|
|
if (__uport) { \
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(__uport, flags); \
|
2016-11-24 14:18:55 +02:00
|
|
|
uart_port_deref(__uport); \
|
|
|
|
} \
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
})
|
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
static inline struct uart_port *uart_port_check(struct uart_state *state)
|
|
|
|
{
|
2016-05-03 14:01:51 -07:00
|
|
|
lockdep_assert_held(&state->port.mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
return state->uart_port;
|
|
|
|
}
|
|
|
|
|
2022-07-28 08:10:52 +02:00
|
|
|
/**
|
|
|
|
* uart_write_wakeup - schedule write processing
|
|
|
|
* @port: port to be processed
|
|
|
|
*
|
|
|
|
* This routine is used by the interrupt handler to schedule processing in the
|
|
|
|
* software interrupt portion of the driver. A driver is expected to call this
|
|
|
|
* function when the number of characters in the transmit buffer have dropped
|
|
|
|
* below a threshold.
|
|
|
|
*
|
|
|
|
* Locking: @port->lock should be held
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
void uart_write_wakeup(struct uart_port *port)
|
|
|
|
{
|
2009-09-19 13:13:28 -07:00
|
|
|
struct uart_state *state = port->state;
|
2006-03-07 21:55:20 -08:00
|
|
|
/*
|
|
|
|
* This means you called this function _after_ the port was
|
|
|
|
* closed. No cookie for you.
|
|
|
|
*/
|
2009-09-19 13:13:28 -07:00
|
|
|
BUG_ON(!state);
|
2016-10-28 07:07:48 -05:00
|
|
|
tty_port_tty_wakeup(&state->port);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2022-01-24 08:14:20 +01:00
|
|
|
EXPORT_SYMBOL(uart_write_wakeup);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
static void uart_stop(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_lock(state, flags);
|
|
|
|
if (port)
|
|
|
|
port->ops->stop_tx(port);
|
|
|
|
uart_port_unlock(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2023-07-12 10:18:08 +02:00
|
|
|
static void __uart_start(struct uart_state *state)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-09-19 13:13:28 -07:00
|
|
|
struct uart_port *port = state->uart_port;
|
2023-05-25 14:30:30 +03:00
|
|
|
struct serial_port_device *port_dev;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (!port || port->flags & UPF_DEAD || uart_tx_stopped(port))
|
|
|
|
return;
|
|
|
|
|
|
|
|
port_dev = port->port_dev;
|
|
|
|
|
|
|
|
/* Increment the runtime PM usage count for the active check below */
|
|
|
|
err = pm_runtime_get(&port_dev->dev);
|
2023-10-23 10:48:54 +03:00
|
|
|
if (err < 0 && err != -EINPROGRESS) {
|
2023-05-25 14:30:30 +03:00
|
|
|
pm_runtime_put_noidle(&port_dev->dev);
|
|
|
|
return;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-05-25 14:30:30 +03:00
|
|
|
/*
|
|
|
|
* Start TX if enabled, and kick runtime PM. If the device is not
|
|
|
|
* enabled, serial_port_runtime_resume() calls start_tx() again
|
|
|
|
* after enabling the device.
|
|
|
|
*/
|
2023-11-13 10:07:53 +02:00
|
|
|
if (pm_runtime_active(&port_dev->dev))
|
2005-08-31 10:12:14 +01:00
|
|
|
port->ops->start_tx(port);
|
2023-05-25 14:30:30 +03:00
|
|
|
pm_runtime_mark_last_busy(&port_dev->dev);
|
|
|
|
pm_runtime_put_autosuspend(&port_dev->dev);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_start(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_lock(state, flags);
|
2023-07-12 10:18:08 +02:00
|
|
|
__uart_start(state);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2015-10-27 17:40:01 +01:00
|
|
|
static void
|
2005-04-16 15:20:36 -07:00
|
|
|
uart_update_mctrl(struct uart_port *port, unsigned int set, unsigned int clear)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
unsigned int old;
|
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
old = port->mctrl;
|
|
|
|
port->mctrl = (old & ~clear) | set;
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (old != port->mctrl && !(port->rs485.flags & SER_RS485_ENABLED))
|
2005-04-16 15:20:36 -07:00
|
|
|
port->ops->set_mctrl(port, port->mctrl);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2008-02-08 04:18:53 -08:00
|
|
|
#define uart_set_mctrl(port, set) uart_update_mctrl(port, set, 0)
|
|
|
|
#define uart_clear_mctrl(port, clear) uart_update_mctrl(port, 0, clear)
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-01-17 11:03:57 +02:00
|
|
|
static void uart_port_dtr_rts(struct uart_port *uport, bool active)
|
2017-07-31 10:46:42 +02:00
|
|
|
{
|
2023-01-17 11:03:57 +02:00
|
|
|
if (active)
|
serial: core: Initialize rs485 RTS polarity already on probe
RTS polarity of rs485-enabled ports is currently initialized on uart
open via:
tty_port_open()
tty_port_block_til_ready()
tty_port_raise_dtr_rts() # if (C_BAUD(tty))
uart_dtr_rts()
uart_port_dtr_rts()
There's at least three problems here:
First, if no baud rate is set, RTS polarity is not initialized.
That's the right thing to do for rs232, but not for rs485, which
requires that RTS is deasserted unconditionally.
Second, if the DeviceTree property "linux,rs485-enabled-at-boot-time" is
present, RTS should be deasserted as early as possible, i.e. on probe.
Otherwise it may remain asserted until first open.
Third, even though RTS is deasserted on open and close, it may
subsequently be asserted by uart_throttle(), uart_unthrottle() or
uart_set_termios() because those functions aren't rs485-aware.
(Only uart_tiocmset() is.)
To address these issues, move RTS initialization from uart_port_dtr_rts()
to uart_configure_port(). Prevent subsequent modification of RTS
polarity by moving the existing rs485 check from uart_tiocmget() to
uart_update_mctrl().
That way, RTS is initialized on probe and then remains unmodified unless
the uart transmits data. If rs485 is enabled at runtime (instead of at
boot) through a TIOCSRS485 ioctl(), RTS is initialized by the uart
driver's ->rs485_config() callback and then likewise remains unmodified.
The PL011 driver initializes RTS on uart open and prevents subsequent
modification in its ->set_mctrl() callback. That code is obsoleted by
the present commit, so drop it.
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Su Bao Cheng <baocheng.su@siemens.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2d2acaf3a69e89b7bf687c912022b11fd29dfa1e.1642909284.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-01-23 05:21:14 +01:00
|
|
|
uart_set_mctrl(uport, TIOCM_DTR | TIOCM_RTS);
|
|
|
|
else
|
|
|
|
uart_clear_mctrl(uport, TIOCM_DTR | TIOCM_RTS);
|
2017-07-31 10:46:42 +02:00
|
|
|
}
|
|
|
|
|
2023-03-09 10:09:19 +02:00
|
|
|
/* Caller holds port mutex */
|
2023-03-09 10:09:20 +02:00
|
|
|
static void uart_change_line_settings(struct tty_struct *tty, struct uart_state *state,
|
|
|
|
const struct ktermios *old_termios)
|
2023-03-09 10:09:19 +02:00
|
|
|
{
|
|
|
|
struct uart_port *uport = uart_port_check(state);
|
|
|
|
struct ktermios *termios;
|
2023-03-09 10:09:22 +02:00
|
|
|
bool old_hw_stopped;
|
2023-03-09 10:09:19 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have no tty, termios, or the port does not exist,
|
|
|
|
* then we can't set the parameters for this port.
|
|
|
|
*/
|
|
|
|
if (!tty || uport->type == PORT_UNKNOWN)
|
|
|
|
return;
|
|
|
|
|
|
|
|
termios = &tty->termios;
|
|
|
|
uport->ops->set_termios(uport, termios, old_termios);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set modem status enables based on termios cflag
|
|
|
|
*/
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2023-03-09 10:09:19 +02:00
|
|
|
if (termios->c_cflag & CRTSCTS)
|
|
|
|
uport->status |= UPSTAT_CTS_ENABLE;
|
|
|
|
else
|
|
|
|
uport->status &= ~UPSTAT_CTS_ENABLE;
|
|
|
|
|
|
|
|
if (termios->c_cflag & CLOCAL)
|
|
|
|
uport->status &= ~UPSTAT_DCD_ENABLE;
|
|
|
|
else
|
|
|
|
uport->status |= UPSTAT_DCD_ENABLE;
|
|
|
|
|
|
|
|
/* reset sw-assisted CTS flow control based on (possibly) new mode */
|
2023-03-09 10:09:22 +02:00
|
|
|
old_hw_stopped = uport->hw_stopped;
|
2023-03-09 10:09:19 +02:00
|
|
|
uport->hw_stopped = uart_softcts_mode(uport) &&
|
|
|
|
!(uport->ops->get_mctrl(uport) & TIOCM_CTS);
|
2023-03-09 10:09:22 +02:00
|
|
|
if (uport->hw_stopped != old_hw_stopped) {
|
|
|
|
if (!old_hw_stopped)
|
2023-03-09 10:09:19 +02:00
|
|
|
uport->ops->stop_tx(uport);
|
2023-03-09 10:09:22 +02:00
|
|
|
else
|
2023-07-12 10:18:08 +02:00
|
|
|
__uart_start(state);
|
2023-03-09 10:09:19 +02:00
|
|
|
}
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2023-03-09 10:09:19 +02:00
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Startup the port. This will be called once per open. All calls
|
2008-07-16 21:53:50 +01:00
|
|
|
* will be serialised by the per-port mutex.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2011-11-09 21:34:14 +01:00
|
|
|
static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
|
2023-01-17 11:03:51 +02:00
|
|
|
bool init_hw)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2021-05-19 11:25:41 +02:00
|
|
|
unsigned long flags;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long page;
|
|
|
|
int retval = 0;
|
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->type == PORT_UNKNOWN)
|
2011-11-09 21:34:14 +01:00
|
|
|
return 1;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2014-04-23 12:33:22 +02:00
|
|
|
/*
|
|
|
|
* Make sure the device is in D0 state.
|
|
|
|
*/
|
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Initialise and allocate the transmit and temporary
|
|
|
|
* buffer.
|
|
|
|
*/
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
page = get_zeroed_page(GFP_KERNEL);
|
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
uart_port_lock(state, flags);
|
|
|
|
if (!state->xmit.buf) {
|
2009-09-19 13:13:28 -07:00
|
|
|
state->xmit.buf = (unsigned char *) page;
|
|
|
|
uart_circ_clear(&state->xmit);
|
2018-12-13 13:58:39 +09:00
|
|
|
uart_port_unlock(uport, flags);
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
} else {
|
2018-12-13 13:58:39 +09:00
|
|
|
uart_port_unlock(uport, flags);
|
|
|
|
/*
|
|
|
|
* Do not free() the page under the port lock, see
|
|
|
|
* uart_shutdown().
|
|
|
|
*/
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
free_page(page);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
retval = uport->ops->startup(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
if (retval == 0) {
|
2011-03-30 00:10:55 +02:00
|
|
|
if (uart_console(uport) && uport->cons->cflag) {
|
2012-07-14 15:31:47 +01:00
|
|
|
tty->termios.c_cflag = uport->cons->cflag;
|
2021-10-02 15:09:00 +02:00
|
|
|
tty->termios.c_ispeed = uport->cons->ispeed;
|
|
|
|
tty->termios.c_ospeed = uport->cons->ospeed;
|
2011-03-30 00:10:55 +02:00
|
|
|
uport->cons->cflag = 0;
|
2021-10-02 15:09:00 +02:00
|
|
|
uport->cons->ispeed = 0;
|
|
|
|
uport->cons->ospeed = 0;
|
2011-03-30 00:10:55 +02:00
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Initialise the hardware port settings.
|
|
|
|
*/
|
2023-03-09 10:09:20 +02:00
|
|
|
uart_change_line_settings(tty, state, NULL);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-01-10 20:36:15 -08:00
|
|
|
/*
|
|
|
|
* Setup the RTS and DTR signals once the
|
|
|
|
* port is open and ready to respond.
|
|
|
|
*/
|
|
|
|
if (init_hw && C_BAUD(tty))
|
2023-01-17 11:03:53 +02:00
|
|
|
uart_port_dtr_rts(uport, true);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2011-08-17 13:48:15 +02:00
|
|
|
/*
|
|
|
|
* This is to allow setserial on this port. People may want to set
|
|
|
|
* port/irq/type and then reconfigure the port properly if it failed
|
|
|
|
* now.
|
|
|
|
*/
|
2005-04-16 15:20:36 -07:00
|
|
|
if (retval && capable(CAP_SYS_ADMIN))
|
2011-11-09 21:34:14 +01:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int uart_startup(struct tty_struct *tty, struct uart_state *state,
|
2023-01-17 11:03:51 +02:00
|
|
|
bool init_hw)
|
2011-11-09 21:34:14 +01:00
|
|
|
{
|
|
|
|
struct tty_port *port = &state->port;
|
|
|
|
int retval;
|
|
|
|
|
2016-04-09 17:53:25 -07:00
|
|
|
if (tty_port_initialized(port))
|
2011-11-09 21:34:14 +01:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
retval = uart_port_startup(tty, state, init_hw);
|
2016-08-22 17:39:09 -05:00
|
|
|
if (retval)
|
|
|
|
set_bit(TTY_IO_ERROR, &tty->flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This routine will shutdown a serial port; interrupts are disabled, and
|
|
|
|
* DTR is dropped if the hangup on close termio flag is on. Calls to
|
|
|
|
* uart_shutdown are serialised by the per-port semaphore.
|
2016-04-09 18:56:35 -07:00
|
|
|
*
|
|
|
|
* uport == NULL if uart_port has already been removed
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2010-06-01 22:52:51 +02:00
|
|
|
static void uart_shutdown(struct tty_struct *tty, struct uart_state *state)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2021-05-19 11:25:41 +02:00
|
|
|
unsigned long flags;
|
2018-12-13 13:58:39 +09:00
|
|
|
char *xmit_buf = NULL;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
2005-11-13 15:28:51 +00:00
|
|
|
* Set the TTY IO error marker
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2009-01-02 13:49:21 +00:00
|
|
|
if (tty)
|
|
|
|
set_bit(TTY_IO_ERROR, &tty->flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-04-09 17:53:25 -07:00
|
|
|
if (tty_port_initialized(port)) {
|
2023-01-17 11:03:47 +02:00
|
|
|
tty_port_set_initialized(port, false);
|
2016-04-09 17:53:25 -07:00
|
|
|
|
2005-11-13 15:28:51 +00:00
|
|
|
/*
|
|
|
|
* Turn off DTR and RTS early.
|
|
|
|
*/
|
2021-10-02 15:09:00 +02:00
|
|
|
if (uport && uart_console(uport) && tty) {
|
2014-07-09 09:21:14 -04:00
|
|
|
uport->cons->cflag = tty->termios.c_cflag;
|
2021-10-02 15:09:00 +02:00
|
|
|
uport->cons->ispeed = tty->termios.c_ispeed;
|
|
|
|
uport->cons->ospeed = tty->termios.c_ospeed;
|
|
|
|
}
|
2014-07-09 09:21:14 -04:00
|
|
|
|
2016-01-10 20:36:15 -08:00
|
|
|
if (!tty || C_HUPCL(tty))
|
2023-01-17 11:03:53 +02:00
|
|
|
uart_port_dtr_rts(uport, false);
|
2005-11-13 15:28:51 +00:00
|
|
|
|
2011-11-09 21:33:51 +01:00
|
|
|
uart_port_shutdown(port);
|
2005-11-13 15:28:51 +00:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
2011-10-19 11:52:01 -07:00
|
|
|
* It's possible for shutdown to be called after suspend if we get
|
|
|
|
* a DCD drop (hangup) at just the right time. Clear suspended bit so
|
|
|
|
* we don't try to resume a port that has been shutdown.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2023-01-17 11:03:48 +02:00
|
|
|
tty_port_set_suspended(port, false);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
2018-12-13 13:58:39 +09:00
|
|
|
* Do not free() the transmit buffer page under the port lock since
|
|
|
|
* this can create various circular locking scenarios. For instance,
|
|
|
|
* console driver may need to allocate/free a debug object, which
|
|
|
|
* can endup in printk() recursion.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
uart_port_lock(state, flags);
|
2018-12-13 13:58:39 +09:00
|
|
|
xmit_buf = state->xmit.buf;
|
|
|
|
state->xmit.buf = NULL;
|
uart: fix race between uart_put_char() and uart_shutdown()
We have reports of the following crash:
PID: 7 TASK: ffff88085c6d61c0 CPU: 1 COMMAND: "kworker/u25:0"
#0 [ffff88085c6db710] machine_kexec at ffffffff81046239
#1 [ffff88085c6db760] crash_kexec at ffffffff810fc248
#2 [ffff88085c6db830] oops_end at ffffffff81008ae7
#3 [ffff88085c6db860] no_context at ffffffff81050b8f
#4 [ffff88085c6db8b0] __bad_area_nosemaphore at ffffffff81050d75
#5 [ffff88085c6db900] bad_area_nosemaphore at ffffffff81050e83
#6 [ffff88085c6db910] __do_page_fault at ffffffff8105132e
#7 [ffff88085c6db9b0] do_page_fault at ffffffff8105152c
#8 [ffff88085c6db9c0] page_fault at ffffffff81a3f122
[exception RIP: uart_put_char+149]
RIP: ffffffff814b67b5 RSP: ffff88085c6dba78 RFLAGS: 00010006
RAX: 0000000000000292 RBX: ffffffff827c5120 RCX: 0000000000000081
RDX: 0000000000000000 RSI: 000000000000005f RDI: ffffffff827c5120
RBP: ffff88085c6dba98 R8: 000000000000012c R9: ffffffff822ea320
R10: ffff88085fe4db04 R11: 0000000000000001 R12: ffff881059f9c000
R13: 0000000000000001 R14: 000000000000005f R15: 0000000000000fba
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#9 [ffff88085c6dbaa0] tty_put_char at ffffffff81497544
#10 [ffff88085c6dbac0] do_output_char at ffffffff8149c91c
#11 [ffff88085c6dbae0] __process_echoes at ffffffff8149cb8b
#12 [ffff88085c6dbb30] commit_echoes at ffffffff8149cdc2
#13 [ffff88085c6dbb60] n_tty_receive_buf_fast at ffffffff8149e49b
#14 [ffff88085c6dbbc0] __receive_buf at ffffffff8149ef5a
#15 [ffff88085c6dbc20] n_tty_receive_buf_common at ffffffff8149f016
#16 [ffff88085c6dbca0] n_tty_receive_buf2 at ffffffff8149f194
#17 [ffff88085c6dbcb0] flush_to_ldisc at ffffffff814a238a
#18 [ffff88085c6dbd50] process_one_work at ffffffff81090be2
#19 [ffff88085c6dbe20] worker_thread at ffffffff81091b4d
#20 [ffff88085c6dbeb0] kthread at ffffffff81096384
#21 [ffff88085c6dbf50] ret_from_fork at ffffffff81a3d69f
after slogging through some dissasembly:
ffffffff814b6720 <uart_put_char>:
ffffffff814b6720: 55 push %rbp
ffffffff814b6721: 48 89 e5 mov %rsp,%rbp
ffffffff814b6724: 48 83 ec 20 sub $0x20,%rsp
ffffffff814b6728: 48 89 1c 24 mov %rbx,(%rsp)
ffffffff814b672c: 4c 89 64 24 08 mov %r12,0x8(%rsp)
ffffffff814b6731: 4c 89 6c 24 10 mov %r13,0x10(%rsp)
ffffffff814b6736: 4c 89 74 24 18 mov %r14,0x18(%rsp)
ffffffff814b673b: e8 b0 8e 58 00 callq ffffffff81a3f5f0 <mcount>
ffffffff814b6740: 4c 8b a7 88 02 00 00 mov 0x288(%rdi),%r12
ffffffff814b6747: 45 31 ed xor %r13d,%r13d
ffffffff814b674a: 41 89 f6 mov %esi,%r14d
ffffffff814b674d: 49 83 bc 24 70 01 00 cmpq $0x0,0x170(%r12)
ffffffff814b6754: 00 00
ffffffff814b6756: 49 8b 9c 24 80 01 00 mov 0x180(%r12),%rbx
ffffffff814b675d: 00
ffffffff814b675e: 74 2f je ffffffff814b678f <uart_put_char+0x6f>
ffffffff814b6760: 48 89 df mov %rbx,%rdi
ffffffff814b6763: e8 a8 67 58 00 callq ffffffff81a3cf10 <_raw_spin_lock_irqsave>
ffffffff814b6768: 41 8b 8c 24 78 01 00 mov 0x178(%r12),%ecx
ffffffff814b676f: 00
ffffffff814b6770: 89 ca mov %ecx,%edx
ffffffff814b6772: f7 d2 not %edx
ffffffff814b6774: 41 03 94 24 7c 01 00 add 0x17c(%r12),%edx
ffffffff814b677b: 00
ffffffff814b677c: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b6782: 75 23 jne ffffffff814b67a7 <uart_put_char+0x87>
ffffffff814b6784: 48 89 c6 mov %rax,%rsi
ffffffff814b6787: 48 89 df mov %rbx,%rdi
ffffffff814b678a: e8 e1 64 58 00 callq ffffffff81a3cc70 <_raw_spin_unlock_irqrestore>
ffffffff814b678f: 44 89 e8 mov %r13d,%eax
ffffffff814b6792: 48 8b 1c 24 mov (%rsp),%rbx
ffffffff814b6796: 4c 8b 64 24 08 mov 0x8(%rsp),%r12
ffffffff814b679b: 4c 8b 6c 24 10 mov 0x10(%rsp),%r13
ffffffff814b67a0: 4c 8b 74 24 18 mov 0x18(%rsp),%r14
ffffffff814b67a5: c9 leaveq
ffffffff814b67a6: c3 retq
ffffffff814b67a7: 49 8b 94 24 70 01 00 mov 0x170(%r12),%rdx
ffffffff814b67ae: 00
ffffffff814b67af: 48 63 c9 movslq %ecx,%rcx
ffffffff814b67b2: 41 b5 01 mov $0x1,%r13b
ffffffff814b67b5: 44 88 34 0a mov %r14b,(%rdx,%rcx,1)
ffffffff814b67b9: 41 8b 94 24 78 01 00 mov 0x178(%r12),%edx
ffffffff814b67c0: 00
ffffffff814b67c1: 83 c2 01 add $0x1,%edx
ffffffff814b67c4: 81 e2 ff 0f 00 00 and $0xfff,%edx
ffffffff814b67ca: 41 89 94 24 78 01 00 mov %edx,0x178(%r12)
ffffffff814b67d1: 00
ffffffff814b67d2: eb b0 jmp ffffffff814b6784 <uart_put_char+0x64>
ffffffff814b67d4: 66 66 66 2e 0f 1f 84 data32 data32 nopw %cs:0x0(%rax,%rax,1)
ffffffff814b67db: 00 00 00 00 00
for our build, this is crashing at:
circ->buf[circ->head] = c;
Looking in uart_port_startup(), it seems that circ->buf (state->xmit.buf)
protected by the "per-port mutex", which based on uart_port_check() is
state->port.mutex. Indeed, the lock acquired in uart_put_char() is
uport->lock, i.e. not the same lock.
Anyway, since the lock is not acquired, if uart_shutdown() is called, the
last chunk of that function may release state->xmit.buf before its assigned
to null, and cause the race above.
To fix it, let's lock uport->lock when allocating/deallocating
state->xmit.buf in addition to the per-port mutex.
v2: switch to locking uport->lock on allocation/deallocation instead of
locking the per-port mutex in uart_put_char. Note that since
uport->lock is a spin lock, we have to switch the allocation to
GFP_ATOMIC.
v3: move the allocation outside the lock, so we can switch back to
GFP_KERNEL
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-06 10:24:57 -06:00
|
|
|
uart_port_unlock(uport, flags);
|
2018-12-13 13:58:39 +09:00
|
|
|
|
2022-02-04 17:28:08 +02:00
|
|
|
free_page((unsigned long)xmit_buf);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:52 +02:00
|
|
|
* uart_update_timeout - update per-port frame timing information
|
|
|
|
* @port: uart_port structure describing the port
|
|
|
|
* @cflag: termios cflag value
|
|
|
|
* @baud: speed of the port
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Set the @port frame timing information from which the FIFO timeout value is
|
|
|
|
* derived. The @cflag value should reflect the actual hardware settings as
|
|
|
|
* number of bits, parity, stop bits and baud rate is taken into account here.
|
|
|
|
*
|
|
|
|
* Locking: caller is expected to take @port->lock
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
void
|
|
|
|
uart_update_timeout(struct uart_port *port, unsigned int cflag,
|
|
|
|
unsigned int baud)
|
|
|
|
{
|
2023-11-09 12:04:17 +05:30
|
|
|
u64 temp = tty_get_frame_size(cflag);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-11-09 12:04:17 +05:30
|
|
|
temp *= NSEC_PER_SEC;
|
|
|
|
port->frame_time = (unsigned int)DIV64_U64_ROUND_UP(temp, baud);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(uart_update_timeout);
|
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:52 +02:00
|
|
|
* uart_get_baud_rate - return baud rate for a particular port
|
|
|
|
* @port: uart_port structure describing the port in question.
|
|
|
|
* @termios: desired termios settings
|
|
|
|
* @old: old termios (or %NULL)
|
|
|
|
* @min: minimum acceptable baud rate
|
|
|
|
* @max: maximum acceptable baud rate
|
|
|
|
*
|
|
|
|
* Decode the termios structure into a numeric baud rate, taking account of the
|
|
|
|
* magic 38400 baud rate (with spd_* flags), and mapping the %B0 rate to 9600
|
|
|
|
* baud.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* If the new baud rate is invalid, try the @old termios setting. If it's still
|
2023-10-10 01:59:22 -07:00
|
|
|
* invalid, we try 9600 baud. If that is also invalid 0 is returned.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* The @termios structure is updated to reflect the baud rate we're actually
|
|
|
|
* going to be using. Don't do this for the case where B0 is requested ("hang
|
|
|
|
* up").
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Locking: caller dependent
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
unsigned int
|
2006-12-08 02:38:45 -08:00
|
|
|
uart_get_baud_rate(struct uart_port *port, struct ktermios *termios,
|
2022-08-16 14:57:37 +03:00
|
|
|
const struct ktermios *old, unsigned int min, unsigned int max)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2015-06-08 14:56:51 +02:00
|
|
|
unsigned int try;
|
|
|
|
unsigned int baud;
|
|
|
|
unsigned int altbaud;
|
2008-04-28 02:14:07 -07:00
|
|
|
int hung_up = 0;
|
2006-01-21 23:03:28 +00:00
|
|
|
upf_t flags = port->flags & UPF_SPD_MASK;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2015-06-08 14:56:51 +02:00
|
|
|
switch (flags) {
|
|
|
|
case UPF_SPD_HI:
|
2005-04-16 15:20:36 -07:00
|
|
|
altbaud = 57600;
|
2015-06-08 14:56:51 +02:00
|
|
|
break;
|
|
|
|
case UPF_SPD_VHI:
|
2005-04-16 15:20:36 -07:00
|
|
|
altbaud = 115200;
|
2015-06-08 14:56:51 +02:00
|
|
|
break;
|
|
|
|
case UPF_SPD_SHI:
|
2005-04-16 15:20:36 -07:00
|
|
|
altbaud = 230400;
|
2015-06-08 14:56:51 +02:00
|
|
|
break;
|
|
|
|
case UPF_SPD_WARP:
|
2005-04-16 15:20:36 -07:00
|
|
|
altbaud = 460800;
|
2015-06-08 14:56:51 +02:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
altbaud = 38400;
|
|
|
|
break;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
for (try = 0; try < 2; try++) {
|
|
|
|
baud = tty_termios_baud_rate(termios);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The spd_hi, spd_vhi, spd_shi, spd_warp kludge...
|
|
|
|
* Die! Die! Die!
|
|
|
|
*/
|
2014-10-16 13:46:38 -04:00
|
|
|
if (try == 0 && baud == 38400)
|
2005-04-16 15:20:36 -07:00
|
|
|
baud = altbaud;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Special case: B0 rate.
|
|
|
|
*/
|
2008-04-28 02:14:07 -07:00
|
|
|
if (baud == 0) {
|
|
|
|
hung_up = 1;
|
2005-04-16 15:20:36 -07:00
|
|
|
baud = 9600;
|
2008-04-28 02:14:07 -07:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (baud >= min && baud <= max)
|
|
|
|
return baud;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Oops, the quotient was zero. Try again with
|
|
|
|
* the old baud rate if possible.
|
|
|
|
*/
|
|
|
|
termios->c_cflag &= ~CBAUD;
|
|
|
|
if (old) {
|
2008-02-04 22:27:53 -08:00
|
|
|
baud = tty_termios_baud_rate(old);
|
2008-04-28 02:14:07 -07:00
|
|
|
if (!hung_up)
|
|
|
|
tty_termios_encode_baud_rate(termios,
|
|
|
|
baud, baud);
|
2005-04-16 15:20:36 -07:00
|
|
|
old = NULL;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2010-01-04 16:26:21 +00:00
|
|
|
* As a last resort, if the range cannot be met then clip to
|
|
|
|
* the nearest chip supported rate.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2010-01-04 16:26:21 +00:00
|
|
|
if (!hung_up) {
|
|
|
|
if (baud <= min)
|
|
|
|
tty_termios_encode_baud_rate(termios,
|
|
|
|
min + 1, min + 1);
|
|
|
|
else
|
|
|
|
tty_termios_encode_baud_rate(termios,
|
|
|
|
max - 1, max - 1);
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(uart_get_baud_rate);
|
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:52 +02:00
|
|
|
* uart_get_divisor - return uart clock divisor
|
|
|
|
* @port: uart_port structure describing the port
|
|
|
|
* @baud: desired baud rate
|
|
|
|
*
|
|
|
|
* Calculate the divisor (baud_base / baud) for the specified @baud,
|
|
|
|
* appropriately rounded.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* If 38400 baud and custom divisor is selected, return the custom divisor
|
|
|
|
* instead.
|
|
|
|
*
|
|
|
|
* Locking: caller dependent
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
unsigned int
|
|
|
|
uart_get_divisor(struct uart_port *port, unsigned int baud)
|
|
|
|
{
|
|
|
|
unsigned int quot;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Old custom speed handling.
|
|
|
|
*/
|
|
|
|
if (baud == 38400 && (port->flags & UPF_SPD_MASK) == UPF_SPD_CUST)
|
|
|
|
quot = port->custom_divisor;
|
|
|
|
else
|
2011-12-20 11:47:44 +01:00
|
|
|
quot = DIV_ROUND_CLOSEST(port->uartclk, 16 * baud);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return quot;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(uart_get_divisor);
|
|
|
|
|
2023-08-10 11:15:02 +02:00
|
|
|
static int uart_put_char(struct tty_struct *tty, u8 c)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-01-10 20:23:55 -08:00
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2016-01-10 20:23:55 -08:00
|
|
|
struct circ_buf *circ;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
2008-04-30 00:54:11 -07:00
|
|
|
int ret = 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-01-10 20:23:55 -08:00
|
|
|
circ = &state->xmit;
|
2019-01-16 10:28:07 -08:00
|
|
|
port = uart_port_lock(state, flags);
|
|
|
|
if (!circ->buf) {
|
|
|
|
uart_port_unlock(port, flags);
|
2008-04-30 00:54:11 -07:00
|
|
|
return 0;
|
2019-01-16 10:28:07 -08:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
if (port && uart_circ_chars_free(circ) != 0) {
|
2005-04-16 15:20:36 -07:00
|
|
|
circ->buf[circ->head] = c;
|
|
|
|
circ->head = (circ->head + 1) & (UART_XMIT_SIZE - 1);
|
2008-04-30 00:54:11 -07:00
|
|
|
ret = 1;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2008-04-30 00:54:11 -07:00
|
|
|
return ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_flush_chars(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
uart_start(tty);
|
|
|
|
}
|
|
|
|
|
2023-08-10 11:15:03 +02:00
|
|
|
static ssize_t uart_write(struct tty_struct *tty, const u8 *buf, size_t count)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2006-03-07 21:55:20 -08:00
|
|
|
struct uart_port *port;
|
|
|
|
struct circ_buf *circ;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
|
|
|
int c, ret = 0;
|
|
|
|
|
2006-03-07 21:55:20 -08:00
|
|
|
/*
|
|
|
|
* This means you called this function _after_ the port was
|
|
|
|
* closed. No cookie for you.
|
|
|
|
*/
|
2023-07-31 10:02:35 +02:00
|
|
|
if (WARN_ON(!state))
|
2006-03-07 21:55:20 -08:00
|
|
|
return -EL3HLT;
|
|
|
|
|
2019-01-16 10:28:07 -08:00
|
|
|
port = uart_port_lock(state, flags);
|
2009-09-19 13:13:28 -07:00
|
|
|
circ = &state->xmit;
|
2019-01-16 10:28:07 -08:00
|
|
|
if (!circ->buf) {
|
|
|
|
uart_port_unlock(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
return 0;
|
2019-01-16 10:28:07 -08:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
while (port) {
|
2005-04-16 15:20:36 -07:00
|
|
|
c = CIRC_SPACE_TO_END(circ->head, circ->tail, UART_XMIT_SIZE);
|
|
|
|
if (count < c)
|
|
|
|
c = count;
|
|
|
|
if (c <= 0)
|
|
|
|
break;
|
|
|
|
memcpy(circ->buf + circ->head, buf, c);
|
|
|
|
circ->head = (circ->head + c) & (UART_XMIT_SIZE - 1);
|
|
|
|
buf += c;
|
|
|
|
count -= c;
|
|
|
|
ret += c;
|
|
|
|
}
|
2014-10-16 16:54:26 -04:00
|
|
|
|
2023-07-12 10:18:08 +02:00
|
|
|
__uart_start(state);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2021-05-05 11:19:15 +02:00
|
|
|
static unsigned int uart_write_room(struct tty_struct *tty)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2008-04-30 00:54:13 -07:00
|
|
|
unsigned long flags;
|
2021-05-05 11:19:15 +02:00
|
|
|
unsigned int ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_lock(state, flags);
|
2009-09-19 13:13:28 -07:00
|
|
|
ret = uart_circ_chars_free(&state->xmit);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2008-04-30 00:54:13 -07:00
|
|
|
return ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2021-05-05 11:19:19 +02:00
|
|
|
static unsigned int uart_chars_in_buffer(struct tty_struct *tty)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2008-04-30 00:54:13 -07:00
|
|
|
unsigned long flags;
|
2021-05-05 11:19:19 +02:00
|
|
|
unsigned int ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_lock(state, flags);
|
2009-09-19 13:13:28 -07:00
|
|
|
ret = uart_circ_chars_pending(&state->xmit);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2008-04-30 00:54:13 -07:00
|
|
|
return ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_flush_buffer(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2008-05-06 20:42:27 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
|
|
|
|
2006-03-07 21:55:20 -08:00
|
|
|
/*
|
|
|
|
* This means you called this function _after_ the port was
|
|
|
|
* closed. No cookie for you.
|
|
|
|
*/
|
2023-07-31 10:02:35 +02:00
|
|
|
if (WARN_ON(!state))
|
2006-03-07 21:55:20 -08:00
|
|
|
return;
|
|
|
|
|
2007-05-06 14:48:52 -07:00
|
|
|
pr_debug("uart_flush_buffer(%d) called\n", tty->index);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_lock(state, flags);
|
|
|
|
if (!port)
|
|
|
|
return;
|
2009-09-19 13:13:28 -07:00
|
|
|
uart_circ_clear(&state->xmit);
|
2008-07-16 21:52:36 +01:00
|
|
|
if (port->ops->flush_buffer)
|
|
|
|
port->ops->flush_buffer(port);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_unlock(port, flags);
|
2016-10-28 07:07:48 -05:00
|
|
|
tty_port_tty_wakeup(&state->port);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2022-03-14 11:14:32 +02:00
|
|
|
/*
|
|
|
|
* This function performs low-level write of high-priority XON/XOFF
|
|
|
|
* character and accounting for it.
|
|
|
|
*
|
|
|
|
* Requires uart_port to implement .serial_out().
|
|
|
|
*/
|
|
|
|
void uart_xchar_out(struct uart_port *uport, int offset)
|
|
|
|
{
|
|
|
|
serial_port_out(uport, offset, uport->x_char);
|
|
|
|
uport->icount.tx++;
|
|
|
|
uport->x_char = 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_xchar_out);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* This function is used to send a high-priority XON/XOFF character to
|
|
|
|
* the device
|
|
|
|
*/
|
2023-12-06 08:36:49 +01:00
|
|
|
static void uart_send_xchar(struct tty_struct *tty, u8 ch)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long flags;
|
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_ref(state);
|
|
|
|
if (!port)
|
|
|
|
return;
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
if (port->ops->send_xchar)
|
|
|
|
port->ops->send_xchar(port, ch);
|
|
|
|
else {
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
port->x_char = ch;
|
2014-09-02 17:39:13 -04:00
|
|
|
if (ch)
|
2005-08-31 10:12:14 +01:00
|
|
|
port->ops->start_tx(port);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(port);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_throttle(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2018-03-27 11:48:24 +08:00
|
|
|
upstat_t mask = UPSTAT_SYNC_FIFO;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_ref(state);
|
|
|
|
if (!port)
|
|
|
|
return;
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
if (I_IXOFF(tty))
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask |= UPSTAT_AUTOXOFF;
|
2016-01-10 20:36:15 -08:00
|
|
|
if (C_CRTSCTS(tty))
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask |= UPSTAT_AUTORTS;
|
2012-04-17 17:23:14 +01:00
|
|
|
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
if (port->status & mask) {
|
2012-04-17 17:23:14 +01:00
|
|
|
port->ops->throttle(port);
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask &= ~port->status;
|
2012-04-17 17:23:14 +01:00
|
|
|
}
|
|
|
|
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
if (mask & UPSTAT_AUTORTS)
|
2012-04-17 17:23:14 +01:00
|
|
|
uart_clear_mctrl(port, TIOCM_RTS);
|
2016-01-10 20:24:02 -08:00
|
|
|
|
|
|
|
if (mask & UPSTAT_AUTOXOFF)
|
|
|
|
uart_send_xchar(tty, STOP_CHAR(tty));
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
|
|
|
|
uart_port_deref(port);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_unthrottle(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2018-03-27 11:48:24 +08:00
|
|
|
upstat_t mask = UPSTAT_SYNC_FIFO;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_ref(state);
|
|
|
|
if (!port)
|
|
|
|
return;
|
|
|
|
|
2012-04-17 17:23:14 +01:00
|
|
|
if (I_IXOFF(tty))
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask |= UPSTAT_AUTOXOFF;
|
2016-01-10 20:36:15 -08:00
|
|
|
if (C_CRTSCTS(tty))
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask |= UPSTAT_AUTORTS;
|
2012-04-17 17:23:14 +01:00
|
|
|
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
if (port->status & mask) {
|
2012-04-17 17:23:14 +01:00
|
|
|
port->ops->unthrottle(port);
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
mask &= ~port->status;
|
2012-04-17 17:23:14 +01:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
if (mask & UPSTAT_AUTORTS)
|
2005-04-16 15:20:36 -07:00
|
|
|
uart_set_mctrl(port, TIOCM_RTS);
|
2016-01-10 20:24:02 -08:00
|
|
|
|
|
|
|
if (mask & UPSTAT_AUTOXOFF)
|
|
|
|
uart_send_xchar(tty, START_CHAR(tty));
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
|
|
|
|
uart_port_deref(port);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
static int uart_get_info(struct tty_port *port, struct serial_struct *retinfo)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2012-10-29 15:20:25 +00:00
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
|
|
|
int ret = -ENODEV;
|
2008-04-30 00:54:13 -07:00
|
|
|
|
2023-10-05 19:34:21 +03:00
|
|
|
/* Initialize structure in case we error out later to prevent any stack info leakage. */
|
|
|
|
*retinfo = (struct serial_struct){};
|
|
|
|
|
2016-01-10 20:23:56 -08:00
|
|
|
/*
|
|
|
|
* Ensure the state we copy is consistent and no hardware changes
|
|
|
|
* occur as we go
|
|
|
|
*/
|
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport)
|
|
|
|
goto out;
|
|
|
|
|
2012-09-04 16:34:45 +01:00
|
|
|
retinfo->type = uport->type;
|
|
|
|
retinfo->line = uport->line;
|
|
|
|
retinfo->port = uport->iobase;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (HIGH_BITS_OFFSET)
|
2012-09-04 16:34:45 +01:00
|
|
|
retinfo->port_high = (long) uport->iobase >> HIGH_BITS_OFFSET;
|
|
|
|
retinfo->irq = uport->irq;
|
2017-07-25 20:39:57 +03:00
|
|
|
retinfo->flags = (__force int)uport->flags;
|
2012-09-04 16:34:45 +01:00
|
|
|
retinfo->xmit_fifo_size = uport->fifosize;
|
|
|
|
retinfo->baud_base = uport->uartclk / 16;
|
|
|
|
retinfo->close_delay = jiffies_to_msecs(port->close_delay) / 10;
|
|
|
|
retinfo->closing_wait = port->closing_wait == ASYNC_CLOSING_WAIT_NONE ?
|
2005-04-16 15:20:36 -07:00
|
|
|
ASYNC_CLOSING_WAIT_NONE :
|
2011-11-09 21:33:45 +01:00
|
|
|
jiffies_to_msecs(port->closing_wait) / 10;
|
2012-09-04 16:34:45 +01:00
|
|
|
retinfo->custom_divisor = uport->custom_divisor;
|
|
|
|
retinfo->hub6 = uport->hub6;
|
|
|
|
retinfo->io_type = uport->iotype;
|
|
|
|
retinfo->iomem_reg_shift = uport->regshift;
|
|
|
|
retinfo->iomem_base = (void *)(unsigned long)uport->mapbase;
|
2016-04-09 18:56:33 -07:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
return ret;
|
2012-10-29 15:20:25 +00:00
|
|
|
}
|
|
|
|
|
2018-09-11 22:29:55 -04:00
|
|
|
static int uart_get_info_user(struct tty_struct *tty,
|
|
|
|
struct serial_struct *ss)
|
2012-10-29 15:20:25 +00:00
|
|
|
{
|
2018-09-11 22:29:55 -04:00
|
|
|
struct uart_state *state = tty->driver_data;
|
|
|
|
struct tty_port *port = &state->port;
|
2008-04-30 00:54:13 -07:00
|
|
|
|
2018-09-11 22:29:55 -04:00
|
|
|
return uart_get_info(port, ss) < 0 ? -EIO : 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2012-09-04 16:34:45 +01:00
|
|
|
static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
|
|
|
|
struct uart_state *state,
|
|
|
|
struct serial_struct *new_info)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned long new_port;
|
2006-01-21 23:03:28 +00:00
|
|
|
unsigned int change_irq, change_port, closing_wait;
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned int old_custom_divisor, close_delay;
|
2006-01-21 23:03:28 +00:00
|
|
|
upf_t old_flags, new_flags;
|
2005-04-16 15:20:36 -07:00
|
|
|
int retval = 0;
|
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
if (!uport)
|
|
|
|
return -EIO;
|
|
|
|
|
2012-09-04 16:34:45 +01:00
|
|
|
new_port = new_info->port;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (HIGH_BITS_OFFSET)
|
2012-09-04 16:34:45 +01:00
|
|
|
new_port += (unsigned long) new_info->port_high << HIGH_BITS_OFFSET;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2012-09-04 16:34:45 +01:00
|
|
|
new_info->irq = irq_canonicalize(new_info->irq);
|
|
|
|
close_delay = msecs_to_jiffies(new_info->close_delay * 10);
|
|
|
|
closing_wait = new_info->closing_wait == ASYNC_CLOSING_WAIT_NONE ?
|
2011-11-09 21:33:45 +01:00
|
|
|
ASYNC_CLOSING_WAIT_NONE :
|
2012-09-04 16:34:45 +01:00
|
|
|
msecs_to_jiffies(new_info->closing_wait * 10);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
change_irq = !(uport->flags & UPF_FIXED_PORT)
|
2012-09-04 16:34:45 +01:00
|
|
|
&& new_info->irq != uport->irq;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Since changing the 'type' of the port changes its resource
|
|
|
|
* allocations, we should treat type changes the same as
|
|
|
|
* IO port changes.
|
|
|
|
*/
|
2009-09-19 13:13:29 -07:00
|
|
|
change_port = !(uport->flags & UPF_FIXED_PORT)
|
|
|
|
&& (new_port != uport->iobase ||
|
2012-09-04 16:34:45 +01:00
|
|
|
(unsigned long)new_info->iomem_base != uport->mapbase ||
|
|
|
|
new_info->hub6 != uport->hub6 ||
|
|
|
|
new_info->io_type != uport->iotype ||
|
|
|
|
new_info->iomem_reg_shift != uport->regshift ||
|
|
|
|
new_info->type != uport->type);
|
2009-09-19 13:13:29 -07:00
|
|
|
|
|
|
|
old_flags = uport->flags;
|
2017-07-25 20:39:57 +03:00
|
|
|
new_flags = (__force upf_t)new_info->flags;
|
2009-09-19 13:13:29 -07:00
|
|
|
old_custom_divisor = uport->custom_divisor;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (!capable(CAP_SYS_ADMIN)) {
|
|
|
|
retval = -EPERM;
|
|
|
|
if (change_irq || change_port ||
|
2012-09-04 16:34:45 +01:00
|
|
|
(new_info->baud_base != uport->uartclk / 16) ||
|
2009-09-19 13:13:29 -07:00
|
|
|
(close_delay != port->close_delay) ||
|
|
|
|
(closing_wait != port->closing_wait) ||
|
2012-09-04 16:34:45 +01:00
|
|
|
(new_info->xmit_fifo_size &&
|
|
|
|
new_info->xmit_fifo_size != uport->fifosize) ||
|
2006-01-21 23:03:28 +00:00
|
|
|
(((new_flags ^ old_flags) & ~UPF_USR_MASK) != 0))
|
2005-04-16 15:20:36 -07:00
|
|
|
goto exit;
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->flags = ((uport->flags & ~UPF_USR_MASK) |
|
2006-01-21 23:03:28 +00:00
|
|
|
(new_flags & UPF_USR_MASK));
|
2012-09-04 16:34:45 +01:00
|
|
|
uport->custom_divisor = new_info->custom_divisor;
|
2005-04-16 15:20:36 -07:00
|
|
|
goto check_and_exit;
|
|
|
|
}
|
|
|
|
|
serial: core: fix suspicious security_locked_down() call
The commit that added this check did so in a very strange way - first
security_locked_down() is called, its value stored into retval, and if
it's nonzero, then an additional check is made for (change_irq ||
change_port), and if this is true, the function returns. However, if
the goto exit branch is not taken, the code keeps the retval value and
continues executing the function. Then, depending on whether
uport->ops->verify_port is set, the retval value may or may not be reset
to zero and eventually the error value from security_locked_down() may
abort the function a few lines below.
I will go out on a limb and assume that this isn't the intended behavior
and that an error value from security_locked_down() was supposed to
abort the function only in case (change_irq || change_port) is true.
Note that security_locked_down() should be called last in any series of
checks, since the SELinux implementation of this hook will do a check
against the policy and generate an audit record in case of denial. If
the operation was to carry on after calling security_locked_down(), then
the SELinux denial record would be bogus.
See commit 59438b46471a ("security,lockdown,selinux: implement SELinux
lockdown") for how SELinux implements this hook.
Fixes: 794edf30ee6c ("lockdown: Lock down TIOCSSERIAL")
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210507115719.140799-1-omosnace@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-07 13:57:19 +02:00
|
|
|
if (change_irq || change_port) {
|
|
|
|
retval = security_locked_down(LOCKDOWN_TIOCSSERIAL);
|
|
|
|
if (retval)
|
|
|
|
goto exit;
|
|
|
|
}
|
2019-08-19 17:17:54 -07:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Ask the low level driver to verify the settings.
|
|
|
|
*/
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->ops->verify_port)
|
2012-09-04 16:34:45 +01:00
|
|
|
retval = uport->ops->verify_port(uport, new_info);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2012-09-04 16:34:45 +01:00
|
|
|
if ((new_info->irq >= nr_irqs) || (new_info->irq < 0) ||
|
|
|
|
(new_info->baud_base < 9600))
|
2005-04-16 15:20:36 -07:00
|
|
|
retval = -EINVAL;
|
|
|
|
|
|
|
|
if (retval)
|
|
|
|
goto exit;
|
|
|
|
|
|
|
|
if (change_port || change_irq) {
|
|
|
|
retval = -EBUSY;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we are the sole user of this port.
|
|
|
|
*/
|
2009-09-19 13:13:32 -07:00
|
|
|
if (tty_port_users(port) > 1)
|
2005-04-16 15:20:36 -07:00
|
|
|
goto exit;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to shutdown the serial port at the old
|
|
|
|
* port/type/irq combination.
|
|
|
|
*/
|
2010-06-01 22:52:51 +02:00
|
|
|
uart_shutdown(tty, state);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
if (change_port) {
|
|
|
|
unsigned long old_iobase, old_mapbase;
|
|
|
|
unsigned int old_type, old_iotype, old_hub6, old_shift;
|
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
old_iobase = uport->iobase;
|
|
|
|
old_mapbase = uport->mapbase;
|
|
|
|
old_type = uport->type;
|
|
|
|
old_hub6 = uport->hub6;
|
|
|
|
old_iotype = uport->iotype;
|
|
|
|
old_shift = uport->regshift;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Free and release old regions
|
|
|
|
*/
|
2016-05-20 01:59:54 -03:00
|
|
|
if (old_type != PORT_UNKNOWN && uport->ops->release_port)
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->ops->release_port(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->iobase = new_port;
|
2012-09-04 16:34:45 +01:00
|
|
|
uport->type = new_info->type;
|
|
|
|
uport->hub6 = new_info->hub6;
|
|
|
|
uport->iotype = new_info->io_type;
|
|
|
|
uport->regshift = new_info->iomem_reg_shift;
|
|
|
|
uport->mapbase = (unsigned long)new_info->iomem_base;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Claim and map the new regions
|
|
|
|
*/
|
2016-05-20 01:59:54 -03:00
|
|
|
if (uport->type != PORT_UNKNOWN && uport->ops->request_port) {
|
2009-09-19 13:13:29 -07:00
|
|
|
retval = uport->ops->request_port(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
} else {
|
|
|
|
/* Always success - Jean II */
|
|
|
|
retval = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we fail to request resources for the
|
|
|
|
* new port, try to restore the old settings.
|
|
|
|
*/
|
2014-04-23 12:33:22 +02:00
|
|
|
if (retval) {
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->iobase = old_iobase;
|
|
|
|
uport->type = old_type;
|
|
|
|
uport->hub6 = old_hub6;
|
|
|
|
uport->iotype = old_iotype;
|
|
|
|
uport->regshift = old_shift;
|
|
|
|
uport->mapbase = old_mapbase;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2014-04-23 12:33:22 +02:00
|
|
|
if (old_type != PORT_UNKNOWN) {
|
|
|
|
retval = uport->ops->request_port(uport);
|
|
|
|
/*
|
|
|
|
* If we failed to restore the old settings,
|
|
|
|
* we fail like this.
|
|
|
|
*/
|
|
|
|
if (retval)
|
|
|
|
uport->type = PORT_UNKNOWN;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We failed anyway.
|
|
|
|
*/
|
|
|
|
retval = -EBUSY;
|
|
|
|
}
|
|
|
|
|
2008-02-08 04:18:53 -08:00
|
|
|
/* Added to return the correct error -Ram Gupta */
|
|
|
|
goto exit;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
serial: define FIXED_PORT flag for serial_core
At present, the serial core always allows setserial in userspace to change the
port address, irq and base clock of any serial port. That makes sense for
legacy ISA ports, but not for (say) embedded ns16550 compatible serial ports
at peculiar addresses. In these cases, the kernel code configuring the ports
must know exactly where they are, and their clocking arrangements (which can
be unusual on embedded boards). It doesn't make sense for userspace to change
these settings.
Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port
structure. If this flag is set when the serial port is configured, any
attempts to alter the port's type, io address, irq or base clock with
setserial are ignored.
In addition this patch uses the new flag for on-chip serial ports probed in
arch/powerpc/kernel/legacy_serial.c, and for other hard-wired serial ports
probed by drivers/serial/of_serial.c.
Signed-off-by: David Gibson <dwg@au1.ibm.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-06 14:48:49 -07:00
|
|
|
if (change_irq)
|
2012-09-04 16:34:45 +01:00
|
|
|
uport->irq = new_info->irq;
|
2009-09-19 13:13:29 -07:00
|
|
|
if (!(uport->flags & UPF_FIXED_PORT))
|
2012-09-04 16:34:45 +01:00
|
|
|
uport->uartclk = new_info->baud_base * 16;
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->flags = (uport->flags & ~UPF_CHANGE_MASK) |
|
2006-01-21 23:03:28 +00:00
|
|
|
(new_flags & UPF_CHANGE_MASK);
|
2012-09-04 16:34:45 +01:00
|
|
|
uport->custom_divisor = new_info->custom_divisor;
|
2009-09-19 13:13:29 -07:00
|
|
|
port->close_delay = close_delay;
|
|
|
|
port->closing_wait = closing_wait;
|
2012-09-04 16:34:45 +01:00
|
|
|
if (new_info->xmit_fifo_size)
|
|
|
|
uport->fifosize = new_info->xmit_fifo_size;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
check_and_exit:
|
|
|
|
retval = 0;
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->type == PORT_UNKNOWN)
|
2005-04-16 15:20:36 -07:00
|
|
|
goto exit;
|
2016-04-09 17:53:25 -07:00
|
|
|
if (tty_port_initialized(port)) {
|
2009-09-19 13:13:29 -07:00
|
|
|
if (((old_flags ^ uport->flags) & UPF_SPD_MASK) ||
|
|
|
|
old_custom_divisor != uport->custom_divisor) {
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* If they're setting up a custom divisor or speed,
|
2017-06-06 12:54:33 +02:00
|
|
|
* instead of clearing it, then bitch about it.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->flags & UPF_SPD_MASK) {
|
2017-06-06 12:54:33 +02:00
|
|
|
dev_notice_ratelimited(uport->dev,
|
2014-09-01 20:49:43 +05:30
|
|
|
"%s sets custom speed on %s. This is deprecated.\n",
|
|
|
|
current->comm,
|
2015-03-31 15:55:59 +02:00
|
|
|
tty_name(port->tty));
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2023-03-09 10:09:20 +02:00
|
|
|
uart_change_line_settings(tty, state, NULL);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2016-08-22 17:39:09 -05:00
|
|
|
} else {
|
2023-01-17 11:03:51 +02:00
|
|
|
retval = uart_startup(tty, state, true);
|
2018-01-11 18:57:26 +01:00
|
|
|
if (retval == 0)
|
|
|
|
tty_port_set_initialized(port, true);
|
2016-08-22 17:39:09 -05:00
|
|
|
if (retval > 0)
|
|
|
|
retval = 0;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
exit:
|
2012-09-04 16:34:45 +01:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2018-09-11 22:29:55 -04:00
|
|
|
static int uart_set_info_user(struct tty_struct *tty, struct serial_struct *ss)
|
2012-09-04 16:34:45 +01:00
|
|
|
{
|
2018-09-11 22:29:55 -04:00
|
|
|
struct uart_state *state = tty->driver_data;
|
2012-09-04 16:34:45 +01:00
|
|
|
struct tty_port *port = &state->port;
|
|
|
|
int retval;
|
|
|
|
|
2018-09-11 22:29:55 -04:00
|
|
|
down_write(&tty->termios_rwsem);
|
2012-09-04 16:34:45 +01:00
|
|
|
/*
|
|
|
|
* This semaphore protects port->count. It is also
|
|
|
|
* very useful to prevent opens. Also, take the
|
|
|
|
* port configuration semaphore to make sure that a
|
|
|
|
* module insertion/removal doesn't change anything
|
|
|
|
* under us.
|
|
|
|
*/
|
|
|
|
mutex_lock(&port->mutex);
|
2018-09-11 22:29:55 -04:00
|
|
|
retval = uart_set_info(tty, port, state, ss);
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2018-09-11 22:29:55 -04:00
|
|
|
up_write(&tty->termios_rwsem);
|
2005-04-16 15:20:36 -07:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2010-06-01 22:52:51 +02:00
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_get_lsr_info - get line status register info
|
|
|
|
* @tty: tty associated with the UART
|
|
|
|
* @state: UART being queried
|
|
|
|
* @value: returned modem value
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2010-06-01 22:52:51 +02:00
|
|
|
static int uart_get_lsr_info(struct tty_struct *tty,
|
|
|
|
struct uart_state *state, unsigned int __user *value)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned int result;
|
|
|
|
|
2009-09-19 13:13:29 -07:00
|
|
|
result = uport->ops->tx_empty(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we're about to load something into the transmit
|
|
|
|
* register, we'll pretend the transmitter isn't empty to
|
|
|
|
* avoid a race condition (depending on when the transmit
|
|
|
|
* interrupt happens).
|
|
|
|
*/
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->x_char ||
|
2009-09-19 13:13:28 -07:00
|
|
|
((uart_circ_chars_pending(&state->xmit) > 0) &&
|
2014-09-10 15:06:26 -04:00
|
|
|
!uart_tx_stopped(uport)))
|
2005-04-16 15:20:36 -07:00
|
|
|
result &= ~TIOCSER_TEMT;
|
2008-02-08 04:18:53 -08:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
return put_user(result, value);
|
|
|
|
}
|
|
|
|
|
2011-02-14 16:26:14 +00:00
|
|
|
static int uart_tiocmget(struct tty_struct *tty)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
int result = -EIO;
|
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport)
|
|
|
|
goto out;
|
|
|
|
|
2016-04-09 17:06:48 -07:00
|
|
|
if (!tty_io_error(tty)) {
|
2009-09-19 13:13:29 -07:00
|
|
|
result = uport->mctrl;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2009-09-19 13:13:29 -07:00
|
|
|
result |= uport->ops->get_mctrl(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2016-04-09 18:56:33 -07:00
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2011-02-14 16:26:50 +00:00
|
|
|
uart_tiocmset(struct tty_struct *tty, unsigned int set, unsigned int clear)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
int ret = -EIO;
|
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport)
|
|
|
|
goto out;
|
|
|
|
|
2016-04-09 17:06:48 -07:00
|
|
|
if (!tty_io_error(tty)) {
|
2009-09-19 13:13:29 -07:00
|
|
|
uart_update_mctrl(uport, set, clear);
|
2005-04-16 15:20:36 -07:00
|
|
|
ret = 0;
|
|
|
|
}
|
2016-04-09 18:56:33 -07:00
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-07-22 11:18:03 +01:00
|
|
|
static int uart_break_ctl(struct tty_struct *tty, int break_state)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
|
|
|
int ret = -EIO;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport)
|
|
|
|
goto out;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2019-11-20 23:18:53 +08:00
|
|
|
if (uport->type != PORT_UNKNOWN && uport->ops->break_ctl)
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->ops->break_ctl(uport, break_state);
|
2016-04-09 18:56:33 -07:00
|
|
|
ret = 0;
|
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
return ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2020-07-16 17:24:38 +05:30
|
|
|
static int uart_do_autoconfig(struct tty_struct *tty, struct uart_state *state)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
int flags, ret;
|
|
|
|
|
|
|
|
if (!capable(CAP_SYS_ADMIN))
|
|
|
|
return -EPERM;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Take the per-port semaphore. This prevents count from
|
|
|
|
* changing, and hence any extra opens of the port while
|
|
|
|
* we're auto-configuring.
|
|
|
|
*/
|
2009-09-19 13:13:31 -07:00
|
|
|
if (mutex_lock_interruptible(&port->mutex))
|
2005-04-16 15:20:36 -07:00
|
|
|
return -ERESTARTSYS;
|
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport) {
|
|
|
|
ret = -EIO;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
ret = -EBUSY;
|
2009-09-19 13:13:32 -07:00
|
|
|
if (tty_port_users(port) == 1) {
|
2010-06-01 22:52:51 +02:00
|
|
|
uart_shutdown(tty, state);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we already have a port type configured,
|
|
|
|
* we must release its resources.
|
|
|
|
*/
|
2016-05-20 01:59:54 -03:00
|
|
|
if (uport->type != PORT_UNKNOWN && uport->ops->release_port)
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->ops->release_port(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
flags = UART_CONFIG_TYPE;
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->flags & UPF_AUTO_IRQ)
|
2005-04-16 15:20:36 -07:00
|
|
|
flags |= UART_CONFIG_IRQ;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This will claim the ports resources if
|
|
|
|
* a port is found.
|
|
|
|
*/
|
2009-09-19 13:13:29 -07:00
|
|
|
uport->ops->config_port(uport, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-01-17 11:03:51 +02:00
|
|
|
ret = uart_startup(tty, state, true);
|
2018-02-03 12:27:23 +01:00
|
|
|
if (ret == 0)
|
|
|
|
tty_port_set_initialized(port, true);
|
2016-08-22 17:39:09 -05:00
|
|
|
if (ret > 0)
|
|
|
|
ret = 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2016-04-09 18:56:33 -07:00
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-06-03 18:54:43 +04:00
|
|
|
static void uart_enable_ms(struct uart_port *uport)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Force modem status interrupts on
|
|
|
|
*/
|
|
|
|
if (uport->ops->enable_ms)
|
|
|
|
uport->ops->enable_ms(uport);
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Wait for any of the 4 modem inputs (DCD,RI,DSR,CTS) to change
|
|
|
|
* - mask passed in arg for lines of interest
|
|
|
|
* (use |'ed TIOCM_RNG/DSR/CD/CTS for masking)
|
|
|
|
* Caller should use TIOCGICOUNT to see which one it was
|
2009-09-19 13:13:31 -07:00
|
|
|
*
|
|
|
|
* FIXME: This wants extracting into a common all driver implementation
|
|
|
|
* of TIOCMWAIT using tty_port.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
static int uart_wait_modem_status(struct uart_state *state, unsigned long arg)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *uport;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2005-04-16 15:20:36 -07:00
|
|
|
DECLARE_WAITQUEUE(wait, current);
|
|
|
|
struct uart_icount cprev, cnow;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* note the counters on entry
|
|
|
|
*/
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uport = uart_port_ref(state);
|
|
|
|
if (!uport)
|
|
|
|
return -EIO;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2009-09-19 13:13:29 -07:00
|
|
|
memcpy(&cprev, &uport->icount, sizeof(struct uart_icount));
|
2014-06-03 18:54:43 +04:00
|
|
|
uart_enable_ms(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
add_wait_queue(&port->delta_msr_wait, &wait);
|
2005-04-16 15:20:36 -07:00
|
|
|
for (;;) {
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2009-09-19 13:13:29 -07:00
|
|
|
memcpy(&cnow, &uport->icount, sizeof(struct uart_icount));
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
set_current_state(TASK_INTERRUPTIBLE);
|
|
|
|
|
|
|
|
if (((arg & TIOCM_RNG) && (cnow.rng != cprev.rng)) ||
|
|
|
|
((arg & TIOCM_DSR) && (cnow.dsr != cprev.dsr)) ||
|
|
|
|
((arg & TIOCM_CD) && (cnow.dcd != cprev.dcd)) ||
|
|
|
|
((arg & TIOCM_CTS) && (cnow.cts != cprev.cts))) {
|
2008-02-08 04:18:53 -08:00
|
|
|
ret = 0;
|
|
|
|
break;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
schedule();
|
|
|
|
|
|
|
|
/* see if a signal did it */
|
|
|
|
if (signal_pending(current)) {
|
|
|
|
ret = -ERESTARTSYS;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
cprev = cnow;
|
|
|
|
}
|
2015-02-20 19:12:57 +01:00
|
|
|
__set_current_state(TASK_RUNNING);
|
2009-09-19 13:13:31 -07:00
|
|
|
remove_wait_queue(&port->delta_msr_wait, &wait);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get counter of input serial line interrupts (DCD,RI,DSR,CTS)
|
|
|
|
* Return: write counters to the user passed counter struct
|
|
|
|
* NB: both 1->0 and 0->1 transitions are counted except for
|
|
|
|
* RI where only 0->1 is counted.
|
|
|
|
*/
|
2010-09-16 18:21:24 +01:00
|
|
|
static int uart_get_icount(struct tty_struct *tty,
|
|
|
|
struct serial_icounter_struct *icount)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2010-09-16 18:21:24 +01:00
|
|
|
struct uart_state *state = tty->driver_data;
|
2005-04-16 15:20:36 -07:00
|
|
|
struct uart_icount cnow;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uport = uart_port_ref(state);
|
|
|
|
if (!uport)
|
|
|
|
return -EIO;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2009-09-19 13:13:29 -07:00
|
|
|
memcpy(&cnow, &uport->icount, sizeof(struct uart_icount));
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2010-09-16 18:21:24 +01:00
|
|
|
icount->cts = cnow.cts;
|
|
|
|
icount->dsr = cnow.dsr;
|
|
|
|
icount->rng = cnow.rng;
|
|
|
|
icount->dcd = cnow.dcd;
|
|
|
|
icount->rx = cnow.rx;
|
|
|
|
icount->tx = cnow.tx;
|
|
|
|
icount->frame = cnow.frame;
|
|
|
|
icount->overrun = cnow.overrun;
|
|
|
|
icount->parity = cnow.parity;
|
|
|
|
icount->brk = cnow.brk;
|
|
|
|
icount->buf_overrun = cnow.buf_overrun;
|
|
|
|
|
|
|
|
return 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2022-06-06 13:04:21 +03:00
|
|
|
#define SER_RS485_LEGACY_FLAGS (SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | \
|
|
|
|
SER_RS485_RTS_AFTER_SEND | SER_RS485_RX_DURING_TX | \
|
|
|
|
SER_RS485_TERMINATE_BUS)
|
|
|
|
|
|
|
|
static int uart_check_rs485_flags(struct uart_port *port, struct serial_rs485 *rs485)
|
|
|
|
{
|
|
|
|
u32 flags = rs485->flags;
|
|
|
|
|
|
|
|
/* Don't return -EINVAL for unsupported legacy flags */
|
|
|
|
flags &= ~SER_RS485_LEGACY_FLAGS;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For any bit outside of the legacy ones that is not supported by
|
|
|
|
* the driver, return -EINVAL.
|
|
|
|
*/
|
2022-07-04 12:45:14 +03:00
|
|
|
if (flags & ~port->rs485_supported.flags)
|
2022-06-06 13:04:21 +03:00
|
|
|
return -EINVAL;
|
|
|
|
|
2022-06-24 23:42:09 +03:00
|
|
|
/* Asking for address w/o addressing mode? */
|
|
|
|
if (!(rs485->flags & SER_RS485_ADDRB) &&
|
|
|
|
(rs485->flags & (SER_RS485_ADDR_RECV|SER_RS485_ADDR_DEST)))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* Address given but not enabled? */
|
|
|
|
if (!(rs485->flags & SER_RS485_ADDR_RECV) && rs485->addr_recv)
|
|
|
|
return -EINVAL;
|
|
|
|
if (!(rs485->flags & SER_RS485_ADDR_DEST) && rs485->addr_dest)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2022-06-06 13:04:21 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-07-10 18:44:38 +02:00
|
|
|
static void uart_sanitize_serial_rs485_delays(struct uart_port *port,
|
|
|
|
struct serial_rs485 *rs485)
|
2022-06-06 13:03:59 +03:00
|
|
|
{
|
2022-07-04 12:45:14 +03:00
|
|
|
if (!port->rs485_supported.delay_rts_before_send) {
|
2022-06-06 13:04:19 +03:00
|
|
|
if (rs485->delay_rts_before_send) {
|
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): RTS delay before sending not supported\n",
|
|
|
|
port->name, port->line);
|
|
|
|
}
|
|
|
|
rs485->delay_rts_before_send = 0;
|
|
|
|
} else if (rs485->delay_rts_before_send > RS485_MAX_RTS_DELAY) {
|
2022-06-06 13:03:59 +03:00
|
|
|
rs485->delay_rts_before_send = RS485_MAX_RTS_DELAY;
|
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): RTS delay before sending clamped to %u ms\n",
|
|
|
|
port->name, port->line, rs485->delay_rts_before_send);
|
|
|
|
}
|
|
|
|
|
2022-07-04 12:45:14 +03:00
|
|
|
if (!port->rs485_supported.delay_rts_after_send) {
|
2022-06-06 13:04:19 +03:00
|
|
|
if (rs485->delay_rts_after_send) {
|
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): RTS delay after sending not supported\n",
|
|
|
|
port->name, port->line);
|
|
|
|
}
|
|
|
|
rs485->delay_rts_after_send = 0;
|
|
|
|
} else if (rs485->delay_rts_after_send > RS485_MAX_RTS_DELAY) {
|
2022-06-06 13:03:59 +03:00
|
|
|
rs485->delay_rts_after_send = RS485_MAX_RTS_DELAY;
|
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): RTS delay after sending clamped to %u ms\n",
|
|
|
|
port->name, port->line, rs485->delay_rts_after_send);
|
|
|
|
}
|
2022-07-10 18:44:38 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_sanitize_serial_rs485(struct uart_port *port, struct serial_rs485 *rs485)
|
|
|
|
{
|
|
|
|
u32 supported_flags = port->rs485_supported.flags;
|
|
|
|
|
|
|
|
if (!(rs485->flags & SER_RS485_ENABLED)) {
|
|
|
|
memset(rs485, 0, sizeof(*rs485));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-12-01 15:15:54 +08:00
|
|
|
/* Clear other RS485 flags but SER_RS485_TERMINATE_BUS and return if enabling RS422 */
|
|
|
|
if (rs485->flags & SER_RS485_MODE_RS422) {
|
|
|
|
rs485->flags &= (SER_RS485_ENABLED | SER_RS485_MODE_RS422 | SER_RS485_TERMINATE_BUS);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2024-01-03 07:18:14 +01:00
|
|
|
rs485->flags &= supported_flags;
|
|
|
|
|
2022-07-10 18:44:38 +02:00
|
|
|
/* Pick sane settings if the user hasn't */
|
2024-01-03 07:18:14 +01:00
|
|
|
if (!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
|
2022-07-10 18:44:38 +02:00
|
|
|
!(rs485->flags & SER_RS485_RTS_AFTER_SEND)) {
|
2024-01-03 07:18:14 +01:00
|
|
|
if (supported_flags & SER_RS485_RTS_ON_SEND) {
|
|
|
|
rs485->flags |= SER_RS485_RTS_ON_SEND;
|
|
|
|
rs485->flags &= ~SER_RS485_RTS_AFTER_SEND;
|
2022-06-06 13:04:19 +03:00
|
|
|
|
2024-01-03 07:18:14 +01:00
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): invalid RTS setting, using RTS_ON_SEND instead\n",
|
|
|
|
port->name, port->line);
|
|
|
|
} else {
|
|
|
|
rs485->flags |= SER_RS485_RTS_AFTER_SEND;
|
|
|
|
rs485->flags &= ~SER_RS485_RTS_ON_SEND;
|
|
|
|
|
|
|
|
dev_warn_ratelimited(port->dev,
|
|
|
|
"%s (%d): invalid RTS setting, using RTS_AFTER_SEND instead\n",
|
|
|
|
port->name, port->line);
|
|
|
|
}
|
|
|
|
}
|
2022-06-06 13:04:19 +03:00
|
|
|
|
2022-07-10 18:44:38 +02:00
|
|
|
uart_sanitize_serial_rs485_delays(port, rs485);
|
|
|
|
|
2022-06-06 13:03:59 +03:00
|
|
|
/* Return clean padding area to userspace */
|
2022-06-24 23:42:09 +03:00
|
|
|
memset(rs485->padding0, 0, sizeof(rs485->padding0));
|
|
|
|
memset(rs485->padding1, 0, sizeof(rs485->padding1));
|
2022-06-06 13:03:59 +03:00
|
|
|
}
|
|
|
|
|
2022-07-10 18:44:37 +02:00
|
|
|
static void uart_set_rs485_termination(struct uart_port *port,
|
|
|
|
const struct serial_rs485 *rs485)
|
|
|
|
{
|
|
|
|
if (!(rs485->flags & SER_RS485_ENABLED))
|
|
|
|
return;
|
|
|
|
|
|
|
|
gpiod_set_value_cansleep(port->rs485_term_gpio,
|
|
|
|
!!(rs485->flags & SER_RS485_TERMINATE_BUS));
|
|
|
|
}
|
|
|
|
|
2024-01-03 07:18:12 +01:00
|
|
|
static void uart_set_rs485_rx_during_tx(struct uart_port *port,
|
|
|
|
const struct serial_rs485 *rs485)
|
|
|
|
{
|
|
|
|
if (!(rs485->flags & SER_RS485_ENABLED))
|
|
|
|
return;
|
|
|
|
|
|
|
|
gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio,
|
|
|
|
!!(rs485->flags & SER_RS485_RX_DURING_TX));
|
|
|
|
}
|
|
|
|
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
static int uart_rs485_config(struct uart_port *port)
|
2022-06-06 13:03:58 +03:00
|
|
|
{
|
2022-06-06 13:04:19 +03:00
|
|
|
struct serial_rs485 *rs485 = &port->rs485;
|
2023-09-21 16:52:33 +02:00
|
|
|
unsigned long flags;
|
2022-06-06 13:04:20 +03:00
|
|
|
int ret;
|
2022-06-06 13:04:19 +03:00
|
|
|
|
2023-09-21 16:52:33 +02:00
|
|
|
if (!(rs485->flags & SER_RS485_ENABLED))
|
|
|
|
return 0;
|
|
|
|
|
2022-06-06 13:04:19 +03:00
|
|
|
uart_sanitize_serial_rs485(port, rs485);
|
2022-07-10 18:44:37 +02:00
|
|
|
uart_set_rs485_termination(port, rs485);
|
2024-01-03 07:18:12 +01:00
|
|
|
uart_set_rs485_rx_during_tx(port, rs485);
|
2022-06-06 13:04:19 +03:00
|
|
|
|
2023-10-16 10:18:49 +02:00
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2022-06-24 23:42:08 +03:00
|
|
|
ret = port->rs485_config(port, NULL, rs485);
|
2023-10-16 10:18:49 +02:00
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2024-01-03 07:18:12 +01:00
|
|
|
if (ret) {
|
2022-06-06 13:04:20 +03:00
|
|
|
memset(rs485, 0, sizeof(*rs485));
|
2024-01-03 07:18:12 +01:00
|
|
|
/* unset GPIOs */
|
|
|
|
gpiod_set_value_cansleep(port->rs485_term_gpio, 0);
|
|
|
|
gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, 0);
|
|
|
|
}
|
2022-06-06 13:04:20 +03:00
|
|
|
|
|
|
|
return ret;
|
2022-06-06 13:03:58 +03:00
|
|
|
}
|
|
|
|
|
2014-11-06 22:46:13 +01:00
|
|
|
static int uart_get_rs485_config(struct uart_port *port,
|
|
|
|
struct serial_rs485 __user *rs485)
|
|
|
|
{
|
2014-11-06 09:23:00 +01:00
|
|
|
unsigned long flags;
|
|
|
|
struct serial_rs485 aux;
|
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2014-11-06 09:23:00 +01:00
|
|
|
aux = port->rs485;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2014-11-06 09:23:00 +01:00
|
|
|
|
|
|
|
if (copy_to_user(rs485, &aux, sizeof(aux)))
|
2014-11-06 22:46:13 +01:00
|
|
|
return -EFAULT;
|
2014-11-06 09:23:00 +01:00
|
|
|
|
2014-11-06 22:46:13 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-06-24 23:42:08 +03:00
|
|
|
static int uart_set_rs485_config(struct tty_struct *tty, struct uart_port *port,
|
2014-11-06 22:46:13 +01:00
|
|
|
struct serial_rs485 __user *rs485_user)
|
|
|
|
{
|
|
|
|
struct serial_rs485 rs485;
|
|
|
|
int ret;
|
2014-11-06 09:23:00 +01:00
|
|
|
unsigned long flags;
|
2014-11-06 22:46:13 +01:00
|
|
|
|
2024-01-03 07:18:15 +01:00
|
|
|
if (!(port->rs485_supported.flags & SER_RS485_ENABLED))
|
2021-04-07 11:52:08 +02:00
|
|
|
return -ENOTTY;
|
2014-11-06 22:46:13 +01:00
|
|
|
|
|
|
|
if (copy_from_user(&rs485, rs485_user, sizeof(*rs485_user)))
|
|
|
|
return -EFAULT;
|
|
|
|
|
2022-06-06 13:04:21 +03:00
|
|
|
ret = uart_check_rs485_flags(port, &rs485);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2022-06-06 13:03:59 +03:00
|
|
|
uart_sanitize_serial_rs485(port, &rs485);
|
2022-07-10 18:44:37 +02:00
|
|
|
uart_set_rs485_termination(port, &rs485);
|
2024-01-03 07:18:12 +01:00
|
|
|
uart_set_rs485_rx_during_tx(port, &rs485);
|
2022-04-10 12:46:34 +02:00
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2022-06-24 23:42:08 +03:00
|
|
|
ret = port->rs485_config(port, &tty->termios, &rs485);
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (!ret) {
|
2022-04-10 12:46:34 +02:00
|
|
|
port->rs485 = rs485;
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
|
|
|
|
/* Reset RTS and other mctrl lines when disabling RS485 */
|
|
|
|
if (!(rs485.flags & SER_RS485_ENABLED))
|
|
|
|
port->ops->set_mctrl(port, port->mctrl);
|
|
|
|
}
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2024-01-03 07:18:12 +01:00
|
|
|
if (ret) {
|
|
|
|
/* restore old GPIO settings */
|
|
|
|
gpiod_set_value_cansleep(port->rs485_term_gpio,
|
|
|
|
!!(port->rs485.flags & SER_RS485_TERMINATE_BUS));
|
|
|
|
gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio,
|
|
|
|
!!(port->rs485.flags & SER_RS485_RX_DURING_TX));
|
2014-11-06 22:46:13 +01:00
|
|
|
return ret;
|
2024-01-03 07:18:12 +01:00
|
|
|
}
|
2014-11-06 22:46:13 +01:00
|
|
|
|
|
|
|
if (copy_to_user(rs485_user, &port->rs485, sizeof(port->rs485)))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-26 14:58:47 +02:00
|
|
|
static int uart_get_iso7816_config(struct uart_port *port,
|
|
|
|
struct serial_iso7816 __user *iso7816)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct serial_iso7816 aux;
|
|
|
|
|
|
|
|
if (!port->iso7816_config)
|
2021-04-07 11:52:08 +02:00
|
|
|
return -ENOTTY;
|
2018-09-26 14:58:47 +02:00
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2018-09-26 14:58:47 +02:00
|
|
|
aux = port->iso7816;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2018-09-26 14:58:47 +02:00
|
|
|
|
|
|
|
if (copy_to_user(iso7816, &aux, sizeof(aux)))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int uart_set_iso7816_config(struct uart_port *port,
|
|
|
|
struct serial_iso7816 __user *iso7816_user)
|
|
|
|
{
|
|
|
|
struct serial_iso7816 iso7816;
|
|
|
|
int i, ret;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!port->iso7816_config)
|
2021-04-07 11:52:08 +02:00
|
|
|
return -ENOTTY;
|
2018-09-26 14:58:47 +02:00
|
|
|
|
|
|
|
if (copy_from_user(&iso7816, iso7816_user, sizeof(*iso7816_user)))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* There are 5 words reserved for future use. Check that userspace
|
|
|
|
* doesn't put stuff in there to prevent breakages in the future.
|
|
|
|
*/
|
2023-03-09 10:09:16 +02:00
|
|
|
for (i = 0; i < ARRAY_SIZE(iso7816.reserved); i++)
|
2018-09-26 14:58:47 +02:00
|
|
|
if (iso7816.reserved[i])
|
|
|
|
return -EINVAL;
|
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2018-09-26 14:58:47 +02:00
|
|
|
ret = port->iso7816_config(port, &iso7816);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2018-09-26 14:58:47 +02:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (copy_to_user(iso7816_user, &port->iso7816, sizeof(port->iso7816)))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
2008-04-30 00:53:28 -07:00
|
|
|
* Called via sys_ioctl. We can use spin_lock_irq() here.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
static int
|
2016-04-09 18:56:33 -07:00
|
|
|
uart_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
void __user *uarg = (void __user *)arg;
|
|
|
|
int ret = -ENOIOCTLCMD;
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* These ioctls don't rely on the hardware to be present.
|
|
|
|
*/
|
|
|
|
switch (cmd) {
|
|
|
|
case TIOCSERCONFIG:
|
2014-10-16 16:54:20 -04:00
|
|
|
down_write(&tty->termios_rwsem);
|
2010-06-01 22:52:51 +02:00
|
|
|
ret = uart_do_autoconfig(tty, state);
|
2014-10-16 16:54:20 -04:00
|
|
|
up_write(&tty->termios_rwsem);
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret != -ENOIOCTLCMD)
|
|
|
|
goto out;
|
|
|
|
|
2016-04-09 17:06:48 -07:00
|
|
|
if (tty_io_error(tty)) {
|
2005-04-16 15:20:36 -07:00
|
|
|
ret = -EIO;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The following should only be used when hardware is present.
|
|
|
|
*/
|
|
|
|
switch (cmd) {
|
|
|
|
case TIOCMIWAIT:
|
|
|
|
ret = uart_wait_modem_status(state, arg);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret != -ENOIOCTLCMD)
|
|
|
|
goto out;
|
|
|
|
|
2022-06-24 23:42:08 +03:00
|
|
|
/* rs485_config requires more locking than others */
|
2023-04-12 14:48:11 +02:00
|
|
|
if (cmd == TIOCSRS485)
|
2022-06-24 23:42:08 +03:00
|
|
|
down_write(&tty->termios_rwsem);
|
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
if (!uport || tty_io_error(tty)) {
|
2005-04-16 15:20:36 -07:00
|
|
|
ret = -EIO;
|
|
|
|
goto out_up;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* All these rely on hardware being present and need to be
|
|
|
|
* protected against the tty being hung up.
|
|
|
|
*/
|
2014-11-06 09:22:59 +01:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
switch (cmd) {
|
2014-11-06 09:22:59 +01:00
|
|
|
case TIOCSERGETLSR: /* Get line status register */
|
|
|
|
ret = uart_get_lsr_info(tty, state, uarg);
|
|
|
|
break;
|
|
|
|
|
2014-11-06 22:46:13 +01:00
|
|
|
case TIOCGRS485:
|
2016-04-09 18:56:33 -07:00
|
|
|
ret = uart_get_rs485_config(uport, uarg);
|
2014-11-06 22:46:13 +01:00
|
|
|
break;
|
|
|
|
|
|
|
|
case TIOCSRS485:
|
2022-06-24 23:42:08 +03:00
|
|
|
ret = uart_set_rs485_config(tty, uport, uarg);
|
2014-11-06 22:46:13 +01:00
|
|
|
break;
|
2018-09-26 14:58:47 +02:00
|
|
|
|
|
|
|
case TIOCSISO7816:
|
|
|
|
ret = uart_set_iso7816_config(state->uart_port, uarg);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case TIOCGISO7816:
|
|
|
|
ret = uart_get_iso7816_config(state->uart_port, uarg);
|
|
|
|
break;
|
2016-04-09 18:56:33 -07:00
|
|
|
default:
|
2009-09-19 13:13:29 -07:00
|
|
|
if (uport->ops->ioctl)
|
|
|
|
ret = uport->ops->ioctl(uport, cmd, arg);
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
}
|
2008-04-30 00:54:13 -07:00
|
|
|
out_up:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2023-04-12 14:48:11 +02:00
|
|
|
if (cmd == TIOCSRS485)
|
2022-06-24 23:42:08 +03:00
|
|
|
up_write(&tty->termios_rwsem);
|
2008-04-30 00:54:13 -07:00
|
|
|
out:
|
2005-04-16 15:20:36 -07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-06-04 10:35:03 -07:00
|
|
|
static void uart_set_ldisc(struct tty_struct *tty)
|
2008-06-03 15:18:54 +01:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2020-12-03 16:58:34 +11:00
|
|
|
struct tty_port *port = &state->port;
|
|
|
|
|
|
|
|
if (!tty_port_initialized(port))
|
|
|
|
return;
|
2008-06-03 15:18:54 +01:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_lock(&state->port.mutex);
|
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (uport && uport->ops->set_ldisc)
|
2014-11-05 13:11:43 -05:00
|
|
|
uport->ops->set_ldisc(uport, &tty->termios);
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_unlock(&state->port.mutex);
|
2008-06-03 15:18:54 +01:00
|
|
|
}
|
|
|
|
|
2008-02-08 04:18:53 -08:00
|
|
|
static void uart_set_termios(struct tty_struct *tty,
|
2022-08-16 14:57:39 +03:00
|
|
|
const struct ktermios *old_termios)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2012-07-14 15:31:47 +01:00
|
|
|
unsigned int cflag = tty->termios.c_cflag;
|
2012-04-17 16:34:13 +01:00
|
|
|
unsigned int iflag_mask = IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK;
|
|
|
|
bool sw_changed = false;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_lock(&state->port.mutex);
|
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (!uport)
|
|
|
|
goto out;
|
|
|
|
|
2012-04-17 16:34:13 +01:00
|
|
|
/*
|
|
|
|
* Drivers doing software flow control also need to know
|
|
|
|
* about changes to these input settings.
|
|
|
|
*/
|
|
|
|
if (uport->flags & UPF_SOFT_FLOW) {
|
|
|
|
iflag_mask |= IXANY|IXON|IXOFF;
|
|
|
|
sw_changed =
|
|
|
|
tty->termios.c_cc[VSTART] != old_termios->c_cc[VSTART] ||
|
|
|
|
tty->termios.c_cc[VSTOP] != old_termios->c_cc[VSTOP];
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* These are the bits that are used to setup various
|
2007-08-22 14:01:11 -07:00
|
|
|
* flags in the low level driver. We can ignore the Bfoo
|
|
|
|
* bits in c_cflag; c_[io]speed will always be set
|
|
|
|
* appropriately by set_termios() in tty_ioctl.c
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
if ((cflag ^ old_termios->c_cflag) == 0 &&
|
2012-07-14 15:31:47 +01:00
|
|
|
tty->termios.c_ospeed == old_termios->c_ospeed &&
|
|
|
|
tty->termios.c_ispeed == old_termios->c_ispeed &&
|
2012-04-17 16:34:13 +01:00
|
|
|
((tty->termios.c_iflag ^ old_termios->c_iflag) & iflag_mask) == 0 &&
|
|
|
|
!sw_changed) {
|
2016-04-09 18:56:33 -07:00
|
|
|
goto out;
|
2008-04-30 00:53:28 -07:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-03-09 10:09:20 +02:00
|
|
|
uart_change_line_settings(tty, state, old_termios);
|
2019-03-28 08:47:33 +05:30
|
|
|
/* reload cflag from termios; port driver may have overridden flags */
|
2014-06-16 09:17:09 -04:00
|
|
|
cflag = tty->termios.c_cflag;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/* Handle transition to B0 status */
|
2023-03-09 10:09:17 +02:00
|
|
|
if (((old_termios->c_cflag & CBAUD) != B0) && ((cflag & CBAUD) == B0))
|
2012-09-24 11:13:15 +01:00
|
|
|
uart_clear_mctrl(uport, TIOCM_RTS | TIOCM_DTR);
|
2005-04-16 15:20:36 -07:00
|
|
|
/* Handle transition away from B0 status */
|
2023-03-09 10:09:17 +02:00
|
|
|
else if (((old_termios->c_cflag & CBAUD) == B0) && ((cflag & CBAUD) != B0)) {
|
2005-04-16 15:20:36 -07:00
|
|
|
unsigned int mask = TIOCM_DTR;
|
2020-07-16 17:24:38 +05:30
|
|
|
|
2016-04-09 17:11:36 -07:00
|
|
|
if (!(cflag & CRTSCTS) || !tty_throttled(tty))
|
2005-04-16 15:20:36 -07:00
|
|
|
mask |= TIOCM_RTS;
|
2012-09-24 11:13:15 +01:00
|
|
|
uart_set_mctrl(uport, mask);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2016-04-09 18:56:33 -07:00
|
|
|
out:
|
|
|
|
mutex_unlock(&state->port.mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2012-12-26 20:43:41 -08:00
|
|
|
* Calls to uart_close() are serialised via the tty_lock in
|
|
|
|
* drivers/tty/tty_io.c:tty_release()
|
|
|
|
* drivers/tty/tty_io.c:do_tty_hangup()
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
static void uart_close(struct tty_struct *tty, struct file *filp)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2008-02-08 04:18:53 -08:00
|
|
|
|
2014-10-16 16:54:27 -04:00
|
|
|
if (!state) {
|
|
|
|
struct uart_driver *drv = tty->driver->driver_state;
|
2017-11-01 10:49:23 +00:00
|
|
|
struct tty_port *port;
|
2014-10-16 16:54:27 -04:00
|
|
|
|
|
|
|
state = drv->state + tty->index;
|
|
|
|
port = &state->port;
|
|
|
|
spin_lock_irq(&port->lock);
|
|
|
|
--port->count;
|
|
|
|
spin_unlock_irq(&port->lock);
|
2009-10-12 19:13:54 +02:00
|
|
|
return;
|
2014-10-16 16:54:27 -04:00
|
|
|
}
|
2009-10-12 19:13:54 +02:00
|
|
|
|
2016-01-10 20:23:57 -08:00
|
|
|
pr_debug("uart_close(%d) called\n", tty->index);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-08-22 17:39:10 -05:00
|
|
|
tty_port_close(tty->port, tty, filp);
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-08-22 17:39:10 -05:00
|
|
|
static void uart_tty_port_shutdown(struct tty_port *port)
|
|
|
|
{
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2021-11-08 09:54:31 +01:00
|
|
|
char *buf;
|
2016-04-09 18:56:35 -07:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* At this point, we stop accepting input. To do this, we
|
|
|
|
* disable the receive line status interrupts.
|
|
|
|
*/
|
2016-09-13 00:23:42 +03:00
|
|
|
if (WARN(!uport, "detached port still initialized!\n"))
|
|
|
|
return;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2016-08-22 17:39:10 -05:00
|
|
|
uport->ops->stop_rx(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-08-22 17:39:10 -05:00
|
|
|
uart_port_shutdown(port);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
2016-08-22 17:39:10 -05:00
|
|
|
* It's possible for shutdown to be called after suspend if we get
|
|
|
|
* a DCD drop (hangup) at just the right time. Clear suspended bit so
|
|
|
|
* we don't try to resume a port that has been shutdown.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2023-01-17 11:03:48 +02:00
|
|
|
tty_port_set_suspended(port, false);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2021-11-08 09:54:31 +01:00
|
|
|
/*
|
|
|
|
* Free the transmit buffer.
|
|
|
|
*/
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2021-11-08 09:54:31 +01:00
|
|
|
buf = state->xmit.buf;
|
|
|
|
state->xmit.buf = NULL;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2014-10-16 16:54:19 -04:00
|
|
|
|
2022-02-04 17:28:08 +02:00
|
|
|
free_page((unsigned long)buf);
|
2021-11-08 09:54:31 +01:00
|
|
|
|
|
|
|
uart_change_pm(state, UART_PM_STATE_OFF);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2011-07-14 14:35:10 +02:00
|
|
|
static void uart_wait_until_sent(struct tty_struct *tty, int timeout)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2011-07-14 14:35:10 +02:00
|
|
|
struct uart_state *state = tty->driver_data;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *port;
|
2022-06-13 14:39:05 +03:00
|
|
|
unsigned long char_time, expire, fifo_timeout;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_ref(state);
|
2016-11-24 14:18:55 +02:00
|
|
|
if (!port)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (port->type == PORT_UNKNOWN || port->fifosize == 0) {
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(port);
|
2005-04-16 15:20:36 -07:00
|
|
|
return;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Set the check interval to be 1/5 of the estimated time to
|
|
|
|
* send a single character, and make it at least 1. The check
|
|
|
|
* interval should also be less than the timeout.
|
|
|
|
*
|
|
|
|
* Note: we have to use pretty tight timings here to satisfy
|
|
|
|
* the NIST-PCTS.
|
|
|
|
*/
|
2022-04-25 17:33:58 +03:00
|
|
|
char_time = max(nsecs_to_jiffies(port->frame_time / 5), 1UL);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
if (timeout && timeout < char_time)
|
|
|
|
char_time = timeout;
|
|
|
|
|
2022-02-28 06:49:11 +01:00
|
|
|
if (!uart_cts_enabled(port)) {
|
|
|
|
/*
|
|
|
|
* If the transmitter hasn't cleared in twice the approximate
|
|
|
|
* amount of time to send the entire FIFO, it probably won't
|
|
|
|
* ever clear. This assumes the UART isn't doing flow
|
|
|
|
* control, which is currently the case. Hence, if it ever
|
2022-06-13 14:39:05 +03:00
|
|
|
* takes longer than FIFO timeout, this is probably due to a
|
2022-02-28 06:49:11 +01:00
|
|
|
* UART bug of some kind. So, we clamp the timeout parameter at
|
2022-06-13 14:39:05 +03:00
|
|
|
* 2 * FIFO timeout.
|
2022-02-28 06:49:11 +01:00
|
|
|
*/
|
2022-06-13 14:39:05 +03:00
|
|
|
fifo_timeout = uart_fifo_timeout(port);
|
|
|
|
if (timeout == 0 || timeout > 2 * fifo_timeout)
|
|
|
|
timeout = 2 * fifo_timeout;
|
2022-02-28 06:49:11 +01:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
expire = jiffies + timeout;
|
|
|
|
|
2007-05-06 14:48:52 -07:00
|
|
|
pr_debug("uart_wait_until_sent(%d), jiffies=%lu, expire=%lu...\n",
|
2008-02-08 04:18:53 -08:00
|
|
|
port->line, jiffies, expire);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Check whether the transmitter is empty every 'char_time'.
|
|
|
|
* 'timeout' / 'expire' give us the maximum amount of time
|
|
|
|
* we wait.
|
|
|
|
*/
|
|
|
|
while (!port->ops->tx_empty(port)) {
|
|
|
|
msleep_interruptible(jiffies_to_msecs(char_time));
|
|
|
|
if (signal_pending(current))
|
|
|
|
break;
|
2022-02-28 06:49:11 +01:00
|
|
|
if (timeout && time_after(jiffies, expire))
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
}
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(port);
|
2010-06-01 22:53:07 +02:00
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
2012-12-26 20:43:41 -08:00
|
|
|
* Calls to uart_hangup() are serialised by the tty_lock in
|
|
|
|
* drivers/tty/tty_io.c:do_tty_hangup()
|
|
|
|
* This runs from a workqueue and can sleep for a _short_ time only.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
static void uart_hangup(struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = tty->driver_data;
|
2009-09-19 13:13:29 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:35 -07:00
|
|
|
struct uart_port *uport;
|
2010-06-01 22:52:57 +02:00
|
|
|
unsigned long flags;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-01-10 20:23:57 -08:00
|
|
|
pr_debug("uart_hangup(%d)\n", tty->index);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:35 -07:00
|
|
|
uport = uart_port_check(state);
|
|
|
|
WARN(!uport, "hangup of detached port!\n");
|
|
|
|
|
2016-04-09 17:53:22 -07:00
|
|
|
if (tty_port_active(port)) {
|
2005-04-16 15:20:36 -07:00
|
|
|
uart_flush_buffer(tty);
|
2010-06-01 22:52:51 +02:00
|
|
|
uart_shutdown(tty, state);
|
2010-06-01 22:52:57 +02:00
|
|
|
spin_lock_irqsave(&port->lock, flags);
|
2009-09-19 13:13:29 -07:00
|
|
|
port->count = 0;
|
2010-06-01 22:52:57 +02:00
|
|
|
spin_unlock_irqrestore(&port->lock, flags);
|
2023-01-17 11:03:49 +02:00
|
|
|
tty_port_set_active(port, false);
|
2009-09-19 13:13:33 -07:00
|
|
|
tty_port_tty_set(port, NULL);
|
2016-04-09 18:56:35 -07:00
|
|
|
if (uport && !uart_console(uport))
|
serial_core: Fix pm imbalance on unbind
When a serial port is closed, uart_close() takes care of shutting down the
hardware, and powering it down.
When a serial port is unbound while in use, uart_close() bypasses all of
this, as this is supposed to be done through uart_hangup() (invoked via
tty_vhangup() in uart_remove_one_port()).
However, uart_hangup() does not set the hardware's power state, leaving it
powered up. This may also lead to unbounded nesting counts in clock and
power management, depending on their internal implementation.
Make sure to power down the port in uart_hangup(), except when the port is
used as a serial console.
For serial consoles, this operation must be postponed until after the port
becomes completely unused. This case is not fixed yet, as it depends on a
(future) fix for the tty->count vs. port->count imbalance on failed
uart_open().
After this, the module clock used by the sh-sci driver is disabled on
unbind while the serial port is in use.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-27 11:40:39 +01:00
|
|
|
uart_change_pm(state, UART_PM_STATE_OFF);
|
2009-09-19 13:13:29 -07:00
|
|
|
wake_up_interruptible(&port->open_wait);
|
2009-09-19 13:13:31 -07:00
|
|
|
wake_up_interruptible(&port->delta_msr_wait);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2016-04-09 18:56:35 -07:00
|
|
|
/* uport == NULL if uart_port has already been removed */
|
2011-11-09 21:33:50 +01:00
|
|
|
static void uart_port_shutdown(struct tty_port *port)
|
|
|
|
{
|
2011-11-09 21:33:51 +01:00
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport = uart_port_check(state);
|
2011-11-09 21:33:51 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* clear delta_msr_wait queue to avoid mem leaks: we may free
|
|
|
|
* the irq here so the queue might never be woken up. Note
|
|
|
|
* that we won't end up waiting on delta_msr_wait again since
|
|
|
|
* any outstanding file descriptors should be pointing at
|
|
|
|
* hung_up_tty_fops now.
|
|
|
|
*/
|
|
|
|
wake_up_interruptible(&port->delta_msr_wait);
|
|
|
|
|
2021-11-18 08:19:11 +01:00
|
|
|
if (uport) {
|
|
|
|
/* Free the IRQ and disable the port. */
|
2016-04-09 18:56:35 -07:00
|
|
|
uport->ops->shutdown(uport);
|
2011-11-09 21:33:51 +01:00
|
|
|
|
2021-11-18 08:19:11 +01:00
|
|
|
/* Ensure that the IRQ handler isn't running on another CPU. */
|
2016-04-09 18:56:35 -07:00
|
|
|
synchronize_irq(uport->irq);
|
2021-11-18 08:19:11 +01:00
|
|
|
}
|
2011-11-09 21:33:50 +01:00
|
|
|
}
|
|
|
|
|
2023-01-17 11:03:52 +02:00
|
|
|
static bool uart_carrier_raised(struct tty_port *port)
|
2010-06-01 22:52:58 +02:00
|
|
|
{
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *uport;
|
2010-06-01 22:52:58 +02:00
|
|
|
int mctrl;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
|
|
|
|
uport = uart_port_ref(state);
|
|
|
|
/*
|
|
|
|
* Should never observe uport == NULL since checks for hangup should
|
|
|
|
* abort the tty_port_block_til_ready() loop before checking for carrier
|
|
|
|
* raised -- but report carrier raised if it does anyway so open will
|
|
|
|
* continue and not sleep
|
|
|
|
*/
|
|
|
|
if (WARN_ON(!uport))
|
2023-01-17 11:03:52 +02:00
|
|
|
return true;
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2014-06-03 18:54:43 +04:00
|
|
|
uart_enable_ms(uport);
|
2010-06-01 22:52:58 +02:00
|
|
|
mctrl = uport->ops->get_mctrl(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(uport);
|
2023-01-17 11:03:52 +02:00
|
|
|
|
|
|
|
return mctrl & TIOCM_CAR;
|
2010-06-01 22:52:58 +02:00
|
|
|
}
|
|
|
|
|
2023-01-17 11:03:57 +02:00
|
|
|
static void uart_dtr_rts(struct tty_port *port, bool active)
|
2010-06-01 22:52:58 +02:00
|
|
|
{
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
struct uart_port *uport;
|
|
|
|
|
|
|
|
uport = uart_port_ref(state);
|
|
|
|
if (!uport)
|
|
|
|
return;
|
2023-01-17 11:03:57 +02:00
|
|
|
uart_port_dtr_rts(uport, active);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(uport);
|
2010-06-01 22:52:58 +02:00
|
|
|
}
|
|
|
|
|
2019-04-17 10:58:53 +02:00
|
|
|
static int uart_install(struct tty_driver *driver, struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_driver *drv = driver->driver_state;
|
|
|
|
struct uart_state *state = drv->state + tty->index;
|
|
|
|
|
|
|
|
tty->driver_data = state;
|
|
|
|
|
|
|
|
return tty_standard_install(driver, tty);
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
2012-12-26 20:43:41 -08:00
|
|
|
* Calls to uart_open are serialised by the tty_lock in
|
|
|
|
* drivers/tty/tty_io.c:tty_open()
|
2005-04-16 15:20:36 -07:00
|
|
|
* Note that if this fails, then uart_close() _will_ be called.
|
|
|
|
*
|
|
|
|
* In time, we want to scrap the "opening nonpresent ports"
|
|
|
|
* behaviour and implement an alternative way for setserial
|
|
|
|
* to set base addresses/ports/types. This will allow us to
|
|
|
|
* get rid of a certain amount of extra tests.
|
|
|
|
*/
|
|
|
|
static int uart_open(struct tty_struct *tty, struct file *filp)
|
|
|
|
{
|
2019-04-17 10:58:53 +02:00
|
|
|
struct uart_state *state = tty->driver_data;
|
|
|
|
int retval;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-08-22 17:39:09 -05:00
|
|
|
retval = tty_port_open(&state->port, tty, filp);
|
|
|
|
if (retval > 0)
|
|
|
|
retval = 0;
|
2014-10-16 16:54:27 -04:00
|
|
|
|
2016-08-22 17:39:09 -05:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int uart_port_activate(struct tty_port *port, struct tty_struct *tty)
|
|
|
|
{
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
|
|
|
struct uart_port *uport;
|
2019-05-08 13:44:41 +03:00
|
|
|
int ret;
|
2011-11-09 21:33:49 +01:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
uport = uart_port_check(state);
|
2016-08-22 17:39:09 -05:00
|
|
|
if (!uport || uport->flags & UPF_DEAD)
|
|
|
|
return -ENXIO;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Start up the serial port.
|
|
|
|
*/
|
2023-01-17 11:03:51 +02:00
|
|
|
ret = uart_startup(tty, state, false);
|
2019-05-08 13:44:41 +03:00
|
|
|
if (ret > 0)
|
2023-01-17 11:03:49 +02:00
|
|
|
tty_port_set_active(port, true);
|
2019-05-08 13:44:41 +03:00
|
|
|
|
|
|
|
return ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static const char *uart_type(struct uart_port *port)
|
|
|
|
{
|
|
|
|
const char *str = NULL;
|
|
|
|
|
|
|
|
if (port->ops->type)
|
|
|
|
str = port->ops->type(port);
|
|
|
|
|
|
|
|
if (!str)
|
|
|
|
str = "unknown";
|
|
|
|
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
|
|
|
2009-03-31 15:19:21 -07:00
|
|
|
static void uart_line_info(struct seq_file *m, struct uart_driver *drv, int i)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state = drv->state + i;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2012-12-07 11:36:08 +01:00
|
|
|
enum uart_pm_state pm_state;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uport;
|
2005-04-16 15:20:36 -07:00
|
|
|
char stat_buf[32];
|
|
|
|
unsigned int status;
|
2009-03-31 15:19:21 -07:00
|
|
|
int mmio;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_lock(&port->mutex);
|
|
|
|
uport = uart_port_check(state);
|
2009-09-19 13:13:31 -07:00
|
|
|
if (!uport)
|
2016-04-09 18:56:33 -07:00
|
|
|
goto out;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mmio = uport->iotype >= UPIO_MEM;
|
2009-03-31 15:19:21 -07:00
|
|
|
seq_printf(m, "%d: uart:%s %s%08llX irq:%d",
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->line, uart_type(uport),
|
2006-09-04 00:04:20 +04:00
|
|
|
mmio ? "mmio:0x" : "port:",
|
2009-09-19 13:13:31 -07:00
|
|
|
mmio ? (unsigned long long)uport->mapbase
|
|
|
|
: (unsigned long long)uport->iobase,
|
|
|
|
uport->irq);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->type == PORT_UNKNOWN) {
|
2009-03-31 15:19:21 -07:00
|
|
|
seq_putc(m, '\n');
|
2016-04-09 18:56:33 -07:00
|
|
|
goto out;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2008-02-08 04:18:53 -08:00
|
|
|
if (capable(CAP_SYS_ADMIN)) {
|
2007-02-14 00:33:06 -08:00
|
|
|
pm_state = state->pm_state;
|
2012-12-07 11:36:08 +01:00
|
|
|
if (pm_state != UART_PM_STATE_ON)
|
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2009-09-19 13:13:31 -07:00
|
|
|
status = uport->ops->get_mctrl(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2012-12-07 11:36:08 +01:00
|
|
|
if (pm_state != UART_PM_STATE_ON)
|
2007-02-14 00:33:06 -08:00
|
|
|
uart_change_pm(state, pm_state);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-03-31 15:19:21 -07:00
|
|
|
seq_printf(m, " tx:%d rx:%d",
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->icount.tx, uport->icount.rx);
|
|
|
|
if (uport->icount.frame)
|
2016-01-10 20:24:01 -08:00
|
|
|
seq_printf(m, " fe:%d", uport->icount.frame);
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->icount.parity)
|
2016-01-10 20:24:01 -08:00
|
|
|
seq_printf(m, " pe:%d", uport->icount.parity);
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->icount.brk)
|
2016-01-10 20:24:01 -08:00
|
|
|
seq_printf(m, " brk:%d", uport->icount.brk);
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->icount.overrun)
|
2016-01-10 20:24:01 -08:00
|
|
|
seq_printf(m, " oe:%d", uport->icount.overrun);
|
2018-03-21 10:52:38 +08:00
|
|
|
if (uport->icount.buf_overrun)
|
|
|
|
seq_printf(m, " bo:%d", uport->icount.buf_overrun);
|
2008-02-08 04:18:53 -08:00
|
|
|
|
|
|
|
#define INFOBIT(bit, str) \
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->mctrl & (bit)) \
|
2005-04-16 15:20:36 -07:00
|
|
|
strncat(stat_buf, (str), sizeof(stat_buf) - \
|
|
|
|
strlen(stat_buf) - 2)
|
2008-02-08 04:18:53 -08:00
|
|
|
#define STATBIT(bit, str) \
|
2005-04-16 15:20:36 -07:00
|
|
|
if (status & (bit)) \
|
|
|
|
strncat(stat_buf, (str), sizeof(stat_buf) - \
|
|
|
|
strlen(stat_buf) - 2)
|
|
|
|
|
|
|
|
stat_buf[0] = '\0';
|
|
|
|
stat_buf[1] = '\0';
|
|
|
|
INFOBIT(TIOCM_RTS, "|RTS");
|
|
|
|
STATBIT(TIOCM_CTS, "|CTS");
|
|
|
|
INFOBIT(TIOCM_DTR, "|DTR");
|
|
|
|
STATBIT(TIOCM_DSR, "|DSR");
|
|
|
|
STATBIT(TIOCM_CAR, "|CD");
|
|
|
|
STATBIT(TIOCM_RNG, "|RI");
|
|
|
|
if (stat_buf[0])
|
|
|
|
stat_buf[0] = ' ';
|
2008-02-08 04:18:53 -08:00
|
|
|
|
2009-03-31 15:19:21 -07:00
|
|
|
seq_puts(m, stat_buf);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2009-03-31 15:19:21 -07:00
|
|
|
seq_putc(m, '\n');
|
2005-04-16 15:20:36 -07:00
|
|
|
#undef STATBIT
|
|
|
|
#undef INFOBIT
|
2016-04-09 18:56:33 -07:00
|
|
|
out:
|
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2009-03-31 15:19:21 -07:00
|
|
|
static int uart_proc_show(struct seq_file *m, void *v)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-04-02 01:30:04 +04:00
|
|
|
struct tty_driver *ttydrv = m->private;
|
2005-04-16 15:20:36 -07:00
|
|
|
struct uart_driver *drv = ttydrv->driver_state;
|
2009-03-31 15:19:21 -07:00
|
|
|
int i;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-01-10 20:24:01 -08:00
|
|
|
seq_printf(m, "serinfo:1.0 driver%s%s revision:%s\n", "", "", "");
|
2009-03-31 15:19:21 -07:00
|
|
|
for (i = 0; i < drv->nr; i++)
|
|
|
|
uart_line_info(m, drv, i);
|
|
|
|
return 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2020-09-09 16:31:01 +02:00
|
|
|
static void uart_port_spin_lock_init(struct uart_port *port)
|
2020-07-07 00:49:03 +03:00
|
|
|
{
|
|
|
|
spin_lock_init(&port->lock);
|
|
|
|
lockdep_set_class(&port->lock, &port_lock_key);
|
|
|
|
}
|
|
|
|
|
2008-03-07 15:51:16 -08:00
|
|
|
#if defined(CONFIG_SERIAL_CORE_CONSOLE) || defined(CONFIG_CONSOLE_POLL)
|
2015-03-09 16:27:13 -04:00
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_console_write - write a console message to a serial port
|
|
|
|
* @port: the port to write the message
|
|
|
|
* @s: array of characters
|
|
|
|
* @count: number of characters in string to write
|
|
|
|
* @putchar: function to write character to port
|
2006-03-20 20:00:09 +00:00
|
|
|
*/
|
|
|
|
void uart_console_write(struct uart_port *port, const char *s,
|
|
|
|
unsigned int count,
|
2022-03-03 09:08:31 +01:00
|
|
|
void (*putchar)(struct uart_port *, unsigned char))
|
2006-03-20 20:00:09 +00:00
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < count; i++, s++) {
|
|
|
|
if (*s == '\n')
|
|
|
|
putchar(port, '\r');
|
|
|
|
putchar(port, *s);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_console_write);
|
|
|
|
|
2022-07-28 08:10:56 +02:00
|
|
|
/**
|
|
|
|
* uart_get_console - get uart port for console
|
|
|
|
* @ports: ports to search in
|
|
|
|
* @nr: number of @ports
|
|
|
|
* @co: console to search for
|
|
|
|
* Returns: uart_port for the console @co
|
|
|
|
*
|
|
|
|
* Check whether an invalid uart number has been specified (as @co->index), and
|
|
|
|
* if so, search for the first available port that does have console support.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
struct uart_port * __init
|
|
|
|
uart_get_console(struct uart_port *ports, int nr, struct console *co)
|
|
|
|
{
|
|
|
|
int idx = co->index;
|
|
|
|
|
|
|
|
if (idx < 0 || idx >= nr || (ports[idx].iobase == 0 &&
|
|
|
|
ports[idx].membase == NULL))
|
|
|
|
for (idx = 0; idx < nr; idx++)
|
|
|
|
if (ports[idx].iobase != 0 ||
|
|
|
|
ports[idx].membase != NULL)
|
|
|
|
break;
|
|
|
|
|
|
|
|
co->index = idx;
|
|
|
|
|
|
|
|
return ports + idx;
|
|
|
|
}
|
|
|
|
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_parse_earlycon - Parse earlycon options
|
|
|
|
* @p: ptr to 2nd field (ie., just beyond '<name>,')
|
|
|
|
* @iotype: ptr for decoded iotype (out)
|
|
|
|
* @addr: ptr for decoded mapbase/iobase (out)
|
|
|
|
* @options: ptr for <options> field; %NULL if not present (out)
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Decodes earlycon kernel command line parameters of the form:
|
|
|
|
* * earlycon=<name>,io|mmio|mmio16|mmio32|mmio32be|mmio32native,<addr>,<options>
|
|
|
|
* * console=<name>,io|mmio|mmio16|mmio32|mmio32be|mmio32native,<addr>,<options>
|
2019-10-08 13:46:53 -07:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* The optional form:
|
|
|
|
* * earlycon=<name>,0x<addr>,<options>
|
|
|
|
* * console=<name>,0x<addr>,<options>
|
2019-10-08 13:46:53 -07:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* is also accepted; the returned @iotype will be %UPIO_MEM.
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Returns: 0 on success or -%EINVAL on failure
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
*/
|
2016-09-02 13:20:21 +02:00
|
|
|
int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
char **options)
|
|
|
|
{
|
|
|
|
if (strncmp(p, "mmio,", 5) == 0) {
|
|
|
|
*iotype = UPIO_MEM;
|
|
|
|
p += 5;
|
2015-10-28 12:46:05 +09:00
|
|
|
} else if (strncmp(p, "mmio16,", 7) == 0) {
|
|
|
|
*iotype = UPIO_MEM16;
|
|
|
|
p += 7;
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
} else if (strncmp(p, "mmio32,", 7) == 0) {
|
|
|
|
*iotype = UPIO_MEM32;
|
|
|
|
p += 7;
|
2015-05-25 06:54:28 +03:00
|
|
|
} else if (strncmp(p, "mmio32be,", 9) == 0) {
|
|
|
|
*iotype = UPIO_MEM32BE;
|
|
|
|
p += 9;
|
2015-09-22 15:20:32 +03:00
|
|
|
} else if (strncmp(p, "mmio32native,", 13) == 0) {
|
|
|
|
*iotype = IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) ?
|
|
|
|
UPIO_MEM32BE : UPIO_MEM32;
|
|
|
|
p += 13;
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
} else if (strncmp(p, "io,", 3) == 0) {
|
|
|
|
*iotype = UPIO_PORT;
|
|
|
|
p += 3;
|
|
|
|
} else if (strncmp(p, "0x", 2) == 0) {
|
|
|
|
*iotype = UPIO_MEM;
|
|
|
|
} else {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2016-09-12 13:29:29 +02:00
|
|
|
/*
|
|
|
|
* Before you replace it with kstrtoull(), think about options separator
|
|
|
|
* (',') it will not tolerate
|
|
|
|
*/
|
|
|
|
*addr = simple_strtoull(p, NULL, 0);
|
serial: earlycon: Refactor parse_options into serial core
Prepare to support console-defined matching; refactor the command
line parameter string processing from parse_options() into a
new core function, uart_parse_earlycon(), which decodes command line
parameters of the form:
earlycon=<name>,io|mmio|mmio32,<addr>,<options>
console=<name>,io|mmio|mmio32,<addr>,<options>
earlycon=<name>,0x<addr>,<options>
console=<name>,0x<addr>,<options>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-01 11:05:46 -05:00
|
|
|
p = strchr(p, ',');
|
|
|
|
if (p)
|
|
|
|
p++;
|
|
|
|
|
|
|
|
*options = p;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_parse_earlycon);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_parse_options - Parse serial port baud/parity/bits/flow control.
|
|
|
|
* @options: pointer to option string
|
|
|
|
* @baud: pointer to an 'int' variable for the baud rate.
|
|
|
|
* @parity: pointer to an 'int' variable for the parity.
|
|
|
|
* @bits: pointer to an 'int' variable for the number of data bits.
|
|
|
|
* @flow: pointer to an 'int' variable for the flow control character.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_parse_options() decodes a string containing the serial console
|
|
|
|
* options. The format of the string is <baud><parity><bits><flow>,
|
|
|
|
* eg: 115200n8r
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2008-04-17 20:05:37 +02:00
|
|
|
void
|
2017-12-28 14:07:07 +01:00
|
|
|
uart_parse_options(const char *options, int *baud, int *parity,
|
|
|
|
int *bits, int *flow)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2017-12-28 14:07:07 +01:00
|
|
|
const char *s = options;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
*baud = simple_strtoul(s, NULL, 10);
|
|
|
|
while (*s >= '0' && *s <= '9')
|
|
|
|
s++;
|
|
|
|
if (*s)
|
|
|
|
*parity = *s++;
|
|
|
|
if (*s)
|
|
|
|
*bits = *s++ - '0';
|
|
|
|
if (*s)
|
|
|
|
*flow = *s;
|
|
|
|
}
|
2008-04-17 20:05:37 +02:00
|
|
|
EXPORT_SYMBOL_GPL(uart_parse_options);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_set_options - setup the serial console parameters
|
|
|
|
* @port: pointer to the serial ports uart_port structure
|
|
|
|
* @co: console pointer
|
|
|
|
* @baud: baud rate
|
|
|
|
* @parity: parity character - 'n' (none), 'o' (odd), 'e' (even)
|
|
|
|
* @bits: number of data bits
|
|
|
|
* @flow: flow control character - 'r' (rts)
|
2023-01-12 17:18:13 +01:06
|
|
|
*
|
|
|
|
* Locking: Caller must hold console_list_lock in order to serialize
|
|
|
|
* early initialization of the serial-console lock.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2008-04-17 20:05:37 +02:00
|
|
|
int
|
2005-04-16 15:20:36 -07:00
|
|
|
uart_set_options(struct uart_port *port, struct console *co,
|
|
|
|
int baud, int parity, int bits, int flow)
|
|
|
|
{
|
2006-12-08 02:38:45 -08:00
|
|
|
struct ktermios termios;
|
2007-10-18 01:24:16 -07:00
|
|
|
static struct ktermios dummy;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2020-09-09 16:31:01 +02:00
|
|
|
/*
|
|
|
|
* Ensure that the serial-console lock is initialised early.
|
|
|
|
*
|
2022-11-16 17:27:34 +01:06
|
|
|
* Note that the console-registered check is needed because
|
|
|
|
* kgdboc can call uart_set_options() for an already registered
|
2020-09-09 16:31:01 +02:00
|
|
|
* console via tty_find_polling_driver() and uart_poll_init().
|
|
|
|
*/
|
2022-11-16 17:27:34 +01:06
|
|
|
if (!uart_console_registered_locked(port) && !port->console_reinit)
|
2020-09-09 16:31:01 +02:00
|
|
|
uart_port_spin_lock_init(port);
|
2005-07-03 21:05:45 +01:00
|
|
|
|
2006-12-08 02:38:45 -08:00
|
|
|
memset(&termios, 0, sizeof(struct ktermios));
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-01-04 15:54:46 +08:00
|
|
|
termios.c_cflag |= CREAD | HUPCL | CLOCAL;
|
|
|
|
tty_termios_encode_baud_rate(&termios, baud, baud);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (bits == 7)
|
|
|
|
termios.c_cflag |= CS7;
|
|
|
|
else
|
|
|
|
termios.c_cflag |= CS8;
|
|
|
|
|
|
|
|
switch (parity) {
|
|
|
|
case 'o': case 'O':
|
|
|
|
termios.c_cflag |= PARODD;
|
2020-08-23 17:36:59 -05:00
|
|
|
fallthrough;
|
2005-04-16 15:20:36 -07:00
|
|
|
case 'e': case 'E':
|
|
|
|
termios.c_cflag |= PARENB;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (flow == 'r')
|
|
|
|
termios.c_cflag |= CRTSCTS;
|
|
|
|
|
2007-07-15 23:37:25 -07:00
|
|
|
/*
|
|
|
|
* some uarts on other side don't support no flow control.
|
|
|
|
* So we set * DTR in host uart to make them happy
|
|
|
|
*/
|
|
|
|
port->mctrl |= TIOCM_DTR;
|
|
|
|
|
2007-10-18 01:24:16 -07:00
|
|
|
port->ops->set_termios(port, &termios, &dummy);
|
2008-04-17 20:05:37 +02:00
|
|
|
/*
|
|
|
|
* Allow the setting of the UART parameters with a NULL console
|
|
|
|
* too:
|
|
|
|
*/
|
2021-10-02 15:09:00 +02:00
|
|
|
if (co) {
|
2008-04-17 20:05:37 +02:00
|
|
|
co->cflag = termios.c_cflag;
|
2021-10-02 15:09:00 +02:00
|
|
|
co->ispeed = termios.c_ispeed;
|
|
|
|
co->ospeed = termios.c_ospeed;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2008-04-17 20:05:37 +02:00
|
|
|
EXPORT_SYMBOL_GPL(uart_set_options);
|
2005-04-16 15:20:36 -07:00
|
|
|
#endif /* CONFIG_SERIAL_CORE_CONSOLE */
|
|
|
|
|
2011-11-09 21:33:47 +01:00
|
|
|
/**
|
|
|
|
* uart_change_pm - set power state of the port
|
|
|
|
*
|
|
|
|
* @state: port descriptor
|
|
|
|
* @pm_state: new state
|
|
|
|
*
|
|
|
|
* Locking: port->mutex has to be held
|
|
|
|
*/
|
2012-12-07 11:36:08 +01:00
|
|
|
static void uart_change_pm(struct uart_state *state,
|
|
|
|
enum uart_pm_state pm_state)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *port = uart_port_check(state);
|
2006-05-16 11:28:49 +01:00
|
|
|
|
|
|
|
if (state->pm_state != pm_state) {
|
2016-04-09 18:56:33 -07:00
|
|
|
if (port && port->ops->pm)
|
2006-05-16 11:28:49 +01:00
|
|
|
port->ops->pm(port, pm_state, state->pm_state);
|
|
|
|
state->pm_state = pm_state;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
struct uart_match {
|
|
|
|
struct uart_port *port;
|
|
|
|
struct uart_driver *driver;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int serial_match_port(struct device *dev, void *data)
|
|
|
|
{
|
|
|
|
struct uart_match *match = data;
|
2008-07-04 09:59:28 -07:00
|
|
|
struct tty_driver *tty_drv = match->driver->tty_driver;
|
|
|
|
dev_t devt = MKDEV(tty_drv->major, tty_drv->minor_start) +
|
|
|
|
match->port->line;
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
|
|
|
|
return dev->devt == devt; /* Actually, only one tty per port */
|
|
|
|
}
|
|
|
|
|
2009-09-19 13:13:30 -07:00
|
|
|
int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-09-19 13:13:30 -07:00
|
|
|
struct uart_state *state = drv->state + uport->line;
|
|
|
|
struct tty_port *port = &state->port;
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
struct device *tty_dev;
|
2009-09-19 13:13:30 -07:00
|
|
|
struct uart_match match = {uport, drv};
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-11-13 10:07:52 +02:00
|
|
|
tty_dev = device_find_child(&uport->port_dev->dev, &match, serial_match_port);
|
2017-05-11 12:56:14 +02:00
|
|
|
if (tty_dev && device_may_wakeup(tty_dev)) {
|
2017-08-13 17:47:42 +03:00
|
|
|
enable_irq_wake(uport->irq);
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
put_device(tty_dev);
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
return 0;
|
|
|
|
}
|
2013-04-15 16:01:07 +02:00
|
|
|
put_device(tty_dev);
|
|
|
|
|
2022-05-16 14:50:10 +05:30
|
|
|
/*
|
|
|
|
* Nothing to do if the console is not suspending
|
|
|
|
* except stop_rx to prevent any asynchronous data
|
2022-06-08 00:22:44 +05:30
|
|
|
* over RX line. However ensure that we will be
|
|
|
|
* able to Re-start_rx later.
|
2022-05-16 14:50:10 +05:30
|
|
|
*/
|
|
|
|
if (!console_suspend_enabled && uart_console(uport)) {
|
2023-05-25 11:37:53 +02:06
|
|
|
if (uport->ops->start_rx) {
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2022-06-08 00:22:44 +05:30
|
|
|
uport->ops->stop_rx(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2023-05-25 11:37:53 +02:06
|
|
|
}
|
2015-01-22 12:24:25 -05:00
|
|
|
goto unlock;
|
2022-05-16 14:50:10 +05:30
|
|
|
}
|
2015-01-22 12:24:25 -05:00
|
|
|
|
|
|
|
uport->suspended = 1;
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
|
2016-04-09 17:53:25 -07:00
|
|
|
if (tty_port_initialized(port)) {
|
2009-09-19 13:13:30 -07:00
|
|
|
const struct uart_ops *ops = uport->ops;
|
2008-02-04 22:27:52 -08:00
|
|
|
int tries;
|
2022-03-24 10:56:20 -04:00
|
|
|
unsigned int mctrl;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-01-17 11:03:48 +02:00
|
|
|
tty_port_set_suspended(port, true);
|
2023-01-17 11:03:47 +02:00
|
|
|
tty_port_set_initialized(port, false);
|
2006-10-01 17:17:40 +01:00
|
|
|
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2015-01-22 12:24:25 -05:00
|
|
|
ops->stop_tx(uport);
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (!(uport->rs485.flags & SER_RS485_ENABLED))
|
|
|
|
ops->set_mctrl(uport, 0);
|
2022-03-24 10:56:20 -04:00
|
|
|
/* save mctrl so it can be restored on resume */
|
|
|
|
mctrl = uport->mctrl;
|
|
|
|
uport->mctrl = 0;
|
2015-01-22 12:24:25 -05:00
|
|
|
ops->stop_rx(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Wait for the transmitter to empty.
|
|
|
|
*/
|
2009-09-19 13:13:30 -07:00
|
|
|
for (tries = 3; !ops->tx_empty(uport) && tries; tries--)
|
2005-04-16 15:20:36 -07:00
|
|
|
msleep(10);
|
2008-02-04 22:27:52 -08:00
|
|
|
if (!tries)
|
2017-03-31 21:35:18 +03:00
|
|
|
dev_err(uport->dev, "%s: Unable to drain transmitter\n",
|
|
|
|
uport->name);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2015-01-22 12:24:25 -05:00
|
|
|
ops->shutdown(uport);
|
2022-03-24 10:56:20 -04:00
|
|
|
uport->mctrl = mctrl;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Disable the console device before suspending.
|
|
|
|
*/
|
2015-01-22 12:24:25 -05:00
|
|
|
if (uart_console(uport))
|
2009-09-19 13:13:30 -07:00
|
|
|
console_stop(uport->cons);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2015-01-22 12:24:25 -05:00
|
|
|
uart_change_pm(state, UART_PM_STATE_OFF);
|
|
|
|
unlock:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2022-01-24 08:14:20 +01:00
|
|
|
EXPORT_SYMBOL(uart_suspend_port);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:30 -07:00
|
|
|
int uart_resume_port(struct uart_driver *drv, struct uart_port *uport)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-09-19 13:13:30 -07:00
|
|
|
struct uart_state *state = drv->state + uport->line;
|
|
|
|
struct tty_port *port = &state->port;
|
2008-05-23 13:04:49 -07:00
|
|
|
struct device *tty_dev;
|
2009-09-19 13:13:30 -07:00
|
|
|
struct uart_match match = {uport, drv};
|
2009-09-19 13:13:33 -07:00
|
|
|
struct ktermios termios;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-11-13 10:07:52 +02:00
|
|
|
tty_dev = device_find_child(&uport->port_dev->dev, &match, serial_match_port);
|
2009-09-19 13:13:30 -07:00
|
|
|
if (!uport->suspended && device_may_wakeup(tty_dev)) {
|
2017-08-13 17:47:42 +03:00
|
|
|
if (irqd_is_wakeup_set(irq_get_irq_data((uport->irq))))
|
2010-12-16 18:12:47 +05:30
|
|
|
disable_irq_wake(uport->irq);
|
2013-04-15 16:01:07 +02:00
|
|
|
put_device(tty_dev);
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
return 0;
|
|
|
|
}
|
2013-04-15 16:01:07 +02:00
|
|
|
put_device(tty_dev);
|
2009-09-19 13:13:30 -07:00
|
|
|
uport->suspended = 0;
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Re-enable the console device after suspending.
|
|
|
|
*/
|
serial-core: reset the console speed on resume
On some platforms, we need to restore the console speed on resume even
it was not suspended (no_console_suspend), and on others we don't have
to do that.
So don't care about the "console_suspend_enabled" and unconditionally
reset the console speed if it is a console.
This is actually a redo of ba15ab0 (Set proper console speed on resume
if console suspend is disabled) from Deepak Saxena. I also tried to
investigate more to find out if this change will break others, here is
what I've found out:
commit 891b9dd10764352926e1e107756aa229dfa2c210
Author: Jason Wang <jason77.wang@gmail.com>
serial-core: restore termios settings when resume console ports
commit ca2e71aa8cfb0056ce720f3fd53f59f5fac4a3e1
Author: Jason Wang <jason77.wang@gmail.com>
serial-core: skip call set_termios/console_start when no_console_suspend
commit 4547be7809a3b775ce750ec7f8b5748954741523
Author: Stanislav Brabec <sbrabec@suse.cz>
serial-core: resume serial hardware with no_console_suspend
commit ba15ab0e8de0d4439a91342ad52d55ca9e313f3d
Author: Deepak Saxena <dsaxena@laptop.org>
Set proper console speed on resume if console suspend is disabled
from ba15ab0, we learned that, even if the console suspend is disabled
(when no_console_suspend is set), we may still need to "reset the port
to the state it was in before we suspended."
Then with 4547be7, this piece of code is removed.
And then Jason Wang added that back in ca2e71a and 891b9dd, to fix
some breakage on OMAP3EVM platform. From ca2e71a we learned that the
"set_termios" things is actually needed by both console is suspended
and not suspended.
That's why I removed the console_suspended_enabled condition, and only
call console_start() when we actually suspeneded it.
I also noticed in this thread:
http://marc.info/?t=129079257100004&r=1&w=2, which talked about on
some platforms, UART HW will be cut power whether or not we set
no_console_suspend, and then on resume it does not work quite well. I
have a similar HW, and this patch fixed this issue, don't know if this
patch also works on their platforms.
[Update: Stanislav tested this patch on Zaurus and reported it improves the
situation. Thanks.]
CC: Greg KH <greg@kroah.com>
CC: Deepak Saxena <dsaxena@laptop.org>
CC: Jason Wang <jason77.wang@gmail.com>
CC: Stanislav Brabec <sbrabec@suse.cz>
CC: Daniel Drake <dsd@laptop.org>
Signed-off-by: Yin Kangkai <kangkai.yin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-01-30 11:15:30 +08:00
|
|
|
if (uart_console(uport)) {
|
serial-core: restore termios settings when resume console ports
The commit 4547be7 rewrites suspend and resume functions. According
to this rewrite, when a serial port is a printk console device and
can suspend(without set no_console_suspend flag), it will definitely
call set_termios function during its resume, but parameter termios
isn't initialized, this will pass an unpredictable config to the
serial port. If this serial port is not a userspace opened tty device
, a suspend and resume action will make this serial port unusable.
I.E. ttyS0 is a printk console device, ttyS1 or keyboard+display is
userspace tty device, a suspend/resume action will make ttyS0
unusable.
If a serial port is both a printk console device and an opened tty
device, this issue can be overcome because it will call set_termios
again with the correct parameter in the uart_change_speed function.
Refer to the deleted content of commit 4547be7, revert parts relate
to restore settings into parameter termios. It is safe because if
a serial port is a printk console only device, the only meaningful
field in termios is c_cflag and its old config is saved in
uport->cons->cflag, if this port is also an opened tty device,
it will clear uport->cons->cflag in the uart_open and the old config
is saved in tty->termios.
Signed-off-by: Jason Wang <jason77.wang@gmail.com>
Acked-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-21 15:14:42 +08:00
|
|
|
/*
|
|
|
|
* First try to use the console cflag setting.
|
|
|
|
*/
|
|
|
|
memset(&termios, 0, sizeof(struct ktermios));
|
|
|
|
termios.c_cflag = uport->cons->cflag;
|
2021-10-02 15:09:00 +02:00
|
|
|
termios.c_ispeed = uport->cons->ispeed;
|
|
|
|
termios.c_ospeed = uport->cons->ospeed;
|
serial-core: restore termios settings when resume console ports
The commit 4547be7 rewrites suspend and resume functions. According
to this rewrite, when a serial port is a printk console device and
can suspend(without set no_console_suspend flag), it will definitely
call set_termios function during its resume, but parameter termios
isn't initialized, this will pass an unpredictable config to the
serial port. If this serial port is not a userspace opened tty device
, a suspend and resume action will make this serial port unusable.
I.E. ttyS0 is a printk console device, ttyS1 or keyboard+display is
userspace tty device, a suspend/resume action will make ttyS0
unusable.
If a serial port is both a printk console device and an opened tty
device, this issue can be overcome because it will call set_termios
again with the correct parameter in the uart_change_speed function.
Refer to the deleted content of commit 4547be7, revert parts relate
to restore settings into parameter termios. It is safe because if
a serial port is a printk console only device, the only meaningful
field in termios is c_cflag and its old config is saved in
uport->cons->cflag, if this port is also an opened tty device,
it will clear uport->cons->cflag in the uart_open and the old config
is saved in tty->termios.
Signed-off-by: Jason Wang <jason77.wang@gmail.com>
Acked-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-21 15:14:42 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If that's unset, use the tty termios setting.
|
|
|
|
*/
|
2012-07-14 15:31:47 +01:00
|
|
|
if (port->tty && termios.c_cflag == 0)
|
|
|
|
termios = port->tty->termios;
|
serial-core: restore termios settings when resume console ports
The commit 4547be7 rewrites suspend and resume functions. According
to this rewrite, when a serial port is a printk console device and
can suspend(without set no_console_suspend flag), it will definitely
call set_termios function during its resume, but parameter termios
isn't initialized, this will pass an unpredictable config to the
serial port. If this serial port is not a userspace opened tty device
, a suspend and resume action will make this serial port unusable.
I.E. ttyS0 is a printk console device, ttyS1 or keyboard+display is
userspace tty device, a suspend/resume action will make ttyS0
unusable.
If a serial port is both a printk console device and an opened tty
device, this issue can be overcome because it will call set_termios
again with the correct parameter in the uart_change_speed function.
Refer to the deleted content of commit 4547be7, revert parts relate
to restore settings into parameter termios. It is safe because if
a serial port is a printk console only device, the only meaningful
field in termios is c_cflag and its old config is saved in
uport->cons->cflag, if this port is also an opened tty device,
it will clear uport->cons->cflag in the uart_open and the old config
is saved in tty->termios.
Signed-off-by: Jason Wang <jason77.wang@gmail.com>
Acked-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-21 15:14:42 +08:00
|
|
|
|
2011-09-05 16:28:18 +08:00
|
|
|
if (console_suspend_enabled)
|
2012-12-07 11:36:08 +01:00
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
2009-09-19 13:13:30 -07:00
|
|
|
uport->ops->set_termios(uport, &termios, NULL);
|
2023-05-25 11:37:55 +02:06
|
|
|
if (!console_suspend_enabled && uport->ops->start_rx) {
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
2022-06-08 00:22:44 +05:30
|
|
|
uport->ops->start_rx(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2023-05-25 11:37:55 +02:06
|
|
|
}
|
serial-core: reset the console speed on resume
On some platforms, we need to restore the console speed on resume even
it was not suspended (no_console_suspend), and on others we don't have
to do that.
So don't care about the "console_suspend_enabled" and unconditionally
reset the console speed if it is a console.
This is actually a redo of ba15ab0 (Set proper console speed on resume
if console suspend is disabled) from Deepak Saxena. I also tried to
investigate more to find out if this change will break others, here is
what I've found out:
commit 891b9dd10764352926e1e107756aa229dfa2c210
Author: Jason Wang <jason77.wang@gmail.com>
serial-core: restore termios settings when resume console ports
commit ca2e71aa8cfb0056ce720f3fd53f59f5fac4a3e1
Author: Jason Wang <jason77.wang@gmail.com>
serial-core: skip call set_termios/console_start when no_console_suspend
commit 4547be7809a3b775ce750ec7f8b5748954741523
Author: Stanislav Brabec <sbrabec@suse.cz>
serial-core: resume serial hardware with no_console_suspend
commit ba15ab0e8de0d4439a91342ad52d55ca9e313f3d
Author: Deepak Saxena <dsaxena@laptop.org>
Set proper console speed on resume if console suspend is disabled
from ba15ab0, we learned that, even if the console suspend is disabled
(when no_console_suspend is set), we may still need to "reset the port
to the state it was in before we suspended."
Then with 4547be7, this piece of code is removed.
And then Jason Wang added that back in ca2e71a and 891b9dd, to fix
some breakage on OMAP3EVM platform. From ca2e71a we learned that the
"set_termios" things is actually needed by both console is suspended
and not suspended.
That's why I removed the console_suspended_enabled condition, and only
call console_start() when we actually suspeneded it.
I also noticed in this thread:
http://marc.info/?t=129079257100004&r=1&w=2, which talked about on
some platforms, UART HW will be cut power whether or not we set
no_console_suspend, and then on resume it does not work quite well. I
have a similar HW, and this patch fixed this issue, don't know if this
patch also works on their platforms.
[Update: Stanislav tested this patch on Zaurus and reported it improves the
situation. Thanks.]
CC: Greg KH <greg@kroah.com>
CC: Deepak Saxena <dsaxena@laptop.org>
CC: Jason Wang <jason77.wang@gmail.com>
CC: Stanislav Brabec <sbrabec@suse.cz>
CC: Daniel Drake <dsd@laptop.org>
Signed-off-by: Yin Kangkai <kangkai.yin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-01-30 11:15:30 +08:00
|
|
|
if (console_suspend_enabled)
|
|
|
|
console_start(uport->cons);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2016-04-09 17:53:24 -07:00
|
|
|
if (tty_port_suspended(port)) {
|
2009-09-19 13:13:30 -07:00
|
|
|
const struct uart_ops *ops = uport->ops;
|
2005-11-13 15:28:51 +00:00
|
|
|
int ret;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2012-12-07 11:36:08 +01:00
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (!(uport->rs485.flags & SER_RS485_ENABLED))
|
|
|
|
ops->set_mctrl(uport, 0);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2009-12-02 16:20:56 +01:00
|
|
|
if (console_suspend_enabled || !uart_console(uport)) {
|
2010-06-01 22:52:51 +02:00
|
|
|
/* Protected by port mutex for now */
|
|
|
|
struct tty_struct *tty = port->tty;
|
2020-07-16 17:24:38 +05:30
|
|
|
|
2009-12-02 16:20:56 +01:00
|
|
|
ret = ops->startup(uport);
|
|
|
|
if (ret == 0) {
|
2010-06-01 22:52:51 +02:00
|
|
|
if (tty)
|
2023-03-09 10:09:20 +02:00
|
|
|
uart_change_line_settings(tty, state, NULL);
|
2023-09-21 16:52:33 +02:00
|
|
|
uart_rs485_config(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irq(uport);
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (!(uport->rs485.flags & SER_RS485_ENABLED))
|
|
|
|
ops->set_mctrl(uport, uport->mctrl);
|
2009-12-02 16:20:56 +01:00
|
|
|
ops->start_tx(uport);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irq(uport);
|
2023-01-17 11:03:47 +02:00
|
|
|
tty_port_set_initialized(port, true);
|
2009-12-02 16:20:56 +01:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Failed to resume - maybe hardware went away?
|
|
|
|
* Clear the "initialized" flag so we won't try
|
|
|
|
* to call the low level drivers shutdown method.
|
|
|
|
*/
|
2010-06-01 22:52:51 +02:00
|
|
|
uart_shutdown(tty, state);
|
2009-12-02 16:20:56 +01:00
|
|
|
}
|
2005-11-13 15:28:51 +00:00
|
|
|
}
|
2006-10-01 17:17:40 +01:00
|
|
|
|
2023-01-17 11:03:48 +02:00
|
|
|
tty_port_set_suspended(port, false);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2022-01-24 08:14:20 +01:00
|
|
|
EXPORT_SYMBOL(uart_resume_port);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
static inline void
|
|
|
|
uart_report_port(struct uart_driver *drv, struct uart_port *port)
|
|
|
|
{
|
2005-09-03 15:30:21 +01:00
|
|
|
char address[64];
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
switch (port->iotype) {
|
|
|
|
case UPIO_PORT:
|
2008-10-13 10:35:42 +01:00
|
|
|
snprintf(address, sizeof(address), "I/O 0x%lx", port->iobase);
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
case UPIO_HUB6:
|
2005-09-03 15:30:21 +01:00
|
|
|
snprintf(address, sizeof(address),
|
2008-10-13 10:35:42 +01:00
|
|
|
"I/O 0x%lx offset 0x%x", port->iobase, port->hub6);
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
case UPIO_MEM:
|
2015-10-28 12:46:05 +09:00
|
|
|
case UPIO_MEM16:
|
2005-04-16 15:20:36 -07:00
|
|
|
case UPIO_MEM32:
|
2014-11-12 12:53:59 -08:00
|
|
|
case UPIO_MEM32BE:
|
2005-11-06 09:07:03 +00:00
|
|
|
case UPIO_AU:
|
2006-06-30 02:29:58 -07:00
|
|
|
case UPIO_TSI:
|
2005-09-03 15:30:21 +01:00
|
|
|
snprintf(address, sizeof(address),
|
2007-07-23 18:43:44 -07:00
|
|
|
"MMIO 0x%llx", (unsigned long long)port->mapbase);
|
2005-09-03 15:30:21 +01:00
|
|
|
break;
|
|
|
|
default:
|
2022-08-18 23:01:12 +02:00
|
|
|
strscpy(address, "*unknown*", sizeof(address));
|
2005-04-16 15:20:36 -07:00
|
|
|
break;
|
|
|
|
}
|
2005-09-03 15:30:21 +01:00
|
|
|
|
2017-03-31 21:35:18 +03:00
|
|
|
pr_info("%s%s%s at %s (irq = %d, base_baud = %d) is a %s\n",
|
2015-01-02 10:05:13 -08:00
|
|
|
port->dev ? dev_name(port->dev) : "",
|
|
|
|
port->dev ? ": " : "",
|
2017-03-31 21:35:18 +03:00
|
|
|
port->name,
|
2013-07-12 13:07:39 -07:00
|
|
|
address, port->irq, port->uartclk / 16, uart_type(port));
|
serial: core: Report magic multiplier extra baud rates
Report extra baud rates supported above the base rate for ports with the
UPF_MAGIC_MULTIPLIER property, so that people have a way to find out
that they can be used with their system, e.g.:
Serial: 8250/16550 driver, 5 ports, IRQ sharing enabled
printk: console [ttyS0] disabled
serial8250.0: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
serial8250.0: ttyS0 extra baud rates supported: 230400, 460800
printk: console [ttyS0] enabled
printk: bootconsole [uart8250] disabled
serial8250.0: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
serial8250.0: ttyS1 extra baud rates supported: 230400, 460800
serial8250.0: ttyS2 at MMIO 0x1f000900 (irq = 20, base_baud = 230400) is a 16550A
Otherwise there is no clear way to figure this out, as the feature is
only reported as an obscure TTY flag in bit 16:
$ cat /sys/class/tty/ttyS[0-2]/flags
0x10010040
0x10010040
0x90000040
$
Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Link: https://lore.kernel.org/r/alpine.DEB.2.21.2106260334170.37803@angie.orcam.me.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-26 06:11:21 +02:00
|
|
|
|
|
|
|
/* The magic multiplier feature is a bit obscure, so report it too. */
|
|
|
|
if (port->flags & UPF_MAGIC_MULTIPLIER)
|
|
|
|
pr_info("%s%s%s extra baud rates supported: %d, %d",
|
|
|
|
port->dev ? dev_name(port->dev) : "",
|
|
|
|
port->dev ? ": " : "",
|
|
|
|
port->name,
|
|
|
|
port->uartclk / 8, port->uartclk / 4);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
uart_configure_port(struct uart_driver *drv, struct uart_state *state,
|
|
|
|
struct uart_port *port)
|
|
|
|
{
|
|
|
|
unsigned int flags;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there isn't a port here, don't do anything further.
|
|
|
|
*/
|
|
|
|
if (!port->iobase && !port->mapbase && !port->membase)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now do the auto configuration stuff. Note that config_port
|
|
|
|
* is expected to claim the resources and map the port for us.
|
|
|
|
*/
|
2009-01-02 13:49:54 +00:00
|
|
|
flags = 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (port->flags & UPF_AUTO_IRQ)
|
|
|
|
flags |= UART_CONFIG_IRQ;
|
|
|
|
if (port->flags & UPF_BOOT_AUTOCONF) {
|
2009-01-02 13:49:54 +00:00
|
|
|
if (!(port->flags & UPF_FIXED_TYPE)) {
|
|
|
|
port->type = PORT_UNKNOWN;
|
|
|
|
flags |= UART_CONFIG_TYPE;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
port->ops->config_port(port, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (port->type != PORT_UNKNOWN) {
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
uart_report_port(drv, port);
|
|
|
|
|
2007-02-14 00:33:06 -08:00
|
|
|
/* Power up port for set_mctrl() */
|
2012-12-07 11:36:08 +01:00
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
2007-02-14 00:33:06 -08:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Ensure that the modem control lines are de-activated.
|
2008-02-04 22:27:46 -08:00
|
|
|
* keep the DTR setting that is set in uart_set_options()
|
2005-04-16 15:20:36 -07:00
|
|
|
* We probably don't need a spinlock around this, but
|
|
|
|
*/
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_lock_irqsave(port, &flags);
|
2022-01-02 18:52:44 +01:00
|
|
|
port->mctrl &= TIOCM_DTR;
|
serial: Deassert Transmit Enable on probe in driver-specific way
When a UART port is newly registered, uart_configure_port() seeks to
deassert RS485 Transmit Enable by setting the RTS bit in port->mctrl.
However a number of UART drivers interpret a set RTS bit as *assertion*
instead of deassertion: Affected drivers include those using
serial8250_em485_config() (except 8250_bcm2835aux.c) and some using
mctrl_gpio (e.g. imx.c).
Since the interpretation of the RTS bit is driver-specific, it is not
suitable as a means to centrally deassert Transmit Enable in the serial
core. Instead, the serial core must call on drivers to deassert it in
their driver-specific way. One way to achieve that is to call
->rs485_config(). It implicitly deasserts Transmit Enable.
So amend uart_configure_port() and uart_resume_port() to invoke
uart_rs485_config(). That allows removing calls to uart_rs485_config()
from drivers' ->probe() hooks and declaring the function static.
Skip any invocation of ->set_mctrl() if RS485 is enabled. RS485 has no
hardware flow control, so the modem control lines are irrelevant and
need not be touched. When leaving RS485 mode, reset the modem control
lines to the state stored in port->mctrl. That way, UARTs which are
muxed between RS485 and RS232 transceivers drive the lines correctly
when switched to RS232. (serial8250_do_startup() historically raises
the OUT1 modem signal because otherwise interrupts are not signaled on
ancient PC UARTs, but I believe that no longer applies to modern,
RS485-capable UARTs and is thus safe to be skipped.)
imx.c modifies port->mctrl whenever Transmit Enable is asserted and
deasserted. Stop it from doing that so port->mctrl reflects the RS232
line state.
8250_omap.c deasserts Transmit Enable on ->runtime_resume() by calling
->set_mctrl(). Because that is now a no-op in RS485 mode, amend the
function to call serial8250_em485_stop_tx().
fsl_lpuart.c retrieves and applies the RS485 device tree properties
after registering the UART port. Because applying now happens on
registration in uart_configure_port(), move retrieval of the properties
ahead of uart_add_one_port().
Link: https://lore.kernel.org/all/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/
Link: https://lore.kernel.org/all/8f538a8903795f22f9acc94a9a31b03c9c4ccacb.camel@ginzinger.com/
Fixes: d3b3404df318 ("serial: Fix incorrect rs485 polarity on uart open")
Cc: stable@vger.kernel.org # v4.14+
Reported-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
Tested-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-22 18:27:33 +02:00
|
|
|
if (!(port->rs485.flags & SER_RS485_ENABLED))
|
|
|
|
port->ops->set_mctrl(port, port->mctrl);
|
2023-09-14 20:44:14 +02:06
|
|
|
uart_port_unlock_irqrestore(port, flags);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2023-09-21 16:52:33 +02:00
|
|
|
uart_rs485_config(port);
|
|
|
|
|
2007-09-01 21:25:09 +01:00
|
|
|
/*
|
|
|
|
* If this driver supports console, and it hasn't been
|
|
|
|
* successfully registered yet, try to re-register it.
|
|
|
|
* It may be that the port was not available.
|
|
|
|
*/
|
2022-11-16 17:27:34 +01:06
|
|
|
if (port->cons && !console_is_registered(port->cons))
|
2007-09-01 21:25:09 +01:00
|
|
|
register_console(port->cons);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Power down all ports by default, except the
|
|
|
|
* console if we have one.
|
|
|
|
*/
|
|
|
|
if (!uart_console(port))
|
2012-12-07 11:36:08 +01:00
|
|
|
uart_change_pm(state, UART_PM_STATE_OFF);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-04-17 20:05:37 +02:00
|
|
|
#ifdef CONFIG_CONSOLE_POLL
|
|
|
|
|
|
|
|
static int uart_poll_init(struct tty_driver *driver, int line, char *options)
|
|
|
|
{
|
|
|
|
struct uart_driver *drv = driver->driver_state;
|
|
|
|
struct uart_state *state = drv->state + line;
|
2023-03-16 13:20:56 -07:00
|
|
|
enum uart_pm_state pm_state;
|
2016-04-09 18:56:32 -07:00
|
|
|
struct tty_port *tport;
|
2008-04-17 20:05:37 +02:00
|
|
|
struct uart_port *port;
|
|
|
|
int baud = 9600;
|
|
|
|
int bits = 8;
|
|
|
|
int parity = 'n';
|
|
|
|
int flow = 'n';
|
2016-04-09 18:56:32 -07:00
|
|
|
int ret = 0;
|
2008-04-17 20:05:37 +02:00
|
|
|
|
2016-04-09 18:56:32 -07:00
|
|
|
tport = &state->port;
|
|
|
|
mutex_lock(&tport->mutex);
|
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
port = uart_port_check(state);
|
tty: serial: kgdboc: Fix 8250_* kgdb over serial
Check if port type is not PORT_UNKNOWN during poll_init.
The kgdboc calls the tty_find_polling_driver that check
if the serial is able to use poll_init. The poll_init calls
the uart uart_poll_init that try to configure the uart with the
selected boot parameters. The uart must be ready before setting
parameters. Seems that PORT_UNKNOWN is already used by other
functions in serial_core to detect uart status, so use the same
to avoid to use it in invalid state.
The crash happen for instance in am62x architecture where the 8250
register the platform driver after the 8250 core is initialized.
Follow the report crash coming from KGDB
Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1]
_outb (addr=<optimized out>, value=<optimized out>) at ./include/asm-generic/io.h:584
584 __raw_writeb(value, PCI_IOBASE + addr);
(gdb) bt
This section of the code is too early because in this case
the omap serial is not probed
Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1]
_outb (addr=<optimized out>, value=<optimized out>) at ./include/asm-generic/io.h:584
584 __raw_writeb(value, PCI_IOBASE + addr);
(gdb) bt
Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1]
_outb (addr=<optimized out>, value=<optimized out>) at ./include/asm-generic/io.h:584
584 __raw_writeb(value, PCI_IOBASE + addr);
(gdb) bt
0 _outb (addr=<optimized out>, value=<optimized out>) at ./include/asm-generic/io.h:584
1 logic_outb (value=0 '\000', addr=18446739675637874689) at lib/logic_pio.c:299
2 0xffff80008082dfcc in io_serial_out (p=0x0, offset=16760830, value=0) at drivers/tty/serial/8250/8250_port.c:416
3 0xffff80008082fe34 in serial_port_out (value=<optimized out>, offset=<optimized out>, up=<optimized out>)
at ./include/linux/serial_core.h:677
4 serial8250_do_set_termios (port=0xffff8000828ee940 <serial8250_ports+1568>, termios=0xffff80008292b93c, old=0x0)
at drivers/tty/serial/8250/8250_port.c:2860
5 0xffff800080830064 in serial8250_set_termios (port=0xfffffbfffe800000, termios=0xffbffe, old=0x0)
at drivers/tty/serial/8250/8250_port.c:2912
6 0xffff80008082571c in uart_set_options (port=0xffff8000828ee940 <serial8250_ports+1568>, co=0x0, baud=115200, parity=110, bits=8, flow=110)
at drivers/tty/serial/serial_core.c:2285
7 0xffff800080828434 in uart_poll_init (driver=0xfffffbfffe800000, line=16760830, options=0xffff8000828f7506 <config+6> "115200n8")
at drivers/tty/serial/serial_core.c:2656
8 0xffff800080801690 in tty_find_polling_driver (name=0xffff8000828f7500 <config> "ttyS2,115200n8", line=0xffff80008292ba90)
at drivers/tty/tty_io.c:410
9 0xffff80008086c0b0 in configure_kgdboc () at drivers/tty/serial/kgdboc.c:194
10 0xffff80008086c1ec in kgdboc_probe (pdev=0xfffffbfffe800000) at drivers/tty/serial/kgdboc.c:249
11 0xffff8000808b399c in platform_probe (_dev=0xffff000000ebb810) at drivers/base/platform.c:1404
12 0xffff8000808b0b44 in call_driver_probe (drv=<optimized out>, dev=<optimized out>) at drivers/base/dd.c:579
13 really_probe (dev=0xffff000000ebb810, drv=0xffff80008277f138 <kgdboc_platform_driver+48>) at drivers/base/dd.c:658
14 0xffff8000808b0d2c in __driver_probe_device (drv=0xffff80008277f138 <kgdboc_platform_driver+48>, dev=0xffff000000ebb810)
at drivers/base/dd.c:800
15 0xffff8000808b0eb8 in driver_probe_device (drv=0xfffffbfffe800000, dev=0xffff000000ebb810) at drivers/base/dd.c:830
16 0xffff8000808b0ff4 in __device_attach_driver (drv=0xffff80008277f138 <kgdboc_platform_driver+48>, _data=0xffff80008292bc48)
at drivers/base/dd.c:958
17 0xffff8000808ae970 in bus_for_each_drv (bus=0xfffffbfffe800000, start=0x0, data=0xffff80008292bc48,
fn=0xffff8000808b0f3c <__device_attach_driver>) at drivers/base/bus.c:457
18 0xffff8000808b1408 in __device_attach (dev=0xffff000000ebb810, allow_async=true) at drivers/base/dd.c:1030
19 0xffff8000808b16d8 in device_initial_probe (dev=0xfffffbfffe800000) at drivers/base/dd.c:1079
20 0xffff8000808af9f4 in bus_probe_device (dev=0xffff000000ebb810) at drivers/base/bus.c:532
21 0xffff8000808ac77c in device_add (dev=0xfffffbfffe800000) at drivers/base/core.c:3625
22 0xffff8000808b3428 in platform_device_add (pdev=0xffff000000ebb800) at drivers/base/platform.c:716
23 0xffff800081b5dc0c in init_kgdboc () at drivers/tty/serial/kgdboc.c:292
24 0xffff800080014db0 in do_one_initcall (fn=0xffff800081b5dba4 <init_kgdboc>) at init/main.c:1236
25 0xffff800081b0114c in do_initcall_level (command_line=<optimized out>, level=<optimized out>) at init/main.c:1298
26 do_initcalls () at init/main.c:1314
27 do_basic_setup () at init/main.c:1333
28 kernel_init_freeable () at init/main.c:1551
29 0xffff8000810271ec in kernel_init (unused=0xfffffbfffe800000) at init/main.c:1441
30 0xffff800080015e80 in ret_from_fork () at arch/arm64/kernel/entry.S:857
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Link: https://lore.kernel.org/r/20231224131200.266224-1-michael@amarulasolutions.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-12-24 14:12:00 +01:00
|
|
|
if (!port || port->type == PORT_UNKNOWN ||
|
|
|
|
!(port->ops->poll_get_char && port->ops->poll_put_char)) {
|
2016-04-09 18:56:32 -07:00
|
|
|
ret = -1;
|
|
|
|
goto out;
|
|
|
|
}
|
2008-04-17 20:05:37 +02:00
|
|
|
|
2023-03-16 13:20:56 -07:00
|
|
|
pm_state = state->pm_state;
|
|
|
|
uart_change_pm(state, UART_PM_STATE_ON);
|
|
|
|
|
2012-09-24 14:27:53 -07:00
|
|
|
if (port->ops->poll_init) {
|
|
|
|
/*
|
2016-04-09 17:53:25 -07:00
|
|
|
* We don't set initialized as we only initialized the hw,
|
|
|
|
* e.g. state->xmit is still uninitialized.
|
2012-09-24 14:27:53 -07:00
|
|
|
*/
|
2016-04-09 17:53:25 -07:00
|
|
|
if (!tty_port_initialized(tport))
|
2012-09-24 14:27:53 -07:00
|
|
|
ret = port->ops->poll_init(port);
|
|
|
|
}
|
|
|
|
|
2016-04-09 18:56:32 -07:00
|
|
|
if (!ret && options) {
|
2008-04-17 20:05:37 +02:00
|
|
|
uart_parse_options(options, &baud, &parity, &bits, &flow);
|
2023-01-12 17:18:13 +01:06
|
|
|
console_list_lock();
|
2016-04-09 18:56:32 -07:00
|
|
|
ret = uart_set_options(port, NULL, baud, parity, bits, flow);
|
2023-01-12 17:18:13 +01:06
|
|
|
console_list_unlock();
|
2008-04-17 20:05:37 +02:00
|
|
|
}
|
2016-04-09 18:56:32 -07:00
|
|
|
out:
|
2023-03-16 13:20:56 -07:00
|
|
|
if (ret)
|
|
|
|
uart_change_pm(state, pm_state);
|
2016-04-09 18:56:32 -07:00
|
|
|
mutex_unlock(&tport->mutex);
|
|
|
|
return ret;
|
2008-04-17 20:05:37 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static int uart_poll_get_char(struct tty_driver *driver, int line)
|
|
|
|
{
|
|
|
|
struct uart_driver *drv = driver->driver_state;
|
|
|
|
struct uart_state *state = drv->state + line;
|
|
|
|
struct uart_port *port;
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
int ret = -1;
|
2008-04-17 20:05:37 +02:00
|
|
|
|
2017-03-15 12:00:23 +01:00
|
|
|
port = uart_port_ref(state);
|
|
|
|
if (port) {
|
|
|
|
ret = port->ops->poll_get_char(port);
|
|
|
|
uart_port_deref(port);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
}
|
2017-03-15 12:00:23 +01:00
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
return ret;
|
2008-04-17 20:05:37 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void uart_poll_put_char(struct tty_driver *driver, int line, char ch)
|
|
|
|
{
|
|
|
|
struct uart_driver *drv = driver->driver_state;
|
|
|
|
struct uart_state *state = drv->state + line;
|
|
|
|
struct uart_port *port;
|
|
|
|
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
port = uart_port_ref(state);
|
|
|
|
if (!port)
|
|
|
|
return;
|
2014-04-21 10:06:43 -07:00
|
|
|
|
|
|
|
if (ch == '\n')
|
|
|
|
port->ops->poll_put_char(port, '\r');
|
2008-04-17 20:05:37 +02:00
|
|
|
port->ops->poll_put_char(port, ch);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
uart_port_deref(port);
|
2008-04-17 20:05:37 +02:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2006-10-02 02:17:18 -07:00
|
|
|
static const struct tty_operations uart_ops = {
|
2019-04-17 10:58:53 +02:00
|
|
|
.install = uart_install,
|
2005-04-16 15:20:36 -07:00
|
|
|
.open = uart_open,
|
|
|
|
.close = uart_close,
|
|
|
|
.write = uart_write,
|
|
|
|
.put_char = uart_put_char,
|
|
|
|
.flush_chars = uart_flush_chars,
|
|
|
|
.write_room = uart_write_room,
|
|
|
|
.chars_in_buffer= uart_chars_in_buffer,
|
|
|
|
.flush_buffer = uart_flush_buffer,
|
|
|
|
.ioctl = uart_ioctl,
|
|
|
|
.throttle = uart_throttle,
|
|
|
|
.unthrottle = uart_unthrottle,
|
|
|
|
.send_xchar = uart_send_xchar,
|
|
|
|
.set_termios = uart_set_termios,
|
2008-06-03 15:18:54 +01:00
|
|
|
.set_ldisc = uart_set_ldisc,
|
2005-04-16 15:20:36 -07:00
|
|
|
.stop = uart_stop,
|
|
|
|
.start = uart_start,
|
|
|
|
.hangup = uart_hangup,
|
|
|
|
.break_ctl = uart_break_ctl,
|
|
|
|
.wait_until_sent= uart_wait_until_sent,
|
|
|
|
#ifdef CONFIG_PROC_FS
|
2018-04-13 21:04:45 +02:00
|
|
|
.proc_show = uart_proc_show,
|
2005-04-16 15:20:36 -07:00
|
|
|
#endif
|
|
|
|
.tiocmget = uart_tiocmget,
|
|
|
|
.tiocmset = uart_tiocmset,
|
2018-09-11 22:29:55 -04:00
|
|
|
.set_serial = uart_set_info_user,
|
|
|
|
.get_serial = uart_get_info_user,
|
2010-09-16 18:21:24 +01:00
|
|
|
.get_icount = uart_get_icount,
|
2008-04-17 20:05:37 +02:00
|
|
|
#ifdef CONFIG_CONSOLE_POLL
|
|
|
|
.poll_init = uart_poll_init,
|
|
|
|
.poll_get_char = uart_poll_get_char,
|
|
|
|
.poll_put_char = uart_poll_put_char,
|
|
|
|
#endif
|
2005-04-16 15:20:36 -07:00
|
|
|
};
|
|
|
|
|
2010-06-01 22:52:58 +02:00
|
|
|
static const struct tty_port_operations uart_port_ops = {
|
|
|
|
.carrier_raised = uart_carrier_raised,
|
|
|
|
.dtr_rts = uart_dtr_rts,
|
2016-08-22 17:39:09 -05:00
|
|
|
.activate = uart_port_activate,
|
2016-08-22 17:39:10 -05:00
|
|
|
.shutdown = uart_tty_port_shutdown,
|
2010-06-01 22:52:58 +02:00
|
|
|
};
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/**
|
2022-07-28 08:10:52 +02:00
|
|
|
* uart_register_driver - register a driver with the uart core layer
|
|
|
|
* @drv: low level driver structure
|
|
|
|
*
|
|
|
|
* Register a uart driver with the core driver. We in turn register with the
|
|
|
|
* tty layer, and initialise the core driver per-port state.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* We have a proc file in /proc/tty/driver which is named after the normal
|
|
|
|
* driver.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* @drv->port should be %NULL, and the per-port structures should be registered
|
|
|
|
* using uart_add_one_port() after this call has succeeded.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Locking: none, Interrupts: enabled
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
int uart_register_driver(struct uart_driver *drv)
|
|
|
|
{
|
2009-10-25 11:16:32 -02:00
|
|
|
struct tty_driver *normal;
|
2019-04-23 08:06:58 +03:00
|
|
|
int i, retval = -ENOMEM;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
BUG_ON(drv->state);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Maybe we should be using a slab cache for this, especially if
|
|
|
|
* we have a large number of ports to handle.
|
|
|
|
*/
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 14:03:40 -07:00
|
|
|
drv->state = kcalloc(drv->nr, sizeof(struct uart_state), GFP_KERNEL);
|
2005-04-16 15:20:36 -07:00
|
|
|
if (!drv->state)
|
|
|
|
goto out;
|
|
|
|
|
2021-07-23 09:43:13 +02:00
|
|
|
normal = tty_alloc_driver(drv->nr, TTY_DRIVER_REAL_RAW |
|
|
|
|
TTY_DRIVER_DYNAMIC_DEV);
|
|
|
|
if (IS_ERR(normal)) {
|
|
|
|
retval = PTR_ERR(normal);
|
2009-10-25 11:16:32 -02:00
|
|
|
goto out_kfree;
|
2021-07-23 09:43:13 +02:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
drv->tty_driver = normal;
|
|
|
|
|
|
|
|
normal->driver_name = drv->driver_name;
|
|
|
|
normal->name = drv->dev_name;
|
|
|
|
normal->major = drv->major;
|
|
|
|
normal->minor_start = drv->minor;
|
|
|
|
normal->type = TTY_DRIVER_TYPE_SERIAL;
|
|
|
|
normal->subtype = SERIAL_TYPE_NORMAL;
|
|
|
|
normal->init_termios = tty_std_termios;
|
|
|
|
normal->init_termios.c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL;
|
2006-12-08 02:38:45 -08:00
|
|
|
normal->init_termios.c_ispeed = normal->init_termios.c_ospeed = 9600;
|
2005-04-16 15:20:36 -07:00
|
|
|
normal->driver_state = drv;
|
|
|
|
tty_set_operations(normal, &uart_ops);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialise the UART state(s).
|
|
|
|
*/
|
|
|
|
for (i = 0; i < drv->nr; i++) {
|
|
|
|
struct uart_state *state = drv->state + i;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port = &state->port;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
tty_port_init(port);
|
2010-06-01 22:52:58 +02:00
|
|
|
port->ops = &uart_port_ops;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
retval = tty_register_driver(normal);
|
2009-10-25 11:16:32 -02:00
|
|
|
if (retval >= 0)
|
|
|
|
return retval;
|
|
|
|
|
2012-11-15 09:49:56 +01:00
|
|
|
for (i = 0; i < drv->nr; i++)
|
|
|
|
tty_port_destroy(&drv->state[i].port);
|
2021-07-23 09:43:16 +02:00
|
|
|
tty_driver_kref_put(normal);
|
2009-10-25 11:16:32 -02:00
|
|
|
out_kfree:
|
|
|
|
kfree(drv->state);
|
|
|
|
out:
|
2019-04-23 08:06:58 +03:00
|
|
|
return retval;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2022-01-24 08:14:20 +01:00
|
|
|
EXPORT_SYMBOL(uart_register_driver);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:52 +02:00
|
|
|
* uart_unregister_driver - remove a driver from the uart core layer
|
|
|
|
* @drv: low level driver structure
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Remove all references to a driver from the core driver. The low level
|
|
|
|
* driver must have removed all its ports via the uart_remove_one_port() if it
|
|
|
|
* registered them with uart_add_one_port(). (I.e. @drv->port is %NULL.)
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Locking: none, Interrupts: enabled
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
void uart_unregister_driver(struct uart_driver *drv)
|
|
|
|
{
|
|
|
|
struct tty_driver *p = drv->tty_driver;
|
2012-11-15 09:49:56 +01:00
|
|
|
unsigned int i;
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
tty_unregister_driver(p);
|
2021-07-23 09:43:16 +02:00
|
|
|
tty_driver_kref_put(p);
|
2012-11-15 09:49:56 +01:00
|
|
|
for (i = 0; i < drv->nr; i++)
|
|
|
|
tty_port_destroy(&drv->state[i].port);
|
2005-04-16 15:20:36 -07:00
|
|
|
kfree(drv->state);
|
2012-05-14 14:51:22 +01:00
|
|
|
drv->state = NULL;
|
2005-04-16 15:20:36 -07:00
|
|
|
drv->tty_driver = NULL;
|
|
|
|
}
|
2022-01-24 08:14:20 +01:00
|
|
|
EXPORT_SYMBOL(uart_unregister_driver);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
struct tty_driver *uart_console_device(struct console *co, int *index)
|
|
|
|
{
|
|
|
|
struct uart_driver *p = co->data;
|
|
|
|
*index = co->index;
|
|
|
|
return p->tty_driver;
|
|
|
|
}
|
2020-01-07 01:03:10 +00:00
|
|
|
EXPORT_SYMBOL_GPL(uart_console_device);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t uartclk_show(struct device *dev,
|
2012-09-06 03:17:18 +02:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
2012-10-29 15:19:57 +00:00
|
|
|
struct serial_struct tmp;
|
2012-09-06 03:17:18 +02:00
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
2012-10-29 15:20:25 +00:00
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.baud_base * 16);
|
2012-09-06 03:17:18 +02:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t type_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.type);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
2020-02-17 13:40:11 +02:00
|
|
|
|
|
|
|
static ssize_t line_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.line);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t port_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
2012-11-26 15:47:15 -08:00
|
|
|
unsigned long ioaddr;
|
2012-10-29 15:20:40 +00:00
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2012-11-26 15:47:15 -08:00
|
|
|
ioaddr = tmp.port;
|
|
|
|
if (HIGH_BITS_OFFSET)
|
|
|
|
ioaddr |= (unsigned long)tmp.port_high << HIGH_BITS_OFFSET;
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "0x%lX\n", ioaddr);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t irq_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.irq);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t flags_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "0x%X\n", tmp.flags);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t xmit_fifo_size_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.xmit_fifo_size);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t close_delay_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.close_delay);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t closing_wait_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.closing_wait);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t custom_divisor_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.custom_divisor);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t io_type_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.io_type);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t iomem_base_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "0x%lX\n", (unsigned long)tmp.iomem_base);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static ssize_t iomem_reg_shift_show(struct device *dev,
|
2012-10-29 15:20:40 +00:00
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct serial_struct tmp;
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_get_info(port, &tmp);
|
2020-08-24 23:39:33 +01:00
|
|
|
return sprintf(buf, "%d\n", tmp.iomem_reg_shift);
|
2012-10-29 15:20:40 +00:00
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:12 +02:00
|
|
|
static ssize_t console_show(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
|
|
|
struct uart_port *uport;
|
|
|
|
bool console = false;
|
|
|
|
|
|
|
|
mutex_lock(&port->mutex);
|
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (uport)
|
2022-11-16 17:27:34 +01:06
|
|
|
console = uart_console_registered(uport);
|
2020-02-17 13:40:12 +02:00
|
|
|
mutex_unlock(&port->mutex);
|
|
|
|
|
|
|
|
return sprintf(buf, "%c\n", console ? 'Y' : 'N');
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t console_store(struct device *dev,
|
|
|
|
struct device_attribute *attr, const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct tty_port *port = dev_get_drvdata(dev);
|
|
|
|
struct uart_state *state = container_of(port, struct uart_state, port);
|
|
|
|
struct uart_port *uport;
|
|
|
|
bool oldconsole, newconsole;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = kstrtobool(buf, &newconsole);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
mutex_lock(&port->mutex);
|
|
|
|
uport = uart_port_check(state);
|
|
|
|
if (uport) {
|
2022-11-16 17:27:34 +01:06
|
|
|
oldconsole = uart_console_registered(uport);
|
2020-02-17 13:40:12 +02:00
|
|
|
if (oldconsole && !newconsole) {
|
|
|
|
ret = unregister_console(uport->cons);
|
|
|
|
} else if (!oldconsole && newconsole) {
|
2020-09-09 16:31:01 +02:00
|
|
|
if (uart_console(uport)) {
|
|
|
|
uport->console_reinit = 1;
|
2020-02-17 13:40:12 +02:00
|
|
|
register_console(uport->cons);
|
2020-09-09 16:31:01 +02:00
|
|
|
} else {
|
2020-02-17 13:40:12 +02:00
|
|
|
ret = -ENOENT;
|
2020-09-09 16:31:01 +02:00
|
|
|
}
|
2020-02-17 13:40:12 +02:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ret = -ENXIO;
|
|
|
|
}
|
|
|
|
mutex_unlock(&port->mutex);
|
|
|
|
|
|
|
|
return ret < 0 ? ret : count;
|
|
|
|
}
|
|
|
|
|
2020-02-17 13:40:11 +02:00
|
|
|
static DEVICE_ATTR_RO(uartclk);
|
|
|
|
static DEVICE_ATTR_RO(type);
|
|
|
|
static DEVICE_ATTR_RO(line);
|
|
|
|
static DEVICE_ATTR_RO(port);
|
|
|
|
static DEVICE_ATTR_RO(irq);
|
|
|
|
static DEVICE_ATTR_RO(flags);
|
|
|
|
static DEVICE_ATTR_RO(xmit_fifo_size);
|
|
|
|
static DEVICE_ATTR_RO(close_delay);
|
|
|
|
static DEVICE_ATTR_RO(closing_wait);
|
|
|
|
static DEVICE_ATTR_RO(custom_divisor);
|
|
|
|
static DEVICE_ATTR_RO(io_type);
|
|
|
|
static DEVICE_ATTR_RO(iomem_base);
|
|
|
|
static DEVICE_ATTR_RO(iomem_reg_shift);
|
2020-02-17 13:40:12 +02:00
|
|
|
static DEVICE_ATTR_RW(console);
|
2012-09-06 03:17:18 +02:00
|
|
|
|
|
|
|
static struct attribute *tty_dev_attrs[] = {
|
2020-02-17 13:40:11 +02:00
|
|
|
&dev_attr_uartclk.attr,
|
2012-10-29 15:20:40 +00:00
|
|
|
&dev_attr_type.attr,
|
|
|
|
&dev_attr_line.attr,
|
|
|
|
&dev_attr_port.attr,
|
|
|
|
&dev_attr_irq.attr,
|
|
|
|
&dev_attr_flags.attr,
|
|
|
|
&dev_attr_xmit_fifo_size.attr,
|
|
|
|
&dev_attr_close_delay.attr,
|
|
|
|
&dev_attr_closing_wait.attr,
|
|
|
|
&dev_attr_custom_divisor.attr,
|
|
|
|
&dev_attr_io_type.attr,
|
|
|
|
&dev_attr_iomem_base.attr,
|
|
|
|
&dev_attr_iomem_reg_shift.attr,
|
2020-02-17 13:40:12 +02:00
|
|
|
&dev_attr_console.attr,
|
|
|
|
NULL
|
|
|
|
};
|
2012-09-06 03:17:18 +02:00
|
|
|
|
2012-09-06 23:17:47 +02:00
|
|
|
static const struct attribute_group tty_dev_attr_group = {
|
2012-09-06 03:17:18 +02:00
|
|
|
.attrs = tty_dev_attrs,
|
2020-02-17 13:40:12 +02:00
|
|
|
};
|
2012-09-06 03:17:18 +02:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/**
|
2023-05-25 14:30:30 +03:00
|
|
|
* serial_core_add_one_port - attach a driver-defined port structure
|
2022-07-28 08:10:52 +02:00
|
|
|
* @drv: pointer to the uart low level driver structure for this port
|
|
|
|
* @uport: uart port structure to use for this port.
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Context: task context, might sleep
|
2021-02-08 19:16:15 +01:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* This allows the driver @drv to register its own uart_port structure with the
|
|
|
|
* core driver. The main purpose is to allow the low level uart drivers to
|
|
|
|
* expand uart_port, rather than having yet more levels of structures.
|
2023-05-25 14:30:30 +03:00
|
|
|
* Caller must hold port_mutex.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2023-05-25 14:30:30 +03:00
|
|
|
static int serial_core_add_one_port(struct uart_driver *drv, struct uart_port *uport)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct uart_state *state;
|
2009-09-19 13:13:31 -07:00
|
|
|
struct tty_port *port;
|
2005-04-16 15:20:36 -07:00
|
|
|
int ret = 0;
|
wake up from a serial port
Enable wakeup from serial ports, make it run-time configurable over sysfs,
e.g.,
echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
Requires
# CONFIG_SYSFS_DEPRECATED is not set
Following suggestions from Alan and Russell moved the may_wake_up checks
to serial_core.c. This time actually tested - it does even work. Could
someone, please, verify, that put_device after device_find_child is
correct?
Also would be nice to test with a Natsemi UART, that can wake up the system,
if such systems exist.
For this you just have to apply the patch below, issue the above "echo"
command to one of your Natsemi port, suspend and resume your system, and
verify that your Natsemi port still works. If you are actually capable of
waking up the system from that port, would be nice to test that as well.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 01:24:02 -07:00
|
|
|
struct device *tty_dev;
|
2014-07-16 01:19:34 +00:00
|
|
|
int num_groups;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
if (uport->line >= drv->nr)
|
2005-04-16 15:20:36 -07:00
|
|
|
return -EINVAL;
|
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
state = drv->state + uport->line;
|
|
|
|
port = &state->port;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2009-09-19 13:13:28 -07:00
|
|
|
if (state->uart_port) {
|
2005-04-16 15:20:36 -07:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-10-16 16:54:25 -04:00
|
|
|
/* Link the port to the driver state table and vice versa */
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
atomic_set(&state->refcount, 1);
|
|
|
|
init_waitqueue_head(&state->remove_wait);
|
2009-09-19 13:13:31 -07:00
|
|
|
state->uart_port = uport;
|
2014-10-16 16:54:25 -04:00
|
|
|
uport->state = state;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2014-10-16 16:54:25 -04:00
|
|
|
state->pm_state = UART_PM_STATE_UNDEFINED;
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->cons = drv->cons;
|
2015-02-24 14:25:00 -05:00
|
|
|
uport->minor = drv->tty_driver->minor_start + uport->line;
|
2017-03-24 10:57:59 +05:30
|
|
|
uport->name = kasprintf(GFP_KERNEL, "%s%d", drv->dev_name,
|
|
|
|
drv->tty_driver->name_base + uport->line);
|
|
|
|
if (!uport->name) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto out;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2020-09-09 16:31:00 +02:00
|
|
|
/*
|
|
|
|
* If this port is in use as a console then the spinlock is already
|
|
|
|
* initialised.
|
|
|
|
*/
|
2022-11-16 17:27:34 +01:06
|
|
|
if (!uart_console_registered(uport))
|
2020-09-09 16:31:01 +02:00
|
|
|
uart_port_spin_lock_init(uport);
|
2020-02-14 13:43:33 +02:00
|
|
|
|
2014-03-27 18:29:46 -07:00
|
|
|
if (uport->cons && uport->dev)
|
2019-10-16 12:36:41 +02:00
|
|
|
of_console_check(uport->dev->of_node, uport->cons->name, uport->line);
|
2005-07-03 21:05:45 +01:00
|
|
|
|
2019-12-12 13:16:02 +00:00
|
|
|
tty_port_link_device(port, drv->tty_driver, uport->line);
|
2009-09-19 13:13:31 -07:00
|
|
|
uart_configure_port(drv, state, uport);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2016-10-28 07:07:47 -05:00
|
|
|
port->console = uart_console(uport);
|
|
|
|
|
2014-07-16 01:19:34 +00:00
|
|
|
num_groups = 2;
|
|
|
|
if (uport->attr_group)
|
|
|
|
num_groups++;
|
|
|
|
|
2014-07-23 06:06:22 +00:00
|
|
|
uport->tty_groups = kcalloc(num_groups, sizeof(*uport->tty_groups),
|
2014-07-16 01:19:34 +00:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (!uport->tty_groups) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
uport->tty_groups[0] = &tty_dev_attr_group;
|
|
|
|
if (uport->attr_group)
|
|
|
|
uport->tty_groups[1] = uport->attr_group;
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* Register the port whether it's detected or not. This allows
|
2014-03-11 11:23:36 +01:00
|
|
|
* setserial to be used to alter this port's parameters.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2017-05-18 17:33:01 +02:00
|
|
|
tty_dev = tty_port_register_device_attr_serdev(port, drv->tty_driver,
|
2023-11-13 10:07:52 +02:00
|
|
|
uport->line, uport->dev, &uport->port_dev->dev, port,
|
|
|
|
uport->tty_groups);
|
2019-02-18 16:31:04 +08:00
|
|
|
if (!IS_ERR(tty_dev)) {
|
2012-01-19 11:28:56 -08:00
|
|
|
device_set_wakeup_capable(tty_dev, 1);
|
|
|
|
} else {
|
2014-09-01 20:49:43 +05:30
|
|
|
dev_err(uport->dev, "Cannot register tty device on line %d\n",
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->line);
|
2012-01-19 11:28:56 -08:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
out:
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2023-05-25 14:30:30 +03:00
|
|
|
* serial_core_remove_one_port - detach a driver defined port structure
|
2022-07-28 08:10:52 +02:00
|
|
|
* @drv: pointer to the uart low level driver structure for this port
|
|
|
|
* @uport: uart port structure for this port
|
2005-04-16 15:20:36 -07:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* Context: task context, might sleep
|
2021-02-08 19:16:15 +01:00
|
|
|
*
|
2022-07-28 08:10:52 +02:00
|
|
|
* This unhooks (and hangs up) the specified port structure from the core
|
|
|
|
* driver. No further calls will be made to the low-level code for this port.
|
2023-05-25 14:30:30 +03:00
|
|
|
* Caller must hold port_mutex.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2023-05-25 14:30:30 +03:00
|
|
|
static void serial_core_remove_one_port(struct uart_driver *drv,
|
|
|
|
struct uart_port *uport)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-09-19 13:13:31 -07:00
|
|
|
struct uart_state *state = drv->state + uport->line;
|
|
|
|
struct tty_port *port = &state->port;
|
2016-04-09 18:56:33 -07:00
|
|
|
struct uart_port *uart_port;
|
2014-03-17 14:10:58 +01:00
|
|
|
struct tty_struct *tty;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_lock(&port->mutex);
|
2016-04-09 18:56:33 -07:00
|
|
|
uart_port = uart_port_check(state);
|
|
|
|
if (uart_port != uport)
|
|
|
|
dev_alert(uport->dev, "Removing wrong port: %p != %p\n",
|
|
|
|
uart_port, uport);
|
|
|
|
|
|
|
|
if (!uart_port) {
|
2012-12-27 15:51:31 +08:00
|
|
|
mutex_unlock(&port->mutex);
|
2023-06-01 11:55:48 +01:00
|
|
|
return;
|
2012-12-27 15:51:31 +08:00
|
|
|
}
|
2009-09-19 13:13:31 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2006-04-30 11:13:50 +01:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/*
|
2005-06-20 21:15:16 -07:00
|
|
|
* Remove the devices from the tty layer
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2017-05-18 17:33:01 +02:00
|
|
|
tty_port_unregister_device(port, drv->tty_driver, uport->line);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2014-03-17 14:10:58 +01:00
|
|
|
tty = tty_port_tty_get(port);
|
|
|
|
if (tty) {
|
2009-09-19 13:13:31 -07:00
|
|
|
tty_vhangup(port->tty);
|
2014-03-17 14:10:58 +01:00
|
|
|
tty_kref_put(tty);
|
|
|
|
}
|
2006-04-30 11:13:50 +01:00
|
|
|
|
2014-02-28 14:21:32 +01:00
|
|
|
/*
|
|
|
|
* If the port is used as a console, unregister it
|
|
|
|
*/
|
|
|
|
if (uart_console(uport))
|
|
|
|
unregister_console(uport->cons);
|
|
|
|
|
2006-04-30 11:13:50 +01:00
|
|
|
/*
|
|
|
|
* Free the port IO and memory resources, if any.
|
|
|
|
*/
|
2016-05-20 01:59:54 -03:00
|
|
|
if (uport->type != PORT_UNKNOWN && uport->ops->release_port)
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->ops->release_port(uport);
|
2014-07-16 01:19:34 +00:00
|
|
|
kfree(uport->tty_groups);
|
2017-03-24 10:57:59 +05:30
|
|
|
kfree(uport->name);
|
2006-04-30 11:13:50 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Indicate that there isn't a port here anymore.
|
|
|
|
*/
|
2009-09-19 13:13:31 -07:00
|
|
|
uport->type = PORT_UNKNOWN;
|
2023-05-25 14:30:30 +03:00
|
|
|
uport->port_dev = NULL;
|
2006-04-30 11:13:50 +01:00
|
|
|
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_lock(&port->mutex);
|
serial: core: Prevent unsafe uart port access, part 2
For serial core operations not already excluded by holding port->mutex,
use reference counting to protect deferencing the state->uart_port.
Introduce helper functions, uart_port_ref() and uart_port_deref(), to
wrap uart_port access, and helper macros, uart_port_lock() and
uart_port_unlock(), to wrap combination uart_port access with uart
port lock sections.
Port removal in uart_remove_one_port() waits for reference count to
drop to zero before detaching the uart port from struct uart_state.
For functions only reading the tx circular buffer indexes (where the
uart port lock is claimed to prevent concurrent users), a NULL uart
port is simply ignored and the operation completes normally.
For functions change the tx circular buffer indexes (where the uart
port lock is claimed to prevent concurrent users), the operation is
aborted if the uart port is NULL (ie., has been detached).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-04-09 18:56:34 -07:00
|
|
|
WARN_ON(atomic_dec_return(&state->refcount) < 0);
|
|
|
|
wait_event(state->remove_wait, !atomic_read(&state->refcount));
|
2009-09-19 13:13:28 -07:00
|
|
|
state->uart_port = NULL;
|
2016-04-09 18:56:33 -07:00
|
|
|
mutex_unlock(&port->mutex);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2022-07-28 08:10:52 +02:00
|
|
|
/**
|
|
|
|
* uart_match_port - are the two ports equivalent?
|
|
|
|
* @port1: first port
|
|
|
|
* @port2: second port
|
|
|
|
*
|
|
|
|
* This utility function can be used to determine whether two uart_port
|
|
|
|
* structures describe the same port.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
2021-05-19 09:21:50 +02:00
|
|
|
bool uart_match_port(const struct uart_port *port1,
|
|
|
|
const struct uart_port *port2)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
if (port1->iotype != port2->iotype)
|
2021-05-19 09:21:50 +02:00
|
|
|
return false;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
switch (port1->iotype) {
|
|
|
|
case UPIO_PORT:
|
2021-05-19 09:21:50 +02:00
|
|
|
return port1->iobase == port2->iobase;
|
2005-04-16 15:20:36 -07:00
|
|
|
case UPIO_HUB6:
|
2021-05-19 09:21:50 +02:00
|
|
|
return port1->iobase == port2->iobase &&
|
|
|
|
port1->hub6 == port2->hub6;
|
2005-04-16 15:20:36 -07:00
|
|
|
case UPIO_MEM:
|
2015-10-28 12:46:05 +09:00
|
|
|
case UPIO_MEM16:
|
2006-08-28 19:49:03 +04:00
|
|
|
case UPIO_MEM32:
|
2014-11-12 12:53:59 -08:00
|
|
|
case UPIO_MEM32BE:
|
2006-08-28 19:49:03 +04:00
|
|
|
case UPIO_AU:
|
|
|
|
case UPIO_TSI:
|
2021-05-19 09:21:50 +02:00
|
|
|
return port1->mapbase == port2->mapbase;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2021-05-19 09:21:50 +02:00
|
|
|
|
|
|
|
return false;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(uart_match_port);
|
|
|
|
|
2023-05-25 14:30:30 +03:00
|
|
|
static struct serial_ctrl_device *
|
|
|
|
serial_core_get_ctrl_dev(struct serial_port_device *port_dev)
|
|
|
|
{
|
|
|
|
struct device *dev = &port_dev->dev;
|
|
|
|
|
|
|
|
return to_serial_base_ctrl_device(dev->parent);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Find a registered serial core controller device if one exists. Returns
|
|
|
|
* the first device matching the ctrl_id. Caller must hold port_mutex.
|
|
|
|
*/
|
|
|
|
static struct serial_ctrl_device *serial_core_ctrl_find(struct uart_driver *drv,
|
|
|
|
struct device *phys_dev,
|
|
|
|
int ctrl_id)
|
|
|
|
{
|
|
|
|
struct uart_state *state;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
lockdep_assert_held(&port_mutex);
|
|
|
|
|
|
|
|
for (i = 0; i < drv->nr; i++) {
|
|
|
|
state = drv->state + i;
|
|
|
|
if (!state->uart_port || !state->uart_port->port_dev)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (state->uart_port->dev == phys_dev &&
|
|
|
|
state->uart_port->ctrl_id == ctrl_id)
|
|
|
|
return serial_core_get_ctrl_dev(state->uart_port->port_dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct serial_ctrl_device *serial_core_ctrl_device_add(struct uart_port *port)
|
|
|
|
{
|
|
|
|
return serial_base_ctrl_add(port, port->dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int serial_core_port_device_add(struct serial_ctrl_device *ctrl_dev,
|
|
|
|
struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct serial_port_device *port_dev;
|
|
|
|
|
|
|
|
port_dev = serial_base_port_add(port, ctrl_dev);
|
|
|
|
if (IS_ERR(port_dev))
|
|
|
|
return PTR_ERR(port_dev);
|
|
|
|
|
|
|
|
port->port_dev = port_dev;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialize a serial core port device, and a controller device if needed.
|
|
|
|
*/
|
|
|
|
int serial_core_register_port(struct uart_driver *drv, struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct serial_ctrl_device *ctrl_dev, *new_ctrl_dev = NULL;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
mutex_lock(&port_mutex);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Prevent serial_port_runtime_resume() from trying to use the port
|
|
|
|
* until serial_core_add_one_port() has completed
|
|
|
|
*/
|
|
|
|
port->flags |= UPF_DEAD;
|
|
|
|
|
|
|
|
/* Inititalize a serial core controller device if needed */
|
|
|
|
ctrl_dev = serial_core_ctrl_find(drv, port->dev, port->ctrl_id);
|
|
|
|
if (!ctrl_dev) {
|
|
|
|
new_ctrl_dev = serial_core_ctrl_device_add(port);
|
2023-06-02 10:00:05 +03:00
|
|
|
if (IS_ERR(new_ctrl_dev)) {
|
|
|
|
ret = PTR_ERR(new_ctrl_dev);
|
2023-05-25 14:30:30 +03:00
|
|
|
goto err_unlock;
|
|
|
|
}
|
|
|
|
ctrl_dev = new_ctrl_dev;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialize a serial core port device. Tag the port dead to prevent
|
|
|
|
* serial_port_runtime_resume() trying to do anything until port has
|
|
|
|
* been registered. It gets cleared by serial_core_add_one_port().
|
|
|
|
*/
|
|
|
|
ret = serial_core_port_device_add(ctrl_dev, port);
|
|
|
|
if (ret)
|
|
|
|
goto err_unregister_ctrl_dev;
|
|
|
|
|
|
|
|
ret = serial_core_add_one_port(drv, port);
|
|
|
|
if (ret)
|
|
|
|
goto err_unregister_port_dev;
|
|
|
|
|
|
|
|
port->flags &= ~UPF_DEAD;
|
|
|
|
|
|
|
|
mutex_unlock(&port_mutex);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_unregister_port_dev:
|
|
|
|
serial_base_port_device_remove(port->port_dev);
|
|
|
|
|
|
|
|
err_unregister_ctrl_dev:
|
|
|
|
serial_base_ctrl_device_remove(new_ctrl_dev);
|
|
|
|
|
|
|
|
err_unlock:
|
|
|
|
mutex_unlock(&port_mutex);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Removes a serial core port device, and the related serial core controller
|
|
|
|
* device if the last instance.
|
|
|
|
*/
|
|
|
|
void serial_core_unregister_port(struct uart_driver *drv, struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct device *phys_dev = port->dev;
|
|
|
|
struct serial_port_device *port_dev = port->port_dev;
|
|
|
|
struct serial_ctrl_device *ctrl_dev = serial_core_get_ctrl_dev(port_dev);
|
|
|
|
int ctrl_id = port->ctrl_id;
|
|
|
|
|
|
|
|
mutex_lock(&port_mutex);
|
|
|
|
|
|
|
|
port->flags |= UPF_DEAD;
|
|
|
|
|
|
|
|
serial_core_remove_one_port(drv, port);
|
|
|
|
|
|
|
|
/* Note that struct uart_port *port is no longer valid at this point */
|
|
|
|
serial_base_port_device_remove(port_dev);
|
|
|
|
|
|
|
|
/* Drop the serial core controller device if no ports are using it */
|
|
|
|
if (!serial_core_ctrl_find(drv, phys_dev, ctrl_id))
|
|
|
|
serial_base_ctrl_device_remove(ctrl_dev);
|
|
|
|
|
|
|
|
mutex_unlock(&port_mutex);
|
|
|
|
}
|
|
|
|
|
2011-11-09 21:33:43 +01:00
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_handle_dcd_change - handle a change of carrier detect state
|
|
|
|
* @uport: uart_port structure for the open port
|
2023-01-17 11:03:54 +02:00
|
|
|
* @active: new carrier detect status
|
2014-09-10 15:06:23 -04:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Caller must hold uport->lock.
|
2011-11-09 21:33:43 +01:00
|
|
|
*/
|
2023-01-17 11:03:54 +02:00
|
|
|
void uart_handle_dcd_change(struct uart_port *uport, bool active)
|
2011-11-09 21:33:43 +01:00
|
|
|
{
|
2013-02-10 04:44:30 -05:00
|
|
|
struct tty_port *port = &uport->state->port;
|
2012-09-19 15:35:46 +01:00
|
|
|
struct tty_struct *tty = port->tty;
|
2014-09-02 17:39:21 -04:00
|
|
|
struct tty_ldisc *ld;
|
2011-11-09 21:33:43 +01:00
|
|
|
|
2014-09-10 15:06:23 -04:00
|
|
|
lockdep_assert_held_once(&uport->lock);
|
|
|
|
|
2014-09-02 17:39:21 -04:00
|
|
|
if (tty) {
|
|
|
|
ld = tty_ldisc_ref(tty);
|
|
|
|
if (ld) {
|
|
|
|
if (ld->ops->dcd_change)
|
2023-01-17 11:03:54 +02:00
|
|
|
ld->ops->dcd_change(tty, active);
|
2014-09-02 17:39:21 -04:00
|
|
|
tty_ldisc_deref(ld);
|
|
|
|
}
|
2013-02-10 04:44:30 -05:00
|
|
|
}
|
2011-11-09 21:33:43 +01:00
|
|
|
|
|
|
|
uport->icount.dcd++;
|
|
|
|
|
2014-09-10 15:06:24 -04:00
|
|
|
if (uart_dcd_enabled(uport)) {
|
2023-01-17 11:03:54 +02:00
|
|
|
if (active)
|
2011-11-09 21:33:43 +01:00
|
|
|
wake_up_interruptible(&port->open_wait);
|
2012-09-19 15:35:46 +01:00
|
|
|
else if (tty)
|
|
|
|
tty_hangup(tty);
|
2011-11-09 21:33:43 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_handle_dcd_change);
|
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_handle_cts_change - handle a change of clear-to-send state
|
|
|
|
* @uport: uart_port structure for the open port
|
2023-01-17 11:03:55 +02:00
|
|
|
* @active: new clear-to-send status
|
2014-09-10 15:06:23 -04:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Caller must hold uport->lock.
|
2011-11-09 21:33:43 +01:00
|
|
|
*/
|
2023-01-17 11:03:55 +02:00
|
|
|
void uart_handle_cts_change(struct uart_port *uport, bool active)
|
2011-11-09 21:33:43 +01:00
|
|
|
{
|
2014-09-10 15:06:23 -04:00
|
|
|
lockdep_assert_held_once(&uport->lock);
|
|
|
|
|
2011-11-09 21:33:43 +01:00
|
|
|
uport->icount.cts++;
|
|
|
|
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
if (uart_softcts_mode(uport)) {
|
2014-09-10 15:06:26 -04:00
|
|
|
if (uport->hw_stopped) {
|
2023-01-17 11:03:55 +02:00
|
|
|
if (active) {
|
2023-03-09 10:09:21 +02:00
|
|
|
uport->hw_stopped = false;
|
2011-11-09 21:33:43 +01:00
|
|
|
uport->ops->start_tx(uport);
|
|
|
|
uart_write_wakeup(uport);
|
|
|
|
}
|
|
|
|
} else {
|
2023-01-17 11:03:55 +02:00
|
|
|
if (!active) {
|
2023-03-09 10:09:21 +02:00
|
|
|
uport->hw_stopped = true;
|
2011-11-09 21:33:43 +01:00
|
|
|
uport->ops->stop_tx(uport);
|
|
|
|
}
|
|
|
|
}
|
serial: core: Rework hw-assisted flow control support
hw-assisted flow control support was added to the serial core
in v3.8 with commits,
dba05832cbe4f ("SERIAL: core: add hardware assisted h/w flow control support")
2cbacafd7af0f ("SERIAL: core: add hardware assisted s/w flow control support")
9aba8d5b01119 ("SERIAL: core: add throttle/unthrottle callbacks for hardware
assisted flow control")
Since then, additional requirements for serial core support have arisen.
Specifically,
1. Separate tx and rx flow control settings for UARTs which only support
tx flow control (ie., autoCTS).
2. Disable sw-assisted CTS flow control in autoCTS mode
3. Support for RTS flow control by serial core and userspace in autoRTS mode
Distinguish mode from capability; introduce UPSTAT_AUTORTS, UPSTAT_AUTOCTS
and UPSTAT_AUTOXOFF which, when set by the uart driver, enable serial core
support for hw-assisted rx, hw-assisted tx and hw-assisted in-band/IXOFF
rx flow control, respectively. [Note: hw-assisted in-band/IXON tx flow
control does not require serial core support/intervention and can be
enabled by the uart driver when required.]
These modes must be set/reset in the driver's set_termios() method, based
on termios settings, and thus can be safely queried in any context in which
one of the port lock, port mutex or termios rwsem are held. Set these modes
in the 2 in-tree drivers, omap-serial and 8250_omap, which currently
use UPF_HARD_FLOW/UPF_SOFT_FLOW support.
Retain UPF_HARD_FLOW and UPF_SOFT_FLOW as capabilities; re-define
UPF_HARD_FLOW as both UPF_AUTO_RTS and UPF_AUTO_CTS to allow for distinct
and separate rx and tx flow control capabilities.
Disable sw-assisted CTS flow control when UPSTAT_AUTOCTS is enabled.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 14:44:51 -05:00
|
|
|
|
2011-11-09 21:33:43 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_handle_cts_change);
|
|
|
|
|
2011-11-09 21:33:47 +01:00
|
|
|
/**
|
|
|
|
* uart_insert_char - push a char to the uart layer
|
|
|
|
*
|
|
|
|
* User is responsible to call tty_flip_buffer_push when they are done with
|
|
|
|
* insertion.
|
|
|
|
*
|
|
|
|
* @port: corresponding port
|
|
|
|
* @status: state of the serial port RX buffer (LSR for 8250)
|
|
|
|
* @overrun: mask of overrun bits in @status
|
|
|
|
* @ch: character to push
|
|
|
|
* @flag: flag for the character (see TTY_NORMAL and friends)
|
|
|
|
*/
|
2011-11-09 21:33:43 +01:00
|
|
|
void uart_insert_char(struct uart_port *port, unsigned int status,
|
2023-07-12 10:18:07 +02:00
|
|
|
unsigned int overrun, u8 ch, u8 flag)
|
2011-11-09 21:33:43 +01:00
|
|
|
{
|
2013-01-03 15:53:03 +01:00
|
|
|
struct tty_port *tport = &port->state->port;
|
2011-11-09 21:33:43 +01:00
|
|
|
|
|
|
|
if ((status & port->ignore_status_mask & ~overrun) == 0)
|
2013-01-03 15:53:03 +01:00
|
|
|
if (tty_insert_flip_char(tport, ch, flag) == 0)
|
2012-05-23 09:37:31 -05:00
|
|
|
++port->icount.buf_overrun;
|
2011-11-09 21:33:43 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Overrun is special. Since it's reported immediately,
|
|
|
|
* it doesn't affect the current character.
|
|
|
|
*/
|
|
|
|
if (status & ~port->ignore_status_mask & overrun)
|
2013-01-03 15:53:03 +01:00
|
|
|
if (tty_insert_flip_char(tport, 0, TTY_OVERRUN) == 0)
|
2012-05-23 09:37:31 -05:00
|
|
|
++port->icount.buf_overrun;
|
2011-11-09 21:33:43 +01:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(uart_insert_char);
|
|
|
|
|
2020-03-02 17:51:35 +00:00
|
|
|
#ifdef CONFIG_MAGIC_SYSRQ_SERIAL
|
2023-07-12 10:18:06 +02:00
|
|
|
static const u8 sysrq_toggle_seq[] = CONFIG_MAGIC_SYSRQ_SERIAL_SEQUENCE;
|
2020-03-02 17:51:35 +00:00
|
|
|
|
|
|
|
static void uart_sysrq_on(struct work_struct *w)
|
|
|
|
{
|
2020-03-10 19:43:35 +02:00
|
|
|
int sysrq_toggle_seq_len = strlen(sysrq_toggle_seq);
|
|
|
|
|
2020-03-02 17:51:35 +00:00
|
|
|
sysrq_toggle_support(1);
|
2020-03-10 19:43:35 +02:00
|
|
|
pr_info("SysRq is enabled by magic sequence '%*pE' on serial\n",
|
|
|
|
sysrq_toggle_seq_len, sysrq_toggle_seq);
|
2020-03-02 17:51:35 +00:00
|
|
|
}
|
|
|
|
static DECLARE_WORK(sysrq_enable_work, uart_sysrq_on);
|
|
|
|
|
|
|
|
/**
|
2022-07-28 08:10:55 +02:00
|
|
|
* uart_try_toggle_sysrq - Enables SysRq from serial line
|
|
|
|
* @port: uart_port structure where char(s) after BREAK met
|
|
|
|
* @ch: new character in the sequence after received BREAK
|
2020-03-02 17:51:35 +00:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Enables magic SysRq when the required sequence is met on port
|
|
|
|
* (see CONFIG_MAGIC_SYSRQ_SERIAL_SEQUENCE).
|
2020-03-02 17:51:35 +00:00
|
|
|
*
|
2022-07-28 08:10:55 +02:00
|
|
|
* Returns: %false if @ch is out of enabling sequence and should be
|
|
|
|
* handled some other way, %true if @ch was consumed.
|
2020-03-02 17:51:35 +00:00
|
|
|
*/
|
2023-07-12 10:18:06 +02:00
|
|
|
bool uart_try_toggle_sysrq(struct uart_port *port, u8 ch)
|
2020-03-02 17:51:35 +00:00
|
|
|
{
|
2020-03-10 19:43:34 +02:00
|
|
|
int sysrq_toggle_seq_len = strlen(sysrq_toggle_seq);
|
|
|
|
|
|
|
|
if (!sysrq_toggle_seq_len)
|
2020-03-02 17:51:35 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
BUILD_BUG_ON(ARRAY_SIZE(sysrq_toggle_seq) >= U8_MAX);
|
|
|
|
if (sysrq_toggle_seq[port->sysrq_seq] != ch) {
|
|
|
|
port->sysrq_seq = 0;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-10 19:43:34 +02:00
|
|
|
if (++port->sysrq_seq < sysrq_toggle_seq_len) {
|
2020-03-02 17:51:35 +00:00
|
|
|
port->sysrq = jiffies + SYSRQ_TIMEOUT;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
schedule_work(&sysrq_enable_work);
|
|
|
|
|
|
|
|
port->sysrq = 0;
|
|
|
|
return true;
|
|
|
|
}
|
2020-06-10 17:22:31 +02:00
|
|
|
EXPORT_SYMBOL_GPL(uart_try_toggle_sysrq);
|
2020-03-02 17:51:35 +00:00
|
|
|
#endif
|
|
|
|
|
2017-09-13 10:18:27 +02:00
|
|
|
/**
|
2017-11-24 23:26:40 +01:00
|
|
|
* uart_get_rs485_mode() - retrieve rs485 properties for given uart
|
2020-06-15 12:24:36 -07:00
|
|
|
* @port: uart device's target port
|
2017-09-13 10:18:27 +02:00
|
|
|
*
|
|
|
|
* This function implements the device tree binding described in
|
|
|
|
* Documentation/devicetree/bindings/serial/rs485.txt.
|
|
|
|
*/
|
2020-05-12 14:40:02 +02:00
|
|
|
int uart_get_rs485_mode(struct uart_port *port)
|
2017-09-13 10:18:27 +02:00
|
|
|
{
|
2020-05-12 14:40:02 +02:00
|
|
|
struct serial_rs485 *rs485conf = &port->rs485;
|
|
|
|
struct device *dev = port->dev;
|
2023-10-03 17:23:46 +03:00
|
|
|
enum gpiod_flags dflags;
|
|
|
|
struct gpio_desc *desc;
|
2017-09-13 10:18:27 +02:00
|
|
|
u32 rs485_delay[2];
|
|
|
|
int ret;
|
|
|
|
|
2024-01-03 07:18:16 +01:00
|
|
|
if (!(port->rs485_supported.flags & SER_RS485_ENABLED))
|
|
|
|
return 0;
|
|
|
|
|
2017-11-24 23:26:40 +01:00
|
|
|
ret = device_property_read_u32_array(dev, "rs485-rts-delay",
|
|
|
|
rs485_delay, 2);
|
2017-09-13 10:18:27 +02:00
|
|
|
if (!ret) {
|
|
|
|
rs485conf->delay_rts_before_send = rs485_delay[0];
|
|
|
|
rs485conf->delay_rts_after_send = rs485_delay[1];
|
|
|
|
} else {
|
|
|
|
rs485conf->delay_rts_before_send = 0;
|
|
|
|
rs485conf->delay_rts_after_send = 0;
|
|
|
|
}
|
|
|
|
|
2022-07-10 18:44:39 +02:00
|
|
|
uart_sanitize_serial_rs485_delays(port, rs485conf);
|
|
|
|
|
2017-09-13 10:18:27 +02:00
|
|
|
/*
|
2017-11-24 23:26:40 +01:00
|
|
|
* Clear full-duplex and enabled flags, set RTS polarity to active high
|
|
|
|
* to get to a defined state with the following properties:
|
2017-09-13 10:18:27 +02:00
|
|
|
*/
|
2017-11-24 23:26:40 +01:00
|
|
|
rs485conf->flags &= ~(SER_RS485_RX_DURING_TX | SER_RS485_ENABLED |
|
2020-05-18 16:45:02 +02:00
|
|
|
SER_RS485_TERMINATE_BUS |
|
2017-11-24 23:26:40 +01:00
|
|
|
SER_RS485_RTS_AFTER_SEND);
|
|
|
|
rs485conf->flags |= SER_RS485_RTS_ON_SEND;
|
2017-09-13 10:18:27 +02:00
|
|
|
|
2017-11-24 23:26:40 +01:00
|
|
|
if (device_property_read_bool(dev, "rs485-rx-during-tx"))
|
2017-09-13 10:18:27 +02:00
|
|
|
rs485conf->flags |= SER_RS485_RX_DURING_TX;
|
|
|
|
|
2017-11-24 23:26:40 +01:00
|
|
|
if (device_property_read_bool(dev, "linux,rs485-enabled-at-boot-time"))
|
2017-09-13 10:18:27 +02:00
|
|
|
rs485conf->flags |= SER_RS485_ENABLED;
|
2017-11-24 23:26:40 +01:00
|
|
|
|
|
|
|
if (device_property_read_bool(dev, "rs485-rts-active-low")) {
|
|
|
|
rs485conf->flags &= ~SER_RS485_RTS_ON_SEND;
|
|
|
|
rs485conf->flags |= SER_RS485_RTS_AFTER_SEND;
|
|
|
|
}
|
2020-05-12 14:40:02 +02:00
|
|
|
|
2020-05-18 16:45:02 +02:00
|
|
|
/*
|
|
|
|
* Disabling termination by default is the safe choice: Else if many
|
|
|
|
* bus participants enable it, no communication is possible at all.
|
|
|
|
* Works fine for short cables and users may enable for longer cables.
|
|
|
|
*/
|
2023-10-03 17:23:46 +03:00
|
|
|
desc = devm_gpiod_get_optional(dev, "rs485-term", GPIOD_OUT_LOW);
|
|
|
|
if (IS_ERR(desc))
|
|
|
|
return dev_err_probe(dev, PTR_ERR(desc), "Cannot get rs485-term-gpios\n");
|
|
|
|
port->rs485_term_gpio = desc;
|
2022-07-04 12:45:15 +03:00
|
|
|
if (port->rs485_term_gpio)
|
|
|
|
port->rs485_supported.flags |= SER_RS485_TERMINATE_BUS;
|
2020-05-18 16:45:02 +02:00
|
|
|
|
2023-10-03 17:23:46 +03:00
|
|
|
dflags = (rs485conf->flags & SER_RS485_RX_DURING_TX) ?
|
|
|
|
GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
|
|
|
|
desc = devm_gpiod_get_optional(dev, "rs485-rx-during-tx", dflags);
|
|
|
|
if (IS_ERR(desc))
|
|
|
|
return dev_err_probe(dev, PTR_ERR(desc), "Cannot get rs485-rx-during-tx-gpios\n");
|
|
|
|
port->rs485_rx_during_tx_gpio = desc;
|
2024-01-03 07:18:13 +01:00
|
|
|
if (port->rs485_rx_during_tx_gpio)
|
|
|
|
port->rs485_supported.flags |= SER_RS485_RX_DURING_TX;
|
2022-12-02 11:41:25 +01:00
|
|
|
|
2020-05-12 14:40:02 +02:00
|
|
|
return 0;
|
2017-09-13 10:18:27 +02:00
|
|
|
}
|
2017-11-24 23:26:40 +01:00
|
|
|
EXPORT_SYMBOL_GPL(uart_get_rs485_mode);
|
2017-09-13 10:18:27 +02:00
|
|
|
|
2022-06-24 23:42:09 +03:00
|
|
|
/* Compile-time assertions for serial_rs485 layout */
|
|
|
|
static_assert(offsetof(struct serial_rs485, padding) ==
|
|
|
|
(offsetof(struct serial_rs485, delay_rts_after_send) + sizeof(__u32)));
|
|
|
|
static_assert(offsetof(struct serial_rs485, padding1) ==
|
|
|
|
offsetof(struct serial_rs485, padding[1]));
|
|
|
|
static_assert((offsetof(struct serial_rs485, padding[4]) + sizeof(__u32)) ==
|
|
|
|
sizeof(struct serial_rs485));
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
MODULE_DESCRIPTION("Serial driver core");
|
|
|
|
MODULE_LICENSE("GPL");
|