Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-09 06:33:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Driver Core: devtmpfs: do not remove non-kernel-created directories

Browse Source 
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Kay Sievers 2009-10-28 19:51:26 +01:00 committed by Greg Kroah-Hartman
parent 073120cc28
commit 015bf43b07
1 changed files with 16 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/base/devtmpfs.c
View File

@ -76,37 +76,26 @@ static int dev_mkdir(const char *name, mode_t mode)
dentry = lookup_create(&nd, 1); dentry = lookup_create(&nd, 1);
if (!IS_ERR(dentry)) { if (!IS_ERR(dentry)) {
err = vfs_mkdir(nd.path.dentry->d_inode, dentry, mode); err = vfs_mkdir(nd.path.dentry->d_inode, dentry, mode);
if (!err)
/* mark as kernel-created inode */
dentry->d_inode->i_private = &dev_mnt;
dput(dentry); dput(dentry);
} else { } else {
err = PTR_ERR(dentry); err = PTR_ERR(dentry);
} }
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
path_put(&nd.path); path_put(&nd.path);
return err; return err;
} }
static int create_path(const char *nodepath) static int create_path(const char *nodepath)
{ {
struct nameidata nd; int err;
int err = 0;
read_lock(&dirlock); read_lock(&dirlock);
err = vfs_path_lookup(dev_mnt->mnt_root, dev_mnt, err = dev_mkdir(nodepath, 0755);
nodepath, LOOKUP_PARENT, &nd); if (err == -ENOENT) {
if (err == 0) {
struct dentry *dentry;
/* create directory right away */
dentry = lookup_create(&nd, 1);
if (!IS_ERR(dentry)) {
err = vfs_mkdir(nd.path.dentry->d_inode,
dentry, 0755);
dput(dentry);
}
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
path_put(&nd.path);
} else if (err == -ENOENT) {
char *path; char *path;
char *s; char *s;
@ -129,7 +118,6 @@ static int create_path(const char *nodepath)
kfree(path); kfree(path);
} }
read_unlock(&dirlock); read_unlock(&dirlock);
return err; return err;
} }
@ -213,16 +201,21 @@ static int dev_rmdir(const char *name)
mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT);
dentry = lookup_one_len(nd.last.name, nd.path.dentry, nd.last.len); dentry = lookup_one_len(nd.last.name, nd.path.dentry, nd.last.len);
if (!IS_ERR(dentry)) { if (!IS_ERR(dentry)) {
if (dentry->d_inode) if (dentry->d_inode) {
err = vfs_rmdir(nd.path.dentry->d_inode, dentry); if (dentry->d_inode->i_private == &dev_mnt)
else err = vfs_rmdir(nd.path.dentry->d_inode,
dentry);
else
err = -EPERM;
} else {
err = -ENOENT; err = -ENOENT;
}
dput(dentry); dput(dentry);
} else { } else {
err = PTR_ERR(dentry); err = PTR_ERR(dentry);
} }
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
path_put(&nd.path); path_put(&nd.path);
return err; return err;
} }