Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-10 15:10:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clk: exynos-audss: Fix memory leak on driver unbind or probe failure

Browse Source 
The memory allocated by basic clock divider/gate/mux (struct clk_gate,
clk_divider and clk_mux) was leaking. During driver unbind or probe
failure the driver only unregistered the clocks.

Use clk_unregister_{gate,divider,mux} to release all resources.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michael Turquette <mturquette@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2015-01-05 10:52:41 +01:00 committed by Michael Turquette
parent 4e3c021fb9
commit 27c76c4362
1 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/clk/samsung/clk-exynos-audss.c
View File

@ -82,6 +82,26 @@ static const struct of_device_id exynos_audss_clk_of_match[] = {
{}, {},
}; };
static void exynos_audss_clk_teardown(void)
{
int i;
for (i = EXYNOS_MOUT_AUDSS; i < EXYNOS_DOUT_SRP; i++) {
if (!IS_ERR(clk_table[i]))
clk_unregister_mux(clk_table[i]);
}
for (; i < EXYNOS_SRP_CLK; i++) {
if (!IS_ERR(clk_table[i]))
clk_unregister_divider(clk_table[i]);
}
for (; i < clk_data.clk_num; i++) {
if (!IS_ERR(clk_table[i]))
clk_unregister_gate(clk_table[i]);
}
}
/* register exynos_audss clocks */ /* register exynos_audss clocks */
static int exynos_audss_clk_probe(struct platform_device *pdev) static int exynos_audss_clk_probe(struct platform_device *pdev)
{ {
@ -219,10 +239,7 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
return 0; return 0;
unregister: unregister:
for (i = 0; i < clk_data.clk_num; i++) { exynos_audss_clk_teardown();
if (!IS_ERR(clk_table[i]))
clk_unregister(clk_table[i]);
}
if (!IS_ERR(epll)) if (!IS_ERR(epll))
clk_disable_unprepare(epll); clk_disable_unprepare(epll);
@ -232,18 +249,13 @@ unregister:
static int exynos_audss_clk_remove(struct platform_device *pdev) static int exynos_audss_clk_remove(struct platform_device *pdev)
{ {
int i;
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
unregister_syscore_ops(&exynos_audss_clk_syscore_ops); unregister_syscore_ops(&exynos_audss_clk_syscore_ops);
#endif #endif
of_clk_del_provider(pdev->dev.of_node); of_clk_del_provider(pdev->dev.of_node);
for (i = 0; i < clk_data.clk_num; i++) { exynos_audss_clk_teardown();
if (!IS_ERR(clk_table[i]))
clk_unregister(clk_table[i]);
}
if (!IS_ERR(epll)) if (!IS_ERR(epll))
clk_disable_unprepare(epll); clk_disable_unprepare(epll);