Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-18 03:06:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs

Browse Source 
If uhdlc_priv_tsa != 1 then utdm is not initialized.
And if ret != NULL then goto undo_uhdlc_init, where
utdm is dereferenced. Same if dev == NULL.

Found by Astra Linux on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: 8d68100ab4ad ("soc/fsl/qe: fix err handling of ucc_of_parse_tdm")
Signed-off-by: Esina Ekaterina <eesina@astralinux.ru>
Link: https://lore.kernel.org/r/20230112074703.13558-1-eesina@astralinux.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Esina Ekaterina 2023-01-12 10:47:03 +03:00 committed by Jakub Kicinski
parent 4bb4db7f31
commit 488e0bf7f3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wan/fsl_ucc_hdlc.c
View File

@ -1243,9 +1243,11 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
free_dev: free_dev:
free_netdev(dev); free_netdev(dev);
undo_uhdlc_init: undo_uhdlc_init:
iounmap(utdm->siram); if (utdm)
iounmap(utdm->siram);
unmap_si_regs: unmap_si_regs:
iounmap(utdm->si_regs); if (utdm)
iounmap(utdm->si_regs);
free_utdm: free_utdm:
if (uhdlc_priv->tsa) if (uhdlc_priv->tsa)
kfree(utdm); kfree(utdm);