Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-15 01:44:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fbdev: broadsheetfb: fix memory leak

Browse Source 
We have requested the firmware and it was loaded but we missed releasing
it both on success and error.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Sudip Mukherjee 2015-09-26 14:22:10 +05:30 committed by Tomi Valkeinen
parent 4bdb462986
commit 4d370b74e7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/fbdev/broadsheetfb.c
View File

@ -752,7 +752,7 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) { if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
dev_err(dev, "Invalid waveform\n"); dev_err(dev, "Invalid waveform\n");
err = -EINVAL; err = -EINVAL;
goto err_failed; goto err_fw;
} }
mutex_lock(&(par->io_lock)); mutex_lock(&(par->io_lock));
@ -762,13 +762,15 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
mutex_unlock(&(par->io_lock)); mutex_unlock(&(par->io_lock));
if (err < 0) { if (err < 0) {
dev_err(dev, "Failed to store broadsheet waveform\n"); dev_err(dev, "Failed to store broadsheet waveform\n");
goto err_failed; goto err_fw;
} }
dev_info(dev, "Stored broadsheet waveform, size %zd\n", fw_entry->size); dev_info(dev, "Stored broadsheet waveform, size %zd\n", fw_entry->size);
return len; err = len;
err_fw:
release_firmware(fw_entry);
err_failed: err_failed:
return err; return err;
} }