mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-08 14:13:53 +00:00
cxl/port: Pre-initialize component register mappings
The component registers of a component may not exist and cxl_setup_comp_regs() will fail for that reason. In another case, Software may not use and set those registers up. cxl_setup_comp_regs() is then called with a base address of CXL_RESOURCE_NONE. Both are valid cases, but the function returns without initializing the register map. Now, a missing component register block is not necessarily a reason to fail (feature is optional or its existence checked later). Change cxl_setup_comp_regs() to also use components with the component register block missing. Thus, always initialize struct cxl_register_map with valid values, set @dev and make @resource CXL_RESOURCE_NONE. The change is in preparation of follow-on patches. Signed-off-by: Terry Bowman <terry.bowman@amd.com> Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20231018171713.1883517-6-rrichter@amd.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
d8add49263
commit
4d758764e7
@ -694,15 +694,17 @@ static struct cxl_port *cxl_port_alloc(struct device *uport_dev,
|
||||
static int cxl_setup_comp_regs(struct device *host, struct cxl_register_map *map,
|
||||
resource_size_t component_reg_phys)
|
||||
{
|
||||
*map = (struct cxl_register_map) {
|
||||
.host = host,
|
||||
.reg_type = CXL_REGLOC_RBI_EMPTY,
|
||||
.resource = component_reg_phys,
|
||||
};
|
||||
|
||||
if (component_reg_phys == CXL_RESOURCE_NONE)
|
||||
return 0;
|
||||
|
||||
*map = (struct cxl_register_map) {
|
||||
.host = host,
|
||||
.reg_type = CXL_REGLOC_RBI_COMPONENT,
|
||||
.resource = component_reg_phys,
|
||||
.max_size = CXL_COMPONENT_REG_BLOCK_SIZE,
|
||||
};
|
||||
map->reg_type = CXL_REGLOC_RBI_COMPONENT;
|
||||
map->max_size = CXL_COMPONENT_REG_BLOCK_SIZE;
|
||||
|
||||
return cxl_setup_regs(map);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user