Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-12-29 09:16:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

autofs: fix missing fput for FSCONFIG_SET_FD

Browse Source 
If you pass an fd using FSCONFIG_SET_FD, autofs_parse_fd() "steals" the
param->file and so the fs_context infrastructure will not do fput() for
us.

Fixes: e6ec453bd0 ("autofs: convert autofs to use the new mount api")
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Link: https://lore.kernel.org/r/20240731-fsconfig-fsparam_fd-fixes-v2-1-e7c472224417@cyphar.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Aleksa Sarai 2024-07-31 23:10:27 +10:00 committed by Christian Brauner
parent 6c203968f5
commit 6a64c5220c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/autofs/inode.c
View File

@ -172,8 +172,7 @@ static int autofs_parse_fd(struct fs_context *fc, struct autofs_sb_info *sbi,
ret = autofs_check_pipe(pipe); ret = autofs_check_pipe(pipe);
if (ret < 0) { if (ret < 0) {
errorf(fc, "Invalid/unusable pipe"); errorf(fc, "Invalid/unusable pipe");
if (param->type != fs_value_is_file) fput(pipe);
fput(pipe);
return -EBADF; return -EBADF;
} }