Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-18 03:06:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

USB: serial: ftdi_sio: clean up modem-status handling

Browse Source 
All chip types but the original SIO (FT8U100AX) return a two-byte modem
status and there's no need to explicitly list every other type in the
handler.

Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2022-09-11 16:02:11 +02:00
parent f353c0d430
commit 6fbd914257
1 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/usb/serial/ftdi_sio.c
View File

@ -2820,27 +2820,13 @@ static int ftdi_get_modem_status(struct usb_serial_port *port,
if (!buf)
return -ENOMEM;
/*
* The 8U232AM returns a two byte value (the SIO a 1 byte value) in
* the same format as the data returned from the in point.
* The device returns a two byte value (the SIO a 1 byte value) in the
* same format as the data returned from the IN endpoint.
*/
switch (priv->chip_type) {
case SIO:
if (priv->chip_type == SIO)
len = 1;
break;
case FT232A:
case FT232B:
case FT2232C:
case FT232R:
case FT2232H:
case FT4232H:
case FT232H:
case FTX:
else
len = 2;
break;
default:
ret = -EFAULT;
goto out;
}
ret = usb_control_msg(port->serial->dev,
usb_rcvctrlpipe(port->serial->dev, 0),