Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-01 10:45:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

iio: dac: ad5791: Use devm_iio_device_register

Browse Source 
Use devm_iio_device_register to automatically free the iio device.
since this is the last remaining resource that was not automatically
freed, we can drop the ".remove" callback.

Suggested-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
Link: https://patch.msgid.link/20241031071746.848694-7-ahaslam@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Axel Haslam 2024-10-31 08:17:46 +01:00 committed by Jonathan Cameron
parent 7bf7b297b6
commit 7f36074c0f
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/iio/dac/ad5791.c
View File

@ -411,24 +411,12 @@ static int ad5791_probe(struct spi_device *spi)
if (ret) if (ret)
return dev_err_probe(&spi->dev, ret, "fail to write ctrl register\n"); return dev_err_probe(&spi->dev, ret, "fail to write ctrl register\n");
spi_set_drvdata(spi, indio_dev);
indio_dev->info = &ad5791_info; indio_dev->info = &ad5791_info;
indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = &st->chip_info->channel; indio_dev->channels = &st->chip_info->channel;
indio_dev->num_channels = 1; indio_dev->num_channels = 1;
indio_dev->name = st->chip_info->name; indio_dev->name = st->chip_info->name;
ret = iio_device_register(indio_dev); return devm_iio_device_register(&spi->dev, indio_dev);
if (ret)
return dev_err_probe(&spi->dev, ret, "unable to register iio device\n");
return 0;
}
static void ad5791_remove(struct spi_device *spi)
{
struct iio_dev *indio_dev = spi_get_drvdata(spi);
iio_device_unregister(indio_dev);
} }
static const struct of_device_id ad5791_of_match[] = { static const struct of_device_id ad5791_of_match[] = {
@ -457,7 +445,6 @@ static struct spi_driver ad5791_driver = {
.of_match_table = ad5791_of_match, .of_match_table = ad5791_of_match,
}, },
.probe = ad5791_probe, .probe = ad5791_probe,
.remove = ad5791_remove,
.id_table = ad5791_id, .id_table = ad5791_id,
}; };
module_spi_driver(ad5791_driver); module_spi_driver(ad5791_driver);