Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-11 07:30:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: allegro: fix an error pointer vs NULL check

Browse Source 
The allegro_mbox_init() function returns error pointers, it never
returns NULL.

Fixes: 94dc76560261 ("media: allegro: rework mbox handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Dan Carpenter 2020-07-22 14:38:48 +02:00 committed by Mauro Carvalho Chehab
parent 43663dc4f4
commit 9bde425e70
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/media/allegro-dvt/allegro-core.c
View File

@ -2952,7 +2952,7 @@ static int allegro_mcu_hw_init(struct allegro_dev *dev,
info->mailbox_size); info->mailbox_size);
dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status, dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status,
info->mailbox_size); info->mailbox_size);
if (!dev->mbox_command || !dev->mbox_status) { if (IS_ERR(dev->mbox_command) || IS_ERR(dev->mbox_status)) {
v4l2_err(&dev->v4l2_dev, v4l2_err(&dev->v4l2_dev,
"failed to initialize mailboxes\n"); "failed to initialize mailboxes\n");
return -EIO; return -EIO;