Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-16 10:17:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mm, hwpoison: cleanup some obsolete comments

Browse Source 
1.Remove meaningless comment in kill_proc(). That doesn't tell anything.
2.Fix the wrong function name get_hwpoison_unless_zero(). It should be
get_page_unless_zero().
3.The gate keeper for free hwpoison page has moved to check_new_page().
Update the corresponding comment.

Link: https://lkml.kernel.org/r/20220830123604.25763-7-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin 2022-08-30 20:36:04 +08:00 committed by Andrew Morton
parent b680dae9a8
commit 9cf2819159
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mm/memory-failure.c
View File

@ -277,7 +277,7 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags)
* to SIG_IGN, but hopefully no one will do that? * to SIG_IGN, but hopefully no one will do that?
*/ */
ret = send_sig_mceerr(BUS_MCEERR_AO, (void __user *)tk->addr, ret = send_sig_mceerr(BUS_MCEERR_AO, (void __user *)tk->addr,
addr_lsb, t); /* synchronous? */ addr_lsb, t);
if (ret < 0) if (ret < 0)
pr_info("Error sending signal to %s:%d: %d\n", pr_info("Error sending signal to %s:%d: %d\n",
t->comm, t->pid, ret); t->comm, t->pid, ret);
@ -1249,9 +1249,9 @@ static int __get_hwpoison_page(struct page *page, unsigned long flags)
return ret; return ret;
/* /*
* This check prevents from calling get_hwpoison_unless_zero() * This check prevents from calling get_page_unless_zero() for any
* for any unsupported type of page in order to reduce the risk of * unsupported type of page in order to reduce the risk of unexpected
* unexpected races caused by taking a page refcount. * races caused by taking a page refcount.
*/ */
if (!HWPoisonHandlable(head, flags)) if (!HWPoisonHandlable(head, flags))
return -EBUSY; return -EBUSY;
@ -2028,7 +2028,7 @@ try_again:
/* /*
* We need/can do nothing about count=0 pages. * We need/can do nothing about count=0 pages.
* 1) it's a free page, and therefore in safe hand: * 1) it's a free page, and therefore in safe hand:
* prep_new_page() will be the gate keeper. * check_new_page() will be the gate keeper.
* 2) it's part of a non-compound high order page. * 2) it's part of a non-compound high order page.
* Implies some kernel user: cannot stop them from * Implies some kernel user: cannot stop them from
* R/W the page; let's pray that the page has been * R/W the page; let's pray that the page has been