Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-16 02:14:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

soc: mediatek: mtk-svs: Call of_node_put(np) only once in svs_get_subsys_device()

Browse Source 
An of_node_put(np) call was immediately used after a pointer check
for a of_find_device_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/884f0a5d-e6d3-47dc-8a9e-201bb86b271f@web.de
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
This commit is contained in:
Markus Elfring 2024-09-24 20:00:09 +02:00 committed by AngeloGioacchino Del Regno
parent d0fa55cc98
commit a1643ae9b3
No known key found for this signature in database
GPG Key ID: 9A3604CFAD978478
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/mediatek/mtk-svs.c
View File

@ -2133,14 +2133,12 @@ static struct device *svs_get_subsys_device(struct svs_platform *svsp,
} }
pdev = of_find_device_by_node(np); pdev = of_find_device_by_node(np);
of_node_put(np);
if (!pdev) { if (!pdev) {
of_node_put(np);
dev_err(svsp->dev, "cannot find pdev by %s\n", node_name); dev_err(svsp->dev, "cannot find pdev by %s\n", node_name);
return ERR_PTR(-ENXIO); return ERR_PTR(-ENXIO);
} }
of_node_put(np);
return &pdev->dev; return &pdev->dev;
} }