mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-03 19:55:31 +00:00
media: pci: drop vb2_ops_wait_prepare/finish
Since commit 88785982a1
("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.
Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.
This simplifies the code and this is a step towards the goal of deleting
these callbacks.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
This commit is contained in:
parent
d01e5a4d86
commit
bde5d79d00
@ -1584,8 +1584,6 @@ static const struct vb2_ops bttv_video_qops = {
|
||||
.buf_cleanup = buf_cleanup,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static void radio_enable(struct bttv *btv)
|
||||
|
@ -170,8 +170,6 @@ const struct vb2_ops bttv_vbi_qops = {
|
||||
.buf_cleanup = buf_cleanup_vbi,
|
||||
.start_streaming = start_streaming_vbi,
|
||||
.stop_streaming = stop_streaming_vbi,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
/* ----------------------------------------------------------------------- */
|
||||
|
@ -424,8 +424,6 @@ static const struct vb2_ops cobalt_qops = {
|
||||
.buf_queue = cobalt_buf_queue,
|
||||
.start_streaming = cobalt_start_streaming,
|
||||
.stop_streaming = cobalt_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
/* V4L2 ioctls */
|
||||
|
@ -229,8 +229,6 @@ static const struct vb2_ops cx18_vb2_qops = {
|
||||
.buf_prepare = cx18_buf_prepare,
|
||||
.start_streaming = cx18_start_streaming,
|
||||
.stop_streaming = cx18_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static int cx18_stream_init(struct cx18 *cx, int type)
|
||||
|
@ -1210,8 +1210,6 @@ static const struct vb2_ops cx23885_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = cx23885_start_streaming,
|
||||
.stop_streaming = cx23885_stop_streaming,
|
||||
};
|
||||
|
@ -170,8 +170,6 @@ static const struct vb2_ops dvb_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = cx23885_start_streaming,
|
||||
.stop_streaming = cx23885_stop_streaming,
|
||||
};
|
||||
|
@ -249,8 +249,6 @@ const struct vb2_ops cx23885_vbi_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = cx23885_start_streaming,
|
||||
.stop_streaming = cx23885_stop_streaming,
|
||||
};
|
||||
|
@ -519,8 +519,6 @@ static const struct vb2_ops cx23885_video_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = cx23885_start_streaming,
|
||||
.stop_streaming = cx23885_stop_streaming,
|
||||
};
|
||||
|
@ -295,8 +295,6 @@ static const struct vb2_ops cx25821_video_qops = {
|
||||
.buf_prepare = cx25821_buffer_prepare,
|
||||
.buf_finish = cx25821_buffer_finish,
|
||||
.buf_queue = cx25821_buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = cx25821_start_streaming,
|
||||
.stop_streaming = cx25821_stop_streaming,
|
||||
};
|
||||
|
@ -781,8 +781,6 @@ static const struct vb2_ops blackbird_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
};
|
||||
|
@ -152,8 +152,6 @@ static const struct vb2_ops dvb_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
};
|
||||
|
@ -228,8 +228,6 @@ const struct vb2_ops cx8800_vbi_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
};
|
||||
|
@ -562,8 +562,6 @@ static const struct vb2_ops cx8800_video_qops = {
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_finish = buffer_finish,
|
||||
.buf_queue = buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
};
|
||||
|
@ -222,8 +222,6 @@ static void dt3155_buf_queue(struct vb2_buffer *vb)
|
||||
|
||||
static const struct vb2_ops q_ops = {
|
||||
.queue_setup = dt3155_queue_setup,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.buf_prepare = dt3155_buf_prepare,
|
||||
.start_streaming = dt3155_start_streaming,
|
||||
.stop_streaming = dt3155_stop_streaming,
|
||||
|
@ -1045,8 +1045,6 @@ static const struct vb2_ops cio2_vb2_ops = {
|
||||
.queue_setup = cio2_vb2_queue_setup,
|
||||
.start_streaming = cio2_vb2_start_streaming,
|
||||
.stop_streaming = cio2_vb2_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
/**************** V4L2 interface ****************/
|
||||
|
@ -767,8 +767,6 @@ void ipu6_isys_queue_buf_ready(struct ipu6_isys_stream *stream,
|
||||
|
||||
static const struct vb2_ops ipu6_isys_queue_ops = {
|
||||
.queue_setup = queue_setup,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.buf_prepare = ipu6_isys_buf_prepare,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
|
@ -304,8 +304,6 @@ static const struct vb2_ops queue_ops = {
|
||||
.buf_queue = buffer_queue,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish
|
||||
};
|
||||
|
||||
static int fh_open(struct file *file)
|
||||
|
@ -230,8 +230,6 @@ static const struct vb2_ops queue_ops = {
|
||||
.buf_queue = buffer_queue,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish
|
||||
};
|
||||
|
||||
static int vidioc_querycap(struct file *file, void *priv,
|
||||
|
@ -78,8 +78,6 @@ static const struct vb2_ops saa7134_empress_qops = {
|
||||
.buf_init = saa7134_ts_buffer_init,
|
||||
.buf_prepare = saa7134_ts_buffer_prepare,
|
||||
.buf_queue = saa7134_vb2_buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
};
|
||||
|
@ -166,8 +166,6 @@ struct vb2_ops saa7134_ts_qops = {
|
||||
.buf_init = saa7134_ts_buffer_init,
|
||||
.buf_prepare = saa7134_ts_buffer_prepare,
|
||||
.buf_queue = saa7134_vb2_buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.stop_streaming = saa7134_ts_stop_streaming,
|
||||
};
|
||||
EXPORT_SYMBOL_GPL(saa7134_ts_qops);
|
||||
|
@ -161,8 +161,6 @@ const struct vb2_ops saa7134_vbi_qops = {
|
||||
.buf_init = buffer_init,
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_queue = saa7134_vb2_buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = saa7134_vb2_start_streaming,
|
||||
.stop_streaming = saa7134_vb2_stop_streaming,
|
||||
};
|
||||
|
@ -844,8 +844,6 @@ static const struct vb2_ops vb2_qops = {
|
||||
.buf_init = buffer_init,
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_queue = saa7134_vb2_buffer_queue,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
.start_streaming = saa7134_vb2_start_streaming,
|
||||
.stop_streaming = saa7134_vb2_stop_streaming,
|
||||
};
|
||||
|
@ -756,8 +756,6 @@ static const struct vb2_ops solo_enc_video_qops = {
|
||||
.buf_finish = solo_enc_buf_finish,
|
||||
.start_streaming = solo_enc_start_streaming,
|
||||
.stop_streaming = solo_enc_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static int solo_enc_querycap(struct file *file, void *priv,
|
||||
|
@ -365,8 +365,6 @@ static const struct vb2_ops solo_video_qops = {
|
||||
.buf_queue = solo_buf_queue,
|
||||
.start_streaming = solo_start_streaming,
|
||||
.stop_streaming = solo_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static int solo_querycap(struct file *file, void *priv,
|
||||
|
@ -372,8 +372,6 @@ static const struct vb2_ops vip_video_qops = {
|
||||
.buf_queue = buffer_queue,
|
||||
.start_streaming = start_streaming,
|
||||
.stop_streaming = stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
|
||||
|
@ -471,8 +471,6 @@ static const struct vb2_ops tw5864_video_qops = {
|
||||
.buf_queue = tw5864_buf_queue,
|
||||
.start_streaming = tw5864_start_streaming,
|
||||
.stop_streaming = tw5864_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static int tw5864_s_ctrl(struct v4l2_ctrl *ctrl)
|
||||
|
@ -524,8 +524,6 @@ static const struct vb2_ops tw68_video_qops = {
|
||||
.buf_finish = tw68_buf_finish,
|
||||
.start_streaming = tw68_start_streaming,
|
||||
.stop_streaming = tw68_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
/* ------------------------------------------------------------------ */
|
||||
|
@ -579,8 +579,6 @@ static const struct vb2_ops tw686x_video_qops = {
|
||||
.buf_prepare = tw686x_buf_prepare,
|
||||
.start_streaming = tw686x_start_streaming,
|
||||
.stop_streaming = tw686x_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
static int tw686x_s_ctrl(struct v4l2_ctrl *ctrl)
|
||||
|
@ -950,8 +950,6 @@ static const struct vb2_ops zr_video_qops = {
|
||||
.buf_prepare = zr_vb2_prepare,
|
||||
.start_streaming = zr_vb2_start_streaming,
|
||||
.stop_streaming = zr_vb2_stop_streaming,
|
||||
.wait_prepare = vb2_ops_wait_prepare,
|
||||
.wait_finish = vb2_ops_wait_finish,
|
||||
};
|
||||
|
||||
int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq, int dir)
|
||||
|
Loading…
Reference in New Issue
Block a user