Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-11 15:40:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

perf top: Make -g refer to callchains

Browse Source 
In most commands -g is used for callchains. Make perf-top follow suit.
Move group to just --group with no short cut making it similar to
perf-record.

Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1384487490-6865-1-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
David Ahern 2013-11-14 20:51:30 -07:00 committed by Arnaldo Carvalho de Melo
parent 15e65c693d
commit bf80669e4f
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/perf/Documentation/perf-top.txt
View File

@ -50,7 +50,6 @@ Default is to monitor all CPUS.
--count-filter=<count>:: --count-filter=<count>::
Only display functions with more events than this. Only display functions with more events than this.
-g::
--group:: --group::
Put the counters into a counter group. Put the counters into a counter group.
@ -143,12 +142,12 @@ Default is to monitor all CPUS.
--asm-raw:: --asm-raw::
Show raw instruction encoding of assembly instructions. Show raw instruction encoding of assembly instructions.
-G:: -g::
Enables call-graph (stack chain/backtrace) recording. Enables call-graph (stack chain/backtrace) recording.
--call-graph:: --call-graph::
Setup and enable call-graph (stack chain/backtrace) recording, Setup and enable call-graph (stack chain/backtrace) recording,
implies -G. implies -g.
--max-stack:: --max-stack::
Set the stack depth limit when parsing the callchain, anything Set the stack depth limit when parsing the callchain, anything

4
tools/perf/builtin-top.c
View File

@ -1084,7 +1084,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
"dump the symbol table used for profiling"), "dump the symbol table used for profiling"),
OPT_INTEGER('f', "count-filter", &top.count_filter, OPT_INTEGER('f', "count-filter", &top.count_filter,
"only display functions with more events than this"), "only display functions with more events than this"),
OPT_BOOLEAN('g', "group", &opts->group, OPT_BOOLEAN(0, "group", &opts->group,
"put the counters into a counter group"), "put the counters into a counter group"),
OPT_BOOLEAN('i', "no-inherit", &opts->no_inherit, OPT_BOOLEAN('i', "no-inherit", &opts->no_inherit,
"child tasks do not inherit counters"), "child tasks do not inherit counters"),
@ -1105,7 +1105,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
" abort, in_tx, transaction"), " abort, in_tx, transaction"),
OPT_BOOLEAN('n', "show-nr-samples", &symbol_conf.show_nr_samples, OPT_BOOLEAN('n', "show-nr-samples", &symbol_conf.show_nr_samples,
"Show a column with the number of samples"), "Show a column with the number of samples"),
OPT_CALLBACK_NOOPT('G', NULL, &top.record_opts, OPT_CALLBACK_NOOPT('g', NULL, &top.record_opts,
NULL, "enables call-graph recording", NULL, "enables call-graph recording",
&callchain_opt), &callchain_opt),
OPT_CALLBACK(0, "call-graph", &top.record_opts, OPT_CALLBACK(0, "call-graph", &top.record_opts,