Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-17 18:56:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

USB: serial: ftdi_sio: clean up attribute visibility logic

Browse Source 
Clean up the attribute visibility logic by defaulting to attributes
being visible and explicitly listing the exceptions.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2022-09-19 15:24:54 +02:00
parent 61dfa797c7
commit c142bdc5c7
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/usb/serial/ftdi_sio.c
View File

@ -1775,19 +1775,18 @@ static umode_t ftdi_is_visible(struct kobject *kobj, struct attribute *attr, int
struct usb_serial_port *port = to_usb_serial_port(dev);
struct ftdi_private *priv = usb_get_serial_port_data(port);
enum ftdi_chip_type type = priv->chip_type;
umode_t mode = attr->mode;
if (type != SIO) {
if (attr == &dev_attr_event_char.attr)
return mode;
if (attr == &dev_attr_event_char.attr) {
if (type == SIO)
return 0;
}
if (type != SIO && type != FT232A) {
if (attr == &dev_attr_latency_timer.attr)
return mode;
if (attr == &dev_attr_latency_timer.attr) {
if (type == SIO || type == FT232A)
return 0;
}
return 0;
return attr->mode;
}
static const struct attribute_group ftdi_group = {